Populating a Select with options from an array

[chanshaw]

Alright im having an issue trying to get the months in the select. Can anyone tell me what I'm doing wrong here

$arrMonths = array("January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December");
 
<select name="txtDOHMonth">
    <?php
        for ( $i=0; $i<count($arrMonths); $i++ )
        {
            $i2 = $i + 1;
            $t1 = "<option value=\"".$i2."\" "; 
            if ( ( isset($_POST['txtDOHMonth']) ) && ( $arrMonths[$i] == $_POST['txtDOHMonth'] ) ) { $t1 .= "selected=\"true\" "; }
            $t1 .= ">".$arrMonths[$i]."</option>";
            echo $t1;
        }
    ?>
</select>
 

[Markus]

Urgh! You can do it much cleaner. Here:

// We set a variable to avoid multiple calls to the count() function (quicker).
$count = count( $arrMonths );
// For loop through the array - using ++$i (instead of $i++) - generally quicker.
for ( $i = 0 ; $i < $count ; ++$i )
{ 
        // @ symbol surpress error, so we can skip isset()
        // does the current POST value match our current array index?
    if ( @$_POST['txtDOHMonth'] == $arrMonths[$i] )
    {
                // echo out the option with the 'select' attribute.
        echo "<option value='{$arrMonths[$i]}' selected='selected'>{$arrMonths[$i]}</option>";
    }
    else
    {
                // otherwise, echo the option without the 'selected' attr.
        echo "<option value='{$arrMonths[$i]}'>{$arrMonths[$i]}</option>";
    }
 
}
 

[dlite922]

or if using Smarty, it can be done in one line!

{html_options options=$myArray selected=$selectedNode}

So Short, huh!?



Dan