CMD shell programming Looping with FOR

[sitko]

Hi,

I'm attempting to add a FOR Loop to a pre-existing cmd batch that I have, and am very confused by the stuff I've found on the web by way of documentation regarding using for loops.

Here is my old code:

@echo on
echo Now processing: %1
@echo off
 
if !%1==! goto ERROR
 
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/     1 /p" > %2____1_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 10001 /p" > %210001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 20001 /p" > %220001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 30001 /p" > %230001_nodin 
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 40001 /p" > %240001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 50001 /p" > %250001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 60001 /p" > %260001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 70001 /p" > %270001_nodin
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 80001 /p" > %280001_nodin
 
%1\util\sed -n -e "/time/p" %2nodout | %1\util\sed -n -e "$!N; /^\(.*\)\n\1$/!P; D" > %2time_nodin
 
REM %1 = Current Working Directory
REM %2 = ".\shake_01\"
REM Format would be do_a_shake2.cmd  . .\shake_01\
 
goto EXIT0
:ERROR
@echo on
echo Usage:   do_a_node .\shake_01\
echo Creates: X+1 bottle datafiles for each shake and a time datafile
echo          
:EXIT0
 

Here is the FOR Loop I intend to add:

 
FOR /L %%G IN (1,1,%3) DO %1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ 10001 /p" > %210001_nodin
 

I've taken one of the calls to the sed and inserted it where the example had "[Commands]", is this the correct way to format it? If there is a new argument "%3 (which is the number of times I want to do this loop, instead of the standard 8 times in the old code (above), would it work to substitute that argument, in the sed statement in the two places where there are mention to the # (at the beginning of the stuff in the strings #0001, where it currently is set to 1,2,3...7,8 (I bolded the numbers in the above codes, which would be substituted with the count variable).

Or would it be better to save the sed call into a new cmd file and call that from the FOR loop passing in the appropriate # for the call? (FYI, I have the windows sed utility, if your wondering how I'm calling sed from a windows cmd file...)

Examples and explanations would be much appreciated.

Thanks,
Sitko.

[sitko]

<please delete me....thanks>

[sitko]

Just to tell you how I figured this out. I created 3 scripts which were:

Main Code.

' VBScript source code
Dim WshShell
Dim CurWrkDir
Dim fso, f, f1, s, sf
Dim MyPos
Dim FolderName
Dim CmdName
Dim oExec
Dim vArg, aArgs(), iCount
Dim NumOfBottles
 
If WScript.Arguments.Count > 1 then
    WScript.Echo "Too many arguments"
    WScript.Quit
End If
If WScript.Arguments.Count = 0 Then
    NumOfBottles = 6
Else
    ReDim aArgs(wscript.Arguments.Count -1)
    For iCount = 0 to WScript.Arguments.Count -1
        aArgs(iCount) = WScript.Arguments(iCount)
        NumOfBottles = aArgs(iCount)
    Next
End If
 
Set WshShell = WScript.CreateObject("WScript.Shell")
CurWrkDir = WshShell.CurrentDirectory
 
Set fso = CreateObject("Scripting.FileSystemObject")
Set f = fso.GetFolder(CurWrkDir)
Set sf = f.SubFolders
For Each f1 in sf
    FolderName = f1.name
    MyPos = InStr(1, FolderName, "shake", 1)
    if MyPos <> 0 then
        CmdName = "do_a_Shake.cmd " & CurWrkDir & " " & f1.path & "\ "
                                   & NumOfBottles
        Set oExec = WshShell.Exec(CmdName)
        Do While oExec.Status = 0
            WScript.Sleep 100
        Loop        
    end if
Next
 

Do_A_Shake.cmd, has basically just this FOR loop along with a couple other unrelevant codes...The FOR statement, I ended up using was:

FOR /L %%G IN (1,1,%3) DO DoSed %1 %2 %%G
 

and as I couldn't figure out haw to call the command with the FOR statement, I moved it to a new cmd file and called (DoSed.cmd) from the previous code.

@echo off
%1\util\sed "/z-rot acc/,/n o d a l/d;/Center/d;/Bottle/d;/n o d a l/d" %2nodout | %1\util\sed -n "/ %30001 /p" > %2%30001_nodin
 

Any other improvements you can offer, would be appreciate, or maybe an explaination of what the vArg variable in the first code snippet is for (I got the argument code off the web, but don't see a call to it anywhere...
In the end, it works...so I guess thats the most important thing...

Thanks,
Sitko.