I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
#define CRC16_POLYNOMIAL 0xA001
crc16(INT16U byte, INT16U crc)
{
INT16U i;
INT16U crc_bit16;
for (i=0;<8;i++)
{
crc_bit16=((crc&0x01)^(byte&0x01));
crc=crc>>1;
if (crc_bit16)
{
crc=(crc^CRC16_POLYNOMIAL);
}
byte=byte>>1;
}
return(crc);
}
Here is my VB6 code
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial = &HA001
Dim CRCBit16 As Integer
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
CRCBit16 = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = ShiftRight(WrkCRC, 1)
If CRCBit16 <> 0 Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = ShiftRight(WrkByte, 1)
Next I
CRC = WrkCRC
END Function
And here is the routine that passes each byte through the CRC routine.
CRCIn = 0
CRC16 = 0
Open "C:\vbasic\shift.src\Page0.bin" For Binary As #1
For I = 1 To 30
A$ = Input(1, 1)
ByteIn = Asc(A$)
CRCIn = CRC16
CRC16 = CRC(CRCIn, ByteIn)
Next I
Page0.bin is a small 32 byte file as shown below. The last 2 bytes are
the CRC as computed by my customers C routine. From looking through
more of their code it appears the CRC is stored as an inverse for some
reason using C's ~ inverse operator.
31 07 49 6E 73 74 72 6F
6E 06 49 6E 53 70 65 63
FF FF FF FF FF FF FF FF
FF FF FF FF FF FF 19 95
I thought the source of the error is in my ShiftRight routine. I tried
roughly 6 different routines claiming to be C's >> equivelent and always
get the same results. Any help is appreciated.
17  5201 
milesh wrote: I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
<snip>
Some people might eventually answer this question, but I think it would
also be appropriate to post in comp.programming as well.
Where is the shiftright routine?
Show us the code!
Cheers
A.
"milesh" <mi****@unlistedspam.com> wrote in message
news:bm*******@dispatch.concentric.net... I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
#define CRC16_POLYNOMIAL 0xA001
crc16(INT16U byte, INT16U crc)
{
INT16U i;
INT16U crc_bit16;
for (i=0;<8;i++)
{
crc_bit16=((crc&0x01)^(byte&0x01));
crc=crc>>1;
if (crc_bit16)
{
crc=(crc^CRC16_POLYNOMIAL);
}
byte=byte>>1;
}
return(crc);
}
Here is my VB6 code
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial = &HA001
Dim CRCBit16 As Integer
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
CRCBit16 = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = ShiftRight(WrkCRC, 1)
If CRCBit16 <> 0 Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = ShiftRight(WrkByte, 1)
Next I
CRC = WrkCRC
END Function
And here is the routine that passes each byte through the CRC routine.
CRCIn = 0
CRC16 = 0
Open "C:\vbasic\shift.src\Page0.bin" For Binary As #1
For I = 1 To 30
A$ = Input(1, 1)
ByteIn = Asc(A$)
CRCIn = CRC16
CRC16 = CRC(CRCIn, ByteIn)
Next I
Page0.bin is a small 32 byte file as shown below. The last 2 bytes are
the CRC as computed by my customers C routine. From looking through
more of their code it appears the CRC is stored as an inverse for some
reason using C's ~ inverse operator.
31 07 49 6E 73 74 72 6F
6E 06 49 6E 53 70 65 63
FF FF FF FF FF FF FF FF
FF FF FF FF FF FF 19 95
I thought the source of the error is in my ShiftRight routine. I tried
roughly 6 different routines claiming to be C's >> equivelent and always
get the same results. Any help is appreciated.
It might be that "INT16U" not corresopnds to VB:s "int". int16u is
possible a 16 bit unsigned integer, it might be declared like this
somewhere in their code: "typedef unsigned int int16u;" or maybe they
uses "systemC".
This might give you problem width the rightShift. For unsigned values,
the left most bit is always replaced with zeros after shift, but if
the value is signed, the left most bit is either replaced by ones (if
the leftmost bit is a one before the shift) or zeros (if the left most
bit is a zero before the shift). So, you need not an int, but an
unsigned int with 16 bytes. (I think vb int is 32 bit?)
If this can't be achived by vb, then you should implement your own
shift routine. A strange this is, that if vb int is 32 bits, this
should have no effect, and everythis should work out fine (if you do
less than 16 shifts)... (If int is 16 bit in vb, try first to replace
your integers width long.)
milesh <mi****@unlistedspam.com> wrote in message news:<bm*******@dispatch.concentric.net>... I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
#define CRC16_POLYNOMIAL 0xA001
crc16(INT16U byte, INT16U crc)
{
INT16U i;
INT16U crc_bit16;
for (i=0;<8;i++)
{
crc_bit16=((crc&0x01)^(byte&0x01));
crc=crc>>1;
if (crc_bit16)
{
crc=(crc^CRC16_POLYNOMIAL);
}
byte=byte>>1;
}
return(crc);
}
Here is my VB6 code
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial = &HA001
Dim CRCBit16 As Integer
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
CRCBit16 = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = ShiftRight(WrkCRC, 1)
If CRCBit16 <> 0 Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = ShiftRight(WrkByte, 1)
Next I
CRC = WrkCRC
END Function
And here is the routine that passes each byte through the CRC routine.
CRCIn = 0
CRC16 = 0
Open "C:\vbasic\shift.src\Page0.bin" For Binary As #1
For I = 1 To 30
A$ = Input(1, 1)
ByteIn = Asc(A$)
CRCIn = CRC16
CRC16 = CRC(CRCIn, ByteIn)
Next I
Page0.bin is a small 32 byte file as shown below. The last 2 bytes are
the CRC as computed by my customers C routine. From looking through
more of their code it appears the CRC is stored as an inverse for some
reason using C's ~ inverse operator.
31 07 49 6E 73 74 72 6F
6E 06 49 6E 53 70 65 63
FF FF FF FF FF FF FF FF
FF FF FF FF FF FF 19 95
I thought the source of the error is in my ShiftRight routine. I tried
roughly 6 different routines claiming to be C's >> equivelent and always
get the same results. Any help is appreciated.
On 17 Oct 2003 00:34:35 -0700, d9****@efd.lth.se (Andreas) wrote: It might be that "INT16U" not corresopnds to VB:s "int". int16u is
possible a 16 bit unsigned integer, it might be declared like this
somewhere in their code: "typedef unsigned int int16u;" or maybe they
uses "systemC".
This might give you problem width the rightShift. For unsigned values,
the left most bit is always replaced with zeros after shift, but if
the value is signed, the left most bit is either replaced by ones (if
the leftmost bit is a one before the shift) or zeros (if the left most
bit is a zero before the shift). So, you need not an int, but an
unsigned int with 16 bytes. (I think vb int is 32 bit?)
VB Int is 16 bit
If this can't be achived by vb, then you should implement your own
shift routine. A strange this is, that if vb int is 32 bits, this
should have no effect, and everythis should work out fine (if you do
less than 16 shifts)... (If int is 16 bit in vb, try first to replace
your integers width long.)
Or use a UDT - shove the low bytes into a 4 byte UDT
then Lset that into a UDT holding a Long, and multiply the Long by
two
milesh <mi****@unlistedspam.com> wrote in message news:<bm*******@dispatch.concentric.net>... I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
#define CRC16_POLYNOMIAL 0xA001
crc16(INT16U byte, INT16U crc)
{
INT16U i;
INT16U crc_bit16;
for (i=0;<8;i++)
{
crc_bit16=((crc&0x01)^(byte&0x01));
crc=crc>>1;
if (crc_bit16)
{
crc=(crc^CRC16_POLYNOMIAL);
}
byte=byte>>1;
}
return(crc);
}
Here is my VB6 code
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial = &HA001
Dim CRCBit16 As Integer
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
CRCBit16 = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = ShiftRight(WrkCRC, 1)
If CRCBit16 <> 0 Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = ShiftRight(WrkByte, 1)
Next I
CRC = WrkCRC
END Function
And here is the routine that passes each byte through the CRC routine.
CRCIn = 0
CRC16 = 0
Open "C:\vbasic\shift.src\Page0.bin" For Binary As #1
For I = 1 To 30
A$ = Input(1, 1)
ByteIn = Asc(A$)
CRCIn = CRC16
CRC16 = CRC(CRCIn, ByteIn)
Next I
Page0.bin is a small 32 byte file as shown below. The last 2 bytes are
the CRC as computed by my customers C routine. From looking through
more of their code it appears the CRC is stored as an inverse for some
reason using C's ~ inverse operator.
31 07 49 6E 73 74 72 6F
6E 06 49 6E 53 70 65 63
FF FF FF FF FF FF FF FF
FF FF FF FF FF FF 19 95
I thought the source of the error is in my ShiftRight routine. I tried
roughly 6 different routines claiming to be C's >> equivelent and always
get the same results. Any help is appreciated.
Aristotelis E. Charalampakis wrote: Where is the shiftright routine?
Show us the code!
I have tried about 6 different shiftright routines searching on google.
All seemed to produce the same results so I'm not sure if thats where
the problem is. I keep thinking I must be overlooking something really
simple.
What do you get instead? It is difficult to identify a bug if you don't what the
output is, as well as what it should be. Maybe you are getting all zeros? Doubt
it, but don't know what you are getting.
"milesh" <mi****@unlistedspam.com> wrote in message
news:bm*******@dispatch.concentric.net... I have a customer that we need to send data files to using their
format. Below is a C routine they sent us for computing a CRC. I
tranlated it to the best of my ability to VB6 but can't reproduce their
results.
Here is the C routine.
#define CRC16_POLYNOMIAL 0xA001
crc16(INT16U byte, INT16U crc)
{
INT16U i;
INT16U crc_bit16;
for (i=0;<8;i++)
{
crc_bit16=((crc&0x01)^(byte&0x01));
crc=crc>>1;
if (crc_bit16)
{
crc=(crc^CRC16_POLYNOMIAL);
}
byte=byte>>1;
}
return(crc);
}
Here is my VB6 code
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial = &HA001
Dim CRCBit16 As Integer
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
CRCBit16 = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = ShiftRight(WrkCRC, 1)
If CRCBit16 <> 0 Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = ShiftRight(WrkByte, 1)
Next I
CRC = WrkCRC
END Function
And here is the routine that passes each byte through the CRC routine.
CRCIn = 0
CRC16 = 0
Open "C:\vbasic\shift.src\Page0.bin" For Binary As #1
For I = 1 To 30
A$ = Input(1, 1)
ByteIn = Asc(A$)
CRCIn = CRC16
CRC16 = CRC(CRCIn, ByteIn)
Next I
Page0.bin is a small 32 byte file as shown below. The last 2 bytes are
the CRC as computed by my customers C routine. From looking through
more of their code it appears the CRC is stored as an inverse for some
reason using C's ~ inverse operator.
31 07 49 6E 73 74 72 6F
6E 06 49 6E 53 70 65 63
FF FF FF FF FF FF FF FF
FF FF FF FF FF FF 19 95
I thought the source of the error is in my ShiftRight routine. I tried
roughly 6 different routines claiming to be C's >> equivelent and always
get the same results. Any help is appreciated.
Steve Gerrard wrote: What do you get instead? It is difficult to identify a bug if you don't what the
output is, as well as what it should be. Maybe you are getting all zeros? Doubt
it, but don't know what you are getting.
The original post showed what I should get. The last 2 bytes of the 32
byte data. No, not getting all 0's, just not the 19 95 that I should.
I'm not at work now and don't have VB6 on this computer but will post
the result I get. I was hoping someone is skilled at both VB6 and C++
and could see what I may have translated wrong as I do not know C at
all. Just looked up the areas of question. My guess is that it has
something to do with C's unsigned integers and how that plays in with
C's >> shiftright routine. I understand how C handles it but not sure
how to translate it to VB6.
"Miles" <un*****@unlistedspam.com> wrote in message
news:NX3kb.29879$Rd4.2397@fed1read07...
Steve Gerrard wrote: What do you get instead? It is difficult to identify a bug if you don't what
the output is, as well as what it should be. Maybe you are getting all zeros?
Doubt it, but don't know what you are getting.
The original post showed what I should get. The last 2 bytes of the 32
byte data. No, not getting all 0's, just not the 19 95 that I should.
I'm not at work now and don't have VB6 on this computer but will post
the result I get. I was hoping someone is skilled at both VB6 and C++
and could see what I may have translated wrong as I do not know C at
all. Just looked up the areas of question. My guess is that it has
something to do with C's unsigned integers and how that plays in with
C's >> shiftright routine. I understand how C handles it but not sure
how to translate it to VB6.
Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961 as
desired.
Note that in addition to inverting all the bits at the end, the CRC is stored in
your sample file in low byte, high byte order (i.e. flipped), a common practice.
The following modified version of your VB code produces a CRC of H9519, as
desired:
Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F, &H6E,
&H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial As Long = 40961
Dim Bit As Boolean
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
Bit = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
If Bit Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = WrkByte \ 2
Next I
CRC = WrkCRC
End Function
That was fun.
Steve
Steve Gerrard wrote: "Miles" <un*****@unlistedspam.com> wrote in message
news:NX3kb.29879$Rd4.2397@fed1read07...
Steve Gerrard wrote:
What do you get instead? It is difficult to identify a bug if you don't what
the
output is, as well as what it should be. Maybe you are getting all zeros?
Doubt
it, but don't know what you are getting.
The original post showed what I should get. The last 2 bytes of the 32
byte data. No, not getting all 0's, just not the 19 95 that I should.
I'm not at work now and don't have VB6 on this computer but will post
the result I get. I was hoping someone is skilled at both VB6 and C++
and could see what I may have translated wrong as I do not know C at
all. Just looked up the areas of question. My guess is that it has
something to do with C's unsigned integers and how that plays in with
C's >> shiftright routine. I understand how C handles it but not sure
how to translate it to VB6.
Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961 as
desired.
Note that in addition to inverting all the bits at the end, the CRC is stored in
your sample file in low byte, high byte order (i.e. flipped), a common practice.
The following modified version of your VB code produces a CRC of H9519, as
desired:
Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F, &H6E,
&H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial As Long = 40961
Dim Bit As Boolean
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
Bit = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
If Bit Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = WrkByte \ 2
Next I
CRC = WrkCRC
End Function
That was fun.
Steve
Steve Gerrard wrote: Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961 as
desired.
Ahhh....hadn't thought of that.
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
I had seen several shift right routines for VB6. All were more complex
because they took into account the sign bit shifting as C's >> does so
thats why I didn't simply try \ 2. Not having unsigned integers in VB6
is sometimes a pain!
I'll run throught several sets of sample data tomorrow and let ya know
if it works every time! Appreciate the help.
Speechless?
"Miles" <un*****@unlistedspam.com> wrote in message
news:7sGkb.30238$Rd4.8460@fed1read07...
Steve Gerrard wrote: "Miles" <un*****@unlistedspam.com> wrote in message
news:NX3kb.29879$Rd4.2397@fed1read07...
Steve Gerrard wrote:
What do you get instead? It is difficult to identify a bug if you don't
what
the
output is, as well as what it should be. Maybe you are getting all zeros?
Doubt
it, but don't know what you are getting.
The original post showed what I should get. The last 2 bytes of the 32
byte data. No, not getting all 0's, just not the 19 95 that I should.
I'm not at work now and don't have VB6 on this computer but will post
the result I get. I was hoping someone is skilled at both VB6 and C++
and could see what I may have translated wrong as I do not know C at
all. Just looked up the areas of question. My guess is that it has
something to do with C's unsigned integers and how that plays in with
C's >> shiftright routine. I understand how C handles it but not sure
how to translate it to VB6.
Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961
as desired.
Note that in addition to inverting all the bits at the end, the CRC is
stored in your sample file in low byte, high byte order (i.e. flipped), a common
practice. The following modified version of your VB code produces a CRC of H9519, as
desired:
Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F,
&H6E, &H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial As Long = 40961
Dim Bit As Boolean
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
Bit = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
If Bit Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = WrkByte \ 2
Next I
CRC = WrkCRC
End Function
That was fun.
Steve
Speechless?
"Miles" <un*****@unlistedspam.com> wrote in message
news:7sGkb.30238$Rd4.8460@fed1read07...
Steve Gerrard wrote: "Miles" <un*****@unlistedspam.com> wrote in message
news:NX3kb.29879$Rd4.2397@fed1read07...
Steve Gerrard wrote:
What do you get instead? It is difficult to identify a bug if you don't
what
the
output is, as well as what it should be. Maybe you are getting all zeros?
Doubt
it, but don't know what you are getting.
The original post showed what I should get. The last 2 bytes of the 32
byte data. No, not getting all 0's, just not the 19 95 that I should.
I'm not at work now and don't have VB6 on this computer but will post
the result I get. I was hoping someone is skilled at both VB6 and C++
and could see what I may have translated wrong as I do not know C at
all. Just looked up the areas of question. My guess is that it has
something to do with C's unsigned integers and how that plays in with
C's >> shiftright routine. I understand how C handles it but not sure
how to translate it to VB6.
Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961
as desired.
Note that in addition to inverting all the bits at the end, the CRC is
stored in your sample file in low byte, high byte order (i.e. flipped), a common
practice. The following modified version of your VB code produces a CRC of H9519, as
desired:
Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F,
&H6E, &H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Function CRC(CRCIn As Long, ByteIn As Byte) As Long
Const CRC16Polynomial As Long = 40961
Dim Bit As Boolean
Dim I As Integer
Dim WrkByte As Integer
Dim WrkCRC As Long
WrkByte = ByteIn
WrkCRC = CRCIn
For I = 0 To 7
Bit = ((WrkCRC And &H1) Xor (WrkByte And &H1))
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
If Bit Then
WrkCRC = (WrkCRC Xor CRC16Polynomial)
End If
WrkByte = WrkByte \ 2
Next I
CRC = WrkCRC
End Function
That was fun.
Steve
"Miles" <un*****@unlistedspam.com> wrote in message
news:IAGkb.30241$Rd4.10686@fed1read07...
Steve Gerrard wrote:
Found the snag. Your definition of the const in the VB version produces a
negative number, not the intended value:
Const CRC16Polynomial = &HA001 ' equals -24575 in VB, not 40961
as desired.
Ahhh....hadn't thought of that.
WrkCRC = WrkCRC \ 2 'this is fine for shift right 1 bit
I had seen several shift right routines for VB6. All were more complex
because they took into account the sign bit shifting as C's >> does so
thats why I didn't simply try \ 2. Not having unsigned integers in VB6
is sometimes a pain!
I'll run throught several sets of sample data tomorrow and let ya know
if it works every time! Appreciate the help.
The Hex constant rang a bell the second time I looked at your code; I have seen
it once before. I don't know if there is a way to define a long Hex constant in
VB.
I agree not having unsigned integers is a pain, hence my use of integers and
longs instead of bytes and integers. I think the \ will only work correctly if
the integer is wider than it needs to be.
: The Hex constant rang a bell the second time I looked at your code; I have
seen
: it once before. I don't know if there is a way to define a long Hex
constant in
: VB.
Const CRC16Polynomial = &HA001& ' <<<<< trailing &
--
Randy Birch
MVP Visual Basic http://www.mvps.org/vbnet/
Please respond only to the newsgroups so all can benefit.
Steve Gerrard wrote: Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F, &H6E,
&H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Ok, I tested it with 3 sets of sample data I have. There is a bit of a
problem when converting to 16 bit (CRC16 = CRC32). Valid CRC's can
range from hex 0000 to hex FFFF or decimal 0 to 65535. VB6's integer
interprets this as +/- 32768. An overflow error occurs when ABS(CRC32)
is greater than 32768. One way I found to correct this is by the
following line.
CRC16 = Val("&H" & Hex$(CRC32 And &HFFFF&))
Seems that converting it to a hex string and taking a value of it works
because it translates the sign bit correctly for 16 bit integers. I
don't like having to convert to string then back to integer but it does
work. Another way would be:
Select Case CRC32
Case Is < -32768
CRC16 = CRC32 + 65535
Case Is > 32768
CRC16 = CRC32 - 65535
Case Else
CRC16 = CRC32
End Select
This works fine too but is there a cleaner way to handle this?
"Randy Birch" <rg************@mvps.org> wrote in message
news:_X*********************@news01.bloor.is.net.c able.rogers.com... : The Hex constant rang a bell the second time I looked at your code; I have
seen
: it once before. I don't know if there is a way to define a long Hex
constant in
: VB.
Const CRC16Polynomial = &HA001& ' <<<<< trailing &
--
Randy Birch
MVP Visual Basic
http://www.mvps.org/vbnet/
Please respond only to the newsgroups so all can benefit.
Oh man, that is so simple. Thanks.
"milesh" <mi****@unlistedspam.com> wrote in message
news:bn********@dispatch.concentric.net...
Steve Gerrard wrote:
Private Sub Command1_Click()
Dim I As Integer
Dim CRC32 As Long
Dim CRC16 As Integer
Dim ByteIn As Byte
Dim A As String
Dim strIn() As String
'using a const instead of reading a file
Const Test As String = "&H31, &H07, &H49, &H6E, &H73, &H74, &H72, &H6F, &H6E,
&H06, &H49, &H6E, &H53, &H70, &H65, &H63, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF,
&HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF, &HFF"
strIn = Split(Test, ",")
CRC32 = 0
For I = 0 To 29
A = strIn(I)
ByteIn = CInt(A)
CRC32 = CRC(CRC32, ByteIn)
Next I
'invert all bits
CRC32 = (CRC32 Xor &HFFFF)
'now get the 16 bit version
CRC16 = CRC32
Debug.Print CRC16, Hex(CRC16)
End Sub
Ok, I tested it with 3 sets of sample data I have. There is a bit of a
problem when converting to 16 bit (CRC16 = CRC32). Valid CRC's can
range from hex 0000 to hex FFFF or decimal 0 to 65535. VB6's integer
interprets this as +/- 32768. An overflow error occurs when ABS(CRC32)
is greater than 32768. One way I found to correct this is by the
following line.
CRC16 = Val("&H" & Hex$(CRC32 And &HFFFF&))
Seems that converting it to a hex string and taking a value of it works
because it translates the sign bit correctly for 16 bit integers. I
don't like having to convert to string then back to integer but it does
work. Another way would be:
Select Case CRC32
Case Is < -32768
CRC16 = CRC32 + 65535
Case Is > 32768
CRC16 = CRC32 - 65535
Case Else
CRC16 = CRC32
End Select
This works fine too but is there a cleaner way to handle this?
I like the select case better. I don't see a way around this, given the nature
of VB's integer. I think it should be 65536 that you add or subtract, to get the
same hex value out. This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: RootShell |
last post by:
Dear All
Im having some dificulty here:
I found a great PHP code by Catalin Mihaila that reads a SRC (Sinclair
Spectrum $SCREEN Image Format) and tranforms it into PNG format to show
onscreen...
|
by: Davis Marques |
last post by:
hi;
I'm translating some PHP scripts to Python and have hit a roadblock
with a for statement. If someone could explain to me how one should
translate the multiple increment, evaluations, etc....
|
by: Jules |
last post by:
Is anyone able to translate the following PHP to ASP ? or come up with
something that would work.
The reason for the code is that I'm using Indexing service to create a
search engine on a...
|
by: Anuj Mathur |
last post by:
Hello All
We are making an application for translating the literals
(HTML text and labels) of an existing ASP website from
English to another language, say Swedish.
Now, for this we are...
|
by: gregf |
last post by:
I have a paragraph of text pasted into a word document, it's in Polish,
complete with polish characters. They show up just fine in word, but
the program I use for web page programming, HomeSite,...
|
by: Carlo, MCP |
last post by:
Hello,
please, help me to translate these four lines of C# code in VB:
bool topLeft, topRight, bottomLeft, bottomRight;
int topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius;...
|
by: Vyz |
last post by:
Hi,
I have a script with hundreds of lines of javascript spread accross 7
files. Is there any tool out there to automatically or
semi-automatically translate the code into python.
Thanks
Vyz
|
by: lombardm |
last post by:
I am trying to decipher/translate some code that I have no experience
with.
I am trying to find out how the checksum is computed for a Megellan
Explorist GPS Waypoint (POI) file. Below is the...
|
by: Andrus |
last post by:
I have database containing translations.
I'm creating VS 2005 WinForms application which should use this database to
translate menu items to user language.
I replaced lines in myform.designer.cs...
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new...
|
by: conductexam |
last post by:
I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and...
| |
