Creating RPG fight code

[SingingDoughnut]

Can someone please help with some code? I have been making a game, but there is a problem with one scenario. When the playable character encounters an NPC and they fight, the game keeps going until the NPC is dead, even though the Playable Character is dead.

ranger_health = 10
ranger_damage = 4
print "You head off down some small hills that go off the path."\
      "\nYou encounter a lonely Ranger sitting on a stump.  He asks you if he can join your trip.  \nBear in mind, he will not fight for you."
 
ranger_join = raw_input("\nWill you let him?(y/n)? ")
 
if ranger_join == "y":
    print "The ranger joins you on your trip.  Yay."
 
elif ranger_join == "n":
    print "The ranger is offended and draws his sword.\n"
    # attacking the ranger
    weapon = raw_input("What weapon do you have? Oak Staff or Iron Sword? ")
    #using the Oak Staff
    if weapon == "oak staff":
        attack = 3
        print "\nYou draw your Oak Staff"
        attack = 3
        while ranger_health > 0:
            ranger_health = ranger_health - attack
            health = health - ranger_damage
 
            print "You're hero takes a swing and the ranger has", ranger_health, " health remaining."\
                  "But you have", health, "hit points remaining\n"
            if health <= 0:
                print "You died.  Bet you wish you stayed at the inn."
 
    # using the Iron Sword
    elif weapon == "iron sword":
        print "\nYou draw your Iron Sword"
        attack = 5
        while ranger_health > 0 or health > 0:
            ranger_health = ranger_health - attack
            health = health - ranger_damage
 
            print "You're hero takes a swing and the ranger has", ranger_health, " health remaining."\
                  "But you have", health, "hit points remaining\n"
            if ranger_health <= 0:
                print "It sucks"
                exit
            #gain an item for defeating ranger
 
            elif health <= 0:
                print "You died.  Bet you wish you stayed at the inn.\n"
 

How do I stop that problem?

[bartonc]

looks like, on line #33, you should use and instead of or:

while ranger_health > 0 and health > 0:

Please note the use of CODE tags. You can see what the look like if you hit the Reply button. Instructions are also on the right hand side of the page when you post.

Thanks.