Writing to file

[dh87lfc]

Hi,
I have almost got my script to do what I want it to do, but I have one final problem for which I have been searching for a solution. My code now successfully reads the content of every text file in the directory, and in the correct order. I have also managed to exclude the lines I didn't want. What I need to do now is to write this very long list of text to a new file. I have tried this, but what it seems to be doing is writing a line to it, removing it and writing another line to it, and repeats this until it reaches the end.

This is the code I am using at the moment:

#!/usr/bin/perl
 
opendir(DIR, "directory") || die "Cannot open directory";
my @file = readdir(DIR);
closedir(DIR);
 
foreach my $file (@file)
{
    @file = sort(@file);
    open(FH, $file) or die "$!";
 
    while (<FH>)
    {
        if ((/0000\s/) || (/0004\s/) || (/0100\s/) || (/0200\s/))
    {
            chomp;
        open(NF, ">file" || die "Cannot open file");
            print NF "$_\n";
        close(NF);
    }
    }
}
close(FH);
 

I would like this code to write every single line that is read in the command prompt into a new file. Any help would be appreciated, thanks in advance.

[mehj123]

You should open the file in append mode

 open(NF, ">>$file" || die "Cannot open file");

and you have written "file" in place of "$file"

[dh87lfc]

You should open the file in append mode

 open(NF, ">>$file" || die "Cannot open file");

and you have written "file" in place of "$file"

Ok, thanks, I will try that. I only put "file" in to save having the full file address and name.

[dh87lfc]

I tried this and I had limited success. It wrote in every single line, but because the new file itself now has the 0000, 0004, 0100 and 0200 that I declared it must have, it is now writing the text in over and over again. I think what I need to do is to exclude the new filename so that it will ignore these numbers in this file. Is that right?

Thanks

[mehj123]

Ya i think so.. you have to consider the files from the directory only and not the new file right.. so i guess excluding the new file will work...please try and let me know too :)

[dh87lfc]

Ya i think so.. you have to consider the files from the directory only and not the new file right.. so i guess excluding the new file will work...please try and let me know too :)

Hi again,
I figured out the problem. I have opened the new output file within the loop, which is why it is constantly writing the data in over and over again. Bit of a schoolboy error. I moved the line that opens the new file to immediately after where I closed the directory, and also moved the line that closes the new file to the bottom, so none of it is inside the foreach loop. This has solved the problem, it only reads the data in once now as desired.