Simple Login Form - Stuck and Frustrated

Hi, i just started learning perl which i would use for my uni. project unfortunately. Well, this is a simple user login page i tried to create but i cant get it to work. Can someone please check this out. Corrections would be highly appreciated. The code:

Expand|Select|Wrap|Line Numbers

 
use strict;

use CGI qw(:standard);

use CGI::Carp qw(warningsToBrowser fatalsToBrowser);

use DBI;

$CGI::POST_MAX = 1024 * 1000;
 
sub print_login_form($);
 
my $dbh = DBI->connect('DBI:mysql:users:localhost', 'root', '', {

    RaiseError    => 1,

    AutoCommit    => 1

}) or &dieNice("Can't connect to database:$DBI::errstr");
 
my $username = param('username');

my $password = param('password');

my $data = $dbh->prepare("select * from users where username=?") or &dbdie;

$data->execute($username) or &dbdie;

my $uinfo = $data->fetchrow_hashref;
 
unless (param("filled")) {

    print_login_form("");

    exit;

}
 
# Error Checking

dieNice("Please enter your Username") if !defined $username;

dieNice("Please enter your Password") if !defined $password;

dieNice("The username $username does not exist.") if $username ne $uinfo->{username};

dieNice("Incorrect password") if $password ne $uinfo->{password};
 
# Successful Match

print redirect(- location=>"upload.html");
 
sub print_login_form($) {

    print <<END1;

<HTML>

<HEAD>

<TITLE> Media File Upload/Search System</TITLE>

</HEAD>
 
<body bgcolor="#003366">

<form ACTION="cgi-bin/login.cgi" METHOD="POST">

<img src="unilogo.gif" border=0> </img>
 
<font color="yellow"><h1>Media File Upload/Search System</h1></font>

<font color="white"><h3>Sign into File Upload/Search System</h3></font>
 
<TABLE>

<TR>

<TD ALIGN="right"><font color="white"><STRONG>Username:</STRONG><font></TD>

<TD><INPUT TYPE="text" SIZE=30 NAME="username"></TD>

</TR>
 
<TR>

<TD ALIGN="right"><font color="white"><STRONG>Password:</STRONG><font></TD>

<TD><INPUT TYPE="password" SIZE=30 NAME="password"></TD>

</TR>
 
</TABLE>
 
<style>

.box{

margin-left: 165px;

}

</style>
 
<TABLE class=box>

<TR>

<TD>

<a href=newuser.html><FONT color=c0c0c0 ><strong>New User</font></a>

<input type="submit" name="submit" value="Login">

</TD>

</TR>
 
<TABLE>

<TR>

<TD ALIGN="left">

<a href=deleteuser.html><FONT color=c0c0c0 ><strong>Don't like this service, Delete User</font></a>

</TD>

</TR>
 
</TABLE>

</FORM>

</BODY>

</HTML>

END1

}
 
sub dieNice {

    my ($msg) = @_;

    print "<h2>Error</h2>\n";

    print $msg;

    exit;

}
 
sub dbdie {

    my ($package, $filename, $line) = caller;

    my $errmsg  = "Database error: $DBI::errstr<br> called from $package $filename line $line";

    &dieNice($errmsg);

}
 
sub encrypt {

    my ($plain) = @_;

    my @salt = ('a'..'z', 'A'..'Z', '0'..'9', '.', '/');

    return crypt($plain, $salt[int(rand(@salt))] . $salt[int(rand(@salt))]);

}

Mar 21 '07 #1

Follow Post Reply

5629

KevinADC

4,059

Expert 2GB

syntax error here:

Expand|Select|Wrap|Line Numbers

Rai seError =>1

can't have a space like that, should be:

Expand|Select|Wrap|Line Numbers

RaiseError =>1

might have othe problems too but that needs correcting

Mar 21 '07 #2

miller

1,089

Expert 1GB

Hi olaamussah,

I took a moment and reformatted your code along with putting a CODE tag around it. Your approach to coding is rather unsophisticated, but that's not an entirely bad thing. The main thing that you could use is an introduction to a few coding conventions, like for naming of variables and functions.

Nevertheless, one thing that I noticed is that your code will currently never get to the verification of the username and password. This is because you look for an input field named "filled" as your key that the form has been submitted. There is no such field in your form, so the primary page will constantly be redisplayed.

One way to fix this is to add that key to your form:

[HTML]
<input type="hidden" name="filled" value="1">
[/HTML]

Another way to fix this would be to check the request method, to see if it equals "POST".

Anyway, make this change and you should be on your way.

- Miller

Mar 21 '07 #3

olaamussah

I've been trying to make this work but still no progress, i think is not getting the entered values to be used in the perl code. Please help if you know what the problem is. Thanks in advance

Expand|Select|Wrap|Line Numbers

 
#!C:/usr/bin/perl
 
use strict;

use CGI qw(:standard);

use CGI::Carp qw(warningsToBrowser fatalsToBrowser);

use DBI;
 
my $dbh = DBI->connect('DBI:mysql:users:localhost', 'root', '', {

    RaiseError => 1,

    AutoCommit => 1

}) or &dienice("Can't connect to database:$DBI::errstr");
 
my $ps = param('ps');

my $user = param('username');

my $pass = param('password');
 
if ($ps eq "login") {

    my $data = $dbh->prepare("SELECT * FROM users WHERE username=?") or &dbdie;

    $data->execute($user) or &dbdie;

    my $uinfo = $data->fetchrow_hashref;
 
    &dienice("Please enter your Username") if !defined $user;

    &dienice("Please enter your Password") if !defined $pass;

    &dienice("The username $user does not exist.") if $user ne $uinfo->{username};

    &dienice("Incorrect password") if $pass ne $uinfo->{password};
 
    print redirect(location=>"upload.html");

}
 
print <<END1;

<HTML>

<HEAD>

<TITLE> Media File Upload/Search System</TITLE>

</HEAD>
 
<body bgcolor="#003366">

<form NAME="login" ACTION="cgi-bin/login.cgi" METHOD="POST">

<img src="unilogo.gif" border=0> </img>
 
<font color="yellow"><h1>Media File Upload/Search System</h1></font>

<font color="white"><h3>Sign into File Upload/Search System</h3></font>
 
<TABLE>

<TR>

<TD ALIGN="right"><font color="white"><STRONG>Username:</STRONG><font></TD>

<TD><INPUT TYPE="text" SIZE=30 NAME="username"></TD>

</TR>
 
<TR>

<TD ALIGN="right"><font color="white"><STRONG>Password:</STRONG><font></TD>

<TD><INPUT TYPE="password" SIZE=30 NAME="password"></TD>

</TR>
 
</TABLE>
 
<style>

.box{

margin-left: 165px;

}

</style>
 
<TABLE class=box>

<TR>

<TD>

<a href="cgi-bin/newuser.cgi"><FONT color=c0c0c0 ><strong>New User</font></a>

<input type="hidden" name="ps" value="login">

<input type="submit" name="login" value="Login">

</TD>

</TR>
 
<TABLE>

<TR>

<TD ALIGN="left">

<a href="cgi-bin/deleteuser.cgi"><FONT color=c0c0c0 ><strong>Don't like this service, Delete User</font></a>

</TD>

</TR>
 
</TABLE>

</FORM>

</BODY>

</HTML>

END1
 
sub dienice {

    my ($msg) = @_;

    print "<h2>Error</h2>\n";

    print $msg;

    exit;

}
 
sub dbdie {

    my ($package, $filename, $line) = caller;

    my $errmsg = "Database error: $DBI::errstr<br> called from $package $filename line $line";

    &dienice($errmsg);

}

Mar 25 '07 #4

KevinADC

4,059

Expert 2GB

what does happen when you run the script?

Mar 26 '07 #5

miller

1,089

Expert 1GB

Hi olaamussah,

We have already been helping you with this problem in another thread. Please ask any related questions in the same thread so that we can be sure that you've heard and applied the advice that we've previously given. Otherwise, we will not be encouraged to help you any further.

Also, take the time to put a CODE tag around your code. This will help persist the formatting and therefore make it much easier to read.

I'm merging the threads now and will reformat your message. If I have time later, I'll take another look at your problem.

- Miller

Mar 26 '07 #6

Simple Login Form - Stuck and Frustrated

Post your reply

Similar topics