Simple Login Form - Stuck and Frustrated

Hi, i just started learning perl which i would use for my uni. project unfortunately. Well, this is a simple user login page i tried to create but i cant get it to work. Can someone please check this out. Corrections would be highly appreciated. The code:

Expand|Select|Wrap|Line Numbers

 
use strict;

use CGI qw(:standard);

use CGI::Carp qw(warningsToBrowser fatalsToBrowser);

use DBI;

$CGI::POST_MAX = 1024 * 1000;
 
sub print_login_form($);
 
my $dbh = DBI->connect('DBI:mysql:users:localhost', 'root', '', {

    RaiseError    => 1,

    AutoCommit    => 1

}) or &dieNice("Can't connect to database:$DBI::errstr");
 
my $username = param('username');

my $password = param('password');

my $data = $dbh->prepare("select * from users where username=?") or &dbdie;

$data->execute($username) or &dbdie;

my $uinfo = $data->fetchrow_hashref;
 
unless (param("filled")) {

    print_login_form("");

    exit;

}
 
# Error Checking

dieNice("Please enter your Username") if !defined $username;

dieNice("Please enter your Password") if !defined $password;

dieNice("The username $username does not exist.") if $username ne $uinfo->{username};

dieNice("Incorrect password") if $password ne $uinfo->{password};
 
# Successful Match

print redirect(- location=>"upload.html");
 
sub print_login_form($) {

    print <<END1;

<HTML>

<HEAD>

<TITLE> Media File Upload/Search System</TITLE>

</HEAD>
 
<body bgcolor="#003366">

<form ACTION="cgi-bin/login.cgi" METHOD="POST">

<img src="unilogo.gif" border=0> </img>
 
<font color="yellow"><h1>Media File Upload/Search System</h1></font>

<font color="white"><h3>Sign into File Upload/Search System</h3></font>
 
<TABLE>

<TR>

<TD ALIGN="right"><font color="white"><STRONG>Username:</STRONG><font></TD>

<TD><INPUT TYPE="text" SIZE=30 NAME="username"></TD>

</TR>
 
<TR>

<TD ALIGN="right"><font color="white"><STRONG>Password:</STRONG><font></TD>

<TD><INPUT TYPE="password" SIZE=30 NAME="password"></TD>

</TR>
 
</TABLE>
 
<style>

.box{

margin-left: 165px;

}

</style>
 
<TABLE class=box>

<TR>

<TD>

<a href=newuser.html><FONT color=c0c0c0 ><strong>New User</font></a>

<input type="submit" name="submit" value="Login">

</TD>

</TR>
 
<TABLE>

<TR>

<TD ALIGN="left">

<a href=deleteuser.html><FONT color=c0c0c0 ><strong>Don't like this service, Delete User</font></a>

</TD>

</TR>
 
</TABLE>

</FORM>

</BODY>

</HTML>

END1

}
 
sub dieNice {

    my ($msg) = @_;

    print "<h2>Error</h2>\n";

    print $msg;

    exit;

}
 
sub dbdie {

    my ($package, $filename, $line) = caller;

    my $errmsg  = "Database error: $DBI::errstr<br> called from $package $filename line $line";

    &dieNice($errmsg);

}
 
sub encrypt {

    my ($plain) = @_;

    my @salt = ('a'..'z', 'A'..'Z', '0'..'9', '.', '/');

    return crypt($plain, $salt[int(rand(@salt))] . $salt[int(rand(@salt))]);

}

Mar 21 '07 #1

Subscribe Post Reply

5719

KevinADC

4,059

Expert 2GB

syntax error here:

Expand|Select|Wrap|Line Numbers

Rai seError =>1

can't have a space like that, should be:

Expand|Select|Wrap|Line Numbers

RaiseError =>1

might have othe problems too but that needs correcting

Mar 21 '07 #2

miller

1,089

Expert 1GB

Hi olaamussah,

I took a moment and reformatted your code along with putting a CODE tag around it. Your approach to coding is rather unsophisticated, but that's not an entirely bad thing. The main thing that you could use is an introduction to a few coding conventions, like for naming of variables and functions.

Nevertheless, one thing that I noticed is that your code will currently never get to the verification of the username and password. This is because you look for an input field named "filled" as your key that the form has been submitted. There is no such field in your form, so the primary page will constantly be redisplayed.

One way to fix this is to add that key to your form:

[HTML]
<input type="hidden" name="filled" value="1">
[/HTML]

Another way to fix this would be to check the request method, to see if it equals "POST".

Anyway, make this change and you should be on your way.

- Miller

Mar 21 '07 #3

olaamussah

I've been trying to make this work but still no progress, i think is not getting the entered values to be used in the perl code. Please help if you know what the problem is. Thanks in advance

Expand|Select|Wrap|Line Numbers

 
#!C:/usr/bin/perl
 
use strict;

use CGI qw(:standard);

use CGI::Carp qw(warningsToBrowser fatalsToBrowser);

use DBI;
 
my $dbh = DBI->connect('DBI:mysql:users:localhost', 'root', '', {

    RaiseError => 1,

    AutoCommit => 1

}) or &dienice("Can't connect to database:$DBI::errstr");
 
my $ps = param('ps');

my $user = param('username');

my $pass = param('password');
 
if ($ps eq "login") {

    my $data = $dbh->prepare("SELECT * FROM users WHERE username=?") or &dbdie;

    $data->execute($user) or &dbdie;

    my $uinfo = $data->fetchrow_hashref;
 
    &dienice("Please enter your Username") if !defined $user;

    &dienice("Please enter your Password") if !defined $pass;

    &dienice("The username $user does not exist.") if $user ne $uinfo->{username};

    &dienice("Incorrect password") if $pass ne $uinfo->{password};
 
    print redirect(location=>"upload.html");

}
 
print <<END1;

<HTML>

<HEAD>

<TITLE> Media File Upload/Search System</TITLE>

</HEAD>
 
<body bgcolor="#003366">

<form NAME="login" ACTION="cgi-bin/login.cgi" METHOD="POST">

<img src="unilogo.gif" border=0> </img>
 
<font color="yellow"><h1>Media File Upload/Search System</h1></font>

<font color="white"><h3>Sign into File Upload/Search System</h3></font>
 
<TABLE>

<TR>

<TD ALIGN="right"><font color="white"><STRONG>Username:</STRONG><font></TD>

<TD><INPUT TYPE="text" SIZE=30 NAME="username"></TD>

</TR>
 
<TR>

<TD ALIGN="right"><font color="white"><STRONG>Password:</STRONG><font></TD>

<TD><INPUT TYPE="password" SIZE=30 NAME="password"></TD>

</TR>
 
</TABLE>
 
<style>

.box{

margin-left: 165px;

}

</style>
 
<TABLE class=box>

<TR>

<TD>

<a href="cgi-bin/newuser.cgi"><FONT color=c0c0c0 ><strong>New User</font></a>

<input type="hidden" name="ps" value="login">

<input type="submit" name="login" value="Login">

</TD>

</TR>
 
<TABLE>

<TR>

<TD ALIGN="left">

<a href="cgi-bin/deleteuser.cgi"><FONT color=c0c0c0 ><strong>Don't like this service, Delete User</font></a>

</TD>

</TR>
 
</TABLE>

</FORM>

</BODY>

</HTML>

END1
 
sub dienice {

    my ($msg) = @_;

    print "<h2>Error</h2>\n";

    print $msg;

    exit;

}
 
sub dbdie {

    my ($package, $filename, $line) = caller;

    my $errmsg = "Database error: $DBI::errstr<br> called from $package $filename line $line";

    &dienice($errmsg);

}

Mar 25 '07 #4

KevinADC

4,059

Expert 2GB

what does happen when you run the script?

Mar 26 '07 #5

miller

1,089

Expert 1GB

Hi olaamussah,

We have already been helping you with this problem in another thread. Please ask any related questions in the same thread so that we can be sure that you've heard and applied the advice that we've previously given. Otherwise, we will not be encouraged to help you any further.

Also, take the time to put a CODE tag around your code. This will help persist the formatting and therefore make it much easier to read.

I'm merging the threads now and will reformat your message. If I have time later, I'll take another look at your problem.

- Miller

Mar 26 '07 #6

Similar topics

by: janet | last post by:

hI ... I am newbie to ASP ... i am trying to write a code to accept login and passwor from a user and verify through a table created in MySQL. I am just trying to write a code on my own...

ASP / Active Server Pages

ASP Login / Database Help.

by: harris | last post by:

I am needing some help with a few asp pages and a login script. Let me start by describing my project. I am trying to connect to a database and verify a users login and password, then based on...

ASP / Active Server Pages

by: amit.purohit | last post by:

hi, I have a very strange problem on my login Page. the Page was working fine a few days back, but now does not generate post back events for controls. this login page uses form based...

.NET Framework

Basic simple dumb question

by: ItNerd | last post by:

Someone PLEASE HELP ME!!!!! All I want to do is a simple postback and grab the value from a textbox on clicking a linkbutton like below, but the value is not writing to the screen. I am...

ASP.NET

screen scrape + login

by: n8 | last post by:

Hi, Hi have to do the followign and have been racking my brain with various solutions that have had no so great results. I want to use the System.Net.WebClient to submit data to a form (log a...

ASP.NET

Simple Variable Pass on to SQL Where Query question.

by: Phillip Vong | last post by:

I'm a newbie using VS2005 to learn and test. I'm testing against the Northwind DB. I created a simple variable called "myVariable" and I assigned it the character "c". I want my SQL query to use...

ASP.NET

by: cyndithomas via AccessMonster.com | last post by:

I new to Visual Basic and am struck on a issue. Have created a Login in Screen for Remote User to access and input data. Want the Remote to be able to login & access the Input Form, and Manager...

Microsoft Access / VBA

ASP.NET Login and authentication

by: JamieHowarth0 | last post by:

Hi folks, Got a bit of an interesting question. I'm in the process of learning ASP.NET using Microsoft's CTP of Visual Web Studio "Orcas". Part of my classic ASP website incorporates a login...

.NET Framework

About simple form validation

by: sukatoa | last post by:

I am a newbie on JavaScript.... I would like to know about what's wrong in my code below: <html> <head> <title>Text Example</title> </head> <body>

Javascript

Looking to do Android software development, any suggestions? Is flutter better?

by: nemocccc | last post by:

hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?

General

How to build RAID in BIOS?

by: Hystou | last post by:

There are some requirements for setting up RAID: 1. The motherboard and BIOS support RAID configuration. 2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...

Computer Hardware

What is ONU?

by: marktang | last post by:

ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...

General

Changing the language in Windows 10

by: Hystou | last post by:

Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...

Windows Server

Problem With Comparison Operator <=> in G++

by: Oralloy | last post by:

Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers,...

C / C++

Maximizing Business Potential: The Nexus of Website Design and Digital Marketing

by: jinu1996 | last post by:

In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...

Online Marketing

The easy way to turn off automatic updates for Windows 10/11

by: Hystou | last post by:

Overview: Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...

Windows Server

Discussion: How does Zigbee compare with other wireless protocols in smart home applications?

by: tracyyun | last post by:

Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...

General

Couldn’t get equations in html when convert word .docx file to html file in C#.

by: conductexam | last post by:

I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and...

C# / C Sharp