Help with making playing cards

[slither101]

Hi, I have been working on this project for about three days now, and seem to be stuck on my conditional statements that specify the face and suit of the card when it is a Jack, Queen, King and Ace. Could someone take a look at my code and give me some helpful hints on what to change to get it to work? Any help is appreciated.

import java.util.Random;
/**
 * 
 * @author jparrish
 * 
 * This class encapsulates a playing card.
 *
 */
public class Card {
    private int suit;
    private int face;
 
    Random generator = new Random();
 
    public Card() {
        suit = generator.nextInt(4) + 1;
        face = generator.nextInt(12) + 2;
    }
 
    public Card(int suit, int face) {
        suit = this.suit;
        face = this.face;
    }
 
    public int getSuit() {
        return suit;
    }
 
    public void setSuit(int suit) {
        this.suit = suit;
    }
 
    public int getFace() {
        return face;
    }
 
    public void setFace(int face) {
        this.face = face;
    }
 
    public String toString() {
        if (this.suit == 1) {
            return this.face + " of Clubs";
        }
        if (this.suit == 2) {
            return this.face + " of Diamonds";
        }
        if (this.suit == 3) {
            return this.face + " of Hearts";
        }
        if (this.suit == 4) {
            return this.face + " of Spades";
        }
        if (this.face == 11) {
            return "Jack of " + this.suit;
        }
        if (this.face == 12) {
            return "Queen of ";
        }
        if (this.face == 13) {
            return "King of ";
        }
        if (this.face == 14) {
            return "Ace of ";
        }
 
 
        return this.getFace() + " " + this.getSuit();
    }
 
    public boolean equals(Card card) {
        if (card.getSuit() == this.getSuit()
                && card.getFace() == this.getFace())
            return true;
        else
            return false;
    }
 
}
 

[JosAH]

I'd say for starters change that 12 to 13 for your maximum face value.

kind regards,

Jos

[slither101]

Jos, thank you for the reply. I have changed my max face value to 13, but I still need help with my whole suit issue. If I put the suit statements before the face statements, then the suit will show up on all faces except it doesn't display the face values of jack, queen, king, and ace. instead it will just say 11 of spades, 12 of hearts, etc. I appreciate that tip, and all other advice is welcome. Thank you for your time.

Josh.

Oh, and here is my up to date code.

import java.util.Random;
/**
 * 
 * @author jparrish
 * 
 * This class encapsulates a playing card.
 *
 */
public class Card {
    private int suit;
    private int face;
 
    Random generator = new Random();
 
    public Card() {
        suit = generator.nextInt(4) + 1;
        face = generator.nextInt(13) + 2;
    }
 
    public Card(int suit, int face) {
        suit = this.suit;
        face = this.face;
    }
 
    public int getSuit() {
        return suit;
    }
 
    public void setSuit(int suit) {
        this.suit = suit;
    }
 
    public int getFace() {
        return face;
    }
 
    public void setFace(int face) {
        this.face = face;
    }
 
    public String toString() {
        if (this.suit == 1) {
            return this.face + " of Clubs";
        }
        if (this.suit == 2) {
            return this.face + " of Diamonds";
        }
        if (this.suit == 3) {
            return this.face + " of Hearts";
        }
        if (this.suit == 4) {
            return this.face + " of Spades";
        }
        if (this.face == 11) {
            return "Jack of " + this.suit;
        }
        if (this.face == 12) {
            return "Queen of ";
        }
        if (this.face == 13) {
            return "King of ";
        }
        if (this.face == 14) {
            return "Ace of ";
        }
 
 
        return this.getFace() + " " + this.getSuit();
    }
 
    public boolean equals(Card card) {
        if (card.getSuit() == this.getSuit()
                && card.getFace() == this.getFace())
            return true;
        else
            return false;
    }
 
}
 

[JosAH]

Jos, thank you for the reply. I have changed my max face value to 13, but I still need help with my whole suit issue. If I put the suit statements before the face statements, then the suit will show up on all faces except it doesn't display the face values of jack, queen, king, and ace. instead it will just say 11 of spades, 12 of hearts, etc. I appreciate that tip, and all other advice is welcome. Thank you for your time.

Your toString() method is goofy, i.e. after you've found the suit (and you always)
find one of them) you simply return a String using the numerical value of the face
value. Better split that method up in a few methods: one for the face values and one
for the suit values. Your toString() method will be something like this then:

public String toString() { return getFaceName()+" of "+getSuitName(); }
 

kind regards,

Jos

[slither101]

Hey Jos, thanks for the help! I got it working now. I appreciate you taking your time to help a new programmer out. Thank you so much. Here's my final code. Thanks!

import java.util.Random;
/**
 * 
 * @author jparrish
 * 
 * This class encapsulates a playing card.
 *
 */
public class Card {
    private int suit;
    private int face;
 
    Random generator = new Random();
 
    public Card() {
        suit = generator.nextInt(4) + 1;
        face = generator.nextInt(13) + 2;
    }
 
    public Card(int suit, int face) {
        suit = this.suit;
        face = this.face;
    }
 
    public int getSuit() {
        return suit;
    }
 
    public void setSuit(int suit) {
        this.suit = suit;
    }
 
    public int getFace() {
        return face;
    }
 
    public void setFace(int face) {
        this.face = face;
    }
 
    public String getFaceName(){
        if(this.getFace() == 2){
            return "2";
        }
        if(this.getFace() == 3){
            return "3";
        }
        if(this.getFace() == 4){
            return "4";
        }
        if(this.getFace() == 5){
            return "5";
        }
        if(this.getFace() == 6){
            return "6";
        }
        if(this.getFace() == 7){
            return "7";
        }
        if(this.getFace() == 8){
            return "8";
        }
        if(this.getFace() == 9){
            return "9";
        }
        if(this.getFace() == 10){
            return "10";
        }
        if(this.getFace() == 11){
            return "Jack";
        }
        if(this.getFace() == 12){
            return "Queen";
        }
        if(this.getFace() == 13){
            return "King";
        }
        if(this.getFace() == 14){
            return "Ace";
        }
        return this.getFaceName();
 
    }
    public String getSuitName(){
        if(this.getSuit() == 1){
            return "Clubs";
        }
        if(this.getSuit() == 2){
            return "Hearts";
        }
        if(this.getSuit() == 3){
            return "Diamonds";
        }
        if(this.getSuit() == 4){
            return "Spades";
        }
        return this.getSuitName();
    }
 
    public String toString() {
        return getFaceName() + " of " + getSuitName();
    }
 
    public boolean equals(Card card) {
        if (card.getSuit() == this.getSuit()
                && card.getFace() == this.getFace())
            return true;
        else
            return false;
    }
 
}
 

-Josh

[JosAH]

Hey Jos, thanks for the help! I got it working now. I appreciate you taking your time to help a new programmer out. Thank you so much. Here's my final code. Thanks!

You're welcome of course. Hint: you can use switch statements for the suit and
face names; the face method can even be this:

switch (face) {
   case 11: return "jack";
   case 12: return "queen";
   case 13: return "king";
   case 14: return "ace";
   default: return ""+face;
}
 

kind regards,

Jos