|| name | Spartanicus <me@privacy.net> | message |
|| news:ns********************************@news.spart anicus.utvinternet.i
|| e: ||
slim <sl**@antiCorp.invalid> wrote:
feel free to pull apart the
rest of the site for bad practice, i'm open to comments to improve the
code.
XHTML 1.0 Transitional
Using XHTML is silly, Transitional is for legacy documents, newly
authored documents should use Strict.
i tried to change this, checked it out in 3 browsers and found a total
mess in ie6 & opera7.1. although, i think that may have been me tinkering
before. i will leave this as is until i sort out my current problems and
then change it.
<div id="header"><h1>
Why the div wrapper? H1 is a block level element, styles you have
attached to the wrapper div can be added to the H1.
when i take away the containing div, the header does not accept all the
style attributes i give it and does not display the same. for example, in
firefox, there is a gap between the bottom of header.jpg and the bottom
border. is there some part of <h> tags that overrules styles i apply?
<div id="navigation">
That's a list.
good point. that's kind of done, except i'm still using a div to frame
it, or <ul> won't take the style attributes i need to keep the design the
same.
<p>
<span class="current">latest</span>
That's not a paragraph.
also fixed, thanks.
<input type="text" name="criteria" style="width:6em;">
Move the inline css to the external stylesheet.
have done, thank you.
Margins should be specified via css.
this was used as part of a fix i found whilst browsing: i want to display
the dotted boxes containing each t-shirt in a row until they need to
break for a new line, this trick was recommended to fix the fact that
they float:left and so occupy no space.
is there a better way to do this? i am currently using a slightly
different version of the same workaround, i'd like to be able to achieve
the boxes displaying as i describe legitimately if possible.
<div id="contentwrap">
<div id="rightcol">
<h2>latest tees</h2>
<div class="teeblock_outercontainer">
Div/span soup.
too many? the contentwrap div was used to fix a bug (which has now
reappeared) where the right column was appearing after the left column
vertically.
the rightcol div is then defined to house the various parts 10em across
so as to meet the leftcol - is this not necessary then?
and finally, the divs used to construct the t-shirt dotted boxes were the
only way i could see to achieve the look i wanted without using a table -
would you be able to suggest a better way of achieving that style with
cleaner code?
i'm new(ish) to this and willing to learn, but i'm kind of putting things
together as i pick it up, so it's not always the best approach.
<div class="spacer"> </div>
Again, margins should be specified with css.
see my response above. i'd love to know how to eliminate this if
possible.
<img src='./images/tees/thumbs/t_shitwizard.jpg' class='tee_thumbnail'
alt='you are the shitwizard!'/>
The images should not be resized by the browser, and definitely not by
specifying the desired dimensions in css.
really? i thought i would be doing the user a favour by defining a fixed
aspect ratio in ems so the images would resize with the user's font.
could you explain why it is bad practice?
thanks very much for all the critique - it's been a help. now if only i
could fix that damned right column, i would move on to sorting out the
other bits!
--
slim