map/set iterators incompatible

[lakshmiyc]

I have defined the following in the header file(mappingItem.h).
typedef std::map <int, std::string> mappingItem;
mappingItemType m1;
mappingItemType m2;

And in mappingItem.cpp i m getting error in the below mention line.
std::stringstream source_val;
std::stringstream target_val;
source_val << m1.size();
target_val << m2.size();
if ( m1.size() == m2.size() )
{
/*I m getting a run time error here..*/
mappingItem::iterator source = m1.begin();
mappingItem::iterator target = m2.begin();

for( ; source != m1.end() && source != m2.end() ;source++, target++ )
{
/*code is here*/
}
Can anybody suggest??? please help....

[weaknessforcats]

If this is in your header file:

typedef std::map <int, std::string> mappingItem;
 mappingItemType m1;
 mappingItemType m2;
 

Then a) thrre is no mappintItemType so there is no m1 and b) everytime you incude this header an instance of m1 and m2 will be created.

It is a hard fule that you do not put executable code in your header files. You only put declarations, so the typedef is appropriate.
Create yout m1 and m2 in a .cpp that is art of the build.

Fix these problems and then repost your code.

Also, you might read this: http://bytes.com/topic/c/insights/73...obal-variables

[lakshmiyc]

I have changed it.. But still i m getting RunTime error..

[lakshmiyc]

typedef std::map <int, std::string> mappingItemType;

And in mappingItem.cpp i m getting error in the below mention line.
mappingItemType m1;
mappingItemType m2;

std::stringstream source_val;
std::stringstream target_val;
source_val << m1.size();
target_val << m2.size();
if ( m1.size() == m2.size() )
{
/*I m getting a run time error here..*/
mappingItemType::iterator source = m1.begin();
mappingItemType::iterator target = m2.begin();

for( ; source != m1.end() && source != m2.end() ;source++, target++ )
{
/*code is here*/
}

[lakshmiyc]

can anybody suggest?? :(:(

[Banfa]

source != m2.end() source is an iterator into m1, there is no point comparing it to m2.end() it will never be equal did you mean target != m2.end() ?