Max and Minimum value in arrays

[mingke]

I tried to find max and min value from arrays. and my code so far looks like this:

for (i=0; i<size2; i++){
          for (j = 0; j < 4; j++){
            by_max[i]=by[i][0];
                if (by[i][j]>by_max[i]){
                    by_max[i]=by[i][j];
                }
            by_min[i]=by[i][0];
              if (by[i][j]<by_min[i]){
                by_min[i]=by[i][j];
               }           
       }
  }   
 

My difficulty is this; the max loop runs perfectly. however the min loop only serves to find the max value somehow. So the min value is same with max value.
I cannot see how it's failing at all, at all. Does anyone have any ideas?

Thank you.

[JosAH]

Move those lines #3 and #7 before your line #2.

kind regards,

Jos

[mingke]

Thank you, Jos..

That solve my problem...

[lonbame]

can do this

//max
max=arr[0];
for(i=0;i<4;i++)
{
 if(arr[i]>max)
  max=arr[i];
}
//min
min=arr[0];
for(i=0;i<4;i++)
{
 if(arr[i]<max)
  max=arr[i];
}
 

[donbock]

You can make this more efficient.
There is no reason to scan the array twice.
If the initial values for max and min are copied from arr[0] outside the loop(s) then you don't need to scan the 0th array element.

[Bassem]

And one for loop is enough, Isn't it?

[JosAH]

@Bassem
The OP wanted to find a min and max value for every row of a matrix; moving the initialization out of the inner loop (as I replied) did the trick. I always prefer to return a pointer to the min or max values just in case there are no values.

kind regards,

Jos

[Bassem]

Sorry for that, I didn't recognize there is a matrix.

I just ate, thanks