470,604 Members | 2,024 Online

# Optimization of Binary Converter 2
Hello all,
Could anyone explain how to optimization this code? In the prosess of optimization what is the factor needed and important to know about it?
Thank you very much for all.
Expand|Select|Wrap|Line Numbers
1. /********************************************************/
2. /*                    Binary converter                  */
3. /*                     By Matt Fowler                   */
4. /*                email address removed              */
5. /*  converts text into binary using the division method */
6. /*                   through ASCII code                 */
7. /*compiled with the Dev-C++ compiler (www.bloodshed.net)*/
8. /********************************************************/
9.
10. #include <iostream>
11. using namespace std;
12. #include <cstring>
13. #include <cstdlib>
14.
15. char *entry, letter, choice;
16. int ascii, len, binary, total;
17. void prog();
18.
19. int main()
20. {
21.       prog();
22.       return 0;
23. }
24.
25. void prog()
26. {
27.    entry = new char;
28.    /* entry should be dynamic, otherwise a new
29.       string entry of 501 chars would be created
30.       each time function is called!
31.       Talk about memory hog! */
32.    cout<<"Enter string to convert (up to 500 chars): ";
33.    cin.getline(entry, 500);
34.    len = strlen(entry);  /* get the number of characters in entry. */
35.    /* this loop is executed for each letter in the string. */
36.    for(int i = 0; i<len; i++)
37.    {
38.       total = 0;
39.       letter = entry[i]; /* store the first letter */
40.       ascii = letter;    /* put that letter into an int, so we can
41.                             see its ASCII number */
42.       while(ascii>0) /* This while loop converts the ASCII # into binary,
43.                         stores it backwards into the binary array. */
44.       {
45.          /* To get the binary code one must take the decimal number in
46.             question, take it and divide it by two repeatedly, save
47.             the remainder (which will become the binary number), save
48.             the whole number, divide by two, and repeat the whole
49.             process until 0 is reached.  This if-else statement serves
50.             this functionality, by getting the remainder of the ascii
51.             code, storing it in the array and then dividing the int
52.             ascii by two */
53.          if((ascii%2)==0)
54.          {
55.             binary[total] = 0;
56.             ascii = ascii/2;
57.             total++; /* increasing by one each time will yeild the
58.                         number of numbers in the array. */
59.          }
60.          else
61.          {
62.             binary[total] = 1;
63.             ascii = ascii/2;
64.             total++;
65.          }
66.       }
67.       total--; /* due to data type factors, the program will actually
68.                   add a 0 at the end of the array that is not supposed
69.                   to be there, decrementing total will solve this
70.                   problem, as that 0 will not be displayed. */
71.       /* this while loop displays the binary code for that letter. */
72.       while(total>=0)
73.       {
74.          cout<<binary[total];
75.          total--;
76.       }
77.    }
78.    delete[] entry; /* free up the memory used by entry */
79.    cout<<endl<<"Do again(1 = yes, 2= no)?: ";
80.    cin.getline(choice,3);
81.    if(choice == '1')
82.       prog(); /* program is recursive, it calls itself.  It's kinda
83.                  like a function loop of sorts. */
84.    else
85.       exit(0); /* quits the program */
86. }
Feb 18 '08 #1
3 3193 weaknessforcats
9,208 Expert Mod 8TB
The characters in a string are already integers. That is, a char containing A is already in binary. Has to be. It's in the computer. In this case the A is 65 so all you need do is convert that 65 to binay.

You convert the char directly to binary.

(str[i] / n ) % 2 ) will get the bit in column n for the ith character in the string str. Just vary n as a power of 2 from 1 to 128.
Feb 18 '08 #2
logaelo
2 The characters in a string are already integers. That is, a char containing A is already in binary. Has to be. It's in the computer. In this case the A is 65 so all you need do is convert that 65 to binay.

You convert the char directly to binary.

(str[i] / n ) % 2 ) will get the bit in column n for the ith character in the string str. Just vary n as a power of 2 from 1 to 128.
Sir, how to check this code can improve performance and usage memory because i'm beginner to know C and dont know about optimization. Could you explain reference about optimization in website. Because it's important for me.
Thanks all.
Feb 18 '08 #3
007india
1 // Binary converter converts text into binary using the division method through ASCII code

#include <iostream>
using namespace std;

char entry, letter;
int ascii, len, binary, total, choice;
void prog();

int main()
{
prog();
return 0;
}

void prog()

{
do
{
/* entry should be dynamic, otherwise a new
string entry of 501 chars would be created
each time function is called!
cout<<"Enter string to convert (up to 500 chars): ";
cin>>entry;
len = strlen(entry); /* get the number of characters in entry. */
for(int i = 0; i<len; i++)
{
total = 0;
letter = entry[i]; /* store the first letter */
ascii = letter; /* put that letter into an int, so we can
see its ASCII number */
while(ascii>0) /* This while loop converts the ASCII # into binary,
stores it backwards into the binary array. */
{
/* To get the binary code one must take the decimal number in
question, take it and divide it by two repeatedly, save
the remainder (which will become the binary number), save
the whole number, divide by two, and repeat the whole
process until 0 is reached. This if-else statement serves
this functionality, by getting the remainder of the ascii
code, storing it in the array and then dividing the int
ascii by two */
if((ascii%2)==0)
{
binary[total] = 0;
ascii = ascii/2;
total++; /* increasing by one each time will yeild the
number of numbers in the array. */
}
else
{
binary[total] = 1;
ascii = ascii/2;
total++;
}
// cout<<binary[6-total];
}
total--; /* due to data type factors, the program will actually
add a 0 at the end of the array that is not supposed
to be there, decrementing total will solve this
problem, as that 0 will not be displayed. */
/* this while loop displays the binary code for that letter. */
while(total>=0)
{
cout<<binary[total];
total--;
}
} /* this loop is executed for each letter in the string. */

cout<<endl<<"Do again(1 = yes, 2= no)?: ";
cin>>choice;
} while (choice==1);
}
Jun 5 '09 #4