Debug program errors

[momotaro]

am supposed to have the same data that i have entred but its not the case!!!
can you help me????

#include<stdio.h>
 
typedef struct
{
    char name[20];
    double salary;
    int rank;
}employee;
 
void fill_up(employee arr[]);
void display(employee arr[]);
 
void main()
{
    employee arr[2];
    fill_up(arr);
    display(arr);
    while(1);
}
 
void fill_up(employee arr[])
{
    int i;
    for(i = 0; i < 2; i++)
    {
        printf("name --> ");
        scanf("%s", &arr[i].name);
        printf("salary --> ");
        scanf("%lf", &arr[i].salary);
        printf("rank --> ");
        scanf("%d", &arr[i].rank);
    }
}
 
void display(employee arr[])
{
    int i;
    for(i = 0; i < 2; i++)
    {
        printf("\n\n\n\nname --> %s", &arr[i].name);
        printf("\nsalary --> %.2f", &arr[i].salary);
        printf("\nrank --> %d", &arr[i].rank);
    }
}

[AdrianH]

Hi,

The problem is your scanf("%s", &arr[i].name); If you are going to get the address of the first char of name, you have to specify the array index. Otherwise you have a char** instead of a char*, which I think would point at a temporary location on the stack in the frame of the function. You have the same problem with your printf's.

Basically, &arr[i].name is the equivalent of saying "Given the char pointer arr[i].name, give me back the address of that pointer." because arr[i].name is a pointer to the first element in the array.

So either say arr[i].name or &arr[i].name[0].


Adrian

P.S. If you use gcc or g++, use the -Wall option as it will give you a whack of warnings that will inform you when you are doing something fishy. If you are using another compiler, tell it to turn warnings on. Warnings are your friend, not your nemesis.

[kvbreddy]

One more issue in the above code is -
If the input of the name field is more than a single word, the scanf("%s", arr[i].name); function takes the first word as the name and left the remaining input to the following fields.

So use the following to avoid the above problem

scanf("%[^\n]", arr[i].name);

It reads a string until it encounters neline character

[kvbreddy]

One more bug in ur code is ..

Don't use & for printing fileds..Replacements for ur error statements

printf("\nsalary --> %.2f", arr[i].salary);
printf("\nrank --> %d", arr[i].rank);

Now ur code works perfecltly.

Vijay