Sending email using System.Net.Mail worked ok untill this morning exception popup

[Chocolade]

Hi,

Im using System.Net.Mail to send email in my application it was working great without any problems untill this morning after like 20-30 tries it was sending the email ok then suddenly this morning i got an exception and i cant figure out what/where the problem is and how to fix it.

The problem say i have some invalid char:

invalid character was found in the mail header: 'י'.
Now this char 'י' is an hebrew letter. But i searched over and over my code all day and this char dosent exist anywhere! I cant understadn why and where from this came up. It worked perfect for the last two days then this morning this exception.

I tried to clear the log file im sending wich is txt file i tried to add some encodinds in my code for the header didnt work. Something unf8 encoding. I tried to change the email address im sending to but didnt work.
I cant figure out how come it worked perfect and this morning suddenly it dosent work.

Maybe something with the gmail smtp address and port changed in the last few hours? Im sending the email from my gmail account to my regular account and it worked no problems!
I tried google all day long and tried what ppl said with encoding but it didnt help maybe i didnt do it right but it didnt help. This is crazy since it worked so good and now it dosent.

Here is my email sending code:

private void button8_Click(object sender, EventArgs e)
         {
             try
             {
                 if (File.Exists(logger_file_to_read + tlf))
                 {
                     File.Delete(logger_file_to_read + tlf);
                 }
                     File.Copy(logger_file_to_read + log_file_name, logger_file_to_read + tlf);
                 message = new MailMessage(
                   "[e-mail]",
                   "[e-mail]",
                   "Log File Report",
                   "See the attached log file and check for errors as the user have requested.");
                 data = new Attachment(logger_file_to_read + tlf, MediaTypeNames.Application.Octet);
                 ContentDisposition disposition = data.ContentDisposition;
                 disposition.CreationDate = System.IO.File.GetCreationTime(tlf);
                 disposition.ModificationDate = System.IO.File.GetLastWriteTime(tlf);
                 disposition.ReadDate = System.IO.File.GetLastAccessTime(tlf);
                 // Add the file attachment to this e-mail message.
                 message.Attachments.Add(data);
                 SmtpClient ss = new SmtpClient("smtp.gmail.com", 587);
                 ss.EnableSsl = true;
                 ss.Timeout = 10000;
                 ss.DeliveryMethod = SmtpDeliveryMethod.Network;
                 ss.UseDefaultCredentials = false;
                 ss.Credentials = new NetworkCredential("chocolade13091972", "ynnadaniel");
                 ss.SendCompleted+=new SendCompletedEventHandler(ss_SendCompleted);
                 string userState = "test message1";
                 ss.SendAsync(message,userState);
                 label11.Enabled = true;
                 label11.Visible = true;
                 label11.BackColor = Color.DarkSeaGreen;
                 label11.Text = "Sending email please wait"; 
             }
             catch (Exception errors)
             {
                 Logger.Write("Error sending message :" + errors);
             }
         }
         private void ss_SendCompleted(object sender, AsyncCompletedEventArgs e)
         {
             String token = (string)e.UserState;
             if (e.Cancelled)
             {
                 Logger.Write("[{0}] Send canceled."+ token);
             }
             if (e.Error != null)
             {
                 label11.Enabled = true;
                 label11.Visible = true;
                 label11.BackColor = Color.DarkSeaGreen;
                 label11.Text = "There was a problem with sending the log file please try again later and check the log file for more information";
                 Logger.Write("There was a problem with sending the log file please try again later and check the log file for more information :" + e.Error.ToString());
             }
             else
             {
                 label11.Enabled = true;
                 label11.Visible = true;
                 label11.BackColor = Color.DarkSeaGreen;
                 label11.Text = "Email have sent successfully";
                 Logger.Write("Attached log file have been sent");
             }
             message.Dispose();
             File.Delete(logger_file_to_read + tlf);
         }
 

Thanks for helping.

[Plater]

HAve you verified which line of the code throws the error, or does it just happen on the SendAsync?
Also, if you cast to the actually exception type, you can probably get more details about where the error occured. (Like if it happened during the DATA section or the RCPT TO section, etc)

[Chocolade]

Plater it dosent show wich line.
Here is the exception i copied from the error:

25/10/2010 22:51:51 -> There was a problem with sending the log file please try again later and check the log file for more information :System.Net.Mail.SmtpException: Failure sending mail. ---> System.FormatException: An invalid character was found in the mail header: 'י'.
at System.Net.Mime.MimeBasePart.EndSend(IAsyncResult asyncResult)
at System.Net.Mail.SmtpClient.SendMessageCallback(IAs yncResult result)
--- End of inner exception stack trace ---

I will try to find wich line is it i think its on the sending line: ss.SendAsync(message,userState);
Cuz i used a breakpoint and moved line by line and the error came up after the SendAsync not before.

Plater here is the full exception on the send line:

25/10/2010 22:59:51 -> error :System.Net.Mail.SmtpException: Failure sending mail. ---> System.FormatException: An invalid character was found in the mail header: 'י'.
   at System.Net.Mime.MailBnfHelper.GetTokenOrQuotedString(String data, StringBuilder builder)
   at System.Net.Mime.ContentDisposition.ToString()
   at System.Net.Mime.ContentDisposition.PersistIfNeeded(HeaderCollection headers, Boolean forcePersist)
   at System.Net.Mime.MimePart.Send(BaseWriter writer)
   at System.Net.Mime.MimeMultiPart.Send(BaseWriter writer)
   at System.Net.Mail.SmtpClient.Send(MailMessage message)
   --- End of inner exception stack trace ---
   at System.Net.Mail.SmtpClient.Send(MailMessage message)
   at WindowsFormsApplication1.Form1.button8_Click(Object sender, EventArgs e) in D:\C-Sharp\Download File\Downloading-File-Project-Version-010\Downloading File\Downloading File\Form1.cs:line 1664
 

And line 1664 in my code is the sending line: ss.SendAsync(message,userState);

Any ideas what cuz make this exception?
I tried also instead sendasync just: ss.Send(message);
But same exception.

Thanks.

[eyalk]

Hi,

I am encoutring the same problem.

Did you find a solution for this?

Thanks.

[Chocolade]

Eyalk Hi ill post here my code wich is working since then if im not mistaken i changed almost the whole code of sending the email.

private void SendLogFile_Click(object sender, EventArgs e)
        {
            try
            {
                MailAddress from = new MailAddress("[e-mail]", "User " + (char)0xD8 + " Name",
                System.Text.Encoding.UTF8);
                MailAddress to = new MailAddress("here you put your own original email or another email to get the email");
                message = new MailMessage(from, to);
                message.Body = "Please check the log file attachment i have some bugs.";
                string someArrows = new string(new char[] { '\u2190', '\u2191', '\u2192', '\u2193' });
                message.Body += Environment.NewLine + someArrows;
                message.BodyEncoding = System.Text.Encoding.UTF8;
                message.Subject = "Log File For Checking Bugs" + someArrows;
                message.SubjectEncoding = System.Text.Encoding.UTF8;
                Attachment myAttachment = new Attachment(logger_file_to_read + tlf, MediaTypeNames.Application.Octet);
                message.Attachments.Add(myAttachment);
                SmtpClient ss = new SmtpClient("smtp.gmail.com", 587);
                ss.SendCompleted += new SendCompletedEventHandler(ss_SendCompleted);
                ss.EnableSsl = true;
                ss.Timeout = 10000;
                ss.DeliveryMethod = SmtpDeliveryMethod.Network;
                ss.UseDefaultCredentials = false;
                ss.Credentials = new NetworkCredential("password if you need autheniticate password username for your email", "same here if autheniticate is needed");
                string userState = "test message1";
                ss.SendAsync(message, userState);
                label3.Enabled = true;
                label3.Visible = true;
                label3.BackColor = Color.DarkSeaGreen;
                label3.Text = "Sending email please wait";
            }
 
            catch (Exception errors)
            {
                Logger.Write("Error sending message :" + errors);
            }
        }
 

Tell me if its working for you or not.

Thanks.

[Chocolade]

Eyalk and here is the code for the ss.SendCompleted += new SendCompletedEventHandler(ss_SendCompleted);

Wich is when the file/email seding sinished completed.

private void ss_SendCompleted(object sender, AsyncCompletedEventArgs e)
        {
            timerdelay = 0;
            timer1.Start();
            String token = (string)e.UserState;
            if (e.Cancelled)
            {
                Logger.Write("[{0}] Send canceled." + token);
                SendLogFile.Enabled = true;
            }
            if (e.Error != null)
            {
                label3.Enabled = true;
                label3.Visible = true;
                label3.BackColor = Color.DarkSeaGreen;
                label3.Text = "There was a problem with sending the log file please try again later and check the log file for more information";
                Logger.Write("There was a problem with sending the log file please try again later and check the log file for more information :" + e.Error.ToString());
                SendLogFile.Enabled = true;
            }
            else
            {
                message.Dispose();
                label3.Enabled = true;
                label3.Visible = true;
                label3.BackColor = Color.DarkSeaGreen;
                label3.Text = "Email have been sent successfully";
                Logger.Write("Attached log file have been emailed successfully");
                File.Delete(logger_file_to_read + log_file_name);
                SendLogFile.Enabled = false;
            }
        }
 

I added a timer in the completed event so when im getting any message for example if the email sent successfully the message will move after few seconds i think 5 seconds or so...so it wont stay there all the time say the message sent successfully it might be confusing.

[eyalk]

Thanks.
It works.
The reason that it didn't work is because that the region & language format was set to 'Hebrew'.
Once you removed the following code You solved the problems.
The other solution is to change the regional settings format to English.

ContentDisposition disposition = data.ContentDisposition; 
                 disposition.CreationDate = System.IO.File.GetCreationTime(tlf); 
                 disposition.ModificationDate = System.IO.File.GetLastWriteTime(tlf); 
                 disposition.ReadDate = System.IO.File.GetLastAccessTime(tlf);

Thanks for the help!