injecting javascript fails all the time?

[Andy B]

I have the following code inside of a Wizard_Finish_Button_Click event:
NewsDB NewsHelper = new NewsDB();
if(NewsHelper.AddNews(DateTime.Now, SubjectTextBox.Text, BodyTextBox.Text))
{
StringBuilder PopUp = new StringBuilder();

PopUp.Append("<script language = 'javascript'>");

PopUp.Append("alert('Your news article was added successfully!');<");

PopUp.Append("/script>");

ClientScript.RegisterClientScriptBlock(GetType(), "PopupScript",
PopUp.ToString());

Server.Transfer("index.aspx");

}

else {

StringBuilder PopUp = new StringBuilder();

PopUp.Append("<script language = 'javascript'>");

PopUp.Append("alert('Warning! Couldn't add your news article for some
reason!');<");

PopUp.Append("/script>");

ClientScript.RegisterClientScriptBlock(GetType(), "PopupScript",
PopUp.ToString());

AddNewsWizard.ActiveStepIndex=0; //if adding failed, reset and start over...

}

When the event runs, everything works/fails like expected except for the
javascript part. For some reason it gets ignored. Any way to fix this? I got
my example from
http://dotnetslackers.com/articles/a...ges_Part1.aspx
The whole idea was to show a popup saying the add worked if it worked and
show one saying it failed if it failed.

[Mark Rae [MVP]]

"Andy B" <a_*****@sbcglobal.netwrote in message
news:uH**************@TK2MSFTNGP04.phx.gbl...

PopUp.Append("<script language = 'javascript'>");
PopUp.Append("/script>");

Firstly, don't do that... For one thing, the language tag is now
deprecated... Instead, use the boolean overload which will make ASP.NET add
the script tags for you correctly:
http://msdn2.microsoft.com/en-us/library/z9h4dk8y.aspx

StringBuilder PopUp = new StringBuilder();

Secondly, there's really no need to use a StringBuilder for this...

ClientScript.RegisterClientScriptBlock

Thirdly, you're using the wrong method...

Server.Transfer("index.aspx");

Finally, if you do that, then your page is never going to get streamed to
the browser so your JavaScript will never run no matter how you inject it...
:-)

Any way to fix this?

if(NewsHelper.AddNews(DateTime.Now, SubjectTextBox.Text, BodyTextBox.Text))
{
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Your news article was added
successfully!');window.location='index.aspx';");
}
else
{
AddNewsWizard.ActiveStepIndex=0; //if adding failed, reset and start
over...
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Warning! Couldn't add your news article for some reason!');");
}
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Andy B]

I tried the below code just as it is shown here and it still doesnt do
anything at all. Any other ideas?

Any way to fix this?

if(NewsHelper.AddNews(DateTime.Now, SubjectTextBox.Text,
BodyTextBox.Text))
{
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Your news article was added
successfully!');window.location='index.aspx';");
}
else
{
AddNewsWizard.ActiveStepIndex=0; //if adding failed, reset and start
over...
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Warning! Couldn't add your news article for some reason!');");
}
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Mark Rae [MVP]]

"Andy B" <a_*****@sbcglobal.netwrote in message
news:%2****************@TK2MSFTNGP06.phx.gbl...

Any way to fix this?

if(NewsHelper.AddNews(DateTime.Now, SubjectTextBox.Text,
BodyTextBox.Text))
{
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Your news article was added
successfully!');window.location='index.aspx';") ;
}
else
{
AddNewsWizard.ActiveStepIndex=0; //if adding failed, reset and start
over...
ClientScript.RegisterStartupScript(GetType(), "PopupScript",
"alert('Warning! Couldn't add your news article for some reason!');");
}

I tried the below code just as it is shown here and it still doesn't do
anything at all. Any other ideas?

Is it even being reached? If you put a breakpoint on the first line, does it
get hit...?

If you do a View Source after the page has loaded, is the script there...?
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Andy B]

Nope... breakpoints aren't noticed and looking at the source shows that
there are no <scriptblocks anywhere...

Is it even being reached? If you put a breakpoint on the first line, does
it get hit...?

If you do a View Source after the page has loaded, is the script there...?
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Mark Rae [MVP]]

"Andy B" <a_*****@sbcglobal.netwrote in message
news:uz****************@TK2MSFTNGP03.phx.gbl...

>Is it even being reached? If you put a breakpoint on the first line, does
it get hit...?

Nope... breakpoints aren't noticed

>If you do a View Source after the page has loaded, is the script
there...?

and looking at the source shows that there are no <scriptblocks
anywhere...

In which case, you have a much more fundamental problem, and you'll need to
look at your entire page, rather than just the JavaScript injection, to work
out why your function is not getting called...
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Mark Rae [MVP]]

"Andy B" <a_*****@sbcglobal.netwrote in message
news:em**************@TK2MSFTNGP02.phx.gbl...

Here is the code for the method AddNews that might be in question:

Might there ge something wrong here?

There might... step through it and check...
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Andy B]

How? when I do it loads the index.aspx for the whole site and the page is
naturally inaccessible as it is... any idea how to fix this?
"Mark Rae [MVP]" <ma**@markNOSPAMrae.netwrote in message
news:%2****************@TK2MSFTNGP02.phx.gbl...

"Andy B" <a_*****@sbcglobal.netwrote in message
news:em**************@TK2MSFTNGP02.phx.gbl...

>Here is the code for the method AddNews that might be in question:

>Might there ge something wrong here?

There might... step through it and check...
--
Mark Rae
ASP.NET MVP
http://www.markrae.net

[Mark Rae [MVP]]

"Andy B" <a_*****@sbcglobal.netwrote in message
news:u5****************@TK2MSFTNGP04.phx.gbl...

How? when I do it loads the index.aspx for the whole site and the page is
naturally inaccessible as it is... any idea how to fix this?

Put a breakpoint on the first line of the first Page_xxx method in the page
in question...
--
Mark Rae
ASP.NET MVP
http://www.markrae.net