Classic ASP Variable Question

[polymorphic]

I have passed some variables via a querystring to an asp page. The variables are passing ok but when I try to concatenate them into a string sql statement they are not appearing:

For example:

dim RecordID, callerPage, FlaggerID
 
RecordID = Request("edit")
callerPage = Request("callerPage")
FlaggerID = Request("flagger")
 
'Response.Write ("flagger is: " & FlaggerID)   '<-------variables will print here!
'Response.Write ("  /     RecordID is : " & RecordID)
 
if request("act") = "update" then
sql_update = "Update TimeAct set reviewerNotes= '" & replace(request("reviewerNotes"),"'", "''") & "'"
sql_update = sql_update & ", Flagged = 1, FlaggerID = " & FlaggerID & ", FlaggedDate = '" & Now() & "' where [ID] = " & RecordID
response.Write sql_update   '<---------Variables do not show here in this string!
response.end
conn.Execute sql_update

What am I doing wrong? I've tried using a straight Request("flagger") in the concatenation and that did not work.

Thanks,
cj

[ilearneditonline]

dim RecordID, callerPage, FlaggerID
 
RecordID = Request("edit")
callerPage = Request("callerPage")
FlaggerID = Request("flagger")
 
'Response.Write ("flagger is: " & FlaggerID) '<-------variables will print here!
'Response.Write (" / RecordID is : " & RecordID)
 
if request("act") = "update" then
sql_update = "Update TimeAct set reviewerNotes= '" & replace(request("reviewerNotes"),"'", "''") & "'"
sql_update = sql_update & ", Flagged = 1, FlaggerID = " & FlaggerID & ", FlaggedDate = '" & Now() & "' where [ID] = " & RecordID
response.Write sql_update '<---------Variables do not show here in this string!
response.end
conn.Execute sql_update

What am I doing wrong? I've tried using a straight Request("flagger") in the concatenation and that did not work.

Thanks,
cj

Are you sure this is happening? If I comment this out, I can get the code to display properly.

 if request("act") = "update" then

[polymorphic]

Are you sure this is happening? If I comment this out, I can get the code to display properly.

 if request("act") = "update" then

The SQL output I get is:

Update TimeAct set reviewerNotes= 'ddd', Flagged = 1, FlaggerID = , FlaggedDate = '7/25/2007 2:37:26 PM' where [ID] =

If I change the code to:

sql_update = "Update TimeAct set reviewerNotes= '" & replace(request("reviewerNotes"),"'", "''") & "'"
sql_update = sql_update & ", Flagged = 1, 
FlaggerID = " & Request.Form("FlaggerID") & 
", FlaggedDate = '" & Now() & "' where [ID] = " 
& Request.Form("RecordID")

then I can get the ID to pull:

Update TimeAct set reviewerNotes= 'ddd', Flagged = 1, FlaggerID = , FlaggedDate = '7/25/2007 2:37:26 PM' where [ID] = 39987

I am calling the page and passing these values as:

<A ID="<%=flagName%>" HREF="javascript:void();" onClick="popWin('/timesheet_Flag.asp?edit=<%=rs.Fields("ID")%>&callerPage=review&flagger=<% = FlaggerID%>', 'TimesheetFlag', 700,650); return false;">flag</A> <br>

I don't know what is unique to the FlaggerID that the value is not appearing in the derived sql.

[ilearneditonline]

Except for the fact that I am not calling your page from a javascript popup, I have copied your code and get the results I would expect. Are you leaving out part of the code? Such as something between lines 8 and 10 that you previously displayed?

[jhardman]

just a hunch; do you have option explicit?

Jared