select case not working

[Mac rod]

Hi everyone,

could you please help me. i have a combo box that have the values "1st month", "2nd month" etc, a text box to put details such as weight, length and ccirc. what i want to do is when a user inputs the details and click a button, the text box wres, lres and ccircres will show the results such as "high", "low" or "normal". i tried the following code in the on click event of the button but it wont show anything...

Private Sub Command24_Click()
Select Case Me.age
Case "1st month"
 
' declares variables
 
If weight <= 2.96 Then
wres = "low"
ElseIf weight >= 4.93 Then
wres = "high"
Else
wres = "Normal"
End If
 
If length <= 49.1 Then
lres = "short"
ElseIf length >= 57 Then
wres = "long"
Else
lres = "Normal"
End If
 
If hcircres <= 34.1 Then
wres = "small"
ElseIf hcircres >= 38.4 Then
wres = "big"
Else
hcircres = "Normal"
End If
End Select
 
Select Case Me.age
Case "2nd month"
 
' declares variables
 
If Me.[weight] <= 3.57 Then
wres = "low"
ElseIf Me.[weight] >= 5.84 Then
wres = "high"
Else
wres = "Normal"
End If
 
If Me.[length] <= 52.1 Then
lres = "short"
ElseIf Me.[length] >= 60.3 Then
wres = "long"
Else
lres = "Normal"
End If
 
If Me.[hcircres] <= 35.7 Then
wres = "small"
ElseIf Me.[hcircres] >= 39.8 Then
wres = "big"
Else
hcircres = "Normal"
End If
End Select

*its up to 12th months but the code is the same

[RuralGuy]

I would start by only having *one* Select Case...End Select in the procedure.

Private Sub Command24_Click()
   Select Case Me.age
      Case "1st month"
 
         ' declares variables
 
         If Weight <= 2.96 Then
            wres = "low"
         ElseIf Weight >= 4.93 Then
            wres = "high"
         Else
            wres = "Normal"
         End If
 
         If length <= 49.1 Then
            lres = "short"
         ElseIf length >= 57 Then
            wres = "long"
         Else
            lres = "Normal"
         End If
 
         If hcircres <= 34.1 Then
            wres = "small"
         ElseIf hcircres >= 38.4 Then
            wres = "big"
         Else
            hcircres = "Normal"
         End If
 
'----- Remove   End Select
 
'----- Remove   Select Case Me.age
 
      Case "2nd month"
 
         ' declares variables
 
         If Me.[Weight] <= 3.57 Then
            wres = "low"
         ElseIf Me.[Weight] >= 5.84 Then
            wres = "high"
         Else
            wres = "Normal"
         End If
 
         If Me.[length] <= 52.1 Then
            lres = "short"
         ElseIf Me.[length] >= 60.3 Then
            wres = "long"
         Else
            lres = "Normal"
         End If
 
         If Me.[hcircres] <= 35.7 Then
            wres = "small"
         ElseIf Me.[hcircres] >= 39.8 Then
            wres = "big"
         Else
            hcircres = "Normal"
         End If
 
   End Select
 
End Sub

[Mac rod]

hi,
Thanks for the quick reply. i tried it but still it's not showing any values.

[RuralGuy]

Put the code in the AfterUpdate event of the ComboBox for more automatic operation. Make sure what is being returned with Me.Age By starting with a MsgBox that displays the value for you as a diagnostic.

[Mac rod]

I put the code in the AfterUpdate event but still won't show any values. Sorry, i'm new to this but how do i make the MsgBox diagnostic?

[RuralGuy]

Private Sub Command24_Click()
   MsgBox "[" & Me.age & "]"
   Select Case Me.age 
 

[Mac rod]

it returns a message box that says "[]". that's it.

[RuralGuy]

That means your Case structure will not work, which is what you are seeing. What is the Bound Column of your ComboBox and what do you have and the RowSource and RowSourceType?

[Mac rod]

RowSource = "1st month";"2nd month";"3rd month";"4th month";"5th month";"6th month";"7th month";"8th month";"9th month";"10th month";"11th month";"12th month";"15th month";"18th month";"24th month"

RowSourcceType = Value List

BoundColumn = 1

[Mac rod]

If it is of any help, i made the combo box by choosing the 2nd option in the wizard something like "i will type the values that i want". then typed it in the form view.

[RuralGuy]

Did you move the code to the AfterUpdate event of the ComboBox?

[Mac rod]

yup, still no values and the message box displays "[]"

[RuralGuy]

Dumb question but you are certain the ComboBox name is age right?

[Mac rod]

This is embarrassing...
actually it might be the answer! it was unbound and nothing is written in the control source. it's working now. thank you very much!

[RuralGuy]

That's Great! Glad we got it working finally.

[Mac rod]

Yes! A really big thanks to you!!! You have been very helpful!

[Mac rod]

hi again, i think this may be a related question since its still the combo box, because when i tested it, the results where all over the place like it would say normal when it shouldn't and sometimes one text box won't display any value at all. i checked the code but it's ok the values are the way they should be. please help.

[RuralGuy]

I'm not sure what else I can do with what we have so far. Do you know how to single step the code to see what values are returned and what branches of the code are taken?

[Mac rod]

Hi!
What we have done before solves the problem that i have with the combo box. My problem now is that its not returning the correct values that i set. maybe it have something to do with the code being long and almost the same? about the single step, i don't know how to do that either.

[RuralGuy]

While looking at the code you click outside the left margin and a dot appears. That is a BreakPoint. When you run the form and execute the code, it will stop at the BreakPoint. You can then F8 a line at a time and watch the path the code takes. Hovering over variables will pop up their current value.

[Mac rod]

How will i know that its the wrong code? most of them turns yellow when i press F8.

[Mr Key]

Mac, pressing F8 helps runs the code step-by-steps, you just check the results to the end of code! Just Continue and you may know where the code is doing wrong

[Mac rod]

where do i see the results? after running the code step by steps up to the End sub nothing happens.

[RuralGuy]

Is the code that sets the other values executing?

[Mac rod]

Yes, but showing other values. like if it should be "normal" it would show "big" or "short" vice versa. And the weight textbox at first it may show for example "low" but if i again click the button it shows "big". and with some values like "60.3" it just won't show anything.

[RuralGuy]

Is the right code executing (getting highlighted)? When you hover over weight for example does it display the correct value?

[Mac rod]

Nope. It displays the value that i see in the form which is wrong.

[RuralGuy]

You lost me on that one. You enter a value in the weight control and when your code executes and you hover over the weight entry you get the "wrong" value?

[RuralGuy]

Maybe you should try and attach you db at this time. Compact and Repair and then ZIP it up first.

[Mac rod]

Yup! From the form view, the value that pops out when i clicked the results button is already wrong, that's the same value that comes when i hover in the code view. Here's my DB, I really appreciate this man.

[RuralGuy]

The Name of your control is Combo22. "age" is the field to which that control is bound. The field is not actually updated until you either move to another record or close the form.

[Mac rod]

Yup, when it is in the afetupdate event. but the code is in the button. and if ever it updates it returns the wrong values. Different to those that i wrote on the code.

[RuralGuy]

All of the fields in the Development table save two, are text fields. You are doing numerical testing against "text". Your table fields should be probably the Single DataType fields.

[Mac rod]

Actually they were numbers before general number and double. Then i tried text, the results were the same.

[RuralGuy]

Try changing them to Single or Double again and see what happens.

[Mac rod]

Still it doesn't show the correct values. have you seen the code? i think i did it correctly? the problem is that for example in the code <= 6.99 should be "short" but after i pressed the button it shows "Normal" or "big". and the thing is "big" is in the other "if" statement.

[RuralGuy]

You should name your Controls differently that the fields to which they are bound. Access does not know whether you are referring to the field or the control.

[RuralGuy]

See if this "1st Month" works as you would expect.

[Mac rod]

Actually to all the data i placed there already, the 1st month returns the best answer. Can you try the 2nd month? and also where do i change the control name?

[Mac rod]

the 1st month returns the values correctly now

[Mac rod]

i see the control now i did that also but i didn't change the code. that's why.

[RuralGuy]

The name of a control is on the "Other" tab of the property sheet of the control. If you use the Me. preface in the code then Intelisense will show you the possible legal answers.

[Mac rod]

I found it!!! Thanks to you rural guy! I tried and change the 2nd month as well and found that i messed a lot since i only copy, paste and edit it so, it ended up that some of them have the same name. I should be more careful when coding. aside from the fact that i'm using the field name. Thanks a lot again!!!!!

[NeoPa]

A good point to note here is that if you were in the (good) habit of using capital letters within your object names then the name "age", being all lower-case, would have jumped out as an obvious problem right from the start. It makes sense to use the facilities available to help with your work.