Keith - Advice on code

[Tempy]

Hi Keith, below is my code to hide the boxes and txt and button for 3
people, is there a shorter way to write this ?

Private Sub Form_Current()
If LastName = "Franz" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
ElseIf LastName = "Davis" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
ElseIf LastName = "Von Patow" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
Else
Me!Supplier1.Visible = True
Me!Supplier2.Visible = True
Me!Supplier3.Visible = True
Me!Supplier4.Visible = True
Me!Supplier5.Visible = True
Me!Label56.Visible = True
Me.AddSupplierBuy.Visible = True
End If

End Sub

Tempy

*** Sent via Developersdex http://www.developersdex.com ***

[Keith]

"Tempy" <an*******@devdex.com> wrote in message
news:m%*************@news.uswest.net...

Hi Keith, below is my code to hide the boxes and txt and button for 3
people, is there a shorter way to write this ?

Private Sub Form_Current()
If LastName = "Franz" Then
Me!Supplier1.Visible = False

You could wrap them all up using "or"s:

If LastName = "Franz" or LastName = "whatever" ... etc

Regards,
Keith.

PS - probably best not to address your postings to an individual :o)

[Justin Hoffman]

"Tempy" <an*******@devdex.com> wrote in message
news:m%*************@news.uswest.net...

Hi Keith, below is my code to hide the boxes and txt and button for 3
people, is there a shorter way to write this ?

Private Sub Form_Current()
If LastName = "Franz" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
ElseIf LastName = "Davis" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
ElseIf LastName = "Von Patow" Then
Me!Supplier1.Visible = False
Me!Supplier2.Visible = False
Me!Supplier3.Visible = False
Me!Supplier4.Visible = False
Me!Supplier5.Visible = False
Me!Label56.Visible = False
Me.AddSupplierBuy.Visible = False
Else
Me!Supplier1.Visible = True
Me!Supplier2.Visible = True
Me!Supplier3.Visible = True
Me!Supplier4.Visible = True
Me!Supplier5.Visible = True
Me!Label56.Visible = True
Me.AddSupplierBuy.Visible = True
End If

End Sub

Tempy

You could structure this by splitting it into two lumps - something like:

Private Sub Form_Current()
Select Case LastName
Case "Franz", "Davis", "Von Patow": ShowControls False
Case Else: ShowControls True
End Select
End Sub

Private Sub ShowControls(blnVisible As Boolean)
Me!Supplier1.Visible = blnVisible
Me!Supplier2.Visible = blnVisible
Me!Supplier3.Visible = blnVisible
Me!Supplier4.Visible = blnVisible
Me!Supplier5.Visible = blnVisible
Me!Label56.Visible = blnVisible
End Sub

[Hank]

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub
Hank Reed

[Justin Hoffman]

"Hank" <ha********@aol.com> wrote in message
news:11********************@g14g2000cwa.googlegrou ps.com...

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub
Hank Reed

You've just made it one line longer

[Justin Hoffman]

"Justin Hoffman" <[e-mail]> wrote in message
news:d7**********@nwrdmz01.dmz.ncs.ea.ibs-infra.bt.com...

"Hank" <ha********@aol.com> wrote in message
news:11********************@g14g2000cwa.googlegrou ps.com...

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub
Hank Reed

You've just made it one line longer

....and that's without the Me.AddSupplierBuy.Visible which has been left out

[Hank]

Justin Hoffman wrote:

"Justin Hoffman" <[e-mail]> wrote in message
news:d7**********@nwrdmz01.dmz.ncs.ea.ibs-infra.bt.com...

"Hank" <ha********@aol.com> wrote in message
news:11********************@g14g2000cwa.googlegrou ps.com...

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub
Hank Reed

You've just made it one line longer

...and that's without the Me.AddSupplierBuy.Visible which has been left out

Yes, but its so much more elegant. ;-)
If he had 10 controls, I could have been a hero.
You are absolutely right of course, but I find the approach useful when
changing the properties of multiple controls.
Hank

[Tim Marshall]

Hank wrote:

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub You've just made it one line longer

...and that's without the Me.AddSupplierBuy.Visible which has been left out

Yes, but its so much more elegant. ;-)
If he had 10 controls, I could have been a hero.
You are absolutely right of course, but I find the approach useful when
changing the properties of multiple controls.

I prefer enumerating controls and checking the tag property:

dim c as Access.control

for each c in access.controls

if c.controltype = actextbox then

if c.tag = "Supplier" then c.visible = false

end if

next

This works well in forms with very many controls and a lot of processes
going on. It's not as efficient, of course as Justin's code, but it
sure is a lot easier to maintain if you are making a lot of changes.
--
Tim http://www.ucs.mun.ca/~tmarshal/
^o<
/#) "Burp-beep, burp-beep, burp-beep?" - Quaker Jake
/^^ "Whatcha doin?" - Ditto "TIM-MAY!!" - Me

[DenBorg]

Justin Hoffman wrote:

"Hank" <ha********@aol.com> wrote in message
news:11********************@g14g2000cwa.googlegrou ps.com...

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer
dim strFieldName as string

For I = 1 to 5
strFieldName = "Supplier" & I
Me(strFieldName).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
End Sub
Hank Reed

You've just made it one line longer

And here the same thing with 2 lines removed, making it one line
shorter, and then even adding the AddSupplierBuy.Visible it is still
one line shorter:

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer

For I = 1 to 5
Me("Supplier" & I).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
AddSupplierBuy.Visible = blnVisible
End Sub

The number of suppliers would then be irrelevant.

[Tempy]

Thanks all for the input and sorry for the late reply.

Tempy

*** Sent via Developersdex http://www.developersdex.com ***

[Justin Hoffman]

"DenBorg" <de******@yahoo.com> wrote in message
news:11**********************@g14g2000cwa.googlegr oups.com...

Justin Hoffman wrote:

"Hank" <ha********@aol.com> wrote in message
news:11********************@g14g2000cwa.googlegrou ps.com...

> Private Sub ShowControls(blnVisible As Boolean)
> Dim I as Integer
> dim strFieldName as string
>
> For I = 1 to 5
> strFieldName = "Supplier" & I
> Me(strFieldName).Visible = blnVisible
> Next I
> Me!Label56.Visible = blnVisible
> End Sub
> Hank Reed

You've just made it one line longer

And here the same thing with 2 lines removed, making it one line
shorter, and then even adding the AddSupplierBuy.Visible it is still
one line shorter:

Private Sub ShowControls(blnVisible As Boolean)
Dim I as Integer

For I = 1 to 5
Me("Supplier" & I).Visible = blnVisible
Next I
Me!Label56.Visible = blnVisible
AddSupplierBuy.Visible = blnVisible
End Sub

The number of suppliers would then be irrelevant.

Alright already! I was only teasing about the length.