I have an application where I want to remove all of the items that are
in one vector from a second vector. In the following short program, my
objective is to remove all of ourCards from cardsAvailable without
writing a loop.
I have tried a number of different variations using the for_each
algorithm without success, and am currently getting a C2664 error that
the compiler cannot convert parameter 1. I am new to STL and not all
that adept with C++ either, so I'm sure there is something basic that
I am missing. Anyway, I have created the following short program to
demonstrate my problem. Any assistance will be greatly appreciated.
// Remove Card test using STL
#include <iostream> // for cout
#include <vector> // for vector
#include <algorithm> // for lower_bound, for_each
#include <functional> // for binary_function
using namespace std;
//STL support functions or objects
struct removeCard : public std::binary_function<vector<int>,int,void>
{
void
operator() (vector<int> & cardsAvailable, int cardToRemove )const
{
vector<int>::iterator iter;
iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(),
cardToRemove);
if ( iter != cardsAvailable.end()) cardsAvailable.erase(iter);
}
};
// To display contents of a container - For testing only
void print ( int element )
{
cout << element << ' ';
}
int main()
{
vector<int> ourCards;
// add two cards to ourCards vector
ourCards.push_back(10);
ourCards.push_back(20);
vector<int> cardsAvailable;
vector<int>::iterator iter;
// initialize cardsAvailable with all 52 cards
for ( int i = 0; i < 52; ++i) cardsAvailable.push_back(i);
// remove all of our cards from the deck
for_each( ourCards.begin(), ourCards.end(), // range
bind1st(removeCard(),cardsAvailable) ); // operation
// display all of the remaining cards in the deck
for_each( cardsAvailable.begin(), cardsAvailable.end(), print );
return 0;
}
// Error message from compiler follows
/*
Compiling...
RemoveCard.cpp
C:\Program Files\Microsoft Visual Studio .NET
2003\Vc7\include\functional(279) :
error C2664: 'void removeCard::operator ()(std::vector<_Ty> &,int)
const' :
cannot convert parameter 1 from 'const
std::binary_function<_Arg1,_Arg2,
_Result>::first_argument_type' to 'std::vector<_Ty> &'
with
[
_Ty=int
]
and
[
_Arg1=std::vector<int>,
_Arg2=int,
_Result=void
]
and
[
_Ty=int
]
Conversion loses qualifiers
C:\Program Files\Microsoft Visual Studio .NET
2003\Vc7\include\functional(278) :
while compiling class-template member function
'std::binder1st<_Fn2>::result_type
std::binder1st<_Fn2>::operator ()(std::binder1st<_Fn2>::argument_type
&) const'
with
[
_Fn2=removeCard
]
RemoveCard.cpp(52) : see reference to class template instantiation
'std::binder1st<_Fn2>' being compiled
with
[
_Fn2=removeCard
]
*/ 6 2664
Greg Lilley wrote: I have an application where I want to remove all of the items that are in one vector from a second vector. In the following short program, my objective is to remove all of ourCards from cardsAvailable without writing a loop.
I have tried a number of different variations using the for_each algorithm without success, and am currently getting a C2664 error that the compiler cannot convert parameter 1. I am new to STL and not all that adept with C++ either, so I'm sure there is something basic that I am missing. Anyway, I have created the following short program to demonstrate my problem. Any assistance will be greatly appreciated.
// Remove Card test using STL
#include <iostream> // for cout #include <vector> // for vector #include <algorithm> // for lower_bound, for_each #include <functional> // for binary_function using namespace std;
//STL support functions or objects
struct removeCard : public std::binary_function<vector<int>,int,void> { void operator() (vector<int> & cardsAvailable, int cardToRemove )const { vector<int>::iterator iter; iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(), cardToRemove);
if ( iter != cardsAvailable.end()) cardsAvailable.erase(iter); } };
// To display contents of a container - For testing only void print ( int element ) { cout << element << ' '; }
int main() { vector<int> ourCards;
// add two cards to ourCards vector ourCards.push_back(10); ourCards.push_back(20);
vector<int> cardsAvailable; vector<int>::iterator iter;
// initialize cardsAvailable with all 52 cards for ( int i = 0; i < 52; ++i) cardsAvailable.push_back(i);
// remove all of our cards from the deck for_each( ourCards.begin(), ourCards.end(), // range bind1st(removeCard(),cardsAvailable) ); // operation
// display all of the remaining cards in the deck for_each( cardsAvailable.begin(), cardsAvailable.end(), print );
return 0; }
// Error message from compiler follows
/*
Compiling... RemoveCard.cpp C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\functional(279) : error C2664: 'void removeCard::operator ()(std::vector<_Ty> &,int) const' : cannot convert parameter 1 from 'const std::binary_function<_Arg1,_Arg2, _Result>::first_argument_type' to 'std::vector<_Ty> &' with [ _Ty=int ] and [ _Arg1=std::vector<int>, _Arg2=int, _Result=void ] and [ _Ty=int ] Conversion loses qualifiers C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\functional(278) : while compiling class-template member function 'std::binder1st<_Fn2>::result_type std::binder1st<_Fn2>::operator ()(std::binder1st<_Fn2>::argument_type &) const' with [ _Fn2=removeCard ] RemoveCard.cpp(52) : see reference to class template instantiation 'std::binder1st<_Fn2>' being compiled with [ _Fn2=removeCard ]
*/
'binder1st' class requires its argument to be a _const_ reference. It
might be the reason why it can't convert what it tries to convert.
Victor
Greg Lilley wrote: I have an application where I want to remove all of the items that are in one vector from a second vector. In the following short program, my objective is to remove all of ourCards from cardsAvailable without writing a loop.
I have tried a number of different variations using the for_each algorithm without success, and am currently getting a C2664 error that the compiler cannot convert parameter 1. I am new to STL and not all that adept with C++ either, so I'm sure there is something basic that I am missing. Anyway, I have created the following short program to demonstrate my problem. Any assistance will be greatly appreciated.
// Remove Card test using STL
#include <iostream> // for cout #include <vector> // for vector #include <algorithm> // for lower_bound, for_each #include <functional> // for binary_function using namespace std;
//STL support functions or objects
struct removeCard : public std::binary_function<vector<int>,int,void> { void operator() (vector<int> & cardsAvailable, int cardToRemove )const { vector<int>::iterator iter; iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(), cardToRemove);
if ( iter != cardsAvailable.end()) cardsAvailable.erase(iter); } };
// To display contents of a container - For testing only void print ( int element ) { cout << element << ' '; }
int main() { vector<int> ourCards;
// add two cards to ourCards vector ourCards.push_back(10); ourCards.push_back(20);
vector<int> cardsAvailable; vector<int>::iterator iter;
// initialize cardsAvailable with all 52 cards for ( int i = 0; i < 52; ++i) cardsAvailable.push_back(i);
// remove all of our cards from the deck for_each( ourCards.begin(), ourCards.end(), // range bind1st(removeCard(),cardsAvailable) ); // operation
// display all of the remaining cards in the deck for_each( cardsAvailable.begin(), cardsAvailable.end(), print );
return 0; }
[snip]
As Victor said, you can't use a non-const reference with bind1st.
You could do otherwise, but as a dirty cheap fix (I'm curious if anyone
thinks it's a stylistic kludge) I'd change to binding a pointer to a vector:
struct removeCard : public std::binary_function<vector<int>*, int, void> {
void operator() (vector<int>* p_cardsAvailable, int cardToRemove) const {
vector<int>::iterator iter;
iter = lower_bound(p_cardsAvailable->begin(), p_cardsAvailable->end(),
cardToRemove);
if ( iter != p_cardsAvailable->end()) p_cardsAvailable->erase(iter);
}
};
.... and the usage in main() is:
for_each( ourCards.begin(), ourCards.end(), // range
bind1st(removeCard(), &cardsAvailable) ); // operation
Denis gr*********@dcjs.virginia.gov (Greg Lilley) wrote in message I have an application where I want to remove all of the items that are in one vector from a second vector. In the following short program, my objective is to remove all of ourCards from cardsAvailable without writing a loop.
struct removeCard : public std::binary_function<vector<int>,int,void>
The first_argument_type is not vector<int> but rather vector<int>&.
{ void operator() (vector<int> & cardsAvailable, int cardToRemove )const { vector<int>::iterator iter; iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(), cardToRemove);
if ( iter != cardsAvailable.end()) cardsAvailable.erase(iter); } };
for_each( ourCards.begin(), ourCards.end(), // range bind1st(removeCard(),cardsAvailable) ); // operation
After changing the first_argument_type as above, I believe you'll run
into the reference to reference problem. There may be a fix to the
ANSI standard to fix this by making a reference to a reference be a
reference.
Please be aware that bind1st creates a copy of cardsAvailable, and it
is this copy that changes. The simple fix is to use pointers. It
should also fix your original problem.
for_each( ourCards.begin(), ourCards.end(), // range
bind1st(removeCard(),&cardsAvailable) ); // operation
struct removeCard : public std::binary_function<vector<int>,int,void>
should be changed to
struct removeCard : public
std::binary_function<vector<int>*,int,void>
Change operator() as appropriate.
An alternative design is to make removeCard store a reference (or
pointer) to cardsAvailable. It would have a constructor
explicit removeCard::removeCard(std::vector<int>&);
In this design you don't need binders.
iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(), cardToRemove);
As a minor optimization, if ourCards is sorted, then instead of
cardsAvailable.begin() you could use the previous value of iter.
Example: for 10, 20; once you find card 10 in cardsAvailable, to find
card 20 you need only start searching cardsAvailable from card 10, not
from the beginning. Don't know how you would do this with binders
though.
Have you considered using set functions like set_difference? As far
as I know, they do employ extra storage. In other words, in
set_difference(a.begin(), a.end(), b.begin(), b.end(), c.begin());
'c' must be different from 'a'. Normally one might use
std::back_inserter(c).
Have you thought about exception safety? What if you are to remove 2
cards 10 and 20 and you removed 10 and removing 20 throws an
exception. What then? It is not necessary to fix this scenario right
now, but at least be aware of it.
Finally, removing an element from a vector is an O(N) operation, but
removing from a list is O(1).
Thanks very much to all of you for your responses. I've been wrestling
with this problem for a long time and your comments were a big help. An alternative design is to make removeCard store a reference (or pointer) to cardsAvailable. It would have a constructor
explicit removeCard::removeCard(std::vector<int>&);
In this design you don't need binders. iter = lower_bound(cardsAvailable.begin(),cardsAvailable. end(), cardToRemove);
Thanks again. I was thinking there were probably some other approaches
that were superior to what I was trying to do. As a minor optimization, if ourCards is sorted, then instead of cardsAvailable.begin() you could use the previous value of iter. Example: for 10, 20; once you find card 10 in cardsAvailable, to find card 20 you need only start searching cardsAvailable from card 10, not from the beginning. Don't know how you would do this with binders though.
I had thought of that, but like you, I didn't know how to do it with
binders. Have you considered using set functions like set_difference? As far as I know, they do employ extra storage. In other words, in
set_difference(a.begin(), a.end(), b.begin(), b.end(), c.begin());
'c' must be different from 'a'. Normally one might use std::back_inserter(c).
No, I hadn't. I've never used set_difference before, and it hadn't
occurred to me, but it sounds like its worth trying.
Finally, removing an element from a vector is an O(N) operation, but removing from a list is O(1).
Thanks. Speed is pretty important to me, so I'm going to think about
the list idea as well.
- Greg Lilley gr*********@dcjs.virginia.gov (Greg Lilley) wrote in message Finally, removing an element from a vector is an O(N) operation, but removing from a list is O(1).
Thanks. Speed is pretty important to me, so I'm going to think about the list idea as well.
std::deque also has removing an element as O(1)
"Siemel Naran" <na*******@excite.com> wrote in message
news:3d*************************@posting.google.co m... gr*********@dcjs.virginia.gov (Greg Lilley) wrote in message
Finally, removing an element from a vector is an O(N) operation, but removing from a list is O(1).
Thanks. Speed is pretty important to me, so I'm going to think about the list idea as well.
std::deque also has removing an element as O(1)
Only if you remove from either end. Otherwise, it's no better than
vector.
P.J. Plauger
Dinkumware, Ltd. http://www.dinkumware.com This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: wenmang |
last post by:
Hi, all:
I am reading Herb Sutter's article:
http://www.cuj.com/documents/s=8840/cujexp0309sutter/
I have trouble to understand for following lines:
class Subject {
// ...
public:
virtual...
|
by: Fred Ma |
last post by:
Hello,
I have a random generator that takes a scaling factor as an
argument. Since it takes one argument, it is not a
generator in the sense defined by SGI's online STL
documentation. I'd...
|
by: Marc |
last post by:
T x;
T foo(T, T);
bind1st(ptr_fun(foo), x)
creates a function object that takes an argument of type T const&. This
does not work if T is already a reference type like int const&. So my
first...
|
by: John Black |
last post by:
I have the following code trying to use bind1st,
class C1{
...
};
class C2{
...
};
|
by: Alberto |
last post by:
Hello,
while writing a program I ran across the problem of using for_each.
Although I can traverse lists with a for loop, I'd prefer to use STL's
for_each. Here's my faulty code:
#include...
| |
by: silverburgh.meryl |
last post by:
I am reading an bind1st example from
http://www.roguewave.com/support/docs/sourcepro/stdlibref/bind1st.html
Can someone please tell me why
// Even better, construct the new predicate on the fly....
|
by: pillbug |
last post by:
I'm having trouble using bind1st with mem_fun1. I can't compile
the line marked below with a @@. If I use the join2 method everything
is fine, but I wind up passing string vectors by value. I...
|
by: Christopher |
last post by:
I used to just use a plain old function pointer is a call to
std::sort.
My colleagues are telling me that I need to use a "functor". Ok, I
google and see that a functor is a class with a public...
|
by: Frank Bergemann |
last post by:
i don't manage to get this compiled:
// shall map compare operator ids to proper std::binary_function's
// for this instantiated for various types
template <typename ForType>
struct...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers,...
| |
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new...
|
by: TSSRALBI |
last post by:
Hello
I'm a network technician in training and I need your help.
I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs.
The...
|
by: adsilva |
last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
| |
by: 6302768590 |
last post by:
Hai team
i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated ...
| |