Saving to files

[Yamasassy]

HI im having problems to saving to a .txt file, i need to be able to store a number of employees to this file (and beable to open and these files to load in to text boxes)and retrieve then for later use to search and print and them add more at another stage , currently i can save and read from these files but only the last person entered is stored and over written each time . i have to use classes and Collections , im using Visual basic 6
my code so far is :

Public Employee As Object
Public EmployeeCollection As New Collection
Dim counter As Integer
 
Private Sub cmdEdit_Click(Index As Integer)
Dim counter As Integer
 
counter = EmployeeCollection.Count
 
counter = 1
 
Open "c:\temp\Storage.txt" For Output As #1
 
For counter = 1 To forcounter
 
Print #1, txtFullname.Text
 
 
Write #1, txtAddress.Text
Write #1, txtArea.Text
Write #1, txtPostcode.Text
Write #1, txtContactno.Text
Write #1, txtPos.Text
Write #1, txtSalary.Text
 
forcounter = forcounter + 1
 
Next
 
Close #1
 
End Sub
 
Private Sub cmdExit_Click(Index As Integer)
 
 
Dim counter As Integer
 
counter = EmployeeCollection.Count
 
counter = 1
 
Open "c:\temp\Storage.txt" For Output As #1
 
For counter = 1 To counter
 
Print #1, txtFullname.Text
Write #1, txtArea.Text
Write #1, txtPostcode.Text
Write #1, txtContactno.Text
Write #1, txtPos.Text
Write #1, txtSalary.Text
 
 
' or Print #1, EmployeeCollection.item(forcounter).Fullname
 
forcounter = forcounter + 1
 
Next
 
Close #1
 
End
 
End Sub
 
 
Private Sub cmdFirst_Click(Index As Integer)
 
    txtEmployeeno.Text = 1 'set the record number to first employee number
 
    txtFullname.Text = EmployeeCollection.Item(1).Fullname
    txtArea.Text = EmployeeCollection.Item(1).Area
    txtPostcode.Text = EmployeeCollection.Item(1).Postcode
    txtAddress.Text = EmployeeCollection.Item(1).Address
    txtContactno.Text = EmployeeCollection.Item(1).Contactno
    txtPos.Text = EmployeeCollection.Item(1).Pos
    txtSalary = EmployeeCollection.Item(1).Salary
 
End Sub
 
Private Sub cmdLast_Click(Index As Integer)
 
    counter = EmployeeCollection.Count
 
    txtEmployeeno.Text = counter
 
    txtFullname.Text = EmployeeCollection.Item(counter).Fullname
    txtArea.Text = EmployeeCollection.Item(counter).Area
    txtPostcode.Text = EmployeeCollection.Item(counter).Postcode
    txtAddress.Text = EmployeeCollection.Item(counter).Address
    txtContactno.Text = EmployeeCollection.Item(counter).Contactno
    txtPos.Text = EmployeeCollection.Item(counter).Pos
    txtSalary = EmployeeCollection.Item(counter).Salary
 
End Sub
 
Private Sub cmdNew_Click(Index As Integer)
 
Set Employee = New clsEmployee
 
Employee.Fullname = txtFullname.Text
Employee.Address = txtAddress.Text
Employee.Area = txtArea.Text
Employee.Postcode = txtPostcode.Text
Employee.Contactno = txtContactno.Text
Employee.Pos = txtPos.Text
Employee.Salary = txtSalary.Text
 
 
EmployeeCollection.Add clsEmployee
txtEmployeeno.Text = EmployeeCollection.Count
 
Set Employee = Nothing
 
txtFullname.Text = " "
txtAddress.Text = " "
txtArea.Text = " "
txtPostcode.Text = " "
txtContactno.Text = " "
txtPos.Text = " "
txtSalary = " "
 
End Sub
 
Private Sub cmdNext_Click(Index As Integer)
 
counter = txtEmployeeno.Text
counter = counter + 1
txtEmployeeno = counter
 
    txtFullname.Text = EmployeeCollection.Item(1).Fullname
    txtArea.Text = EmployeeCollection.Item(1).Area
    txtPostcode.Text = EmployeeCollection.Item(1).Postcode
    txtAddress.Text = EmployeeCollection.Item(1).Address
    txtContactno.Text = EmployeeCollection.Item(1).Contactno
    txtPos.Text = EmployeeCollection.Item(1).Pos
    txtSalary = EmployeeCollection.Item(1).Salary
 
End Sub
 
Private Sub cmdPrev_Click(Index As Integer)
 
counter = txtEmployeeno.Text
counter = counter - 1
txtEmployeeno = counter
 
    txtFullname.Text = EmployeeCollection.Item(1).Fullname
    txtArea.Text = EmployeeCollection.Item(1).Area
    txtPostcode.Text = EmployeeCollection.Item(1).Postcode
    txtAddress.Text = EmployeeCollection.Item(1).Address
    txtContactno.Text = EmployeeCollection.Item(1).Contactno
    txtPos.Text = EmployeeCollection.Item(1).Pos
    txtSalary = EmployeeCollection.Item(1).Salary
 
End Sub
 
Private Sub Form_Load()
 
    Dim FileFullname As String
    Dim FileArea As String
    Dim FileAddress As String
    Dim FilePostcode As String
    Dim FileContactno As String
    Dim FilePos As String
    Dim FileSalary As String
 
Set EmployeeCollection = New Collection
Set Employee = New clsEmployee
 
Open "c:\temp\Storage.txt" For Input As #1
 
While EOF(1) = False
 
    Input #1, FileFullname
    Input #1, FileAddress
    Input #1, FileArea
    Input #1, FilePostcode
    Input #1, FileContactno
    Input #1, FilePos
    Input #1, FileSalary
 
    Employee.Fullname = FileFullname
    Employee.Address = FileAddress
    Employee.Area = FileArea
    Employee.Postcode = FilePostcode
    Employee.Contactno = FileContactno
    Employee.Pos = FilePos
    Employee.Salary = FileSalary
    EmployeeCollection.Add Employee
 
Wend
Close #1
 
    txtEmployeeno.Text = EmployeeCollection.Count
    txtFullname.Text = EmployeeCollection.Item(EmployeeCollection.Count).Fullname
    txtAddress.Text = EmployeeCollection.Item(EmployeeCollection.Count).Address
    txtArea.Text = EmployeeCollection.Item(EmployeeCollection.Count).Area
    txtPostcode.Text = EmployeeCollection.Item(EmployeeCollection.Count).Postcode
    txtContactno.Text = EmployeeCollection.Item(EmployeeCollection.Count).Contactno
    txtPos.Text = EmployeeCollection.Item(EmployeeCollection.Count).Pos
    txtSalary.Text = EmployeeCollection.Item(EmployeeCollection.Count).Salary
End Sub
 

[QVeen72]

Hi,

I guess, you are writing the Code To Save in Exit Button, And You are saving the Last Displayed TextBox Values.
Instead, Loop through all the Collection Items and Save From the Collection to the File..

Regards
Veena

[Yamasassy]

Hi,

I guess, you are writing the Code To Save in Exit Button, And You are saving the Last Displayed TextBox Values.
Instead, Loop through all the Collection Items and Save From the Collection to the File..

Regards
Veena

How would i go about doing this ? im new to VB and not really any good with it

[QVeen72]

Hi,

Change the Code in Cmd_Exit to this :

Private Sub cmdExit_Click(Index As Integer)
 
Dim i As Integer
Dim counter As Integer
 
counter = EmployeeCollection.Count
 
Open "c:\temp\Storage.txt" For Output As #1
 
For i = 1 To counter
 
    Print #1, EmployeeCollection.Item(i).Fullname
    Print #1, EmployeeCollection.Item(i).Area
    Print #1, EmployeeCollection.Item(i).Postcode
    Print #1, EmployeeCollection.Item(i).Address
    Print #1, EmployeeCollection.Item(i).Contactno
    Print #1, EmployeeCollection.Item(i).Pos
    Print #1, EmployeeCollection.Item(i).Salary
Next
 
Close #1
 
End
 
End Sub
 
 

Regards
Veena

[Yamasassy]

its giving out now an error 424 on

Print #1, EmployeeCollection.Item(i).Fullname

object required , sorry to be a pain but im really greatfull for ypur help:)

[VBWheaties]

Will the following work?

 
    Dim employeeObject As clsEmployee
 
    Set employeeObject = EmployeeCollection.Item(i) 
 
    Print #1, employeeObject.Fullname
    Print #1, employeeObject.Area
    Print #1, employeeObject.Postcode
    Print #1, employeeObject.Address
    Print #1, employeeObject.Contactno
    Print #1, employeeObject.Pos
    Print #1, employeeObject.Salary
 

[Yamasassy]

Will the following work?

 
    Dim employeeObject As clsEmployee
 
    Set employeeObject = EmployeeCollection.Item(i) 
 
    Print #1, employeeObject.Fullname
    Print #1, employeeObject.Area
    Print #1, employeeObject.Postcode
    Print #1, employeeObject.Address
    Print #1, employeeObject.Contactno
    Print #1, employeeObject.Pos
    Print #1, employeeObject.Salary
 

nope giving out error 9 on click of exit button

Set employeeObject = EmployeeCollection.Item(i)

Script out of range ?

[VBWheaties]

nope giving out error 9 on click of exit button

Set employeeObject = EmployeeCollection.Item(i)

Script out of range ?

This may be your issue:

Private Sub cmdNew_Click(Index As Integer)
 
Set Employee = New clsEmployee
 
Employee.Fullname = txtFullname.Text
Employee.Address = txtAddress.Text
Employee.Area = txtArea.Text
Employee.Postcode = txtPostcode.Text
Employee.Contactno = txtContactno.Text
Employee.Pos = txtPos.Text
Employee.Salary = txtSalary.Text
 
 
EmployeeCollection.Add clsEmployee   
 

The last line above shows you are adding a type to the collection and not the object itself. I think you should be adding Employee and not its type 'clsEmployee' to the collection.

[Yamasassy]

ok i got some thing working but still kinda over writting in the txt file now using

 
Private Sub cmdExit_Click(Index As Integer)
 
Dim i As Integer
Dim counter As Integer
 
counter = EmployeeCollection.Count
 
Open "c:\temp\Storage.txt" For Append As #1
Seek #1, (counter + 1) * 7
    Print #1, txtFullname.Text
    Print #1, txtAddress.Text
    Print #1, txtArea.Text
    Print #1, txtPostcode.Text
    Print #1, txtContactno.Text
    Print #1, txtPos.Text
    Print #1, txtSalary.Text
 
 Close #1
 End
 
End Sub
 

has anyone got any ideas to stop it over writting ?

[Killer42]

The way you're using that Seek statement, it looks as though you're trying to treat the file as though all entries are exactly the same size. I doubt this is in fact the case. If you want to add onto the end of the file, just remove the Seek statement.