If Clauses to Verify Array Subscript Validity

[jock1up]

I have this array and Dim statement:


Dim curSales(1 to 5) as Currency


Using an If clause, I was wondering which one might verify that the array subscript called intX was valid? I realize that this has to be within the range to be valid such as 1 to 5.


If intX > 1 and intX < 5 Then
If intX >= 1 and intX <= 5 Then
If curSales(intX) >= 1 and curSales(intX) < 5 Then
If curSales(intX) >= 1 and curSales(intX) <= 5 Then

[Wagz]

Dim curSales(1 to 5) As currency creates an array with indexes 1 through 5 inclusive. Therefore the valid indexes are 1,2,3,4,5 and the 2nd if statement you wrote is the one you'd want to use to verify that intX is valid.

Wagz

[Killer42]

Just as a personal preference, I like to use Select Case for range checking, simply because of the To operator.

Example

Select Case IntX
  Case 1 To 5
    ' Ok
  Case Else
    ' Not Ok
End Select

The outcome is the same as your IF test, of course, I just feel it makes the code "self-documenting". Especially in cases where you need to check multiple ranges. (like 1-5, 6-10, etc.)

Example

Select Case ItemPrice
  Case Is < 0
    strDescription = "Program error - price CANNOT be negative."
  Case 0
    strDescription = "Free!!!"
  Case 1 To 9
    strDescription = "Less than ten dollars."
  Case 10 To 19
    strDescription = "Less than twenty dollars."
  Case Else
    strDescription = "Forget it, too expsensive."
End Select

[QVeen72]

Hi,

Yes, you can check with :

If intX >= 1 and intX <= 5 Then
' Valid
Else
  MsgBox "InValid.."
End If
 

You can Generalize it further, so in future, if you cange the Range of array, you need not change the other code:

If intX >= LBound(cuRSales) and intX <= UBound(curSales) Then
' Valid
Else
  MsgBox "InValid.."
End If
 

Regards
Veena