Reading data from serial port and saving it in text file

[glaskan]

This code is meant to take an input from the serial port and then save the input from the serial port as the name and as the data to a text file but all i am getting is an empty text file or a text file with only "," in it. It would be much appreciated if anyone could help with this problem. Thanks

Private Sub Form_Unload(Cancel As Integer)
    MSComm1.PortOpen = False ' Close the comm port
End Sub
 
Private Sub Timer1_Timer()
    If MSComm1.PortOpen = False Then ' If comm port is not open
       MSComm1.PortOpen = True ' Open it
    End If
 
    If MSComm1.InBufferCount > 0 Then ' If theres data in comm buffer
        inst = inst + MSComm1.Input ' Get the data
        Text1.Text = inst ' Show its value
        Filename.Text = Text1.Text
        Text2.Text = Text1.Text
    End If
    If Text1.DataChanged < True Then
        Open "C:\test\" + Filename.Text + ".txt" For Output As #1 'location of the file.
            Write #1, Text1.Text, Text2.Text 'The things you want to save
        Close 1
    End If
 
End Sub

[glaskan]

Sorry didn't add this to first post but anyway new to this type of thing.

I was working on making it save to a specific folder in many small files for me to sort through the data (small amounts of information currently for it) without a save popup or dialog to save. The timer is also set to 1000mils didn't know if that had any bearing on the saves or not. Thanks again for any input anyone can offer.

[Killer42]

Two very important questions...

1. What version of VB is this? (From the looks of it, I'd guess VB6)
2. Are you getting the wrong data, or just writing the files incorrectly?

If you don't know the answer to the second question, then you need to investigate and work it out. After all, there are two distinct operations going on - you need to know which one is misbehaving before you can fix it.

[vijaydiwakar]

This code is meant to take an input from the serial port and then save the input from the serial port as the name and as the data to a text file but all i am getting is an empty text file or a text file with only "," in it. It would be much appreciated if anyone could help with this problem. Thanks

Private Sub Form_Unload(Cancel As Integer)
    MSComm1.PortOpen = False ' Close the comm port
End Sub
 
Private Sub Timer1_Timer()
    If MSComm1.PortOpen = False Then ' If comm port is not open
       MSComm1.PortOpen = True ' Open it
    End If
 
    If MSComm1.InBufferCount > 0 Then ' If theres data in comm buffer
        inst = inst + MSComm1.Input ' Get the data
        Text1.Text = inst ' Show its value
        Filename.Text = Text1.Text
        Text2.Text = Text1.Text
    End If
    If Text1.DataChanged < True Then
        Open "C:\test\" + Filename.Text + ".txt" For Output As #1 'location of the file.
            Write #1, Text1.Text, Text2.Text 'The things you want to save
        Close 1
    End If
 
End Sub

what's the interval of ur timmer?
try to increase it or u may use onComm event insted of timmer..
cut and paste the code of text1.datachanged into inbuffercount>0
try it
Good Luck

[glaskan]

Two very important questions...

1. What version of VB is this? (From the looks of it, I'd guess VB6)
2. Are you getting the wrong data, or just writing the files incorrectly?

Yeah the VB version is 6 and its not wrong data really just when it does get information on that port it does save a text file only its names ".txt" and it only contains "" or "," at most and does not contain any of the data

[glaskan]

what's the interval of ur timmer?
try to increase it or u may use onComm event insted of timmer..
cut and paste the code of text1.datachanged into inbuffercount>0
try it
Good Luck

Thanks vijaydiwakari will try what you said. Also tried moving the code fo text1.datachanged up under inbuffercount but it gave me that same response. Keep those replies comming any informations that leads me towards a semi working program is better than what i got so far :)

[Killer42]

Yeah the VB version is 6 and its not wrong data really just when it does get information on that port it does save a text file only its names ".txt" and it only contains "" or "," at most and does not contain any of the data

Sounds as though vijaydiwakar is probably on the right track. You're probably checking the port too often, before any data arrives, or something. The OnComm event does sound like a better option.

Let us know how it goes.

Also, consider simply writing stuff to the immediate window rather than actually creating the files. It's much quicker and simpler to debug that way.

[glaskan]

Thanks for the help so far i have this and it works...now lemme add some stuff and see what i can screw up next *grins*

Private Sub Command1_Click()
Open "z:\" + Test1 + ".txt" For Append As #1
Write #1, Text1
Close #1
End Sub
Private Sub Form_Load()
If MSComm1.PortOpen = False Then ' If comm port is not open
    MSComm1.PortOpen = True ' Open it
End If
End Sub
Private Sub MSComm1_OnComm()
If MSComm1.InBufferCount > 0 Then
        inst = MSComm1.Input
      Text1 = inst
 
End If
End Sub
Private Sub Text1_Change()
Call Command1_Click
End Sub

[Killer42]

Thanks for the help so far i have this and it works...now lemme add some stuff and see what i can screw up next *grins*

That's the spirit! :D

Let us know how it goes. And vijaydiwakar, thanks for your help.