Baffled by dataset error....

[ltfcphil]

Hi,
Can anyone offer an explanation please? (Code below).

I have a VB2005 express program that reads through a dataset (approx 100 records) looking at items 7 and 8.
If item 7 has a particular value ("R"), then I wish to delete the record.
A filter 'srsshow' is turned on to activate the feature.

When the filter is activated, this always returns the error - 'There is no row at position 9'.
However if the line with the remove statement is disabled, the loop runs right through the file without a problem, indicating that this is the line that is causing trouble. Also, the last 'debug.writeline ' before the error message returns "line 8".

What is the problem?
Why does the 'debug.writeline' not show "9" as it is executed before the line causing the error?

Many thanks.
Phil

For x = 0 To mdrows - 1
 
For y = 7 To 8 
dataread = dt.Rows(x).Item(y)
 
'discard records not required
 
If y = 7 And srshow = 0 And dataread = "R" Then skiprec = 1
Next y
 
Debug.WriteLine("line " & x )
If skiprec = 1 Then dt.Rows.Remove(dt.Rows(x))
skiprec = 0
y = 7 
Next x

[willakawill]

Hi. Looks like you have a problem with the number of rows that are left after you remove one. You may have to recount or reset after you delete a row in order to continue with the loop

[Killer42]

Ok, I'm not familiar with the dataset manipulation code you're using, so don't take me too seriously - I'm just curious. In this code...

dt.Rows.Remove(dt.Rows(x))

I would have expected to see a simple row number as the parameter, rather than an actual row object. In other words, how come it isn't simply...

dt.Rows.Remove(x)

Or have I just got the syntax wrong?

[ltfcphil]

Ok, I'm not familiar with the dataset manipulation code you're using, so don't take me too seriously - I'm just curious. In this code...

dt.Rows.Remove(dt.Rows(x))

I would have expected to see a simple row number as the parameter, rather than an actual row object. In other words, how come it isn't simply...

dt.Rows.Remove(x)

Or have I just got the syntax wrong?

Hi,
Thanks for the reply.
I have tried your suggestion, but if I simply put a number in the brackets, I get a syntax error.

Phil

[willakawill]

Hi,
Thanks for the reply.
I have tried your suggestion, but if I simply put a number in the brackets, I get a syntax error.

Phil

And, good heavens, did you completely ignore what I said? Is my handle not cool enough? My picture too girly for you?

[Killer42]

And, good heavens, did you completely ignore what I said? Is my handle not cool enough? My picture too girly for you?

Who can take a mere face seriously, compared to an impressively animated orange swirl? :p

Seriously itfcphil, you should pay attention to willakawill, who is much more familiar with this area. I was just guessing, based on what the syntax looked like.