473,320 Members | 1,978 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

Help! It does not scan all the records

I am trying to write a code for the login. I have took into account
of the all the possibilities and therefore came with the following
code:

Private Sub cmdLogin_Click()
Dim db As Database
Dim rs As Recordset

Set db = OpenDatabase(App.Path & "\login.mdb")
Set rs = db.OpenRecordset("login")

Do While Not rs.EOF
If rs.Fields("username") <> (txtUsername.Text) And _
rs.Fields("password") <> (txtPassword.Text) Then
MsgBox "Incorrect username and password!", vbCritical

ElseIf rs.Fields("username") <> (txtUsername.Text) Then
MsgBox "Incorrect username!", vbCritical

ElseIf rs.Fields("password") <> (txtPassword.Text) Then
MsgBox "Incorrect password!", vbCritical
ElseIf txtUsername.Text = "" And txtPassword.Text = "" Then
MsgBox "Empty fields!", vbCritical
ElseIf txtPassword.Text = "" Then
MsgBox "Empty password!", vbCritical
ElseIf txtUsername.Text = "" Then
MsgBox "Empty username!", vbCritical

ElseIf rs.Fields("username") = (txtUsername.Text) And _
rs.Fields("password") = (txtPassword.Text) Then
quizFrm.Show
Unload Me
Exit Sub

Else
rs.MoveNext
End If
Loop
End Sub

However, it does not read the second record after the first. For
example if I enter a username which is the second record of the
database, it says "Incorrect username!". Can anyone suggest me an
improvement to the above code?

much appreciated
Jul 17 '05 #1
1 1515

"Mohammed Mazid" <ka******@hotmail.com> wrote in message
news:7c**************************@posting.google.c om...
I am trying to write a code for the login. I have took into account
of the all the possibilities and therefore came with the following
code:

Private Sub cmdLogin_Click()
Dim db As Database
Dim rs As Recordset

Set db = OpenDatabase(App.Path & "\login.mdb")
Set rs = db.OpenRecordset("login")

Do While Not rs.EOF
If rs.Fields("username") <> (txtUsername.Text) And _
rs.Fields("password") <> (txtPassword.Text) Then
MsgBox "Incorrect username and password!", vbCritical

ElseIf rs.Fields("username") <> (txtUsername.Text) Then
MsgBox "Incorrect username!", vbCritical

ElseIf rs.Fields("password") <> (txtPassword.Text) Then
MsgBox "Incorrect password!", vbCritical
ElseIf txtUsername.Text = "" And txtPassword.Text = "" Then
MsgBox "Empty fields!", vbCritical
ElseIf txtPassword.Text = "" Then
MsgBox "Empty password!", vbCritical
ElseIf txtUsername.Text = "" Then
MsgBox "Empty username!", vbCritical

ElseIf rs.Fields("username") = (txtUsername.Text) And _
rs.Fields("password") = (txtPassword.Text) Then
quizFrm.Show
Unload Me
Exit Sub

Else
rs.MoveNext
End If
Loop
End Sub

However, it does not read the second record after the first. For
example if I enter a username which is the second record of the
database, it says "Incorrect username!". Can anyone suggest me an
improvement to the above code?

much appreciated
According to the following line of code, that is precisely what you are
telling it to do:
ElseIf rs.Fields("username") <> (txtUsername.Text) Then
MsgBox "Incorrect username!", vbCritical

Drop the above ElseIf. Then you can scan through all the records. If it
is still not found, then and only then do you know that you have an
incorrect user name.

Also, as a matter of style, I would use Len( txtUsername.Text) = 0
rather than txtUsername.Text = "". I would put checks for blanks first.
I would not consider any of your messages vbCritical, which should be
used for serious system errors, not typos. vbInformation will suffice.
But that's just me.
Jul 17 '05 #2

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

21
by: Dave | last post by:
After following Microsofts admonition to reformat my system before doing a final compilation of my app I got many warnings/errors upon compiling an rtf file created in word. I used the Help...
9
by: Tom | last post by:
A question for gui application programmers. . . I 've got some GUI programs, written in Python/wxPython, and I've got a help button and a help menu item. Also, I've got a compiled file made with...
2
by: Sudheer Kareem | last post by:
Dear All Please tell me how to assosiate help files with my Vb.net Project. Regards Sudheer
6
by: wukexin | last post by:
Help me, good men. I find mang books that introduce bit "mang header files",they talk too bit,in fact it is my too fool, I don't learn it, I have do a test program, but I have no correct doing...
5
by: Craig Keightley | last post by:
Please help, i have attached my page which worksin IE but i cannnot get the drop down menu to fucntion in firefox. Any one have any ideas why? Many Thanks Craig ...
0
by: tbatwork828 | last post by:
If you were like me trying to figure out how to launch context sensitive help topic by the context id, here is the link: http://weblogs.asp.net/kencox/archive/2004/09/12/228349.aspx and if...
4
by: dixie | last post by:
Help, I'm really out of my depth here (not unusual I hear you say :-). I have just installed HTML Help in an application. I told it in the Project Properties the path to the help file. I then...
5
by: Steve | last post by:
I have written a help file (chm) for a DLL and referenced it using Help.ShowHelp My expectation is that a developer using my DLL would be able to access this help file during his development time...
9
by: JJ | last post by:
Do you all use HTML help workshop to create your help system. I am finding it quite clumsy to use. Mayeb because I am not used to using it. Do any of you use any other techniques to create help...
10
by: JonathanOrlev | last post by:
Hello everybody, I wrote this comment in another message of mine, but decided to post it again as a standalone message. I think that Microsoft's Office 2003 help system is horrible, probably...
0
by: DolphinDB | last post by:
Tired of spending countless mintues downsampling your data? Look no further! In this article, you’ll learn how to efficiently downsample 6.48 billion high-frequency records to 61 million...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
0
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
0
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.