Problem changing label text from different form

[robertybob]

Hi

I have a form, say Form1, that contains Label1 and a subroutine doText() that loads text into Label1.

Public Sub doText()
    Label1.Text = "Hello"
End Sub
 

Form1 opens Form2 via Form2.Showdialog().

Public Sub loadForm()
    Form2.ShowDialog()
End Sub
 

A subroutine on Form2 triggers the doText() on Form1 to reload the text of Label1.

Public Sub changeText()
    Form1.doText()
End Sub
 

The subroutine fires but Label1.Text does not change as for some reason it can't locate Label1.Text value. Please be advised that there is code that determines the new text prior to changing Label1 but there's simply no need for it here as that's not the issue.

I assume there's a way to open Form2 and target Label1 properly and I'm obviously not doing that.

Any suggestions as to the proper format of the code to get this to work?

Thanks

[robertybob]

For clarity....

If I run MsgBox("Old: " & Label1.Text) from Form1 it's fine. If I trigger doText() from Form2, the same line outputs "Old: ".

Something is not targeting the label correctly.

Thanks

[IronRazer]

Hello robertybob,
I have checked your example code and it changed the label text and showed the text in the messagebox fine. There must be a problem somewhere else that is causing the problem. You will have to post the code you are actually using in the subs for us to be able to see what is wrong.

[VanessaMeacham]

HI robertybob,

if you have example please share with us because i have also face this problem.

[robertybob]

Thanks for the replies - I tried this myself with a basic version this morning and it also seemed ok so am trying to sort out an extended version of the code to see if anyone can spot a conflict somewhere

[robertybob]

Here is a snippet of code

'FORM1
Option Explicit On
 
Public Sub doText()
        MsgBox("Old: " & Label1.Text) ' this fails to find Label1.Text but only when called from Form2
' remaining sub code irrelevant as this line fails
End Sub
 
' FORM2
    Private Sub doStuff()
        If TextBox1.Text <> "" Then
                TextBox1.Text = ""
                Label2.Text = "Success"
                Label2.ForeColor = Color.Lime
                Button1.Enabled = True
                Button1.Focus()
                Form1.doText()
        End If
    End Sub
 

The Label1 text is blank initially and is populated by running the full doText sub on load of Form1.

If I run the sub from Form2, the first time the MsgBox does NOT find Label1.Text value but if I immediately run it again it DOES find the old value but it still DOESN'T update it when asked to do so via Label1.Text = "Hello".

[IronRazer]

Hi robertybob,
I have checked this example and it is also working for me as long as label1.text has been set before the messagebox is shown. When is label1.text being set on form1. Are you sure it is being set before the doText sub is called or before the messagebox is being shown? That sounds like it could be the problem to me if text is shown the second time.

[robertybob]

Hi IronRazor,

The onload for Form1 definitely populates the text for Label1 so it has a value before Form2 is opened (at least a visible value although I feel its actual value is still blank). The fact is that even if it finds the value for Label1.Text and shows it in the MsgBox, it still doesn't then replace the Label1.Text with the new text in the next line. Doesn't seem feasible but it's true.

Always seems to take the old value of the label but never replaces it - it's like the swapping of the text initially invalidates the label from any form other than the one containing it.

[IronRazer]

I`m back,
Maybe i am just not understanding what your trying to do or how the code is set up in your program. I am guessing your code is to long or you just don`t want everyone to see it so, this is the code i have been testing. Can you make this code so it is set up to reproduce the problem and re-post the code so i can see it.

Form1.vb

Public Class Form1
 
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        Label1.Text = "Old Text"
    End Sub
 
    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Form2.ShowDialog()
    End Sub
 
    Public Sub doText()
        MessageBox.Show("Old: " & Label1.Text)
 
        'I just used this to change the text so i
        'could do it 2 times and see text change
        'each time for testing.
        If Label1.Text = "Old Text" Then
            Label1.Text = "New Text"
        Else
            Label1.Text = "New Text 2"
        End If
    End Sub
End Class
 

Form2.vb

Public Class Form2
 
    Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
        doStuff()
    End Sub
 
    Private Sub doStuff()
        If TextBox1.Text <> "" Then
            'I used dummy controls on form 2 for
            'these just to reproduce the effect.
            TextBox1.Text = ""
            Label2.Text = "Success"
            Label2.ForeColor = Color.Lime
            Button1.Enabled = True
            Button1.Focus()
            'The call to show messagebox.
            Form1.doText()
        End If
    End Sub
End Class

[robertybob]

Hi everyone,

Many thanks for all the effort here but I think I've located the problem and it goes way further back than I thought :\

It seems the error was that the opening of Form2 was done by creating a Dim newform2 as New Form2 and then calling newform2.Show() rather than just doing Form2.Show()

This seems to have killed the shared variables and the amended text etc, causing the error....

Didn't occur to me that this could be an issue as this is all a bit new to me but thanks for all you replies here confirming that the actual code I was attempting was fine - just now seems my opening of the form was the culprit.

Nice to find a forum with helpful, prompt and informative responses though. All the best.

[IronRazer]

Hey robertybob,
It was no problem. I like to help when i can. I find that most times it seems to be something simple that i overlook all day long that ends up being the problem in my programs. Have a good day.