Does the for closing event always fire?

[Harry]

Hi All

VS 2008 Pro

It appears that the form_closing event of a form may not always fire. I put
an explicit lock on a customer record when it is open for edit and then
remove the lock in the form_closing event when the form is closed. This used
to work fine in VB6 but appears to be a bit unreliable in VB.Net.

code------------------------------------------------------------------

Private Sub frmAccount_FormClosing(ByVal sender As Object, ByVal e As
System.Windows.Forms.FormClosingEventArgs) Handles Me.FormClosing
Select Case Ask_Save(oAccount.IsDirty)

Case Windows.Forms.DialogResult.Cancel

e.Cancel = True

Return

Case Windows.Forms.DialogResult.No

oAccount.Fetch() 'refresh the data

Case Windows.Forms.DialogResult.Yes

oAccount.Operator_ID = Glo.OperatorID

_DataChanged = oAccount.Save()

End Select

'--------------------

'clear user form lock

'--------------------

ClearLock(oLock)

End Sub

Can anyone offer any suggestions on how to overcome this. Should I use the
form_disposed event or perhaps the Finalise method?

Thank you for any input

Harry

[Armin Zingler]

"Harry" <ha*********@ffapaysmart.com.auschrieb

Hi All

VS 2008 Pro

It appears that the form_closing event of a form may not always
fire. I put an explicit lock on a customer record when it is open
for edit and then remove the lock in the form_closing event when the
form is closed. This used to work fine in VB6 but appears to be a
bit unreliable in VB.Net.

[...]
Can anyone offer any suggestions on how to overcome this. Should I
use the form_disposed event or perhaps the Finalise method?

No, the Form_Closing event is the right place. Have you set a breakpoint
in the event handler? Is it reached every time? I have never seen a Form
closing without the FormClosing event fires.
Armin

[Patrice]

Never seen that. You may want to check that the event is triggered. My guess
would be rather than oAccount.IsDirty is not correct perhaps making the
dialog auto-answering (not sure what you have done in Ask_Save, does it
always show a UI or can it return directly ?) ?

--
Patrice

"Harry" <ha*********@ffapaysmart.com.aua écrit dans le message de groupe
de discussion : es**************@TK2MSFTNGP03.phx.gbl...

Hi All

VS 2008 Pro

It appears that the form_closing event of a form may not always fire. I
put an explicit lock on a customer record when it is open for edit and
then remove the lock in the form_closing event when the form is closed.
This used to work fine in VB6 but appears to be a bit unreliable in
VB.Net.

code------------------------------------------------------------------

Private Sub frmAccount_FormClosing(ByVal sender As Object, ByVal e As
System.Windows.Forms.FormClosingEventArgs) Handles Me.FormClosing
Select Case Ask_Save(oAccount.IsDirty)

Case Windows.Forms.DialogResult.Cancel

e.Cancel = True

Return

Case Windows.Forms.DialogResult.No

oAccount.Fetch() 'refresh the data

Case Windows.Forms.DialogResult.Yes

oAccount.Operator_ID = Glo.OperatorID

_DataChanged = oAccount.Save()

End Select

'--------------------

'clear user form lock

'--------------------

ClearLock(oLock)

End Sub

Can anyone offer any suggestions on how to overcome this. Should I use the
form_disposed event or perhaps the Finalise method?

Thank you for any input

Harry

[Cor Ligthert [MVP]]

Armin,

>
No, the Form_Closing event is the right place. Have you set a breakpoint
in the event handler? Is it reached every time? I have never seen a Form
closing without the FormClosing event fires.

Me either, however as you set somewhere "End" in a program what is than the
effect.

Cor

[Armin Zingler]

"Cor Ligthert [MVP]" <no************@planet.nlschrieb

Armin,

No, the Form_Closing event is the right place. Have you set a
breakpoint in the event handler? Is it reached every time? I have
never seen a Form closing without the FormClosing event fires.

Me either, however as you set somewhere "End" in a program what is
than the effect.

I use "End" very frequently...
....followed by "Sub", "Function",...

;-)

Armin

[Joergen Bech]

On Tue, 29 Apr 2008 08:09:53 +1000, "Harry"
<ha*********@ffapaysmart.com.auwrote:

>Hi All

---snip---

>Can anyone offer any suggestions on how to overcome this. Should I use the
form_disposed event or perhaps the Finalise method?

You are not crazy. There are situations where the FormClosing event
does not fire.

There is a discussion about it here with a few examples:
http://forums.devshed.com/net-develo...-c-475778.html

For my own part, I have on occasion been bitten by one of those:
---snip---
"FormClosing will not fire on a form if it is a secondary form that is
not owned by the primary form, and the primary form is closed, causing
Main() to return and the application to exit."
---snip---

In any case, you should *not* use Disposed or Finalize to control
your locks.

/Joergen Bech

[Armin Zingler]

"Joergen Bech" <jb***@post1.tele.dkschrieb

---snip---
"FormClosing will not fire on a form if it is a secondary form that
is not owned by the primary form, and the primary form is closed,
causing Main() to return and the application to exit."
---snip---

Good point. However, IMO it's the programmers fault if he sets Form1 as
the startup object on the one hand, and also wants to keep Form2 alive
even if Form1 has been closed on the other hand. That's a
contradiction. - unless the "application framework" is used and the
shutdown mode is "when last form closes".
Armin