Hi,
i get the error:
"There is already an open DataReader associated with this Command which must
be closed first"
Thanks
Bart
-----------------------------------------
Imports System.Data.sqlclient
Imports System.Data
....
....
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNonQuery()
Next
dtreader.Close()
--------------------------------------------------------------- 13 31676
Create another command object for running the insert:
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET] http://msmvps.com/blogs/egoldin
"Bart" <b@sdq.dcwrote in message
news:uk**************@TK2MSFTNGP02.phx.gbl...
Hi,
i get the error:
"There is already an open DataReader associated with this Command which
must
be closed first"
Thanks
Bart
-----------------------------------------
Imports System.Data.sqlclient
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNonQuery()
Next
dtreader.Close()
---------------------------------------------------------------
Hi, thansk for replying
I did this:
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
Next
dtreader.Close()
but still same error at line: comd1.ExecuteNonQuery()
"Eliyahu Goldin" <RE**************************@mMvVpPsS.orgschree f in
bericht news:OB*************@TK2MSFTNGP02.phx.gbl...
Create another command object for running the insert:
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET] http://msmvps.com/blogs/egoldin
You need to re-structure the code to close the first datareader before
starting using another one on the same connection. Only one request can be
served at the time and untill the first reader closes it won't let anyone
else to run.
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET] http://msmvps.com/blogs/egoldin
"Bart" <b@sdq.dcwrote in message
news:Og**************@TK2MSFTNGP02.phx.gbl...
Hi, thansk for replying
I did this:
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
Next
dtreader.Close()
but still same error at line: comd1.ExecuteNonQuery()
"Eliyahu Goldin" <RE**************************@mMvVpPsS.orgschree f in
bericht news:OB*************@TK2MSFTNGP02.phx.gbl...
Create another command object for running the insert:
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET] http://msmvps.com/blogs/egoldin
Bart wrote:
Hi,
i get the error:
"There is already an open DataReader associated with this Command which must
be closed first"
Thanks
Bart
-----------------------------------------
Imports System.Data.sqlclient
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNonQuery()
Next
dtreader.Close()
---------------------------------------------------------------
You can't use the connection for running queries while it's used by the
data reader.
Why don't you do this in a single query?
"insert into mytable (field1) select pcnt from pc where lokl='" & w & "';"
--
Göran Andersson
_____ http://www.guffa.com
Not sure why you want to loop to do this, as this can all be done on the SQL
side, with a temp table, unless you are persisting the answers for a long
time. Even with a permanent table, you can clear the table before rerunning
this operation. If you need to know which number the record is, you can use
an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or
autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS
INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all records
at the same time. The syntax is much easier.
1. Set up connection
2. Set up command
3. Set command as CommandType.StoredProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA
*********************************************
Think outside the box!
*********************************************
"Bart" <b@sdq.dcwrote in message
news:uk**************@TK2MSFTNGP02.phx.gbl...
Hi,
i get the error:
"There is already an open DataReader associated with this Command which
must be closed first"
Thanks
Bart
-----------------------------------------
Imports System.Data.sqlclient
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNonQuery()
Next
dtreader.Close()
---------------------------------------------------------------
Good morning Bart,
You used the same connection for more than one data readers and I guess
you're not using MARS - Multiple Active Result Sets (which is supported by
SQL Server 2005 only), therefore, once reader is executed, connection is
assigned to it exclusively - to release the connection, you have to close
connection or reader. In addition to that, there is not point to make things
complex and inefficient (shooting database many times in the loop as you’ve
presented in the posted code snipped). It’s very easy to build the query that
does exactly the same thing, but in one roundtrip:
sql = "INSERT INTO mytable (field1) SELECT pcnr FROM pc WHERE lokl = @lokl"
comd = new SqlCommand(sql, oConnection)
comd.Parameters.Add("@lokl", SqlDbType.NVarChar).Value = w
try
oConnection.Open()
comd.ExecuteNonQuery();
catch ex as Exception
throw ex
finally
oConnection.Close()
end try
Done. Hope this helps
--
Milosz
"Bart" wrote:
Hi, thansk for replying
I did this:
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteReader
For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetValue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
Next
dtreader.Close()
but still same error at line: comd1.ExecuteNonQuery()
"Eliyahu Goldin" <RE**************************@mMvVpPsS.orgschree f in
bericht news:OB*************@TK2MSFTNGP02.phx.gbl...
Create another command object for running the insert:
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNonQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET] http://msmvps.com/blogs/egoldin
Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed.
What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] ,
[dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
comd.Parameters.AddWithValue("[lol]", lol)
comd.Parameters.AddWithValue("[dag]", tda)
comd.Parameters.AddWithValue("[uur]", vv)
comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field
uur is int
....
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamMschreef in
bericht news:FB**********************************@microsof t.com...
Not sure why you want to loop to do this, as this can all be done on the
SQL side, with a temp table, unless you are persisting the answers for a
long time. Even with a permanent table, you can clear the table before
rerunning this operation. If you need to know which number the record is,
you can use an IDENTITY field, in SQL Server (have to work from DUAL in
Oracle) or autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS
INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all
records at the same time. The syntax is much easier.
1. Set up connection
2. Set up command
3. Set command as CommandType.StoredProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA
*********************************************
Think outside the box!
*********************************************
"Bart" <b@sdq.dcwrote in message
news:uk**************@TK2MSFTNGP02.phx.gbl...
>Hi,
i get the error: "There is already an open DataReader associated with this Command which must be closed first"
Thanks Bart ----------------------------------------- Imports System.Data.sqlclient Imports System.Data ... ... sql = "SELECT count(*) FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) dtreader = comd.ExecuteReader
for j = 1 To recpc dtreader.Read() ww = dtreader.GetValue(0) sql = "INSERT INTO mytable (field1 values(" & ww & ")" comd.ExecuteNonQuery() Next
dtreader.Close() ---------------------------------------------------------------
Specify the data type for the parameters.
Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a
string is a name. It's used for names with non-alphanumeric characters,
like [current-price], or names that are keywords, like [from].
Bart wrote:
Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed.
What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] ,
[dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
comd.Parameters.AddWithValue("[lol]", lol)
comd.Parameters.AddWithValue("[dag]", tda)
comd.Parameters.AddWithValue("[uur]", vv)
comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field
uur is int
...
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamMschreef in
bericht news:FB**********************************@microsof t.com...
>Not sure why you want to loop to do this, as this can all be done on the SQL side, with a temp table, unless you are persisting the answers for a long time. Even with a permanent table, you can clear the table before rerunning this operation. If you need to know which number the record is, you can use an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc ( @w int -- Not sure of type here ) AS
INSERT INTO MyTable (pcnr) SELECT pcnr FROM pc WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all records at the same time. The syntax is much easier.
1. Set up connection 2. Set up command 3. Set command as CommandType.StoredProcedure 4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
-- Gregory A. Beamer MVP; MCP: +I, SE, SD, DBA
********************************************* Think outside the box! ********************************************* "Bart" <b@sdq.dcwrote in message news:uk**************@TK2MSFTNGP02.phx.gbl...
>>Hi,
i get the error: "There is already an open DataReader associated with this Command which must be closed first"
Thanks Bart ----------------------------------------- Imports System.Data.sqlclient Imports System.Data ... ... sql = "SELECT count(*) FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) dtreader = comd.ExecuteReader
for j = 1 To recpc dtreader.Read() ww = dtreader.GetValue(0) sql = "INSERT INTO mytable (field1 values(" & ww & ")" comd.ExecuteNonQuery() Next
dtreader.Close() ---------------------------------------------------------------
--
Göran Andersson
_____ http://www.guffa.com
Yes, that's it
thanks
"Göran Andersson" <gu***@guffa.comschreef in bericht
news:eZ**************@TK2MSFTNGP02.phx.gbl...
Specify the data type for the parameters.
Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a
string is a name. It's used for names with non-alphanumeric characters,
like [current-price], or names that are keywords, like [from].
Bart wrote:
>Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed. What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] , [dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) comd.Parameters.AddWithValue("[lol]", lol) comd.Parameters.AddWithValue("[dag]", tda) comd.Parameters.AddWithValue("[uur]", vv) comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field uur is int
...
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamMschreef in bericht news:FB**********************************@microsof t.com...
>>Not sure why you want to loop to do this, as this can all be done on the SQL side, with a temp table, unless you are persisting the answers for a long time. Even with a permanent table, you can clear the table before rerunning this operation. If you need to know which number the record is, you can use an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc ( @w int -- Not sure of type here ) AS
INSERT INTO MyTable (pcnr) SELECT pcnr FROM pc WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all records at the same time. The syntax is much easier.
1. Set up connection 2. Set up command 3. Set command as CommandType.StoredProcedure 4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
-- Gregory A. Beamer MVP; MCP: +I, SE, SD, DBA
********************************************* Think outside the box! ********************************************* "Bart" <b@sdq.dcwrote in message news:uk**************@TK2MSFTNGP02.phx.gbl... Hi,
i get the error: "There is already an open DataReader associated with this Command which must be closed first"
Thanks Bart ----------------------------------------- Imports System.Data.sqlclient Imports System.Data ... ... sql = "SELECT count(*) FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) dtreader = comd.ExecuteReader
for j = 1 To recpc dtreader.Read() ww = dtreader.GetValue(0) sql = "INSERT INTO mytable (field1 values(" & ww & ")" comd.ExecuteNonQuery() Next
dtreader.Close() ---------------------------------------------------------------
--
Göran Andersson
_____ http://www.guffa.com
Goran,
would it be possible to do this::
sql = "INSERT INTO studres ( uur, pcnr) SELECT uur from uur where range='"
& v & "', pcnr FROM pc where naam='" & w & "';"
Thanks
"Göran Andersson" <gu***@guffa.comschreef in bericht
news:eZ**************@TK2MSFTNGP02.phx.gbl...
Specify the data type for the parameters.
Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a
string is a name. It's used for names with non-alphanumeric characters,
like [current-price], or names that are keywords, like [from].
Bart wrote:
>Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed. What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] , [dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) comd.Parameters.AddWithValue("[lol]", lol) comd.Parameters.AddWithValue("[dag]", tda) comd.Parameters.AddWithValue("[uur]", vv) comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field uur is int
...
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamMschreef in bericht news:FB**********************************@microsof t.com...
>>Not sure why you want to loop to do this, as this can all be done on the SQL side, with a temp table, unless you are persisting the answers for a long time. Even with a permanent table, you can clear the table before rerunning this operation. If you need to know which number the record is, you can use an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc ( @w int -- Not sure of type here ) AS
INSERT INTO MyTable (pcnr) SELECT pcnr FROM pc WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all records at the same time. The syntax is much easier.
1. Set up connection 2. Set up command 3. Set command as CommandType.StoredProcedure 4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
-- Gregory A. Beamer MVP; MCP: +I, SE, SD, DBA
********************************************* Think outside the box! ********************************************* "Bart" <b@sdq.dcwrote in message news:uk**************@TK2MSFTNGP02.phx.gbl... Hi,
i get the error: "There is already an open DataReader associated with this Command which must be closed first"
Thanks Bart ----------------------------------------- Imports System.Data.sqlclient Imports System.Data ... ... sql = "SELECT count(*) FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) recpc = comd.ExecuteScalar
sql = "SELECT pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) dtreader = comd.ExecuteReader
for j = 1 To recpc dtreader.Read() ww = dtreader.GetValue(0) sql = "INSERT INTO mytable (field1 values(" & ww & ")" comd.ExecuteNonQuery() Next
dtreader.Close() ---------------------------------------------------------------
--
Göran Andersson
_____ http://www.guffa.com
Join the tables:
insert into studres (uur, pcnr)
select uur.uur, pc.pcnr
from uur
inner join pc on pc.naam = @w
where uur.range = @v
Bart wrote:
Goran,
would it be possible to do this::
sql = "INSERT INTO studres ( uur, pcnr) SELECT uur from uur where range='"
& v & "', pcnr FROM pc where naam='" & w & "';"
Thanks
"Göran Andersson" <gu***@guffa.comschreef in bericht
news:eZ**************@TK2MSFTNGP02.phx.gbl...
>Specify the data type for the parameters. Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a string is a name. It's used for names with non-alphanumeric characters, like [current-price], or names that are keywords, like [from].
Bart wrote:
>>Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed. What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] , [dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) comd.Parameters.AddWithValue("[lol]", lol) comd.Parameters.AddWithValue("[dag]", tda) comd.Parameters.AddWithValue("[uur]", vv) comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field uur is int
...
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamMschreef in bericht news:FB**********************************@microsof t.com... Not sure why you want to loop to do this, as this can all be done on the SQL side, with a temp table, unless you are persisting the answers for a long time. Even with a permanent table, you can clear the table before rerunning this operation. If you need to know which number the record is, you can use an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or autonumber in Access.
This is the proc in SQL Server:
CREATE PROCEDURE TestProc ( @w int -- Not sure of type here ) AS
INSERT INTO MyTable (pcnr) SELECT pcnr FROM pc WHERE lokl = @w
SELECT @@COUNT
You now can use the return value for count and run the insert on all records at the same time. The syntax is much easier.
1. Set up connection 2. Set up command 3. Set command as CommandType.StoredProcedure 4. Run ExecuteScalar on Command and retrieve count of records changed
Very effficient and much easier to manage.
-- Gregory A. Beamer MVP; MCP: +I, SE, SD, DBA
********************************************* Think outside the box! ********************************************* "Bart" <b@sdq.dcwrote in message news:uk**************@TK2MSFTNGP02.phx.gbl... Hi, > i get the error: "There is already an open DataReader associated with this Command which must be closed first" > Thanks Bart ----------------------------------------- Imports System.Data.sqlclient Imports System.Data ... ... sql = "SELECT count(*) FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) recpc = comd.ExecuteScalar > sql = "SELECT pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) dtreader = comd.ExecuteReader > for j = 1 To recpc dtreader.Read() ww = dtreader.GetValue(0) sql = "INSERT INTO mytable (field1 values(" & ww & ")" comd.ExecuteNonQuery() Next > dtreader.Close() --------------------------------------------------------------- >
--
Göran Andersson
_____ http://www.guffa.com
thanks,
I tried something else and it works too::
sql = "INSERT INTO studres (logon, dag, type, uur, pcnr) SELECT @lol , @dag,
'l', uur.uur, pc.pcnr FROM uur, pc WHERE pc.naam=@pcna AND uur.range= @uur;"
"Göran Andersson" <gu***@guffa.comschreef in bericht
news:eU**************@TK2MSFTNGP04.phx.gbl...
Join the tables:
insert into studres (uur, pcnr)
select uur.uur, pc.pcnr
from uur
inner join pc on pc.naam = @w
where uur.range = @v
Bart wrote:
>Goran,
would it be possible to do this::
sql = "INSERT INTO studres ( uur, pcnr) SELECT uur from uur where range='" & v & "', pcnr FROM pc where naam='" & w & "';"
Thanks "Göran Andersson" <gu***@guffa.comschreef in bericht news:eZ**************@TK2MSFTNGP02.phx.gbl...
>>Specify the data type for the parameters. Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a string is a name. It's used for names with non-alphanumeric characters, like [current-price], or names that are keywords, like [from].
Bart wrote: Thanks to all ...
But in fact, it's not so simple, because there are other parameters needed. What i try to do is:
sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] , [dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) comd.Parameters.AddWithValue("[lol]", lol) comd.Parameters.AddWithValue("[dag]", tda) comd.Parameters.AddWithValue("[uur]", vv) comd.ExecuteNonQuery()
but this gives the error:"Incorrect syntax near 'nvarchar'.
In sql server, field login is nvarchar(25), field dag is Datetime and field uur is int
...
"Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamM> schreef in bericht news:FB**********************************@micro soft.com... Not sure why you want to loop to do this, as this can all be done on the SQL side, with a temp table, unless you are persisting the answers for a long time. Even with a permanent table, you can clear the table before rerunning this operation. If you need to know which number the record is, you can use an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or autonumber in Access. > This is the proc in SQL Server: > CREATE PROCEDURE TestProc ( @w int -- Not sure of type here ) AS > INSERT INTO MyTable (pcnr) SELECT pcnr FROM pc WHERE lokl = @w > SELECT @@COUNT > You now can use the return value for count and run the insert on all records at the same time. The syntax is much easier. > 1. Set up connection 2. Set up command 3. Set command as CommandType.StoredProcedure 4. Run ExecuteScalar on Command and retrieve count of records changed > Very effficient and much easier to manage. > -- Gregory A. Beamer MVP; MCP: +I, SE, SD, DBA > ******************************************** * Think outside the box! ******************************************** * "Bart" <b@sdq.dcwrote in message news:uk**************@TK2MSFTNGP02.phx.gbl.. . >Hi, >> >i get the error: >"There is already an open DataReader associated with this Command >which must be closed first" >> >Thanks >Bart >----------------------------------------- >Imports System.Data.sqlclient >Imports System.Data >... >... >sql = "SELECT count(*) FROM pc where lokl='" & w & "';" >comd = New SqlCommand(sql, oConnection) >recpc = comd.ExecuteScalar >> >sql = "SELECT pcnr FROM pc where lokl='" & w & "';" >comd = New SqlCommand(sql, oConnection) >dtreader = comd.ExecuteReader >> >for j = 1 To recpc >dtreader.Read() >ww = dtreader.GetValue(0) >sql = "INSERT INTO mytable (field1 values(" & ww & ")" >comd.ExecuteNonQuery() >Next >> >dtreader.Close() >--------------------------------------------------------------- >>
--
Göran Andersson
_____ http://www.guffa.com
Yes, that's how you would write a join before the join keyword was
introduced.
Bart wrote:
thanks,
I tried something else and it works too::
sql = "INSERT INTO studres (logon, dag, type, uur, pcnr) SELECT @lol , @dag,
'l', uur.uur, pc.pcnr FROM uur, pc WHERE pc.naam=@pcna AND uur.range= @uur;"
"Göran Andersson" <gu***@guffa.comschreef in bericht
news:eU**************@TK2MSFTNGP04.phx.gbl...
>Join the tables:
insert into studres (uur, pcnr) select uur.uur, pc.pcnr from uur inner join pc on pc.naam = @w where uur.range = @v
Bart wrote:
>>Goran,
would it be possible to do this::
sql = "INSERT INTO studres ( uur, pcnr) SELECT uur from uur where range='" & v & "', pcnr FROM pc where naam='" & w & "';"
Thanks "Göran Andersson" <gu***@guffa.comschreef in bericht news:eZ**************@TK2MSFTNGP02.phx.gbl... Specify the data type for the parameters. Example:
comd.Parameters.Add("@lol", SqlDbType.NVarChar. 25).Value = lol
Parameters are named using @. Square brackets are used to specify that a string is a name. It's used for names with non-alphanumeric characters, like [current-price], or names that are keywords, like [from].
Bart wrote: Thanks to all ... > But in fact, it's not so simple, because there are other parameters needed. What i try to do is: > sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] , [dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';" comd = New SqlCommand(sql, oConnection) comd.Parameters.AddWithValue("[lol]", lol) comd.Parameters.AddWithValue("[dag]", tda) comd.Parameters.AddWithValue("[uur]", vv) comd.ExecuteNonQuery() > but this gives the error:"Incorrect syntax near 'nvarchar'. > In sql server, field login is nvarchar(25), field dag is Datetime and field uur is int > ... > > "Cowboy (Gregory A. Beamer)" <No************@comcast.netNoSpamM> schreef in bericht news:FB**********************************@micr osoft.com... >Not sure why you want to loop to do this, as this can all be done on >the SQL side, with a temp table, unless you are persisting the answers >for a long time. Even with a permanent table, you can clear the table >before rerunning this operation. If you need to know which number the >record is, you can use an IDENTITY field, in SQL Server (have to work >from DUAL in Oracle) or autonumber in Access. >> >This is the proc in SQL Server: >> >CREATE PROCEDURE TestProc >( > @w int -- Not sure of type here >) >AS >> >INSERT INTO MyTable (pcnr) >SELECT pcnr FROM pc >WHERE lokl = @w >> >SELECT @@COUNT >> >You now can use the return value for count and run the insert on all >records at the same time. The syntax is much easier. >> >1. Set up connection >2. Set up command >3. Set command as CommandType.StoredProcedure >4. Run ExecuteScalar on Command and retrieve count of records changed >> >Very effficient and much easier to manage. >> >-- >Gregory A. Beamer >MVP; MCP: +I, SE, SD, DBA >> >******************************************* ** >Think outside the box! >******************************************* ** >"Bart" <b@sdq.dcwrote in message >news:uk**************@TK2MSFTNGP02.phx.gbl. .. >>Hi, >>> >>i get the error: >>"There is already an open DataReader associated with this Command >>which must be closed first" >>> >>Thanks >>Bart >>----------------------------------------- >>Imports System.Data.sqlclient >>Imports System.Data >>... >>... >>sql = "SELECT count(*) FROM pc where lokl='" & w & "';" >>comd = New SqlCommand(sql, oConnection) >>recpc = comd.ExecuteScalar >>> >>sql = "SELECT pcnr FROM pc where lokl='" & w & "';" >>comd = New SqlCommand(sql, oConnection) >>dtreader = comd.ExecuteReader >>> >>for j = 1 To recpc >>dtreader.Read() >>ww = dtreader.GetValue(0) >>sql = "INSERT INTO mytable (field1 values(" & ww & ")" >>comd.ExecuteNonQuery() >>Next >>> >>dtreader.Close() >>--------------------------------------------------------------- >>>
-- Göran Andersson _____ http://www.guffa.com
--
Göran Andersson
_____ http://www.guffa.com This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: fniles |
last post by:
I am using VB.NET 2003, SQL 2000, and SqlDataReader.
As I read data from tblA, I want to populate tblB. I use SQLDataReader for
both tables. I do not use thread.
When I ExecuteReader on tblB, I...
|
by: jimmy |
last post by:
Hi again,
sorry for posting two questions so close together but im working on a
school project which is due in soon and running into some difficulties
implementing the database parts. I have the...
|
by: Bart |
last post by:
Hi,
i get the error:
"There is already an open DataReader associated with this Command which must
be closed first"
Thanks
Bart
-----------------------------------------
Imports...
|
by: BLUE |
last post by:
I've a TransactionScope in which I select some data and I want to do some
queries for each record retrieved with my select.
I'm using a DataReader and for each record I do factory.CreateCommand()...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: Sonnysonu |
last post by:
This is the data of csv file
1 2 3
1 2 3
1 2 3
1 2 3
2 3
2 3
3
the lengths should be different i have to store the data by column-wise with in the specific length.
suppose the i have to...
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new...
| |