This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could point
me in the right direction.
The history:
My work involves creating custom packages of our software product for golf
courses that purchase our software. The course data is kept as a back up in
the event the course needs us to replace their custom files. Each course has
a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our customer
base increases.
The solution:
Compress each course folder into an individual .cab file containing all of
the course's custom files and then archive these files to storage media such
as CD/DVD.
Where I need help:
I found some code for implementing a command line window and passing it a
string through a stream. The command window is being instantiated, but the
string is not getting passed or my syntax for running the makecab utility is
off-base. I've spent several hours looking for sample code that would
explain the makecab syntax and I've also tried to determine if the
parameters are being passed in to the Sub correctly. I've set a break at the
line where the string should be passed to the command window, but I can not
seem to get a respnse from the watches that have been set. I've included a
copy of the sub that I'm using to compress the files. If this is not the
correct forum for this, I do apologize. A nudge in the correct direction
would be deeply appreciated.
Private Sub CompressFolder(ByVal ToFolder As String, ByVal FromFolder As
String, ByVal FinalFile As String)
Dim CompressProcess As Process = New Process
CompressProcess.StartInfo.FileName = "cmd.exe"
CompressProcess.StartInfo.UseShellExecute = False
CompressProcess.StartInfo.CreateNoWindow = True
CompressProcess.StartInfo.RedirectStandardInput = True
CompressProcess.StartInfo.RedirectStandardOutput = True
CompressProcess.StartInfo.RedirectStandardError = True
CompressProcess.Start()
Dim stmStreamIn As IO.StreamWriter = CompressProcess.StandardInput
stmStreamIn.AutoFlush = True
Dim stmStreamOut As IO.StreamReader = CompressProcess.StandardOutput
Dim stmStreamErr As IO.StreamReader = CompressProcess.StandardError
stmStreamIn.Write("makecab.exe /L %ToFolder% %FromFolder% %FinalFile%" &
System.Environment.NewLine)
stmStreamIn.Write("exit" & System.Environment.NewLine)
If Not CompressProcess.HasExited Then
CompressProcess.Kill()
End If
stmStreamIn.Close()
stmStreamOut.Close()
stmStreamErr.Close()
End Sub
46  2469 
Nice idea, but you're slightly on the wrong track with your usage of
makecab.exe.
The /L switch can only be used to compress a single source file into a
single .cab file, so unless you want gazillions of .cab files that's not
much good.
The /F switch is used to compress multiple source files into a into a single
..cab file, but it's a bit more complicated that you think.
Makecab.exe does not use standardinput/output. With the /F switch it reads
the required information from a definition file and it, in addition to
creating the .cab file, writes summary information to a 'report' file and
other information to a 'inf' file. Don't even consider the whys and
wherefores of this because what you are attempting to do is slight
non-standard compared to what makecab.exe was actually designed for.
Now for the nitty gritty.
The first thing you need to do is write a definition file, lets call it
test.ddf for the purpose of the exercise:
Dim _sw As New StreamWriter("test.ddf")
_sw.WriteLine(".Set SourceDir=" & FromFolder)
_sw.WriteLine(".Set CabinetNameTemplate=" & FinalFile)
_sw.WriteLine(".Set DiskDirectoryTemplate=" & ToFolder)
_sw.WriteLine(".Set InfFileName=test.inf")
_sw.WriteLine(".Set RptFileName=test.rpt")
_sw.WriteLine(".Set Cabinet=ON")
_sw.WriteLine(".Set Compress=ON")
Dim _files as String() = Directory.GetFiles(FromFolder)
For Each _file as String In _files
_sw.WriteLine(File.GetFileName(_file))
Next
_sw.Close()
Makecab.exe is very unforgiving if you get the syntax of the definition file
wrong.
If FromFolder does not exist then it will fail.
It will create the folder indicated by the final node of ToFolder, but it
will fail if any of the folders higher up the hierachy do not exist. This
can be circumvented by executing:
If Not Directory.Exists(Path.GetDirectory(ToFolder)) Then
Directory.CreateDirectory(Path.GetDirectory(ToFold er))
Note that ALL the files that you want in the .cab file MUST be included in
the definition file. As you can see this is easily achieved by iterating
through all the files in FromFolder. Also note that baecause .Set SourceDir
is specified, only the actual filename is required and not the full path.
The next thing is to execute makecab.exe:
Process.Start("makecab.exe", "/F test.ddf").WaitForExit()
A command window will momentarily appear and disappear.
Now you will probably want to see what happened. Plonk a TextBox on the
form, make it multiline, set it's Font to your favourite mono-spaced font
and size it to a decent size.
TextBox1.Text = File.ReadAllText("test.rpt")
Now all you have to do is tidy up after yourself:
File.Delete("test.ddf")
File.Delete("test.inf")
File.Delete("test.rpt")
Supress the File.Delete's if you want to have a look in the test.inf file
but I doubt whether the content of it will be of any value to you given what
you are trying to achieve.
The following link will alow you to download the a file called Cabsdk.exe
hich contains, among other things, a Word document that provides a lot of
detail about makecab.exe. http://download.microsoft.com/downlo...-us/Cabsdk.exe
Have fun!
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:bZ******************************@comcast.com. ..
This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could
point me in the right direction.
The history:
My work involves creating custom packages of our software product for golf
courses that purchase our software. The course data is kept as a back up
in the event the course needs us to replace their custom files. Each
course has a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our
customer base increases.
The solution:
Compress each course folder into an individual .cab file containing all of
the course's custom files and then archive these files to storage media
such as CD/DVD.
Where I need help:
I found some code for implementing a command line window and passing it a
string through a stream. The command window is being instantiated, but the
string is not getting passed or my syntax for running the makecab utility
is off-base. I've spent several hours looking for sample code that would
explain the makecab syntax and I've also tried to determine if the
parameters are being passed in to the Sub correctly. I've set a break at
the line where the string should be passed to the command window, but I
can not seem to get a respnse from the watches that have been set. I've
included a copy of the sub that I'm using to compress the files. If this
is not the correct forum for this, I do apologize. A nudge in the correct
direction would be deeply appreciated.
Private Sub CompressFolder(ByVal ToFolder As String, ByVal FromFolder As
String, ByVal FinalFile As String)
Dim CompressProcess As Process = New Process
CompressProcess.StartInfo.FileName = "cmd.exe"
CompressProcess.StartInfo.UseShellExecute = False
CompressProcess.StartInfo.CreateNoWindow = True
CompressProcess.StartInfo.RedirectStandardInput = True
CompressProcess.StartInfo.RedirectStandardOutput = True
CompressProcess.StartInfo.RedirectStandardError = True
CompressProcess.Start()
Dim stmStreamIn As IO.StreamWriter = CompressProcess.StandardInput
stmStreamIn.AutoFlush = True
Dim stmStreamOut As IO.StreamReader = CompressProcess.StandardOutput
Dim stmStreamErr As IO.StreamReader = CompressProcess.StandardError
stmStreamIn.Write("makecab.exe /L %ToFolder% %FromFolder% %FinalFile%" &
System.Environment.NewLine)
stmStreamIn.Write("exit" & System.Environment.NewLine)
If Not CompressProcess.HasExited Then
CompressProcess.Kill()
End If
stmStreamIn.Close()
stmStreamOut.Close()
stmStreamErr.Close()
End Sub
Stephany,
Thank you so very much. I will give this a go when I get home from work. The
link to the CabSDK I've already downloaded, but I didn't see the .doc, so
I'll go through my download again. Cheers!
"Stephany Young" <noone@localhostwrote in message
news:u5**************@TK2MSFTNGP03.phx.gbl...
Nice idea, but you're slightly on the wrong track with your usage of
makecab.exe.
On Sat, 9 Dec 2006 00:34:16 -0700, Bruce W. Darby wrote:
This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could point
me in the right direction.
The history:
My work involves creating custom packages of our software product for golf
courses that purchase our software. The course data is kept as a back up in
the event the course needs us to replace their custom files. Each course has
a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our customer
base increases.
The solution:
Compress each course folder into an individual .cab file containing all of
the course's custom files and then archive these files to storage media such
as CD/DVD.
If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to accomplish
this sort of thing. http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes http://bytes.thinkersroom.com
Rad,
I have downloaded the SharpZip files and am reading into them, but at this
point in time, I doubt my ability as a programmer to be able to incorporate
this on a module level. I do understand that there are better compression
methods available, but I'd like to start small and work my way up the
ladder, so to speak. Thank you very much for your assistance.
Bruce
"Rad [Visual C# MVP]" <no****@nospam.comwrote in message
news:rn***************@thinkersroom.com...
On Sat, 9 Dec 2006 00:34:16 -0700, Bruce W. Darby wrote:
>This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could
point
me in the right direction.
The history:
My work involves creating custom packages of our software product for
golf
courses that purchase our software. The course data is kept as a back up
in
the event the course needs us to replace their custom files. Each course
has
a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our
customer
base increases.
The solution:
Compress each course folder into an individual .cab file containing all
of
the course's custom files and then archive these files to storage media
such
as CD/DVD.
If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to
accomplish
this sort of thing.
http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes
http://bytes.thinkersroom.com
It sounds like losser mentality to me, insecurities in your ability to
learn. Maybe programming just isn't the right thing for you. Don't feel
too ashamed, not everyone can reach the highest levels. You can always
try something else less demanding.
The Grand Master
Bruce W. Darby wrote:
Rad,
I have downloaded the SharpZip files and am reading into them, but at this
point in time, I doubt my ability as a programmer to be able to incorporate
this on a module level. I do understand that there are better compression
methods available, but I'd like to start small and work my way up the
ladder, so to speak. Thank you very much for your assistance.
Bruce
"Rad [Visual C# MVP]" <no****@nospam.comwrote in message
news:rn***************@thinkersroom.com...
On Sat, 9 Dec 2006 00:34:16 -0700, Bruce W. Darby wrote:
This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could
point
me in the right direction.
The history:
My work involves creating custom packages of our software product for
golf
courses that purchase our software. The course data is kept as a back up
in
the event the course needs us to replace their custom files. Each course
has
a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our
customer
base increases.
The solution:
Compress each course folder into an individual .cab file containing all
of
the course's custom files and then archive these files to storage media
such
as CD/DVD.
If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to
accomplish
this sort of thing.
http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes
http://bytes.thinkersroom.com
"Rad [Visual C# MVP]" <no****@nospam.comwrote in message
news:rn***************@thinkersroom.com...
If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to
accomplish
this sort of thing.
http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes
http://bytes.thinkersroom.com
Took a look into the sharpziplib you suggested and found it easier than
usual to add it to my solution, but I am having a bit of an issue. Not sure
what I'm doing wrong and hope that you can enlightem my fuzzy brain. When I
start the compression, I get an UnauthorizedAccessException thrown as the
program trys to recurse through the subfolders in FromFolder. I can
understand that it's treating the subdirectories as files, but cannot figure
out why. Any tweaks or nudges? Code follows...
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
If strSourceDir.Length = 0 Then
MsgBox("Please specify a directory")
txtSelectDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strSourceDir) Then
MsgBox("Directory not found")
txtSelectDir.Focus()
Exit Sub
End If
End If
Dim strTargetDir As String = txtWriteDir.Text
If strTargetDir.Length = 0 Then
MsgBox("Please specify a directory")
txtWriteDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strTargetDir) Then
MsgBox("Directory not found")
txtWriteDir.Focus()
Exit Sub
End If
End If
Dim arystrmFolderNames() As String = Directory.GetDirectories(strSourceDir)
Dim strmZipOutputStream As ZipOutputStream
Dim intCounter As Integer
Dim strTargetFile As String = strTargetDir &
arystrmFolderNames(intCounter).LastIndexOfAny("\")
strmZipOutputStream = New ZipOutputStream(File.Create(strTargetFile))
strmZipOutputStream.SetLevel(9)
Dim strFolder As String
For Each strFolder In arystrmFolderNames
Dim strmFile As FileStream = File.OpenRead(strFolder)
Dim abyBuffer(strmFile.Length - 1) As Byte
strmFile.Read(abyBuffer, 0, abyBuffer.Length)
Dim objZipEntry As ZipEntry = New ZipEntry(strFolder)
objZipEntry.DateTime = DateTime.Now
objZipEntry.Size = strmFile.Length
strmFile.Close()
strmZipOutputStream.PutNextEntry(objZipEntry)
strmZipOutputStream.Write(abyBuffer, 0, abyBuffer.Length)
intCounter += 1
Next
strmZipOutputStream.Finish()
strmZipOutputStream.Close()
MsgBox("Operation completed")
End Sub
P.S. Please forgive my sloppy coding
Stephany,
I've gotten a whole lot more understanding of makecab because of your
assistance. I attempted to modify the code to recurse subfolders, but
couldn't get the modified code to work. Started digging around on the
Internet and in an obscure corner found this site. http://www.codeproject.com/cs/files/...essExtract.asp
Have you ever heard of or used this tool?
Bruce
"Stephany Young" <noone@localhostwrote in message
news:u5**************@TK2MSFTNGP03.phx.gbl...
Nice idea, but you're slightly on the wrong track with your usage of
makecab.exe.
The /L switch can only be used to compress a single source file into a
single .cab file, so unless you want gazillions of .cab files that's not
much good.
The /F switch is used to compress multiple source files into a into a
single .cab file, but it's a bit more complicated that you think.
Makecab.exe does not use standardinput/output. With the /F switch it reads
the required information from a definition file and it, in addition to
creating the .cab file, writes summary information to a 'report' file and
other information to a 'inf' file. Don't even consider the whys and
wherefores of this because what you are attempting to do is slight
non-standard compared to what makecab.exe was actually designed for.
Now for the nitty gritty.
The first thing you need to do is write a definition file, lets call it
test.ddf for the purpose of the exercise:
Dim _sw As New StreamWriter("test.ddf")
_sw.WriteLine(".Set SourceDir=" & FromFolder)
_sw.WriteLine(".Set CabinetNameTemplate=" & FinalFile)
_sw.WriteLine(".Set DiskDirectoryTemplate=" & ToFolder)
_sw.WriteLine(".Set InfFileName=test.inf")
_sw.WriteLine(".Set RptFileName=test.rpt")
_sw.WriteLine(".Set Cabinet=ON")
_sw.WriteLine(".Set Compress=ON")
Dim _files as String() = Directory.GetFiles(FromFolder)
For Each _file as String In _files
_sw.WriteLine(File.GetFileName(_file))
Next
_sw.Close()
Makecab.exe is very unforgiving if you get the syntax of the definition
file wrong.
If FromFolder does not exist then it will fail.
It will create the folder indicated by the final node of ToFolder, but it
will fail if any of the folders higher up the hierachy do not exist. This
can be circumvented by executing:
If Not Directory.Exists(Path.GetDirectory(ToFolder)) Then
Directory.CreateDirectory(Path.GetDirectory(ToFold er))
Note that ALL the files that you want in the .cab file MUST be included in
the definition file. As you can see this is easily achieved by iterating
through all the files in FromFolder. Also note that baecause .Set
SourceDir is specified, only the actual filename is required and not the
full path.
The next thing is to execute makecab.exe:
Process.Start("makecab.exe", "/F test.ddf").WaitForExit()
A command window will momentarily appear and disappear.
Now you will probably want to see what happened. Plonk a TextBox on the
form, make it multiline, set it's Font to your favourite mono-spaced font
and size it to a decent size.
TextBox1.Text = File.ReadAllText("test.rpt")
Now all you have to do is tidy up after yourself:
File.Delete("test.ddf")
File.Delete("test.inf")
File.Delete("test.rpt")
Supress the File.Delete's if you want to have a look in the test.inf file
but I doubt whether the content of it will be of any value to you given
what you are trying to achieve.
The following link will alow you to download the a file called Cabsdk.exe
hich contains, among other things, a Word document that provides a lot of
detail about makecab.exe.
http://download.microsoft.com/downlo...-us/Cabsdk.exe
Have fun!
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:bZ******************************@comcast.com. ..
>This will be my very first VB.Net application and it's pretty simple. But
I've got a snag in my syntax somewhere. Was hoping that someone could
point me in the right direction.
The history:
My work involves creating custom packages of our software product for
golf courses that purchase our software. The course data is kept as a
back up in the event the course needs us to replace their custom files.
Each course has a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our
customer base increases.
The solution:
Compress each course folder into an individual .cab file containing all
of the course's custom files and then archive these files to storage
media such as CD/DVD.
Where I need help:
I found some code for implementing a command line window and passing it a
string through a stream. The command window is being instantiated, but
the string is not getting passed or my syntax for running the makecab
utility is off-base. I've spent several hours looking for sample code
that would explain the makecab syntax and I've also tried to determine if
the parameters are being passed in to the Sub correctly. I've set a break
at the line where the string should be passed to the command window, but
I can not seem to get a respnse from the watches that have been set. I've
included a copy of the sub that I'm using to compress the files. If this
is not the correct forum for this, I do apologize. A nudge in the correct
direction would be deeply appreciated.
Private Sub CompressFolder(ByVal ToFolder As String, ByVal FromFolder As
String, ByVal FinalFile As String)
Dim CompressProcess As Process = New Process
CompressProcess.StartInfo.FileName = "cmd.exe"
CompressProcess.StartInfo.UseShellExecute = False
CompressProcess.StartInfo.CreateNoWindow = True
CompressProcess.StartInfo.RedirectStandardInput = True
CompressProcess.StartInfo.RedirectStandardOutpu t = True
CompressProcess.StartInfo.RedirectStandardError = True
CompressProcess.Start()
Dim stmStreamIn As IO.StreamWriter = CompressProcess.StandardInput
stmStreamIn.AutoFlush = True
Dim stmStreamOut As IO.StreamReader = CompressProcess.StandardOutput
Dim stmStreamErr As IO.StreamReader = CompressProcess.StandardError
stmStreamIn.Write("makecab.exe /L %ToFolder% %FromFolder% %FinalFile%" &
System.Environment.NewLine)
stmStreamIn.Write("exit" & System.Environment.NewLine)
If Not CompressProcess.HasExited Then
CompressProcess.Kill()
End If
stmStreamIn.Close()
stmStreamOut.Close()
stmStreamErr.Close()
End Sub
You sure are having a bit of an issue!!!!!! :)
Before you even attempt to go any further, I stringly recommend that you
'turn' Option Strict and Option Explicit 'on' for ALL your VB.NET projects
and solutions. You can do this in Tools/Options. Expand the Projects and
Solutions node and select VB Defaults. Settings those to 'on' in there will
ensure that Option Strict and Option Explicit are automatically 'on' for all
new projects. For existing projects you will need to change the settings for
each individual project.
Option Explicit 'on' means that you must explicitly define each variable
before you can use it.
Option Strict 'on' means that the complier will make NO assumptions about
what the code should do. When you turn it on for this project than a number
of compile-time 'errors' will appear and you will need to correct them all.
A number of the problems in the code fragment are caused by Option Strict
being 'off'. If you leave it turned off then you will continue to tear your
hair out because you not be able to spot various subtle problems.
Now for the nitty gritty.
Dim arystrmFolderNames() As String =
Directory.GetDirectories(strSourceDir)
This line create a string array that contains 1 element for each sub-folder
in whatever folder strSourceDir is pointing to. Each element contains the
name of (or the path to) a single sub-folder.
With the line (inside the loop):
Dim strmFile As FileStream = File.OpenRead(strFolder)
you are attempting to open a sub-folder for reading and that is where you
are falling over. A folder (or directory) cannot be opened as if it were a
file. You need to walk the 'tree' and deal with each and every file in each
and every sub-folder.
Before we deal with that, the line:
Dim strTargetFile As String = strTargetDir &
arystrmFolderNames(intCounter).LastIndexOfAny("\")
must also be causing you problems. If your strTargetDir is "C:\Temp\" and
arystrmFolderNames(intCounter) is "C:\Data\SubA" then strTargetFile will
become "C:\Temp\7" and I don't really think that is what you intend. I
suspect that you are looking for strTargetFile to be "C:\Temp\SubA.zip". If
that is what you are looking for than you need to use something like:
Dim strTargetFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir,
Path.GetFileName(arystrmFolderNames(intCounter))), "zip")
You use the phrase 'as the program trys to recurse through the subfolders in
FromFolder', but what your code is, in fact, doing is iterating through the
subfolders in FromFolder.
You do actually need to recursively walk the tree that starts at FromFolder,
dealing with every sub-folder including nested sub-folders and handling
every file that you encounter. This can be done with something like:
Private Sub RecurseFolders(ByVal folder as String)
Dim _files as String() = Directory.GetFiles(folder)
For Each _file As String In _files
Dim strmFile As FileStream = File.OpenRead(_file)
Dim abyBuffer(strmFile.Length - 1) As Byte
strmFile.Read(abyBuffer, 0, abyBuffer.Length)
strmFile.Close()
Dim objZipEntry As New ZipEntry(_file)
objZipEntry.DateTime = DateTime.Now
objZipEntry.Size = abyBuffer.Length
strmZipOutputStream.PutNextEntry(objZipEntry)
strmZipOutputStream.Write(abyBuffer, 0, abyBuffer.Length)
Next
Dim _folders As String() = Directory.GetDirectories(folder)
For Each _folder in _folders
RecurseFolders(FromFolder)
Next
End Sub
Call this method for the appropriate place with:
RecurseFolders(FromFolder)
Let us know how you get on.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:FK******************************@comcast.com. ..
>
"Rad [Visual C# MVP]" <no****@nospam.comwrote in message
news:rn***************@thinkersroom.com...
>If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to
accomplish
this sort of thing.
http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes
http://bytes.thinkersroom.com
Took a look into the sharpziplib you suggested and found it easier than
usual to add it to my solution, but I am having a bit of an issue. Not
sure what I'm doing wrong and hope that you can enlightem my fuzzy brain.
When I start the compression, I get an UnauthorizedAccessException thrown
as the program trys to recurse through the subfolders in FromFolder. I can
understand that it's treating the subdirectories as files, but cannot
figure out why. Any tweaks or nudges? Code follows...
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
If strSourceDir.Length = 0 Then
MsgBox("Please specify a directory")
txtSelectDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strSourceDir) Then
MsgBox("Directory not found")
txtSelectDir.Focus()
Exit Sub
End If
End If
Dim strTargetDir As String = txtWriteDir.Text
If strTargetDir.Length = 0 Then
MsgBox("Please specify a directory")
txtWriteDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strTargetDir) Then
MsgBox("Directory not found")
txtWriteDir.Focus()
Exit Sub
End If
End If
Dim arystrmFolderNames() As String =
Directory.GetDirectories(strSourceDir)
Dim strmZipOutputStream As ZipOutputStream
Dim intCounter As Integer
Dim strTargetFile As String = strTargetDir &
arystrmFolderNames(intCounter).LastIndexOfAny("\")
strmZipOutputStream = New ZipOutputStream(File.Create(strTargetFile))
strmZipOutputStream.SetLevel(9)
Dim strFolder As String
For Each strFolder In arystrmFolderNames
Dim strmFile As FileStream = File.OpenRead(strFolder)
Dim abyBuffer(strmFile.Length - 1) As Byte
strmFile.Read(abyBuffer, 0, abyBuffer.Length)
Dim objZipEntry As ZipEntry = New ZipEntry(strFolder)
objZipEntry.DateTime = DateTime.Now
objZipEntry.Size = strmFile.Length
strmFile.Close()
strmZipOutputStream.PutNextEntry(objZipEntry)
strmZipOutputStream.Write(abyBuffer, 0, abyBuffer.Length)
intCounter += 1
Next
strmZipOutputStream.Finish()
strmZipOutputStream.Close()
MsgBox("Operation completed")
End Sub
P.S. Please forgive my sloppy coding
I haven't come across that one before but it is certainly one of the better
presented articles and projects at CodeProject.
I had a dig in the source code and it looks OK. The CompressFolder will
compress everything in a given tree and this means that you wouldn't have to
worry abot doing any recursion yourself. I note that it also has the ability
to encrypt the compressed data.
I can only suggest that you try it and see if it will work for you. If you
do then also test the extraction methods to ensure that you can actually
'restore' the data from the compressed file.
Out of interest, what sort of data quantity are you talking about in a given
tree. Are you talking about multi-Gigabytes, because if you are then you
could hit some 'ceiling' or other.
Let us know how you get on.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:C4******************************@comcast.com. ..
Stephany,
I've gotten a whole lot more understanding of makecab because of your
assistance. I attempted to modify the code to recurse subfolders, but
couldn't get the modified code to work. Started digging around on the
Internet and in an obscure corner found this site.
http://www.codeproject.com/cs/files/...essExtract.asp
Have you ever heard of or used this tool?
Bruce
"Stephany Young" <noone@localhostwrote in message
news:u5**************@TK2MSFTNGP03.phx.gbl...
>Nice idea, but you're slightly on the wrong track with your usage of
makecab.exe.
The /L switch can only be used to compress a single source file into a
single .cab file, so unless you want gazillions of .cab files that's not
much good.
The /F switch is used to compress multiple source files into a into a
single .cab file, but it's a bit more complicated that you think.
Makecab.exe does not use standardinput/output. With the /F switch it
reads the required information from a definition file and it, in addition
to creating the .cab file, writes summary information to a 'report' file
and other information to a 'inf' file. Don't even consider the whys and
wherefores of this because what you are attempting to do is slight
non-standard compared to what makecab.exe was actually designed for.
Now for the nitty gritty.
The first thing you need to do is write a definition file, lets call it
test.ddf for the purpose of the exercise:
Dim _sw As New StreamWriter("test.ddf")
_sw.WriteLine(".Set SourceDir=" & FromFolder)
_sw.WriteLine(".Set CabinetNameTemplate=" & FinalFile)
_sw.WriteLine(".Set DiskDirectoryTemplate=" & ToFolder)
_sw.WriteLine(".Set InfFileName=test.inf")
_sw.WriteLine(".Set RptFileName=test.rpt")
_sw.WriteLine(".Set Cabinet=ON")
_sw.WriteLine(".Set Compress=ON")
Dim _files as String() = Directory.GetFiles(FromFolder)
For Each _file as String In _files
_sw.WriteLine(File.GetFileName(_file))
Next
_sw.Close()
Makecab.exe is very unforgiving if you get the syntax of the definition
file wrong.
If FromFolder does not exist then it will fail.
It will create the folder indicated by the final node of ToFolder, but it
will fail if any of the folders higher up the hierachy do not exist. This
can be circumvented by executing:
If Not Directory.Exists(Path.GetDirectory(ToFolder)) Then
Directory.CreateDirectory(Path.GetDirectory(ToFol der))
Note that ALL the files that you want in the .cab file MUST be included
in the definition file. As you can see this is easily achieved by
iterating through all the files in FromFolder. Also note that baecause
.Set SourceDir is specified, only the actual filename is required and not
the full path.
The next thing is to execute makecab.exe:
Process.Start("makecab.exe", "/F test.ddf").WaitForExit()
A command window will momentarily appear and disappear.
Now you will probably want to see what happened. Plonk a TextBox on the
form, make it multiline, set it's Font to your favourite mono-spaced font
and size it to a decent size.
TextBox1.Text = File.ReadAllText("test.rpt")
Now all you have to do is tidy up after yourself:
File.Delete("test.ddf")
File.Delete("test.inf")
File.Delete("test.rpt")
Supress the File.Delete's if you want to have a look in the test.inf file
but I doubt whether the content of it will be of any value to you given
what you are trying to achieve.
The following link will alow you to download the a file called Cabsdk.exe
hich contains, among other things, a Word document that provides a lot of
detail about makecab.exe.
http://download.microsoft.com/downlo...-us/Cabsdk.exe
Have fun!
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:bZ******************************@comcast.com ...
>>This will be my very first VB.Net application and it's pretty simple.
But I've got a snag in my syntax somewhere. Was hoping that someone
could point me in the right direction.
The history:
My work involves creating custom packages of our software product for
golf courses that purchase our software. The course data is kept as a
back up in the event the course needs us to replace their custom files.
Each course has a folder of it's own data under a centralized directory.
The problem:
The custom files are going to become a serious storage issue as our
customer base increases.
The solution:
Compress each course folder into an individual .cab file containing all
of the course's custom files and then archive these files to storage
media such as CD/DVD.
Where I need help:
I found some code for implementing a command line window and passing it
a string through a stream. The command window is being instantiated, but
the string is not getting passed or my syntax for running the makecab
utility is off-base. I've spent several hours looking for sample code
that would explain the makecab syntax and I've also tried to determine
if the parameters are being passed in to the Sub correctly. I've set a
break at the line where the string should be passed to the command
window, but I can not seem to get a respnse from the watches that have
been set. I've included a copy of the sub that I'm using to compress the
files. If this is not the correct forum for this, I do apologize. A
nudge in the correct direction would be deeply appreciated.
Private Sub CompressFolder(ByVal ToFolder As String, ByVal FromFolder As
String, ByVal FinalFile As String)
Dim CompressProcess As Process = New Process
CompressProcess.StartInfo.FileName = "cmd.exe"
CompressProcess.StartInfo.UseShellExecute = False
CompressProcess.StartInfo.CreateNoWindow = True
CompressProcess.StartInfo.RedirectStandardInpu t = True
CompressProcess.StartInfo.RedirectStandardOutp ut = True
CompressProcess.StartInfo.RedirectStandardErro r = True
CompressProcess.Start()
Dim stmStreamIn As IO.StreamWriter = CompressProcess.StandardInput
stmStreamIn.AutoFlush = True
Dim stmStreamOut As IO.StreamReader = CompressProcess.StandardOutput
Dim stmStreamErr As IO.StreamReader = CompressProcess.StandardError
stmStreamIn.Write("makecab.exe /L %ToFolder% %FromFolder% %FinalFile%" &
System.Environment.NewLine)
stmStreamIn.Write("exit" & System.Environment.NewLine)
If Not CompressProcess.HasExited Then
CompressProcess.Kill()
End If
stmStreamIn.Close()
stmStreamOut.Close()
stmStreamErr.Close()
End Sub
Nothing massive. Each course folder may contain 1-2 subfolder's and a
maximum size of 20 MB. Nothing near the 2 GB limit. If I can't get the other
stuff with SharpZipLib to work, I may follow up on that one. Thanks for the
reply.
Bruce
"Stephany Young" <noone@localhostwrote in message
news:e1**************@TK2MSFTNGP06.phx.gbl...
>I haven't come across that one before but it is certainly one of the better
presented articles and projects at CodeProject.
Stephany,
Checked VB Defaults and Option Explicit was already on. Set Option Strict to
on and got two error's from my code, which I've resolved, with a little help
from a 'friend'. hehehehe I'll give this a shot and let you know what
happens. Thanks a boatload! from an old, senile wannabe! :)
Bruce
"Stephany Young" <noone@localhostwrote in message
news:%2****************@TK2MSFTNGP02.phx.gbl...
You sure are having a bit of an issue!!!!!! :)
Before you even attempt to go any further, I stringly recommend that you
'turn' Option Strict and Option Explicit 'on' for ALL your VB.NET projects
and solutions. You can do this in Tools/Options. Expand the Projects and
Solutions node and select VB Defaults. Settings those to 'on' in there
will ensure that Option Strict and Option Explicit are automatically 'on'
for all new projects. For existing projects you will need to change the
settings for each individual project.
Option Explicit 'on' means that you must explicitly define each variable
before you can use it.
Option Strict 'on' means that the complier will make NO assumptions about
what the code should do. When you turn it on for this project than a
number of compile-time 'errors' will appear and you will need to correct
them all.
A number of the problems in the code fragment are caused by Option Strict
being 'off'. If you leave it turned off then you will continue to tear
your hair out because you not be able to spot various subtle problems.
Now for the nitty gritty.
Dim arystrmFolderNames() As String =
Directory.GetDirectories(strSourceDir)
This line create a string array that contains 1 element for each
sub-folder in whatever folder strSourceDir is pointing to. Each element
contains the name of (or the path to) a single sub-folder.
With the line (inside the loop):
Dim strmFile As FileStream = File.OpenRead(strFolder)
you are attempting to open a sub-folder for reading and that is where you
are falling over. A folder (or directory) cannot be opened as if it were a
file. You need to walk the 'tree' and deal with each and every file in
each and every sub-folder.
Before we deal with that, the line:
Dim strTargetFile As String = strTargetDir &
arystrmFolderNames(intCounter).LastIndexOfAny("\")
must also be causing you problems. If your strTargetDir is "C:\Temp\" and
arystrmFolderNames(intCounter) is "C:\Data\SubA" then strTargetFile will
become "C:\Temp\7" and I don't really think that is what you intend. I
suspect that you are looking for strTargetFile to be "C:\Temp\SubA.zip".
If that is what you are looking for than you need to use something like:
Dim strTargetFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir,
Path.GetFileName(arystrmFolderNames(intCounter))), "zip")
You use the phrase 'as the program trys to recurse through the subfolders
in FromFolder', but what your code is, in fact, doing is iterating through
the subfolders in FromFolder.
You do actually need to recursively walk the tree that starts at
FromFolder, dealing with every sub-folder including nested sub-folders and
handling every file that you encounter. This can be done with something
like:
Private Sub RecurseFolders(ByVal folder as String)
Dim _files as String() = Directory.GetFiles(folder)
For Each _file As String In _files
Dim strmFile As FileStream = File.OpenRead(_file)
Dim abyBuffer(strmFile.Length - 1) As Byte
strmFile.Read(abyBuffer, 0, abyBuffer.Length)
strmFile.Close()
Dim objZipEntry As New ZipEntry(_file)
objZipEntry.DateTime = DateTime.Now
objZipEntry.Size = abyBuffer.Length
strmZipOutputStream.PutNextEntry(objZipEntry)
strmZipOutputStream.Write(abyBuffer, 0, abyBuffer.Length)
Next
Dim _folders As String() = Directory.GetDirectories(folder)
For Each _folder in _folders
RecurseFolders(FromFolder)
Next
End Sub
Call this method for the appropriate place with:
RecurseFolders(FromFolder)
Let us know how you get on.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:FK******************************@comcast.com. ..
>>
"Rad [Visual C# MVP]" <no****@nospam.comwrote in message
news:rn***************@thinkersroom.com...
>>If file size is paramount you might want to consider using better
compression formats (rar, bzip, etc). You can use sharpziplib to
accomplish
this sort of thing.
http://www.icsharpcode.net/OpenSourc...b/Default.aspx
--
Bits.Bytes
http://bytes.thinkersroom.com
Took a look into the sharpziplib you suggested and found it easier than
usual to add it to my solution, but I am having a bit of an issue. Not
sure what I'm doing wrong and hope that you can enlightem my fuzzy brain.
When I start the compression, I get an UnauthorizedAccessException thrown
as the program trys to recurse through the subfolders in FromFolder. I
can understand that it's treating the subdirectories as files, but cannot
figure out why. Any tweaks or nudges? Code follows...
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
If strSourceDir.Length = 0 Then
MsgBox("Please specify a directory")
txtSelectDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strSourceDir) Then
MsgBox("Directory not found")
txtSelectDir.Focus()
Exit Sub
End If
End If
Dim strTargetDir As String = txtWriteDir.Text
If strTargetDir.Length = 0 Then
MsgBox("Please specify a directory")
txtWriteDir.Focus()
Exit Sub
Else
If Not Directory.Exists(strTargetDir) Then
MsgBox("Directory not found")
txtWriteDir.Focus()
Exit Sub
End If
End If
Dim arystrmFolderNames() As String =
Directory.GetDirectories(strSourceDir)
Dim strmZipOutputStream As ZipOutputStream
Dim intCounter As Integer
Dim strTargetFile As String = strTargetDir &
arystrmFolderNames(intCounter).LastIndexOfAny("\" )
strmZipOutputStream = New ZipOutputStream(File.Create(strTargetFile))
strmZipOutputStream.SetLevel(9)
Dim strFolder As String
For Each strFolder In arystrmFolderNames
Dim strmFile As FileStream = File.OpenRead(strFolder)
Dim abyBuffer(strmFile.Length - 1) As Byte
strmFile.Read(abyBuffer, 0, abyBuffer.Length)
Dim objZipEntry As ZipEntry = New ZipEntry(strFolder)
objZipEntry.DateTime = DateTime.Now
objZipEntry.Size = strmFile.Length
strmFile.Close()
strmZipOutputStream.PutNextEntry(objZipEntry)
strmZipOutputStream.Write(abyBuffer, 0, abyBuffer.Length)
intCounter += 1
Next
strmZipOutputStream.Finish()
strmZipOutputStream.Close()
MsgBox("Operation completed")
End Sub
P.S. Please forgive my sloppy coding
Stephany,
THIS IS IT! :) I downloaded the .NET project from CodeProject last night and
messed around a bit with building the .dll before figuring out that it was
already built. LOL I then added it to the solution and started working with
the coding. Took me about 30 minutes to work it out with some of the code
that you so graciously provided in the SharZiplib examples. Fired up the
project and started stepping through the compression routine in my program
and it actually WORKED! Gee, guess I gotta think of myself as a bit more
than senile now, though I'll be danged if I can remember why... The cab file
is created in MS-Zip format, so it opened right up by double-clicking on the
..zip file. And it properly recursed all subdirectories. I'm almost finished
and am hoping that this will be the beginning of a fruitful learning
experience for me.
Again, thanks ever so much for the assistance.
Bruce
"Stephany Young" <noone@localhostwrote in message
news:e1**************@TK2MSFTNGP06.phx.gbl...
>I haven't come across that one before but it is certainly one of the better
presented articles and projects at CodeProject.
Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find a
way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and use to
make things a bit easier on my techs. While I doubt that the coding is all
that elegant, here is the final sub that I was able to come up with that is
doing the job I need it to do. Again, thanks for all the assistance. Happy
Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
For Each _Folder As String In _Folders
Dim strFldr2Compress As String = Path.GetFileName(_Folder)
Dim strFinalFile As String = Path.ChangeExtension(Path.Combine(strTargetDir,
_
Path.GetFileName(strFldr2Compress)), "cab")
Dim i_Compress As CabLib.Compress = New CabLib.Compress()
i_Compress.CompressFolder(strTargetDir, strFinalFile, "", 0)
prbProgress.PerformStep()
lblProgress.Text = ("Compressing: " & strFinalFile)
Next
End Sub
"Stephany Young" <noone@localhostwrote in message
news:e1**************@TK2MSFTNGP06.phx.gbl...
I can only suggest that you try it and see if it will work for you. If you
do then also test the extraction methods to ensure that you can actually
'restore' the data from the compressed file.
May I make one small suggestion since you might be in the mood to tweak it a
bit at this time?
Reducing dependencies is a good goal to keep in mind and you've set up a
dependency here that is very easy to eliminate. The SourceDir and TargetDir
in your example are supplied by two components which "must" be named what
you have them named. Any attempt to use the CompressFolder() routine in any
other way will fail.
Simply modify CompressFolder() so that it accepts strSourceDir and
strTargetDir as parameters passed to it. The call will then supply the
..Text properties of your two textboxes (in your example) but it can be used
in other situations by simply passing two properly composed strings. They
don't have to be textboxes and they don't have to be named what you have
them named.
Tom
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:F-******************************@comcast.com...
Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find a
way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and use
to make things a bit easier on my techs. While I doubt that the coding is
all that elegant, here is the final sub that I was able to come up with
that is doing the job I need it to do. Again, thanks for all the
assistance. Happy Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
Tom,
Always open to constructive opinions. :) If I'm understanding what you're
putting forth....
The procedure call would be something like...
CompressFolder(txtSelectDir.Text, txtWriteDir.Text)
And the resulting procedure would receive the information by the
following...
Private Sub CompressFolder(ByVal strSourceDir As String, ByVal strTargetDir
As String)
Then strSourceDir and strTargetDir would not need to be Dim'd as they
already contain the information required from the calling procedure?
"Tom Leylan" <tl*****@nospam.netwrote in message
news:eP*************@TK2MSFTNGP04.phx.gbl...
May I make one small suggestion since you might be in the mood to tweak it
a bit at this time?
Reducing dependencies is a good goal to keep in mind and you've set up a
dependency here that is very easy to eliminate. The SourceDir and
TargetDir in your example are supplied by two components which "must" be
named what you have them named. Any attempt to use the CompressFolder()
routine in any other way will fail.
Simply modify CompressFolder() so that it accepts strSourceDir and
strTargetDir as parameters passed to it. The call will then supply the
.Text properties of your two textboxes (in your example) but it can be
used in other situations by simply passing two properly composed strings.
They don't have to be textboxes and they don't have to be named what you
have them named.
Tom
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:F-******************************@comcast.com...
>Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find a
way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and use
to make things a bit easier on my techs. While I doubt that the coding is
all that elegant, here is the final sub that I was able to come up with
that is doing the job I need it to do. Again, thanks for all the
assistance. Happy Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
If I understand what you are trying to achieve correctly then you have a
folder structure that resembles;
C:\Top
Sub1
SubSub11
SubSub12
SubSub13
Sub2
SubSub21
SubSub22
SubSub23
Sub3
SubSub31
SubSub32
SubSub33
and what you want to end up with is a struncture that resembles:
C:\Compress
Sub1.cab
Sub2.cab
Sub3.cab
If that is the case then you logic is a bit flawed. The line
'i_Compress.CompressFolder(strTargetDir, strFinalFile, "", 0)' should
probable read 'i_Compress.CompressFolder(_Folder, strFinalFile, "", 0)'.
Apart from that, 7 out of 10 and here are your notes: :)
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
These 2 lines are completely redundant. Their values are seldom referred to
and never modified therefore the values can be used directly from the
TextBox controls. Before proceeding, I would be inclined to trim the content
of both TextBoxes to ensure that any leading and/or trailing whitespace,
that may be present, is removed. You may also like to add some validation to
ensure that values have been entered and the values entered are, in fact,
valid.
prbProgress.Minimum = 0
Unless you mave modified the value of prbProgress.Minimum elsewhere in your
app, (which is probalbly unlikely) then there is no need to set it here
because it is already 0. However, it is more likely that you have used the
ProgressBar elsewhere in you app so it is important to make sure that it
starts it's counting from 0 by resetting the value of prbProgress.Value.
prbProgress.Maximum = CInt(_Folders.Length)
The Length property of an array returns an Integer so there is no need to
carry out any conversion when assigning it to any other object that is also
an Integer.
The Path.GetFileName(strFldr2Compress) in the 2nd line of the loop is, at
the least, redundant, but more importantly it is downright confusing. The
first line of the loop get the last node of the folder name and stores it in
a variable. To do carry out the operation again on the variable is
absolutely not necessary.
Now we can note that the only time that strFldr2Compress is used is in the
very next line and therefore the use of an interim variable is not
necessary.
Dim i_Compress As CabLib.Compress = New CabLib.Compress()
In VB.Net this can be shortened to 'Dim i_Compress As New CabLib.Compress'.
Also, the instantiation of i_Compress is being carried out on every
iteration of the loop, whereas it only needs to carried out once.
lblProgress.Text = ("Compressing: " & strFinalFile)
At the point that this is executed the compression operation has already
finished so this line should appear earlier in the loop.
At the 2 points where UI elements are 'updated', the app is in a faily tight
loop and you may find that the ProgressBar and/or Label do not 'update' as
you might expect them to. A couple of forced updates will be of assistance
here to allow the UI Elements to repaint in a timely manner.
The modified method is shown below:
Private Sub CompressFolder()
txtSelectDir.Text = txtSelectDir.Text.Trim()
txtWriteDir.Text = txtWriteDir.Text.Trim()
Dim _folders As String() = Directory.GetDirectories(txtSelectDir.Text)
prbProgress.Value = 0
prbProgress.Maximum = _folders.Length
prbProgress.Step = 1
Dim _compress As New CabLib.Compress
For Each _folder As String In _folders
Dim _finalfile As String =
Path.ChangeExtension(Path.Combine(txtWriteDir.Text ,
Path.GetFileName(_folder)), "cab")
lblProgress.Text = ("Compressing: " & _finalfile)
lblProgress.Update()
_compress.CompressFolder(_folder, _finalfile, "", 0)
prbProgress.PerformStep()
prbProgress.Update()
Next
End Sub
As you can see, it is now a bit leaner without the redundant variables and
with the loop having no extraneous logic in it.
Although I invariably use hugarian notation for names of controls as you
have done, (even if you didn't know you were doing it), I like to use
lowercase with a preceding underscore for naming all local variables. I find
that this gives me continual visual prompts as to the scope of objects.
Of course, all this is my opinion, and you should code in a style that suits
you.
Have fun dissect that lot :)
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:F-******************************@comcast.com...
Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find a
way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and use
to make things a bit easier on my techs. While I doubt that the coding is
all that elegant, here is the final sub that I was able to come up with
that is doing the job I need it to do. Again, thanks for all the
assistance. Happy Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
For Each _Folder As String In _Folders
Dim strFldr2Compress As String = Path.GetFileName(_Folder)
Dim strFinalFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir, _
Path.GetFileName(strFldr2Compress)), "cab")
Dim i_Compress As CabLib.Compress = New CabLib.Compress()
i_Compress.CompressFolder(strTargetDir, strFinalFile, "", 0)
prbProgress.PerformStep()
lblProgress.Text = ("Compressing: " & strFinalFile)
Next
End Sub
"Stephany Young" <noone@localhostwrote in message
news:e1**************@TK2MSFTNGP06.phx.gbl...
>I can only suggest that you try it and see if it will work for you. If
you do then also test the extraction methods to ensure that you can
actually 'restore' the data from the compressed file.
Yes, That's exactly what Tom is saying and it's a good idea too.
If you're feeling bold, you could reduce the dependencies further by raising
events insteading of updating the UI elements directly. That would mean that
you could get even bolder and launch CompressFolder as a thread and let your
app get on with other stuff while the compression is happening.
We'll make a half-decent programmer out of you yet :)
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:O8******************************@comcast.com. ..
Tom,
Always open to constructive opinions. :) If I'm understanding what you're
putting forth....
The procedure call would be something like...
CompressFolder(txtSelectDir.Text, txtWriteDir.Text)
And the resulting procedure would receive the information by the
following...
Private Sub CompressFolder(ByVal strSourceDir As String, ByVal
strTargetDir As String)
Then strSourceDir and strTargetDir would not need to be Dim'd as they
already contain the information required from the calling procedure?
"Tom Leylan" <tl*****@nospam.netwrote in message
news:eP*************@TK2MSFTNGP04.phx.gbl...
>May I make one small suggestion since you might be in the mood to tweak
it a bit at this time?
Reducing dependencies is a good goal to keep in mind and you've set up a
dependency here that is very easy to eliminate. The SourceDir and
TargetDir in your example are supplied by two components which "must" be
named what you have them named. Any attempt to use the CompressFolder()
routine in any other way will fail.
Simply modify CompressFolder() so that it accepts strSourceDir and
strTargetDir as parameters passed to it. The call will then supply the
.Text properties of your two textboxes (in your example) but it can be
used in other situations by simply passing two properly composed strings.
They don't have to be textboxes and they don't have to be named what you
have them named.
Tom
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:F-******************************@comcast.com...
>>Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find
a way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and use
to make things a bit easier on my techs. While I doubt that the coding
is all that elegant, here is the final sub that I was able to come up
with that is doing the job I need it to do. Again, thanks for all the
assistance. Happy Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
I thought I'd take one step at a time Stephany :-)
Bruce... You've got it. And Stephany's first idea is another sensible and
common way to separate "process" from UI.
Rather than update a specific (and specifically named) UI element your
CompressFolder() procedure should raise an "I've processed one" event. You
may even opt to have it raise multiple events, "I've started", "I'm
processing" and "I'm done". Now watch... you (in one scenario) decide to
have a progress bar update, then you simply tell the progress bar to listen
for and react to "I'm processing" events. Every time it "hears" one it
moves the progress bar. In some other scenario you may decide to have the
words "Processing Folder <whatever>" appear in a label. So this time you
tell the label to listen to "I'm processing" events instead and write code
the UI code there. Nothing in the UI knows what CompressFolder does and
CompressFolder has no idea about forms, buttons and progress bars. Needless
to say you would name your events something more sensible than "I'm
processing" but that's what you're telling the event listeners.
Note that to get <whatever(the folder name) to appear in an event handler
you will have to send that information along when you raise the event.
Again there is an entire event system available to us for doing exactly
this. You send any information that the UI needs to know about in the
"args" argument and an event handler will receive it.
Threading? When you have everything else working smoothly you might look
into it. There can be concurrency issues so you have to think it through.
The nice thing is (as Stephany ponts out) you can use the app while the
compressing is going on. You would have to make certain that nothing you do
interferes with the compressing operation while it is running. There are
ways this can be done and among them setting a "compressing" flag turns on
when the process starts and off when it is done. The rest of the app can
check the flag and disable various actions (when needed) with the most
obvious action to prevent being the "compress folders" option. :-)
Try the events thing it will amaze you.
Tom
"Stephany Young" <noone@localhostwrote in message
news:e3**************@TK2MSFTNGP03.phx.gbl...
Yes, That's exactly what Tom is saying and it's a good idea too.
If you're feeling bold, you could reduce the dependencies further by
raising events insteading of updating the UI elements directly. That would
mean that you could get even bolder and launch CompressFolder as a thread
and let your app get on with other stuff while the compression is
happening.
We'll make a half-decent programmer out of you yet :)
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:O8******************************@comcast.com. ..
>Tom,
Always open to constructive opinions. :) If I'm understanding what you're
putting forth....
The procedure call would be something like...
CompressFolder(txtSelectDir.Text, txtWriteDir.Text)
And the resulting procedure would receive the information by the
following...
Private Sub CompressFolder(ByVal strSourceDir As String, ByVal
strTargetDir As String)
Then strSourceDir and strTargetDir would not need to be Dim'd as they
already contain the information required from the calling procedure?
"Tom Leylan" <tl*****@nospam.netwrote in message
news:eP*************@TK2MSFTNGP04.phx.gbl...
>>May I make one small suggestion since you might be in the mood to tweak
it a bit at this time?
Reducing dependencies is a good goal to keep in mind and you've set up a
dependency here that is very easy to eliminate. The SourceDir and
TargetDir in your example are supplied by two components which "must" be
named what you have them named. Any attempt to use the CompressFolder()
routine in any other way will fail.
Simply modify CompressFolder() so that it accepts strSourceDir and
strTargetDir as parameters passed to it. The call will then supply the
.Text properties of your two textboxes (in your example) but it can be
used in other situations by simply passing two properly composed
strings. They don't have to be textboxes and they don't have to be named
what you have them named.
Tom
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:F-******************************@comcast.com...
Stephany,
I owe you a debt of gratitude. With your assistance, I was able to find
a way to do what I wanted to do, even though I don't consider myself a
developer by any mean's. I now have something I can take to work and
use to make things a bit easier on my techs. While I doubt that the
coding is all that elegant, here is the final sub that I was able to
come up with that is doing the job I need it to do. Again, thanks for
all the assistance. Happy Holidays.
Private Sub CompressFolder()
Dim strSourceDir As String = txtSelectDir.Text
Dim strTargetDir As String = txtWriteDir.Text
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Minimum = 0
prbProgress.Maximum = CInt(_Folders.Length)
prbProgress.Step = 1
Stephany,
After posting last night, I ran back through my code and there was a LOT of
stuff that I discovered about my code being incomplete and illogical.*sigh*
I was pointing one directory too high AND was not using the correct source
to draw from. Took a bit for me to work it out, but found that I was using
the destination folder as my source folder and was getting some really weird
results. Tom's post last night and yours this morning really helped me get
things ironed out in my mind. Incorporating the parts that you posted this
morning, here is my new compression sub, hopefully all neat and tidy. I know
that this one works as it should. LOL I've also decided to use labels with
autoellilpsis turned on in place of the text boxes. I did this as a personal
attribute because of space issues and my own anal perspective toward
neatness. I am doing the sanity check on the label entries from a seperate
sub so that is taken care of. If the user doesn't select a From and To
folder, it won't go anwhere but back to the folderbrowserdialog. Thanks
again for all the help.
The (hopefully) almost completed compression sub...
Private Sub CompressFolder(ByVal strSourceDir As String, ByVal strTargetDir
As String)
Dim _Folders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Maximum = _Folders.Length
prbProgress.Step = 1
prbProgress.Visible = True
lblProgress.Visible = True
For Each _Folder As String In _Folders
Dim strFinalFile As String = Path.ChangeExtension(Path.Combine(strTargetDir,
_
Path.GetFileName(_Folder)), "cab")
lblProgress.Text = ("Compressing: " & Path.GetFileName(_Folder))
lblProgress.Update()
Dim i_Compress As New CabLib.Compress
i_Compress.CompressFolder(_Folder, strFinalFile, "", 0)
prbProgress.PerformStep()
prbProgress.Update()
Next
prbProgress.Visible = False
lblProgress.Visible = False
End Sub
So you've found that there's nothing more sobering than looking at code you
have written yourself and saying, 'What idiot wrote this rubish?'. :)
That's much betterer now ... but a couple of notes.
You are making 2 calls to the Path.GetFileName() method with the same
parameter, to get the name of the deepest node of the folder path. I my view
it is better to call that method once, store the result in a local variable
and use that when you need to:
Dim _deepestnode As String = Path.GetFileName(_Folder)
Christmas shopping almost finished.... :)
"Stephany Young" <noone@localhostwrote in message
news:uf*************@TK2MSFTNGP04.phx.gbl...
So you've found that there's nothing more sobering than looking at code
you have written yourself and saying, 'What idiot wrote this rubish?'. :)
And nothing more sobering than doing it 5 minutes after you post a EUREKA!
on the newsgroup. :)
You are making 2 calls to the Path.GetFileName() method with the same
parameter, to get the name of the deepest node of the folder path. I my
view it is better to call that method once, store the result in a local
variable and use that when you need to:
A logical conclusion and one which I shall take to heart.
You then don't need the local variable strFinalFile and the line where
that is used becomes:
i_Compress.CompressFolder(_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab"), "",
0)
This won't work. I've already tried it. Not sure why but it gives me an IO
error stating that I'm passing too many variables.
The instantiation of i_Compress is still inside the loop. This will cause
unecessary overhead and should be moved to a point before the start of the
loop. Think of it like making a cup of coffee and leaving it on the beench
of your kitchen. Every time you want a sip you have to go out to the
kitchen and then return to your office. I'm sure that you would consider
that to be a waste of your resources (time and effort).
Now, to make sure I've got this down... The line stating Dim i_Compress as
New CabLib.Compress should occur on any line OUTSIDE the start of the
For...Next loop, but the actual line stating i_Compress.CompressFolder...
should be on a line INSIDE the loop?
>Onward and upward :)
As Mork would have stated.... Nanoo...Nanoo... :) Sorry, can't do the
spreadfingered handshake here... might get me arrested. :)
Yes ... But I would term it 'BEFORE the start of the loop' rather than
'OUTSIDE the start of the loop' which could also include after the end of
loop (for those that are picky).
And yes, the actual call to i_Compress.CompressFolder MUST be inside the
loop.
I don't understand why the call to i_Compress.CompressFolder is not working.
It takes 4 parameters and they are:
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
The 1st parameter is the source folder.
The 2nd parameter is the name of the resultant .cab file.
The 3rd parameter is a filter for dealing only with a subset of files. ""
(empty string) means don't filter.
The 4th parameter is for limiting the size of any one .cab file. 0 (zero)
means don't limit.
Directly before that line you can throw in:
Console.WriteLine(_Folder)
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
and then you can make sure that the values are as expected. (Make sure you
run it from the IDE and the results will be displayed in the Output window).
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:55******************************@comcast.com. ..
Christmas shopping almost finished.... :)
"Stephany Young" <noone@localhostwrote in message
news:uf*************@TK2MSFTNGP04.phx.gbl...
>So you've found that there's nothing more sobering than looking at code
you have written yourself and saying, 'What idiot wrote this rubish?'. :)
And nothing more sobering than doing it 5 minutes after you post a EUREKA!
on the newsgroup. :)
>You are making 2 calls to the Path.GetFileName() method with the same
parameter, to get the name of the deepest node of the folder path. I my
view it is better to call that method once, store the result in a local
variable and use that when you need to:
A logical conclusion and one which I shall take to heart.
>You then don't need the local variable strFinalFile and the line where
that is used becomes:
i_Compress.CompressFolder(_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab"),
"", 0)
This won't work. I've already tried it. Not sure why but it gives me an IO
error stating that I'm passing too many variables.
>The instantiation of i_Compress is still inside the loop. This will cause
unecessary overhead and should be moved to a point before the start of
the loop. Think of it like making a cup of coffee and leaving it on the
beench of your kitchen. Every time you want a sip you have to go out to
the kitchen and then return to your office. I'm sure that you would
consider that to be a waste of your resources (time and effort).
Now, to make sure I've got this down... The line stating Dim i_Compress as
New CabLib.Compress should occur on any line OUTSIDE the start of the
For...Next loop, but the actual line stating i_Compress.CompressFolder...
should be on a line INSIDE the loop?
>>Onward and upward :)
As Mork would have stated.... Nanoo...Nanoo... :) Sorry, can't do the
spreadfingered handshake here... might get me arrested. :)
Possibly a good time to introduce the debugger... if you are going to
monitor code take the opportunity to see how breakpoints, watchpoints, step
and trace work.
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
Yes ... But I would term it 'BEFORE the start of the loop' rather than
'OUTSIDE the start of the loop' which could also include after the end of
loop (for those that are picky).
And yes, the actual call to i_Compress.CompressFolder MUST be inside the
loop.
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
The 1st parameter is the source folder.
The 2nd parameter is the name of the resultant .cab file.
The 3rd parameter is a filter for dealing only with a subset of files. ""
(empty string) means don't filter.
The 4th parameter is for limiting the size of any one .cab file. 0 (zero)
means don't limit.
Directly before that line you can throw in:
Console.WriteLine(_Folder)
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
and then you can make sure that the values are as expected. (Make sure you
run it from the IDE and the results will be displayed in the Output
window).
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:55******************************@comcast.com. ..
>Christmas shopping almost finished.... :)
"Stephany Young" <noone@localhostwrote in message
news:uf*************@TK2MSFTNGP04.phx.gbl...
>>So you've found that there's nothing more sobering than looking at code
you have written yourself and saying, 'What idiot wrote this rubish?'.
:)
And nothing more sobering than doing it 5 minutes after you post a
EUREKA! on the newsgroup. :)
>>You are making 2 calls to the Path.GetFileName() method with the same
parameter, to get the name of the deepest node of the folder path. I my
view it is better to call that method once, store the result in a local
variable and use that when you need to:
A logical conclusion and one which I shall take to heart.
>>You then don't need the local variable strFinalFile and the line where
that is used becomes:
i_Compress.CompressFolder(_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir , _deepestnode), "cab"),
"", 0)
This won't work. I've already tried it. Not sure why but it gives me an
IO error stating that I'm passing too many variables.
>>The instantiation of i_Compress is still inside the loop. This will
cause unecessary overhead and should be moved to a point before the
start of the loop. Think of it like making a cup of coffee and leaving
it on the beench of your kitchen. Every time you want a sip you have to
go out to the kitchen and then return to your office. I'm sure that you
would consider that to be a waste of your resources (time and effort).
Now, to make sure I've got this down... The line stating Dim i_Compress
as New CabLib.Compress should occur on any line OUTSIDE the start of the
For...Next loop, but the actual line stating i_Compress.CompressFolder...
should be on a line INSIDE the loop?
>>>Onward and upward :)
As Mork would have stated.... Nanoo...Nanoo... :) Sorry, can't do the
spreadfingered handshake here... might get me arrested. :)
Tom,
The only one of these tools that I haven't used is the trace. Without the
other three, I'd have been pulling my hair out by the handful... and I'm
already bald! :) I'll take a look into the trace tool tomorrow, if I can get
back to the keyboard. :) Thanks again.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:u9*************@TK2MSFTNGP04.phx.gbl...
Possibly a good time to introduce the debugger... if you are going to
monitor code take the opportunity to see how breakpoints, watchpoints,
step and trace work.
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>Yes ... But I would term it 'BEFORE the start of the loop' rather than
'OUTSIDE the start of the loop' which could also include after the end of
loop (for those that are picky).
And yes, the actual call to i_Compress.CompressFolder MUST be inside the
loop.
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
The 1st parameter is the source folder.
The 2nd parameter is the name of the resultant .cab file.
The 3rd parameter is a filter for dealing only with a subset of files. ""
(empty string) means don't filter.
The 4th parameter is for limiting the size of any one .cab file. 0 (zero)
means don't limit.
Directly before that line you can throw in:
Console.WriteLine(_Folder)
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
and then you can make sure that the values are as expected. (Make sure
you run it from the IDE and the results will be displayed in the Output
window).
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:55******************************@comcast.com ...
>>Christmas shopping almost finished.... :)
"Stephany Young" <noone@localhostwrote in message
news:uf*************@TK2MSFTNGP04.phx.gbl...
So you've found that there's nothing more sobering than looking at code
you have written yourself and saying, 'What idiot wrote this rubish?'.
:)
And nothing more sobering than doing it 5 minutes after you post a
EUREKA! on the newsgroup. :)
You are making 2 calls to the Path.GetFileName() method with the same
parameter, to get the name of the deepest node of the folder path. I my
view it is better to call that method once, store the result in a local
variable and use that when you need to:
A logical conclusion and one which I shall take to heart.
You then don't need the local variable strFinalFile and the line where
that is used becomes:
i_Compress.CompressFolder(_Folder,
Path.ChangeExtension(Path.Combine(strTargetDi r, _deepestnode), "cab"),
"", 0)
This won't work. I've already tried it. Not sure why but it gives me an
IO error stating that I'm passing too many variables.
The instantiation of i_Compress is still inside the loop. This will
cause unecessary overhead and should be moved to a point before the
start of the loop. Think of it like making a cup of coffee and leaving
it on the beench of your kitchen. Every time you want a sip you have to
go out to the kitchen and then return to your office. I'm sure that you
would consider that to be a waste of your resources (time and effort).
Now, to make sure I've got this down... The line stating Dim i_Compress
as New CabLib.Compress should occur on any line OUTSIDE the start of the
For...Next loop, but the actual line stating
i_Compress.CompressFolder... should be on a line INSIDE the loop?
Onward and upward :)
As Mork would have stated.... Nanoo...Nanoo... :) Sorry, can't do the
spreadfingered handshake here... might get me arrested. :)
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that it's
catching the commas in the Path.Combine method and thinking that it's
getting five or six parameters rather than four. In software testing terms,
I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
If nothing else I believe you are missing a "." as in ".cab" in the
Path.Combine method. Trust the compiler it isn't confused by commas :-) It
is precisely the lack of ambiguity in a language that makes it all work.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com. ..
>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that it's
catching the commas in the Path.Combine method and thinking that it's
getting five or six parameters rather than four. In software testing
terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
> _Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Well normally I test these things before posting but this time I just read
the docs. After I tested it, it appears to work whether one includes the
dot extension separator or not but given the documentation says it should
include the dot I would make a habit of it.
What I would suggest is that you break this line apart:
Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode), ".cab") to see
what the results are in the two methods (you can recombine them after you
see it works.
So try something similar to this (may have been suggested already) to see if
you get the results you expect.
debug.writeline(strTargetDir)
debug.writeline(_deepestNode)
debug.writeline(Path.Combine(strTargetDir,_deepest Node))
debug.writeline(Path.ChangeExtension(Path.Combine( strTargetDir,_deepestNode),
".cab"))
If everything looks okay I'd suggest you run through the loop you have but
don't call i_Compress.CompressFolder() just comment that for now. Just
output the results of the path methods instead so you can see if one of them
is malformed. Besides that you should post what IO error you received
(those are clues.)
Is there a possibility you have need to trim the values you're getting from
the textbox? If there are trailing blanks anywhere they would be combined
into the final path and that one isn't likely to exist.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:up**************@TK2MSFTNGP06.phx.gbl...
If nothing else I believe you are missing a "." as in ".cab" in the
Path.Combine method. Trust the compiler it isn't confused by commas :-)
It is precisely the lack of ambiguity in a language that makes it all
work.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com. ..
>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>>I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that
it's catching the commas in the Path.Combine method and thinking that
it's getting five or six parameters rather than four. In software testing
terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
>> _Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Typo!!!!!
Directly following the b of cab should be a " - you have a :
FYI, I get the impression that you are typing your code into the message
rather than copying and pasting it. If you are then it is too open to typo's
etc. and we are scratching our heads to figure out how you even managed to
compile it etc.
When you do copy and paste code from the IDE into a message it may look like
a load of rubbish. Simply do a Format/Rich Text (HTML) from the menu and
then do a Format/Plain Text and it will look OK.
Now the big question is, what result do you get when you execute?:
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com. ..
>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that it's
catching the commas in the Path.Combine method and thinking that it's
getting five or six parameters rather than four. In software testing
terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
> _Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Well, I'm not attempting to be argumentative, but in reading up in the
Path.Combine method, it states that if a period is not included in the
extension path, then it automatically includes it. I'm not in any way trying
to fault the compiler.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:up**************@TK2MSFTNGP06.phx.gbl...
If nothing else I believe you are missing a "." as in ".cab" in the
Path.Combine method. Trust the compiler it isn't confused by commas :-)
It is precisely the lack of ambiguity in a language that makes it all
work.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com. ..
>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>>I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that
it's catching the commas in the Path.Combine method and thinking that
it's getting five or six parameters rather than four. In software testing
terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
>> _Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Tom,
I'll give that a shot. Thanks for the input.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:uE*************@TK2MSFTNGP04.phx.gbl...
Well normally I test these things before posting but this time I just read
the docs. After I tested it, it appears to work whether one includes the
dot extension separator or not but given the documentation says it should
include the dot I would make a habit of it.
What I would suggest is that you break this line apart:
Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode), ".cab") to
see what the results are in the two methods (you can recombine them after
you see it works.
So try something similar to this (may have been suggested already) to see
if you get the results you expect.
debug.writeline(strTargetDir)
debug.writeline(_deepestNode)
debug.writeline(Path.Combine(strTargetDir,_deepest Node))
debug.writeline(Path.ChangeExtension(Path.Combine( strTargetDir,_deepestNode),
".cab"))
If everything looks okay I'd suggest you run through the loop you have but
don't call i_Compress.CompressFolder() just comment that for now. Just
output the results of the path methods instead so you can see if one of
them is malformed. Besides that you should post what IO error you
received (those are clues.)
Is there a possibility you have need to trim the values you're getting
from the textbox? If there are trailing blanks anywhere they would be
combined into the final path and that one isn't likely to exist.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:up**************@TK2MSFTNGP06.phx.gbl...
>If nothing else I believe you are missing a "." as in ".cab" in the
Path.Combine method. Trust the compiler it isn't confused by commas :-)
It is precisely the lack of ambiguity in a language that makes it all
work.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com ...
>>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not
seeing that I'm attempting to pass 'one' simple parameter. I'm thinking
that it's catching the commas in the Path.Combine method and thinking
that it's getting five or six parameters rather than four. In software
testing terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Stephany,
I'm far too lazy to type that much code into a newsgroup window... LOL Trust
me when I say that I've made prodigious use of the Ctrl-C/Ctrl-V option.
Now on with the show...
When I commented out the i_Compress.CompressFolder line and used your
Console.Writeline command line, I got a string of text showing the path of
the compressed file, as follows
strSourceDir "C:\Program Files\Corel\Corel Paint Shop Pro X" String
strDeepestNode "C:\Program Files\Corel\Corel Paint Shop Pro X\Brushes"
String
But I went just a little bit further and changed the Console.Writeline
portion of the command line to i_Compress.CompressFolder. As soon as I left
that line, three errors popped up in the IDE. Here they are...
Error 1 Argument not specified for parameter 's_CabFile' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As String,
s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129 13
Folder Archive
Error 2 Argument not specified for parameter 's_Filter' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As String,
s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129 13
Folder Archive
Error 3 Argument not specified for parameter 's32_SplitSize' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As String,
s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129 13
Folder Archive
These are the same errors I was receiving when I tried what you suggested,
which is why I believe that there may be a bug in the .dll because it's
(possibly) parsing the command strings only for commas and when it sees one,
it goes looking for the next piece of the puzzle instead of trying to make
sure the piece I've provided it really fits. When I present it with just a
variable it behaves as it should. :)
P.S. In the last message I posted with the leading params, I did make a
typo, but I was trying to illustrate how I thought the .dll was parsing it's
commands and got in a rush and just typed stuff in. The actual code doesn't
have that colon at the end of "cab". Sorry.
"Stephany Young" <noone@localhostwrote in message
news:u%****************@TK2MSFTNGP06.phx.gbl...
Typo!!!!!
Directly following the b of cab should be a " - you have a :
FYI, I get the impression that you are typing your code into the message
rather than copying and pasting it. If you are then it is too open to
typo's etc. and we are scratching our heads to figure out how you even
managed to compile it etc.
When you do copy and paste code from the IDE into a message it may look
like a load of rubbish. Simply do a Format/Rich Text (HTML) from the menu
and then do a Format/Plain Text and it will look OK.
Now the big question is, what result do you get when you execute?:
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com. ..
>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>>I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not seeing
that I'm attempting to pass 'one' simple parameter. I'm thinking that
it's catching the commas in the Path.Combine method and thinking that
it's getting five or six parameters rather than four. In software testing
terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
>> _Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
"Bruce W. Darby" <kr****@comcast.netwrote:
>These are the same errors I was receiving when I tried what you suggested,
which is why I believe that there may be a bug in the .dll because it's
(possibly) parsing the command strings only for commas and when it sees one,
it goes looking for the next piece of the puzzle instead of trying to make
sure the piece I've provided it really fits. When I present it with just a
variable it behaves as it should. :)
I remember looking at source code for an infozip dll. (or was it
pkzip? gzip? I forget). What they did for the DLL interface was to
take the arguments, construct a command-line text string out of them,
and pass this string to the zip libraries main() routine (which
obviously had been written as a standalone console program).
Also I've been using the command-line utility "mplayer" recently which
simply fails to work when given filenames that include commas.
I haven't been following the details of this thread. But what you
describe is not beyond the bounds of possibility, depending on how
lazy/inelegant the developers of your DLL were.
--
Lucian
Yes. There are few things about the documentation for the
Path.ChangeExtension method that, at first reading, appear to be
contradictory. When one reads it carefully, it turns out that the
contradictions are really ambiguities.
For instance, one might expect:
Console.WriteLine(Path.ChangeExtension("abc.def", ""))
Console.WriteLine(Path.ChangeExtension("abc", ""))
to produce:
abc
abc
However it actually produces abc. in both cases.
The paremeter can have a trailing . and the second parameter can have a
leading . and the method will work out what to do:
Console.WriteLine(Path.ChangeExtension("abc.def", ".ghi"))
Console.WriteLine(Path.ChangeExtension("abc.", "ghi"))
Console.WriteLine(Path.ChangeExtension("abc", ".ghi"))
Console.WriteLine(Path.ChangeExtension("abc", "ghi"))
all produce the same result.
When presented with ambiguities and/or contradictions in the documentation I
generally run some tests to see what actually happens. I also find Lutx
Roeder's Reflector, ( http://www.aisto.com/roeder/dotnet/), very useful for
having a look at the internals of various things.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:lf******************************@comcast.com. ..
Well, I'm not attempting to be argumentative, but in reading up in the
Path.Combine method, it states that if a period is not included in the
extension path, then it automatically includes it. I'm not in any way
trying to fault the compiler.
"Tom Leylan" <tl*****@nospam.netwrote in message
news:up**************@TK2MSFTNGP06.phx.gbl...
>If nothing else I believe you are missing a "." as in ".cab" in the
Path.Combine method. Trust the compiler it isn't confused by commas :-)
It is precisely the lack of ambiguity in a language that makes it all
work.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com ...
>>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not
seeing that I'm attempting to pass 'one' simple parameter. I'm thinking
that it's catching the commas in the Path.Combine method and thinking
that it's getting five or six parameters rather than four. In software
testing terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Another Paint Shop Pro X user. That makes 2 I know of now. :)
I would expect strDeepestNode to have a value of Brushes rather than the
full path, because strDeepestNode is assigned the result of
Path.GetFilename(_Folder).
If strTargetDir is "C:\Temp" then I would expect the result of
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), "cab") to
be "C:\Temp\Brushes.cab".
What happens if you use paths that don't have any spaces in them?
It's possible that the CabLib library has a 'bug' in it but I would be
inclined to make sure that I am sure that my own code is correct and what
the behaviours are before I start going down that path.?
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:T9******************************@comcast.com. ..
Stephany,
I'm far too lazy to type that much code into a newsgroup window... LOL
Trust me when I say that I've made prodigious use of the Ctrl-C/Ctrl-V
option.
Now on with the show...
When I commented out the i_Compress.CompressFolder line and used your
Console.Writeline command line, I got a string of text showing the path of
the compressed file, as follows
strSourceDir "C:\Program Files\Corel\Corel Paint Shop Pro X" String
strDeepestNode "C:\Program Files\Corel\Corel Paint Shop Pro X\Brushes"
String
But I went just a little bit further and changed the Console.Writeline
portion of the command line to i_Compress.CompressFolder. As soon as I
left that line, three errors popped up in the IDE. Here they are...
Error 1 Argument not specified for parameter 's_CabFile' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
Error 2 Argument not specified for parameter 's_Filter' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
Error 3 Argument not specified for parameter 's32_SplitSize' of 'Public
Sub CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
These are the same errors I was receiving when I tried what you suggested,
which is why I believe that there may be a bug in the .dll because it's
(possibly) parsing the command strings only for commas and when it sees
one, it goes looking for the next piece of the puzzle instead of trying to
make sure the piece I've provided it really fits. When I present it with
just a variable it behaves as it should. :)
P.S. In the last message I posted with the leading params, I did make a
typo, but I was trying to illustrate how I thought the .dll was parsing
it's commands and got in a rush and just typed stuff in. The actual code
doesn't have that colon at the end of "cab". Sorry.
"Stephany Young" <noone@localhostwrote in message
news:u%****************@TK2MSFTNGP06.phx.gbl...
>Typo!!!!!
Directly following the b of cab should be a " - you have a :
FYI, I get the impression that you are typing your code into the message
rather than copying and pasting it. If you are then it is too open to
typo's etc. and we are scratching our heads to figure out how you even
managed to compile it etc.
When you do copy and paste code from the IDE into a message it may look
like a load of rubbish. Simply do a Format/Rich Text (HTML) from the menu
and then do a Format/Plain Text and it will look OK.
Now the big question is, what result do you get when you execute?:
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.com ...
>>>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not
seeing that I'm attempting to pass 'one' simple parameter. I'm thinking
that it's catching the commas in the Path.Combine method and thinking
that it's getting five or six parameters rather than four. In software
testing terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Stephany & Tom,
Here is the latest iteration of my sub that you both have been so kind as to
work with me on. In this format, the sub works perfectly...
Private Sub CompressFolder(ByVal strSourceDir As String, ByVal strTargetDir
As String)
Dim strFolders As String() = Directory.GetDirectories(strSourceDir)
prbProgress.Maximum = strFolders.Length
prbProgress.Step = 1
prbProgress.Visible = True
lblProgress.Visible = True
Dim i_Compress As New CabLib.Compress
For Each strFolder As String In strFolders
Dim strDeepestNode As String = Path.GetFileName(strFolder)
Dim strFinalFile As String = Path.ChangeExtension(Path.Combine(strTargetDir,
_
strDeepestNode), ".cab")
lblProgress.Text = "Compressing: " & strDeepestNode
lblProgress.Update()
i_Compress.CompressFolder(strFolder, strFinalFile, "", 0)
prbProgress.PerformStep()
prbProgress.Update()
Next
prbProgress.Visible = False
lblProgress.Visible = False
End Sub
You both have been so very kind to put up with me and my coding and I shall
truly appreciate that, even when I start to grow as a developer (should THAT
ever happen) :) I know that I have a lot to learn, but I'm moving as fast as
I can most of the time and the time I get to code actually comes out of my
discretionary time at the end of the day. Call that, my own time. hehehe But
it's an opportunity for me to learn from those who have a better grasp than
I on the intracacies of the language and I want you to know that I'm not
going to stop, no matter how slowly I move. Perhaps someday I'll know enough
to give something back to the community.
Happy Holidays,
Bruce
Stephany,
I'm going to hold out my wrist and let you slap it, OK?? You are correct. I
had temporarily changed the
Path.GetFilename(_Folder) to simply '= _Folder' to try something after
reading one of your messages. When I noted that it was providing the full
path, I changed it back to the original. But I mada the copy of the line
prior to changing it back without realizing that I would throw everything
out of whack. Told you I was senile. :) I posted the working sub under your
other response earlier.
"Stephany Young" <noone@localhostwrote in message
news:%2****************@TK2MSFTNGP02.phx.gbl...
Another Paint Shop Pro X user. That makes 2 I know of now. :)
I would expect strDeepestNode to have a value of Brushes rather than the
full path, because strDeepestNode is assigned the result of
Path.GetFilename(_Folder).
If strTargetDir is "C:\Temp" then I would expect the result of
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), "cab") to
be "C:\Temp\Brushes.cab".
What happens if you use paths that don't have any spaces in them?
It's possible that the CabLib library has a 'bug' in it but I would be
inclined to make sure that I am sure that my own code is correct and what
the behaviours are before I start going down that path.?
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:T9******************************@comcast.com. ..
>Stephany,
I'm far too lazy to type that much code into a newsgroup window... LOL
Trust me when I say that I've made prodigious use of the Ctrl-C/Ctrl-V
option.
Now on with the show...
When I commented out the i_Compress.CompressFolder line and used your
Console.Writeline command line, I got a string of text showing the path
of the compressed file, as follows
strSourceDir "C:\Program Files\Corel\Corel Paint Shop Pro X" String
strDeepestNode "C:\Program Files\Corel\Corel Paint Shop Pro X\Brushes"
String
But I went just a little bit further and changed the Console.Writeline
portion of the command line to i_Compress.CompressFolder. As soon as I
left that line, three errors popped up in the IDE. Here they are...
Error 1 Argument not specified for parameter 's_CabFile' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
Error 2 Argument not specified for parameter 's_Filter' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
Error 3 Argument not specified for parameter 's32_SplitSize' of 'Public
Sub CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb 129
13 Folder Archive
These are the same errors I was receiving when I tried what you
suggested, which is why I believe that there may be a bug in the .dll
because it's (possibly) parsing the command strings only for commas and
when it sees one, it goes looking for the next piece of the puzzle
instead of trying to make sure the piece I've provided it really fits.
When I present it with just a variable it behaves as it should. :)
P.S. In the last message I posted with the leading params, I did make a
typo, but I was trying to illustrate how I thought the .dll was parsing
it's commands and got in a rush and just typed stuff in. The actual code
doesn't have that colon at the end of "cab". Sorry.
"Stephany Young" <noone@localhostwrote in message
news:u%****************@TK2MSFTNGP06.phx.gbl...
>>Typo!!!!!
Directly following the b of cab should be a " - you have a :
FYI, I get the impression that you are typing your code into the message
rather than copying and pasting it. If you are then it is too open to
typo's etc. and we are scratching our heads to figure out how you even
managed to compile it etc.
When you do copy and paste code from the IDE into a message it may look
like a load of rubbish. Simply do a Format/Rich Text (HTML) from the
menu and then do a Format/Plain Text and it will look OK.
Now the big question is, what result do you get when you execute?:
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.co m...
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
I don't understand why the call to i_Compress.CompressFolder is not
working. It takes 4 parameters and they are:
The second parameter is what causes the failure. It is somehow not
seeing that I'm attempting to pass 'one' simple parameter. I'm thinking
that it's catching the commas in the Path.Combine method and thinking
that it's getting five or six parameters rather than four. In software
testing terms, I'd say that was a bug. LOL
Example:
Param 1 - _Folder,
Param 2 - Path.ChangeExtension(Path.Combine(strTargetDir,_de epestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
_Folder,
Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode), "cab")
""
0
Bruce,
In my idea are you too much ironing. In this case it is in my idea better to
carpenter a small project where only the problems are in.
In that way you can more easily eliminate the things that are going wrong to
come to the right result.
(Almost the same advice as Tom gave in another question this night (for
me)).
Cor
Let me get my black leather basque and thigh boots on and let me grap my
whip.
'You know what happens to naughty boys don't you!!!!!!!!!!'
Now we've got the punishment out of the way, are you saying that:
i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
still doesn't work and that:
Dim strFinalFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab")
i_Compress.CompressFolder(strFolder, strFinalFile)
does work?
If that is the case then I'll fall off my chair because it worked for me
even with space charactes in the paths.
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:PJ******************************@comcast.com. ..
Stephany,
I'm going to hold out my wrist and let you slap it, OK?? You are correct.
I had temporarily changed the
Path.GetFilename(_Folder) to simply '= _Folder' to try something after
reading one of your messages. When I noted that it was providing the full
path, I changed it back to the original. But I mada the copy of the line
prior to changing it back without realizing that I would throw everything
out of whack. Told you I was senile. :) I posted the working sub under
your other response earlier.
"Stephany Young" <noone@localhostwrote in message
news:%2****************@TK2MSFTNGP02.phx.gbl...
>Another Paint Shop Pro X user. That makes 2 I know of now. :)
I would expect strDeepestNode to have a value of Brushes rather than the
full path, because strDeepestNode is assigned the result of
Path.GetFilename(_Folder).
If strTargetDir is "C:\Temp" then I would expect the result of
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), "cab")
to be "C:\Temp\Brushes.cab".
What happens if you use paths that don't have any spaces in them?
It's possible that the CabLib library has a 'bug' in it but I would be
inclined to make sure that I am sure that my own code is correct and what
the behaviours are before I start going down that path.?
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:T9******************************@comcast.com ...
>>Stephany,
I'm far too lazy to type that much code into a newsgroup window... LOL
Trust me when I say that I've made prodigious use of the Ctrl-C/Ctrl-V
option.
Now on with the show...
When I commented out the i_Compress.CompressFolder line and used your
Console.Writeline command line, I got a string of text showing the path
of the compressed file, as follows
strSourceDir "C:\Program Files\Corel\Corel Paint Shop Pro X" String
strDeepestNode "C:\Program Files\Corel\Corel Paint Shop Pro X\Brushes"
String
But I went just a little bit further and changed the Console.Writeline
portion of the command line to i_Compress.CompressFolder. As soon as I
left that line, three errors popped up in the IDE. Here they are...
Error 1 Argument not specified for parameter 's_CabFile' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb
129 13 Folder Archive
Error 2 Argument not specified for parameter 's_Filter' of 'Public Sub
CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb
129 13 Folder Archive
Error 3 Argument not specified for parameter 's32_SplitSize' of 'Public
Sub CompressFolder(s_Folder As String, s_CabFile As String, s_Filter As
String, s32_SplitSize As Integer)'. D:\Program Files\Microsoft Visual
Studio\Projects\Folder Archive\Folder Archive\Folder Archive\Form1.vb
129 13 Folder Archive
These are the same errors I was receiving when I tried what you
suggested, which is why I believe that there may be a bug in the .dll
because it's (possibly) parsing the command strings only for commas and
when it sees one, it goes looking for the next piece of the puzzle
instead of trying to make sure the piece I've provided it really fits.
When I present it with just a variable it behaves as it should. :)
P.S. In the last message I posted with the leading params, I did make a
typo, but I was trying to illustrate how I thought the .dll was parsing
it's commands and got in a rush and just typed stuff in. The actual code
doesn't have that colon at the end of "cab". Sorry.
"Stephany Young" <noone@localhostwrote in message
news:u%****************@TK2MSFTNGP06.phx.gbl.. .
Typo!!!!!
Directly following the b of cab should be a " - you have a :
FYI, I get the impression that you are typing your code into the
message rather than copying and pasting it. If you are then it is too
open to typo's etc. and we are scratching our heads to figure out how
you even managed to compile it etc.
When you do copy and paste code from the IDE into a message it may look
like a load of rubbish. Simply do a Format/Rich Text (HTML) from the
menu and then do a Format/Plain Text and it will look OK.
Now the big question is, what result do you get when you execute?:
Console.WriteLine(Path.ChangeExtension(Path.Combin e(strTargetDir,
_deepestnode), "cab"))
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:Vq******************************@comcast.c om...
>
"Stephany Young" <noone@localhostwrote in message
news:O5*************@TK2MSFTNGP04.phx.gbl...
>I don't understand why the call to i_Compress.CompressFolder is not
>working. It takes 4 parameters and they are:
>
The second parameter is what causes the failure. It is somehow not
seeing that I'm attempting to pass 'one' simple parameter. I'm
thinking that it's catching the commas in the Path.Combine method and
thinking that it's getting five or six parameters rather than four. In
software testing terms, I'd say that was a bug. LOL
>
Example:
Param 1 - _Folder,
Param 2 -
Path.ChangeExtension(Path.Combine(strTargetDir ,_deepestNode),
Param 3 -"cab:),
Param 4 - "",
Param 5 - 0
>
> _Folder,
> Path.ChangeExtension(Path.Combine(strTargetDir, _deepestnode),
>"cab")
> ""
> 0
>
>
Except we could understand what Tom said :)
Merry Christmas Cor :)
"Cor Ligthert [MVP]" <no************@planet.nlwrote in message
news:eW**************@TK2MSFTNGP02.phx.gbl...
Bruce,
In my idea are you too much ironing. In this case it is in my idea better
to carpenter a small project where only the problems are in.
In that way you can more easily eliminate the things that are going wrong
to come to the right result.
(Almost the same advice as Tom gave in another question this night (for
me)).
Cor
Thigh boots???? Hmmm... No, better not go there. :)
Yes, that's exactly what I mean. This doesn't work for me.
i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
still doesn't work and that:
And this DOES work for me.
Dim strFinalFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab")
i_Compress.CompressFolder(strFolder, strFinalFile)
does work?
Should I send someone to help you up? :)
Cor,
I read that one. :) But I'm just letting Stephany know what is and isn't
working for me. My project is otherwise working perfectly well. I've
actually started my project over, thinking some changes that I had made
elsewhere, through my own stupidity, of course, had botched my solution. In
both solutions, the exact same errors occured on that line of code. I'm
perfectly happy with the code working as it is. I really don't want anyone
wasting their time on it, so if it is getting to that point, I apologize.
Bruce
"Cor Ligthert [MVP]" <no************@planet.nlwrote in message
news:eW**************@TK2MSFTNGP02.phx.gbl...
Bruce,
In my idea are you too much ironing. In this case it is in my idea better
to carpenter a small project where only the problems are in.
In that way you can more easily eliminate the things that are going wrong
to come to the right result.
(Almost the same advice as Tom gave in another question this night (for
me)).
Cor
It's definitely time for the black boots and whip this time!!!!!!!!!!!!!!
I would like you to try it with EXACTLY this line:
i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
Copy and paste it verbatim and remove any line breaks that propogate
themselves.
Do not, I repeat, DO not modify the line in any other way.
Do not, I repeat, DO not attempt to run the program.
Compile it and see if you get any compile time errors and if so report back.
If it compile ok, then you can run it and report back with the results.
If that doesn't work I'll come and marry you and, believe me, you wouldn't
want that!!!!!!!!!
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:qe******************************@comcast.com. ..
Thigh boots???? Hmmm... No, better not go there. :)
Yes, that's exactly what I mean. This doesn't work for me.
> i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
still doesn't work and that:
And this DOES work for me.
> Dim strFinalFile As String =
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab")
i_Compress.CompressFolder(strFolder, strFinalFile)
does work?
Should I send someone to help you up? :)
Hmmm... That one worked, though for the life of me I cannot see anything
different from any of the previous lines that you provided. So I suppose
you're safe from the wedding bells. :) Besides, even though I live in Utah,
my wife isn't into polygamy. LOL
Ummm... if I put a line continuation character in, could I get a few extra
lashes?? ROFL
Thanks Stephany,
Bruce
"Stephany Young" <noone@localhostwrote in message
news:OT*************@TK2MSFTNGP06.phx.gbl...
I would like you to try it with EXACTLY this line:
i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
I suspect that you had a tray comma, a missing comma or a comma in the wrong
place.
When I stragecially misplaced a comma or 2 I got one or more of the errors
you saw, byt the important thing is that they were compile-time errors not
run-time exceptions.
When you are posting about 'errors', it is important that you are absolutely
clear as to the type of error or exception that you are talking about, cos
even though we're pretty good, we don't have telepathy down to a fine art as
yet.
Don't get lost in the snow :)
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:fN******************************@comcast.com. ..
Hmmm... That one worked, though for the life of me I cannot see anything
different from any of the previous lines that you provided. So I suppose
you're safe from the wedding bells. :) Besides, even though I live in
Utah, my wife isn't into polygamy. LOL
Ummm... if I put a line continuation character in, could I get a few extra
lashes?? ROFL
Thanks Stephany,
Bruce
"Stephany Young" <noone@localhostwrote in message
news:OT*************@TK2MSFTNGP06.phx.gbl...
>I would like you to try it with EXACTLY this line:
i_Compress.CompressFolder(strFolder,
Path.ChangeExtension(Path.Combine(strTargetDir, strDeepestNode), ".cab"),
"", 0)
Bruce this isn't a big deal but why I mentioned it before was so you (an
others) understand, what you are suggesting is "impossible". I believe you
think the function calls are passed along as parameters to be "parsed" by
the function itself and they aren't. The outer function has no idea that
you supplied the parameters indirectly via other function calls.
MyFunc1( "this", 15 )
MyFunc1( GetThis(), 3 * 5 )
Are equal (so long as GetThis() returns "this" of course. All computations
"must" be done prior to calling MyFunc1().
It isn't something you should worry about because it can't happen. If a
function returns something "wrong" then yes the function will fail but due
to the bad value not due to the fact that a function was called..
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:T9******************************@comcast.com. ..
These are the same errors I was receiving when I tried what you suggested,
which is why I believe that there may be a bug in the .dll because it's
(possibly) parsing the command strings only for commas and when it sees
one, it goes looking for the next piece of the puzzle instead of trying to
make sure the piece I've provided it really fits. When I present it with
just a variable it behaves as it should. :)
Tom,
I appreciate everything that you've done to assist me in learning. I've got
a hard head sometimes, but it also allows me to bang it against the wall
until something sinks in. :) Of course, that really leaves a bloody mess on
the wall... ROFL
Happy Holidays,
Bruce
"Tom Leylan" <tl*****@nospam.netwrote in message
news:eA****************@TK2MSFTNGP06.phx.gbl...
Bruce this isn't a big deal but why I mentioned it before was so you (an
others) understand, what you are suggesting is "impossible". I believe
you think the function calls are passed along as parameters to be "parsed"
by the function itself and they aren't. The outer function has no idea
that you supplied the parameters indirectly via other function calls.
MyFunc1( "this", 15 )
MyFunc1( GetThis(), 3 * 5 )
Are equal (so long as GetThis() returns "this" of course. All
computations "must" be done prior to calling MyFunc1().
It isn't something you should worry about because it can't happen. If a
function returns something "wrong" then yes the function will fail but due
to the bad value not due to the fact that a function was called..
"Bruce W. Darby" <kr****@comcast.netwrote in message
news:T9******************************@comcast.com. ..
>These are the same errors I was receiving when I tried what you
suggested, which is why I believe that there may be a bug in the .dll
because it's (possibly) parsing the command strings only for commas and
when it sees one, it goes looking for the next piece of the puzzle
instead of trying to make sure the piece I've provided it really fits.
When I present it with just a variable it behaves as it should. :)
This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: mike |
last post by:
Hello,
After trying to validate this page for a couple of days now I was
wondering if someone might be able to help me out. Below is a list of
snippets where I am having the errors.
1. Line 334,...
|
by: John Flynn |
last post by:
hi all
i'm going to be quick i have an assignment due which i have no idea how to
do. i work full time so i dont have the time to learn it and its due date
has crept up on me ..
As follows:...
|
by: xunling |
last post by:
i have a question about answering ..... this topic is "need help"
what do i have to write at te topic line, !after i have klicked the
"answer message" button
ive tried many possibilities,...
|
by: sk |
last post by:
I have an applicaton in which I collect data for different parameters
for a set of devices. The data are entered into a single table, each
set of name, value pairs time-stamped and associated with...
|
by: Timothy Shih |
last post by:
Hi, I am trying to figure out how to use unmanaged code using P/Invoke. I
wrote a simple function which takes in 2 buffers (one a byte buffer, one a
char buffer) and copies the contents of the byte...
|
by: Cheryl Langdon |
last post by:
Hello everyone,
This is my first attempt at getting help in this manner. Please
forgive me if this is an inappropriate request.
I suddenly find myself in urgent need of instruction on how to...
|
by: pamelafluente |
last post by:
I am still working with no success on that client/server
problem. I need your help. I will submit simplified versions
of my problem so we can see clearly what is going on.
My model:
A client...
|
by: skumar434 |
last post by:
i need to store the data from a data base in to structure
.............the problem is like this ....suppose there is a data base
which stores the sequence no and item type etc ...but i need only...
|
by: U S Contractors Offering Service A Non-profit |
last post by:
Brilliant technology helping those most in need Inbox
Reply
U S Contractors Offering Service A Non-profit
show details
10:37 pm (1 hour ago)
Brilliant technology helping those most in need ...
|
by: mike |
last post by:
I help manage a large web site, one that has over
600 html pages... It's a reference site for ham radio
folks and as an example, one page indexes over
1.8 gb of on-line PDF documents.
The site...
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: ryjfgjl |
last post by:
In our work, we often receive Excel tables with data in the same format. If we want to analyze these data, it can be difficult to analyze them because the data is spread across multiple Excel files...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers,...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
| |
