How can I improve this code please?

[Trint Smith]

How can I improve this code please?
It sometimes produces this error:
"Object reference not set to an instance of an object"
When I do this:
strSQL = "UPDATE TBL_Items SET" & _
" item_itemnumber = " & PrepareStr(Label6.Text) & _
" ,item_itemcurrentbidprice = " &
PrepareStr(itemCurrentbidprice) & _
" ,item_itembidhistory = " &
PrepareStr(itembidHistory) & _
" ,item_itemcurrentorpurchasedbidder = " &
PrepareStr(itemCurrentorpurchasedbidder) & _
"FROM TBL_Items " & _
"WHERE item_itemnumber = '" & Label6.Text & "'"

Here is the code:

Private Function PrepareStr(ByVal strValue As String) As String
' This function accepts a string and creates a string that can
' be used in a SQL statement by adding single quotes around
' it and handling empty values.
If strValue.Trim() = "" Then
Return "NULL"
Else
Return "'" & strValue.Trim() & "'"
End If
End Function

Thanks,
Trint
.Net programmer
tr********@hotmail.com

*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!

[Stephajn Craig]

It looks like your function will return the word NULL to your calling
function, when what it looks like you want to return is 'NULL'. Another
idea is to return String.Empty instead of "NULL".

Stephajn
"Trint Smith" <tr********@hotmail.com> wrote in message
news:u8******************@TK2MSFTNGP10.phx.gbl...

How can I improve this code please?
It sometimes produces this error:
"Object reference not set to an instance of an object"
When I do this:
strSQL = "UPDATE TBL_Items SET" & _
" item_itemnumber = " & PrepareStr(Label6.Text) & _
" ,item_itemcurrentbidprice = " &
PrepareStr(itemCurrentbidprice) & _
" ,item_itembidhistory = " &
PrepareStr(itembidHistory) & _
" ,item_itemcurrentorpurchasedbidder = " &
PrepareStr(itemCurrentorpurchasedbidder) & _
"FROM TBL_Items " & _
"WHERE item_itemnumber = '" & Label6.Text & "'"

Here is the code:

Private Function PrepareStr(ByVal strValue As String) As String
' This function accepts a string and creates a string that can
' be used in a SQL statement by adding single quotes around
' it and handling empty values.
If strValue.Trim() = "" Then
Return "NULL"
Else
Return "'" & strValue.Trim() & "'"
End If
End Function

Thanks,
Trint
Net programmer
tr********@hotmail.com

*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!

[Herfried K. Wagner [MVP]]

* Trint Smith <tr********@hotmail.com> scripsit:

How can I improve this code please?
It sometimes produces this error:
"Object reference not set to an instance of an object"

On which line?

--
Herfried K. Wagner [MVP]
<http://www.mvps.org/dotnet/>

..NET FAQs: <http://www.mvps.org/dotnet/dotnet/faqs/> (German)

[Cor]

Hi Trint,

Have a look at command.parameters that is made for this.

http://msdn.microsoft.com/library/de...eterstopic.asp

I hope this helps,

Cor

How can I improve this code please?
It sometimes produces this error:
"Object reference not set to an instance of an object"
When I do this:
strSQL = "UPDATE TBL_Items SET" & _
" item_itemnumber = " & PrepareStr(Label6.Text) & _
" ,item_itemcurrentbidprice = " &
PrepareStr(itemCurrentbidprice) & _
" ,item_itembidhistory = " &
PrepareStr(itembidHistory) & _
" ,item_itemcurrentorpurchasedbidder = " &
PrepareStr(itemCurrentorpurchasedbidder) & _
"FROM TBL_Items " & _
"WHERE item_itemnumber = '" & Label6.Text & "'"

Here is the code:

Private Function PrepareStr(ByVal strValue As String) As String
' This function accepts a string and creates a string that can
' be used in a SQL statement by adding single quotes around
' it and handling empty values.
If strValue.Trim() = "" Then
Return "NULL"
Else
Return "'" & strValue.Trim() & "'"
End If
End Function

[Trint Smith]

thanks Cor.
Herfried:
If strValue.Trim() = "" Then

Return "NULL"

Thanks,
Trint

.Net programmer
tr********@hotmail.com

*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!