473,320 Members | 1,916 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

Array

in my code I am using an array, but it only reads one like it doe not loop
Dim i As Integer
Dim sr As IO.StreamReader
Dim strline, strlines() As String
Dim fmtstr As String = "{0,-15}{1,5:n1}{2,10:n1}"
sr = IO.File.OpenText("Soft Drinks.txt")
strline = sr.ReadLine
lstdisplay.Items.Clear()
For i = 0 To upperbound
strlines = strline.Split(CChar(","))
soda(i).drinks = sr.ReadLine
soda(i).shares = CDbl(sr.ReadLine)
soda(i).sales = CDbl(soda(i).shares / 100 * 42)
lstdisplay.Items.Add(String.Format(fmtstr, soda(i).drinks,
soda(i).shares, soda(i).sales))
Next
sr.Close()
End sub

Form_load
Dim name As String
Dim i As Integer
Dim sr As StreamReader = IO.File.OpenText("Soft Drinks.txt")
upperbound = 0
Do While (sr.Peek <> -1)
name = sr.ReadLine
upperbound += 1
Loop
sr.Close()
ReDim soda(upperbound)
sr = IO.File.OpenText("Soft Drinks.txt")
For i = 1 To upperbound
soda(i).drinks = sr.ReadLine
Next
sr.Close()
End Sub
Help please
Nov 21 '05 #1
1 1695
I assume soda() is declared at the class level? I also assume upperbound
is too?

You can move upperbound back into form_Load because you can loop through
an array using the length of the array:

for x=0 to soda.Length-1

However, I am concerned about the double loop you have to read in the
items. In fact, I can't even follow the logic of the code.

I think you have a comma-delimited file for your drinks and shares,
similar to:

ABC,10
XYZ,30
MORE,50

Seems like you could trim off a lot of code with an arraylist:
' Global
Dim alSodas As New ArrayList

' Form Load
Dim sr As IO.StreamReader
Dim sCSVLine As String
Dim aCSVValues() As String
Dim oSoda As soda

sr = IO.File.OpenText("Soft Drinks.txt")

sCSVLine = sr.ReadLine

Do While Not sCSVLine Is Nothing
aCSVValues = sCSVLine.Split(CChar(","))
oSoda = New soda
With oSoda
.drinks = aCSVValues(0)
.shares = aCSVValues(1)
.sales = CDbl(.shares / 100 * 42)
End With
alSodas.Add(oSoda)
Loop

sr.Close()

' Bind to List
Dim oSoda As soda
Dim iCounter As Integer
Dim fmtstr As String = "{0,-15}{1,5:n1}{2,10:n1}"

lstdisplay.Items.Clear()

For iCounter = 0 To alSodas.Count - 1
oSoda = CType(alSodas(iCounter), soda)
lstdisplay.Items.Add(String.Format(fmtstr, osoda.drinks,
osoda.shares, osoda.sales))

Next

That reduces your file reads from three to one. Hopefully I'm on target
with that one.

=?Utf-8?B?ZnJlZGR5?= <fr****@discussions.microsoft.com> wrote in
news:9D**********************************@microsof t.com:
in my code I am using an array, but it only reads one like it doe not
loop Dim i As Integer
Dim sr As IO.StreamReader
Dim strline, strlines() As String
Dim fmtstr As String = "{0,-15}{1,5:n1}{2,10:n1}"
sr = IO.File.OpenText("Soft Drinks.txt")
strline = sr.ReadLine
lstdisplay.Items.Clear()
For i = 0 To upperbound
strlines = strline.Split(CChar(","))
soda(i).drinks = sr.ReadLine
soda(i).shares = CDbl(sr.ReadLine)
soda(i).sales = CDbl(soda(i).shares / 100 * 42)
lstdisplay.Items.Add(String.Format(fmtstr, soda(i).drinks,
soda(i).shares, soda(i).sales))
Next
sr.Close()
End sub

Form_load
Dim name As String
Dim i As Integer
Dim sr As StreamReader = IO.File.OpenText("Soft Drinks.txt")
upperbound = 0
Do While (sr.Peek <> -1)
name = sr.ReadLine
upperbound += 1
Loop
sr.Close()
ReDim soda(upperbound)
sr = IO.File.OpenText("Soft Drinks.txt")
For i = 1 To upperbound
soda(i).drinks = sr.ReadLine
Next
sr.Close()
End Sub
Help please


Nov 21 '05 #2

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

2
by: Brian | last post by:
I'm diddlying with a script, and found some behavior I don't understand. Take this snippet: for ($i = 0; $i <= count($m); $i++) { array_shift($m); reset($m); }
2
by: Stormkid | last post by:
Hi Group I'm trying to figure out a way that I can take two (two dimensional) arrays and avShed and shed, and subtract the matching elements in shed from avShed I've pasted the arrays blow from a...
15
by: lawrence | last post by:
I wanted to test xml_parse_into_struct() so I took the example off of www.php.net and put this code up on a site: <?php $simple = <<<END <item>
8
by: vcardillo | last post by:
Hello all, Okay, I am having some troubles. What I am doing here is dealing with an employee hierarchy that is stored in an array. It looks like this: $employees = array( "user_id" => array(...
12
by: Sam Collett | last post by:
How do I remove an item with a specified value from an array? i.e. array values 1,2,2,5,7,12,15,21 remove 2 from array would return 1,5,7,12,15,21 (12 and 21 are NOT removed, duplicates are...
8
by: Mike S. Nowostawsky | last post by:
I tried using the "toUpperCase()" property to change the value of an array entity to uppercase BUT it tells me that the property is invalid. It seems that an array is not considered an object when...
58
by: jr | last post by:
Sorry for this very dumb question, but I've clearly got a long way to go! Can someone please help me pass an array into a function. Here's a starting point. void TheMainFunc() { // Body of...
104
by: Leszek | last post by:
Hi. Is it possible in javascript to operate on an array without knowing how mamy elements it has? What i want to do is sending an array to a script, and this script should add all values from...
7
by: Jim Carlock | last post by:
Looking for suggestions on how to handle bad words that might get passed in through $_GET variables. My first thoughts included using str_replace() to strip out such content, but then one ends...
17
by: =?Utf-8?B?U2hhcm9u?= | last post by:
Hi Gurus, I need to transfer a jagged array of byte by reference to unmanaged function, The unmanaged code should changed the values of the array, and when the unmanaged function returns I need...
0
by: DolphinDB | last post by:
The formulas of 101 quantitative trading alphas used by WorldQuant were presented in the paper 101 Formulaic Alphas. However, some formulas are complex, leading to challenges in calculation. Take...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
0
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
0
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
0
by: Shællîpôpï 09 | last post by:
If u are using a keypad phone, how do u turn on JavaScript, to access features like WhatsApp, Facebook, Instagram....
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.