Help! Stuck in a datareader loop

[Mike D]

Attached is my code. Which I know there is a better way of writing however
this is what I came up with and it works until the value is null or not = to
the <> value.
'Do While rdrSQL.Read()

'While rdrSQL.Read()

' Dim result As String

' result = Trim(rdrSQL.GetString(0))

' Do While result <> Me.txtUserID.Text

' Loop

' If result = Me.txtUserID.Text Then

' MsgBox("Authenticated")

' Dim frm As New Form1

' frm.Show()

' Me.Hide()

' Else

' Me.Close()

' End If

'End While

[Cor]

Hi Mike,
Did not check it all, but in this code I saw some things

'Do While rdrSQL.Read() delete that row I think wthat ill be better
'While rdrSQL.Read()
' Dim result As String
' result = Trim(rdrSQL.GetString(0))
' Do While result <> Me.txtUserID.Text I think you want here
If resul = Me.txtUserId.text then exit while
' Loop change it to end while ' If result = Me.txtUserID.Text Then
' MsgBox("Authenticated")

And please do us a favor, paste your code the next time first in a notepad
and copy it that back before to paste it in the message, makes it more
readable and people will mostly faster help you.

I hope this helps a little bit?
Cor

[Roy Osherove]

Um.. perhpas these two lines are your problem:

' Do While result <> Me.txtUserID.Text

' Loop

that, my friend, is an endless loop. You don't change the result
variable inside the loop and so the loop goes on forever.
---
Regards,

Roy Osherove
www.iserializable.com

On Wed, 5 Nov 2003 16:04:19 -0500, "Mike D" <di****@hotmail.com>
wrote:

' Do While result <> Me.txtUserID.Text

' Loop

[Mike D]

>> Proudly fixed.<<

I worked most of the night thinking this out and today walked in wit a
result..

Here is the final code that actually works

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As
System.EventArgs) Handles Button1.Click
cnSQL.Open()
Dim strsql As String
strsql = "Select username FROM tblSecurity"
Dim cmd As New SqlCommand(strsql, cnSQL)
Dim daSQL As New SqlDataAdapter(strsql, cnSQL)
Dim rdrSQL As SqlDataReader = cmd.ExecuteReader()

Do While rdrSQL.Read()
result = Trim(rdrSQL.GetString(0))
If result = Me.txtUserID.Text Then
MsgBox("Authenticated")
Dim frm As New Form1
frm.Show()
Me.Hide()
Exit Do
End If
Loop
If result <> Me.txtUserID.Text Then
MsgBox("You are not Authorized on the system!")
cnSQL.Close()
rdrSQL.Close()
Me.Close()
End If
cnSQL.Close()
rdrSQL.Close()
Me.Close()
End Sub
"Roy Osherove" <ro**@iserializable.com> wrote in message
news:92********************************@4ax.com... Um.. perhpas these two lines are your problem:

' Do While result <> Me.txtUserID.Text

' Loop

that, my friend, is an endless loop. You don't change the result
variable inside the loop and so the loop goes on forever.
---
Regards,

Roy Osherove
www.iserializable.com

On Wed, 5 Nov 2003 16:04:19 -0500, "Mike D" <di****@hotmail.com>
wrote:

' Do While result <> Me.txtUserID.Text

' Loop

[Tom Leylan]

"Mike D" <di****@hotmail.com> wrote...

Here is the final code that actually works

Mike... congrats on getting it "to work" now :you just have to fix it :-) I
don't mean to cause you grief but now that you have the basics figured out
consider how much stuff is going on in an event handler. Not only a ton of
code (unreusable except for cut-and-paste) but you are declaring (and
displaying) a form within it.

You are referencing the txtUserID textbox "directly" rather than passing in
a string, you have cnSQL.Close() and rdrSQL.Close() and Me.Close() in there
twice. The trouble with this kind of thing is that it can only get worse as
more of the app gets completed. Code doesn't get cleaner, it only decays
over time and gets harder to follow as a result.

You can ignore me of course, it works... but think about it at least.

Tom

[Cor]

Hi Mike,

I did not want to give some critique on your code, you did sound so proud.
And there is nothing wrong to start with doing things even if it is not the
best way. But now that Tom did it a little bit, I give you the advice to
change this.

strsql = "Select username FROM tblSecurity"

If you put in here a where clause (there is a nicer way to do it, but this
shows it fine)

strsql = "Select username from tblSecurity WHERE username = '" & trim(txt)
& "'"

Then your system has only to do one read. and if it exist in the first read
you have it.

What Tom said was more efficiency in coding, it does not give you any
advantage in your program itself. With this it goes a lot faster (except
when you have 1 user than it is slower) :-).

I now can see that it is not, but your approach looks like the webform old
ASP style, but that will soon also change in the way Tom said I think.

But it is good you did found it yourself, it is the same as what I did tell
in my message with the difference you use the do while and I was telling you
the while. The do while you use is more from this time, but I did not wanted
to change your basic code to much then.

I hope this helps a little bit.

Cor