urllib.urlretrieve returns a corrupt file when using a variable for filename

[dank4201]

The code below has two calls to urllib.urlretrieve, the first using a string for the file name. Works great. The second returns the same file name but the file is corrupt.


import urllib
import os

url = 'https://s3.amazonaws.com/MobiFlexImages/[e-mail]/splogolawyer.png'
# download with string for file name
urllib.urlretrieve(url, "splogolawyer.png")
# works great

# download by unpacking string to url and filename
# the png file is corrupt
url, filename = os.path.split('https://s3.amazonaws.com/MobiFlexImages/[e-mail]/splogolawyer.png')
urllib.urlretrieve(url, filename)
print tail
print head

[dwblas]

I would suggest that you print "url" before each of the 2 downloads and compare them.

[dank4201]

Thanks. I think I'm picking up the EOL character.

[dank4201]

Yup.
line = line.rstrip("\r\n")
did the trick.

[dwblas]

The first url is url = 'https://s3.amazonaws.com/MobiFlexImages/[e-mail]/splogolawyer.png'
The second is url = 'https://s3.amazonaws.com/MobiFlexImages/[e-mail]'

[dank4201]

Thanks. I know. This was just a test to see if I could download a file. It turns out my problem was I was stripping the off the filename. So the URL didn't have anything to download and the file that was created was empty.

The actual problem I was trying to solve was reading a text file with a list of URL's with filenames and downloading all of them. Here's the code that actually worked: (note I save the complete URL before grabbing the filename)

import urllib
import os

f = open('AxikitSponsors-s3only.txt')
for line in iter(f):
line = line.rstrip("\r\n")
url, fileName = os.path.split(line)
urllib.urlretrieve(line, fileName)
print "Downloaded: ", line, " ", fileName
f.close()

[dwblas]

You didn't say that you were reading from a file which obviously makes a difference, but anyway, just use strip() as it will strip "\r", "\n", tabs, spaces, etc. and so if there is any leading or trailing whitespace, it will remove all of it, unless of course you only want to remove one thing.

line=line.strip()