Trivia Game

[alesitaam]

Help!!!! Im new using python, currently writing a program which tests one game, IQ test. When the module is run, the program should ask user to choose the game to start. Also, I'm using Try...Except statements, and os file operator.
My code needs some adjustments, most of all at the end. Please give some tips!!!


import os

while True:
print"Welcome to trivia game!"
print "0-Choose a game to play:"
print "1- IQ Test.trv"

s=raw_input()
if s==1:
def open_file(file_name,mode):
"""Open a file."""
try:
choice=float(raw_input("Choice:"))
the_file=open(file_name,mode)
except(IOError),e:
print "Unable to open the file", file_name,"Ending program.\n",e
raw_input("\n\nPress the enter key to exit")
else:
return the_file

#Directory
print"Welcome to trivia game!"
print
print "0-Choose a game to play:"
print
print "1- IQ Test.trv"
game=os.listdir(os.getcwd()+"Question")

i=0
for i in game:
print i, s
i=i+1

while True:
try:
choice=float(raw_input("Choice:"))
if choice>=0 and choice<=len(game):
break
except(ValueError):
print "Not valid."



myFile=open_file(os.listdir(os.getcwd()+"Question" +game[choice],"r")
score=0

#Beginning of the trivia game
question=myFile.readline()
while choice != "":
answer1=myFile.readline()
answer2=myFile.readline()
answer3=myFile.readline()
answer4=myFile.readline()
explanation=myFile.readline()
points=float(myFile.readline())

print question

print "1- " + answer1
print "2- " + answer2
print "3- " + answer3
print "4- " + answer4

results=["answer1","answer2", "answer3", "answer4"]

while True:
try:
answer= raw_input("What is your answer?:")
if answer>=1 and answer<=4
break
except(ValueError):
print "Not valid answer."

#Results
if results[answer]==correct[0]:
print "n\Right"
score += points
else:
print "n\Wrong" + explanation

print "Score:", score, "\n\n"
question=myFile.readline()

if s!=1:
print "Unable to open the file"

os.close()

[jlm699]

Please try to use [code] tags when posting, it makes it much more readable...

There are a number of syntax errors...
line 45 - missing closing parenthesis
line 69 - missing colon at end of if statement

I'm not sure what you're trying to do here though, as when the 'game' starts it just keeps asking what you would like to do (stuck in the while True: loop)

There is no way to exit the loop, and every time the user enters '1', it simply redefines the function open_file.

Other suggestions:
line 25 - This line should be modified as the following (and line 42 should be modified in a similar way):

game=os.listdir(os.path.join(os.getcwd(),"Question"))
 

line 28 - I believe in this loop you're looking for the following:

for i, s in enumerate(game):
 

Perhaps the structuring of this program was lost when you didn't use the [code] tags, so perhaps try reposting and fixing the indentation and maybe we can help further

[alesitaam]

pls can you tell me how to use code tags for posting?, thanks

[jlm699]

pls can you tell me how to use code tags for posting?, thanks

When you hit reply on the right side of the editing box there is a message box that reads: REPLY GUIDELINES and the third bullet shows how to use code tags. You basically have an opening [code] tag (tip: use code=python inthis tag to designate the code as python code... then you have a closing tag that is /code surrounded by []

[alesitaam]

 
import os
 
while True:
    print"Welcome to trivia game!"
    print
    print "Choose a game to play:"
    print
    print "1- IQ Test.trv"
 
    s=raw_input()
    if s==1:
 
 
        def open_file(file_name,mode):
            """Open a file."""
            try:
                choice=float(raw_input("Choice:"))
                the_file=open(file_name,mode)
            except(IOError),e:
                print "Unable to open the file", file_name,"Ending program.\n",e
                raw_input("\n\nPress the enter key to exit")
            else:
                return the_file
 
 
print"Welcome to trivia game!"
print
print "Choose a game to play:"
print
print "1- IQ Test.trv"
game=os.listdir(os.path.join(os.getcwd()+"Questions"))
 
i=0
for i,s in enumerate(game):
    print i,s
    i=i+1
 
 
 
while True:
    try:
        choice=float(raw_input("Choice:"))
        if choice>=0 and choice<len(game):
            break
    except(ValueError):
        print "Not valid."
 
 
 
myFile=open_file(os.listdir(os.path.join(os.getcwd()+"Questions"+game[choice],"r"))  
score=0
 
 
question=myFile.readline()
while choice != "":
    answer1=myFile.readline()
    answer2=myFile.readline()
    answer3=myFile.readline()
    answer4=myFile.readline()
    explanation=myFile.readline()
    points=float(myFile.readline())
 
    print question
 
    print "1- " + answer1
    print "2- " + answer2
    print "3- " + answer3
    print "4- " + answer4
 
    results=["answer1","answer2", "answer3", "answer4"]
 
    while True:
        try:
            answer= raw_input("What is your answer?:")
            if answer>=1 and answer<=4:
                break
        except(ValueError):
            print "Not valid answer."
 
 
if results[answer]==correct[0]:
    print "n\Right"
    score += float(points)
else:
    print "n\Wrong" + explanation
 
print "Score:", score, "\n\n"
question=myFile.readline()
 
 

[jlm699]

You fixed the two syntax errors, but you're still putting an infinite loop at the very beginning of your program that keeps re-defining a function and nothing else. Take the function definition out of that loop and get rid of that loop, as it does nothing. The rest of your code looks like it's supposed to go there, however it seems your structure is all messed up. Try something similar to this:

# import things first
 
# function definitions here
def func1():
    # func1 details...
def func2():
    # func2 details...
 
# here's your main function
def main():
    # Put your main execution code here
 
if __name__ == '__main__':
    # Perform any initialization here then call your main function
    main()