Strange Behaviour with an IF Statement

[WhiteRider]

def load(): # function to load game data
    if os.path.exists('./data.dat') == True: 
        load = open('data.dat', 'r') 
        save = load.readline() 
        if save == "":
            welcome()
        elif save == "1\n" or "1": 
            chce = raw_input("A saved game has been detected. Would you like to load this? Y/N ")
            if chce == "Y" or "y":
                pass # Not came that far yet
            elif chce == "N" or "n":
                welcome()
            else:
                print "Invalid choice please choose Y for yes or N for no."
    else:
        print "Fatal Error: 'data.dat' not detected."
 

This is an excerpt of a text-based RPG I am currently writing. The problem is when I come to line 8 where it asks if I want to load a saved game or not. For some reason I just can't understand it doesn't do what its supposed to do. One: it doesn't give me the "else" section if I type in something other than Y, y, N, n. Two: it doesn't go to my "welcome()" function if I select N or n. I get no errors. The program will just exit when I try one of those things :S

Am I missing something obvious? Perhaps a syntax issue - like a block of code not in the right place. I am not that new to Python and have made a text-based RPG before in this language. However its been a while since I started using it again so maybe I am having a noob moment. Any help would be greatly appreciated, thanks,

[bvdet]

def load(): # function to load game data
    if os.path.exists('./data.dat') == True: 
        load = open('data.dat', 'r') 
        save = load.readline() 
        if save == "":
            welcome()
        elif save == "1\n" or "1": 
            chce = raw_input("A saved game has been detected. Would you like to load this? Y/N ")
            if chce == "Y" or "y":
                pass # Not came that far yet
            elif chce == "N" or "n":
                welcome()
            else:
                print "Invalid choice please choose Y for yes or N for no."
    else:
        print "Fatal Error: 'data.dat' not detected."
 

This is an excerpt of a text-based RPG I am currently writing. The problem is when I come to line 8 where it asks if I want to load a saved game or not. For some reason I just can't understand it doesn't do what its supposed to do. One: it doesn't give me the "else" section if I type in something other than Y, y, N, n. Two: it doesn't go to my "welcome()" function if I select N or n. I get no errors. The program will just exit when I try one of those things :S

Am I missing something obvious? Perhaps a syntax issue - like a block of code not in the right place. I am not that new to Python and have made a text-based RPG before in this language. However its been a while since I started using it again so maybe I am having a noob moment. Any help would be greatly appreciated, thanks,

Your problem is here:

if chce == "Y" or "y"

It should be:

if chce == "Y" or chce == "y"

This looks better:

if chce.lower() == 'y':

>>> s = 'N'
>>> s == 'y' or 'Y'
'Y'
>>> if s == 'y' or 'Y':
... print "'Y' evaluates True"
...
'Y' evaluates True
>>>

[WhiteRider]

Your problem is here:

if chce == "Y" or "y"

It should be:

if chce == "Y" or chce == "y"

This looks better:

if chce.lower() == 'y':

>>> s = 'N'
>>> s == 'y' or 'Y'
'Y'
>>> if s == 'y' or 'Y':
... print "'Y' evaluates True"
...
'Y' evaluates True
>>>

Silly me, it really was a noob moment. I mean really, what language in earth is smart enough to take 'or' as direct as that. OK back to work!

Thank you for your help bvdet :)

[bartonc]

Silly me, it really was a noob moment. I mean really, what language in earth is smart enough to take 'or' as direct as that. OK back to work!

Thank you for your help bvdet :)

I often use the in operator in order to shorten many combined ors:

if chce in "Yy":
    print 'yep'

[WhiteRider]

Thats great. My code looks a lot neater now. Thanks for sharing that bartonc.

[bartonc]

Thats great. My code looks a lot neater now. Thanks for sharing that bartonc.

Any time, really. And you may call me "Barton".
Thanks for joining us here on the Python Forum at TSDN!

[WhiteRider]

Any time, really. And you may call me "Barton".
Thanks for joining us here on the Python Forum at TSDN!

Thank you for welcoming me Barton! This is a great forum =)