Python program to sort lists

[thatos]

When I run the code in only returns the new list with only the min of the list it doesn't go throughtout the list to return other numbers in the list.

>>>def short(list2):
         while len(list2) != 0:
            new = []
            loop = -1
            a = min(list2)
            for s in list2:
              loop += 1
              if s == a:
                new.append(a)
                list.pop(loop)
                return list2

[ilikepython]

When I run the code in only returns the new list with only the min of the list it doesn't go throughtout the list to return other numbers in the list.

>>>def short(list2):
while len(list2) != 0:
new = []
loop = -1
a = min(list2)
for s in list2:
loop += 1
if s == a:
new.append(a)
list.pop(loop)
return list2

Why are you doing this? There is a built in sorted() function that sorts an itarable and lists have a list.sort() function which sorts in place.

[bartonc]

When I run the code in only returns the new list with only the min of the list it doesn't go throughtout the list to return other numbers in the list.

>>>def short(list2):
         while len(list2) != 0:
            new = []
            loop = -1
            a = min(list2)
            for s in list2:
              loop += 1
              if s == a:
                new.append(a)
                list.pop(loop)
                return list2

The problem here is (and I believe that writing sort routines is very good practice) that you hit the return inside the inner loop. You don't want to return until the whole sort is complete: Also, you are continually making a new, empty list inside the while loop.

def short(list2):
    newList = []  # do this outside to loop
    while len(list2) != 0:
        loop = -1
        a = min(list2)
        for s in list2:
            loop += 1
            if s == a:
                newList.append(a)
                list2.pop(loop)
    return newList

Note, however, that a list sent into this routine will end up empty due to the "pass-by-reference" nature of Python and most other programming languages.

[thatos]

The problem here is (and I believe that writing sort routines is very good practice) that you hit the return inside the inner loop. You don't want to return until the whole sort is complete: Also, you are continually making a new, empty list inside the while loop.

def short(list2):
    newList = []  # do this outside to loop
    while len(list2) != 0:
        loop = -1
        a = min(list2)
        for s in list2:
            loop += 1
            if s == a:
                newList.append(a)
                list2.pop(loop)
    return newList

Note, however, that a list sent into this routine will end up empty due to the "pass-by-reference" nature of Python and most other programming languages.

when I want to sort [3,2,1] it return [1,1,3]

[thatos]

The problem here is (and I believe that writing sort routines is very good practice) that you hit the return inside the inner loop. You don't want to return until the whole sort is complete: Also, you are continually making a new, empty list inside the while loop.

def short(list2):
    newList = []  # do this outside to loop
    while len(list2) != 0:
        loop = -1
        a = min(list2)
        for s in list2:
            loop += 1
            if s == a:
                newList.append(a)
                list2.pop(loop)
    return newList

Note, however, that a list sent into this routine will end up empty due to the "pass-by-reference" nature of Python and most other programming languages.

thanks for your help you helped me a lot and at least I'm improving