unpack problem

[echo]

i have never contacted to python language before this, i want to use the following py file to convert a pgm image to *.coe file, which is initial file of Xilinx memory.And this py file was written by I. Chuang, MIT, downloaded from MIT web site.
i just use python 2.4(for windows idle) to run this file,but it shows error:

Traceback (most recent call last):
File "D:\python\pgm2coe.py", line 31, in -toplevel-
imgbytes = struct.unpack('%dB' % ndat,imgdat)
error: unpack str size does not match format

Thanks for your help!

the py file:pgm2coe.py

#!/usr/bin/python
#
# File:   pgm2coe.py
# Date:   14-Nov-05
# Author: I. Chuang <[e-mail]>
#
# Q&D conversion of PGM format image file to COE file for Xiling FPGA memory
# initialization.
 
import string,re,sys,os,struct
 
fn = "flowers2-bw-320-240"
 
fp = open('%s.pgm' % fn)
 
s = fp.readline()    # P5
 
s = fp.readline()
m = re.compile('([0-9]+) ([0-9]+)').search(s)
nx = string.atoi(m.group(1))
ny = string.atoi(m.group(2))
 
print "nx = %d, ny=%d" % (nx,ny)
 
s = fp.readline()    # maxval
 
ndat = nx*ny
 
imgdat = fp.read(ndat)
 
imgbytes = struct.unpack('%dB' % ndat,imgdat)
 
print "size = %d" % len(imgbytes)
 
fp.close()
 
fp = open('%s.coe' % fn,'w')
 
fp.write("memory_initialization_radix=16;\nmemory_initialization_vector=\n")
 
for j in range(ny):
    for k in range(nx):
    fp.write("%02x," % imgbytes[k+j*nx])
    fp.write("\n");
 
fp.close()

[bartonc]

Try:

imgdat = fp.read()
# ndat = nx*ny
ndat = len(imgdat)#
 
# imgdat = fp.read(ndat)

on lines 26 - 29.

The error that you are getting is due to the calculated size and the actual size differing. One reason could be that the parsing of the size on lines 18 - 21 is not functioning correctly. Or it could be that the entire file is not being read due to buffering. This test should tell which is happening by viewing the result.

[echo]

Try:

imgdat = fp.read()
# ndat = nx*ny
ndat = len(imgdat)#
 
# imgdat = fp.read(ndat)

on lines 26 - 29.

The error that you are getting is due to the calculated size and the actual size differing. One reason could be that the parsing of the size on lines 18 - 21 is not functioning correctly. Or it could be that the entire file is not being read due to buffering. This test should tell which is happening by viewing the result.

thanks for your replying！
i followed your method and solved the problem above, but another error comes out:

>>>
nx = 320, ny=240
size = 13492

Traceback (most recent call last):
File "D:\python\pgm2coe.py", line 45, in <module>
fp.write("%02x," % imgbytes[k+j*nx])
IndexError: tuple index out of range

i am really newbie to python, so hope you can help me again.thanks!
PS: my *.pgm image file is 320x240.

[bartonc]

I've detected "mixed mode" (spaces and tabs) indentation here:

for j in range(ny):
    for k in range(nx):
    fp.write("%02x," % imgbytes[k+j*nx])
    fp.write("\n");

it should look like:

for j in range(ny):
    for k in range(nx):
        fp.write("%02x," % imgbytes[k+j*nx])
    fp.write("\n");

That could be the problem if the indexing math is good (my brain is to fried at the moment to process that part).