Need advice on reading contents of a file into memory

[vinjvinj]

f = open(someFilePath, "rb")
content = []
for data in content.read()
content.append(data)
fullContent = "".join(content)

Is there a more efficient way of doing this? I'll be running this
operation on 10,000+ files where each file is an image file with size
50k-100k

[Felipe Almeida Lessa]

Em Qua, 2006-03-15 Ã*s 13:49 -0800, vinjvinj escreveu:

f = open(someFilePath, "rb")
content = []
for data in content.read()
content.append(data)
fullContent = "".join(content)

Is there a more efficient way of doing this? I'll be running this
operation on 10,000+ files where each file is an image file with size
50k-100k

If you really need everything in memory, why not just...

fullContent = open(someFilePath, "rb").read()

....?

[Fredrik Lundh]

"vinjvinj" wrote:

f = open(someFilePath, "rb")
content = []
for data in content.read()
content.append(data)
fullContent = "".join(content)

Is there a more efficient way of doing this?

read reads until end of file, so unless the source is something unusual,
a plain

fullContent = content.read()

should be good enough (not that it matters much; that join will be in
no-op, and the list/append overhead is marginal compared to the time
required to get the data from disk)

</F>

[vinjvinj]

Thanks. read() did not work when I opened the file with:

f = open(someFilePath)

But after changing to f = open(someFilePath, "rb") the read() works
fine.

VJ