properties vs. eval()

[Bob Rogers]

Given this class:

class C(object):
def set_x(self, x):
self._x = x

def get_x(self):
return self._x

x = property(get_x, set_x)
This use of compile() and eval() works as I expected it to:

c = C()
c.x = 5000
n = '\'five thousand\''
code = compile('c.x = ' + n, '<input>', 'exec')
print 'before ', c.x
eval(code)
print 'after ', c.x

But this, using eval() without compile(), does not:

c = C()
c.x = 5000
n = '\'five thousand\''
print 'before ', c.x
eval('c.x = ' + n)
print 'after ', c.x

It gives:

before 5000
Traceback (most recent call last):
File "./r.py", line 16, in ?
eval('c.x = ' + n)
File "<string>", line 1
c.x = 'five thousand'
^
SyntaxError: invalid syntax

Could someone please explain just what is going on here, and whether it
is possible to dispense with the compile step and use eval() alone
while setting a property?

Thanks.

[Peter Otten]

Bob Rogers wrote:

Given this class:

class C(object):
def set_x(self, x):
self._x = x

def get_x(self):
return self._x

x = property(get_x, set_x)
This use of compile() and eval() works as I expected it to:

c = C()
c.x = 5000
n = '\'five thousand\''
code = compile('c.x = ' + n, '<input>', 'exec')
print 'before ', c.x
eval(code)
print 'after ', c.x
I believe it is an implementation accident that this works.

But this, using eval() without compile(), does not:

c = C()
c.x = 5000
n = '\'five thousand\''
print 'before ', c.x
eval('c.x = ' + n)
print 'after ', c.x

It gives:

before 5000
Traceback (most recent call last):
File "./r.py", line 16, in ?
eval('c.x = ' + n)
File "<string>", line 1
c.x = 'five thousand'
^
SyntaxError: invalid syntax

Could someone please explain just what is going on here, and whether it
is possible to dispense with the compile step and use eval() alone
while setting a property?

Use

eval(s)

to evaluate an expression and

exec s

to execute a statement.

Peter

[Michael Hoffman]

Peter Otten wrote:

Use

eval(s)

to evaluate an expression and

exec s

to execute a statement.

I never thought of using compile() to get around this before. Now I can
finally use print in my lambda functions! Just think of the horrible
code I could write:

f = lambda x: eval(compile("print %s" % x, "<string>", "exec"))
--
Michael Hoffman

[Jason Mobarak]

Why are you using eval in the first place? This isn't bash. Use setattr
and getattr for dynamic attribute access.

[Bob Rogers]

So you're saying you don't know the answer? The question wasn't
"should I use setattr?"

[Steve Holden]

Bob Rogers wrote:

So you're saying you don't know the answer? The question wasn't
"should I use setattr?"

No, the "*question*" was (paraphrasing slightly) "is [it] possible to
dispense with the compile step and use eval() alone while setting a
property" the *answer* was "you should use setattr".

If you don't see that this implies that using eval() is not a good idea
until other resources have been exhausted, then you need to understand:
"using eval() is not a good idea until other resources have been exhausted".

regards
Steve
--
Steve Holden [phone] [phone]
Holden Web LLC http://www.holdenweb.com/
Python Web Programming http://pydish.holdenweb.com/

[Jason Mobarak]

Bob Rogers wrote:

So you're saying you don't know the answer? The question wasn't
"should I use setattr?"

If what you're doing is wrong and backwards then it doesn't matter what
the question is. Best practices are best practices for a reason.
There's no reason to use eval to do what you want. The constructs
eval/exec/compile all have their purposes (for example: a remote python
shell) but they weren't intended to be broken replacements for setattr.