By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
446,137 Members | 1,944 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 446,137 IT Pros & Developers. It's quick & easy.

String find and replace

P: n/a
import os, string
print " "
setpath = raw_input("Enter the path: ")
def find_replace(setpath):
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
find = string.find(file(os.path.join(root,fname),
'rb').read(), 'THIS')
print find
if find >=1:
replace = string.replace(str, 'THIS', 'THAT')
find_replace(setpath)
print " "

Why doesn't this work? I get this error:

Traceback (most recent call last):
File "html_find_replace.py", line 12, in ?
find_replace(setpath)
File "html_find_replace.py", line 11, in find_replace
replace = string.replace(str, 'THIS', 'THAT')
File "/usr/local/lib/python2.3/string.py", line 370, in replace
return s.replace(old, new, maxsplit)
TypeError: expected a character buffer object

Jul 18 '05 #1
Share this Question
Share on Google+
10 Replies


P: n/a

"hokieghal99" <ho********@hotmail.com> wrote in message
news:bi**********@solaris.cc.vt.edu...
import os, string
print " "
setpath = raw_input("Enter the path: ")
def find_replace(setpath):
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
find = string.find(file(os.path.join(root,fname),
'rb').read(), 'THIS')
print find
if find >=1:
replace = string.replace(str, 'THIS', 'THAT')
find_replace(setpath)
print " "

Why doesn't this work? I get this error:

Traceback (most recent call last):
File "html_find_replace.py", line 12, in ?
find_replace(setpath)
File "html_find_replace.py", line 11, in find_replace
replace = string.replace(str, 'THIS', 'THAT')
File "/usr/local/lib/python2.3/string.py", line 370, in replace
return s.replace(old, new, maxsplit)
TypeError: expected a character buffer object
what's "str" in line 11?

John Roth

Jul 18 '05 #2

P: n/a
hokieghal99 wrote:
import os, string
print " "
setpath = raw_input("Enter the path: ")
def find_replace(setpath):
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
find = string.find(file(os.path.join(root,fname), 'rb').read(),
'THIS')
print find
if find >=1:
replace = string.replace(str, 'THIS', 'THAT') ^^^

In your app, what do you think 'str' is?

You haven't defined it, but it still exists. It's the string type, *not*
a particular string (cos you haven't defined it). That's why you get the
error below:
find_replace(setpath)
print " "

Why doesn't this work? I get this error:

Traceback (most recent call last):
File "html_find_replace.py", line 12, in ?
find_replace(setpath)
File "html_find_replace.py", line 11, in find_replace
replace = string.replace(str, 'THIS', 'THAT')
File "/usr/local/lib/python2.3/string.py", line 370, in replace
return s.replace(old, new, maxsplit)
TypeError: expected a character buffer object


-- Gerhard

Jul 18 '05 #3

P: n/a
Thanks for the explanation, I can make it work this way:

import os, string
setpath = raw_input("Enter the path: ")
for root, dirs, files in os.walk(setpath):
fname = files
x = 'THIS'
y = 'THAT'
for fname in files:
myfile = file(os.path.join(root,fname), 'r')
mystr = myfile.read()
myfile.close()
search = string.find(mystr, x)
if search >=1:
string.replace(mystr, x, y)
print "Replacing", x, "with", y, "in", fname

If only I could actually make the change to the files! It works in
theory, but not in practice ;) Anyone recommend how to actual write the
change to the file? I'm new to this, so be kind.

Thanks Everyone!!!

Geoff Gerrietts wrote:
Quoting hokieghal99 (ho********@hotmail.com):
import os, string
print " "
setpath = raw_input("Enter the path: ")
def find_replace(setpath):
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
find = string.find(file(os.path.join(root,fname), 'rb').read(), 'THIS')


^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
this string is never bound to a name
(ie, you never assign str=file(...).read())
print find
if find >=1:
replace = string.replace(str, 'THIS', 'THAT')


^^^
this name is currently bound to
the builtin function str()

find_replace(setpath)
print " "


You might consider the fragment below, instead. It's a couple lines
longer, but safer (your .close() happens exactly when you want it to)
and probably more readable.

for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
myfile = file(os.path.join(root,fname), 'rb')
mystr = myfile.read()
myfile.close()
find = string.find(mystr, 'THIS')
print find
if find >=1:
replace = string.replace(mystr, 'THIS', 'THAT')
Luck,
--G.

Jul 18 '05 #4

P: n/a

"hokiegal99" <ho********@vt.edu> wrote in message
news:3F**************@vt.edu...
Thanks for the explanation, I can make it work this way:

import os, string
setpath = raw_input("Enter the path: ")
for root, dirs, files in os.walk(setpath):
fname = files
x = 'THIS'
y = 'THAT'
for fname in files:
myfile = file(os.path.join(root,fname), 'r')
mystr = myfile.read()
myfile.close()
search = string.find(mystr, x)
if search >=1:
string.replace(mystr, x, y)
print "Replacing", x, "with", y, "in", fname

If only I could actually make the change to the files! It works in
theory, but not in practice ;) Anyone recommend how to actual write the
change to the file? I'm new to this, so be kind.
Are you trying to rename the file? Look under os - Files and Directories
for the rename() function. It's 6.1.4 in the 2.2.3 docs.

John Roth
Thanks Everyone!!!

Geoff Gerrietts wrote:
Quoting hokieghal99 (ho********@hotmail.com):
import os, string
print " "
setpath = raw_input("Enter the path: ")
def find_replace(setpath):
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
find = string.find(file(os.path.join(root,fname), 'rb').read(),
'THIS')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this string is never bound to a name
(ie, you never assign str=file(...).read())
print find
if find >=1:
replace = string.replace(str, 'THIS', 'THAT')


^^^
this name is currently bound to
the builtin function str()

find_replace(setpath)
print " "


You might consider the fragment below, instead. It's a couple lines
longer, but safer (your .close() happens exactly when you want it to)
and probably more readable.

for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
myfile = file(os.path.join(root,fname), 'rb')
mystr = myfile.read()
myfile.close()
find = string.find(mystr, 'THIS')
print find
if find >=1:
replace = string.replace(mystr, 'THIS', 'THAT')
Luck,
--G.


Jul 18 '05 #5

P: n/a
John Roth wrote:
Are you trying to rename the file? Look under os - Files and Directories
for the rename() function. It's 6.1.4 in the 2.2.3 docs.

John Roth


No, I'm trying to find 'this' in files and replace it with 'that'
recursively through a directory. It works, but it doesn't actually
commit the change to the files, it finds 'this' and reports that it
replaced it with 'that', but when I run the scipt again it reports the
same files that it just fixed.

Jul 18 '05 #6

P: n/a

"hokiegal99" <ho********@hotmail.com> wrote in message
news:3F************@hotmail.com...
John Roth wrote:
Are you trying to rename the file? Look under os - Files and Directories
for the rename() function. It's 6.1.4 in the 2.2.3 docs.

John Roth
No, I'm trying to find 'this' in files and replace it with 'that'
recursively through a directory. It works, but it doesn't actually
commit the change to the files, it finds 'this' and reports that it
replaced it with 'that', but when I run the scipt again it reports the
same files that it just fixed.


Oh. You need to open it again for write and write the
changed string back out. The string doesn't have any
persistant connection to the file.

John Roth

Jul 18 '05 #7

P: n/a
hokiegal99 wrote:
I hate to answer my own post, but I think I understand what I'm doing
wrong. I'm finding and replacing 'this' with 'that' in the varible
named
mystr, not the actual files. So, how would I go about making the
change
to the actual files instead of a variable that contains their content?


Easy:

inputFile = file(filename, 'r')
data = inputFile.read()
inputFile.close()
data = data.replace(this, that)
outputFile = file(filename, 'w')
outputFile.write(data)
outputFile.close()

--
Erik Max Francis && ma*@alcyone.com && http://www.alcyone.com/max/
__ San Jose, CA, USA && 37 20 N 121 53 W && &tSftDotIotE
/ \ There never was a good war or a bad peace.
\__/ Benjamin Franklin
Jul 18 '05 #8

P: n/a
Easy for you maybe ;)

That works great. I learn something each time I post to the list. With a
community like this, Python will be around forever!!! Thanks for the help.

Erik Max Francis wrote:
hokiegal99 wrote:

I hate to answer my own post, but I think I understand what I'm doing
wrong. I'm finding and replacing 'this' with 'that' in the varible
named
mystr, not the actual files. So, how would I go about making the
change
to the actual files instead of a variable that contains their content?

Easy:

inputFile = file(filename, 'r')
data = inputFile.read()
inputFile.close()
data = data.replace(this, that)
outputFile = file(filename, 'w')
outputFile.write(data)
outputFile.close()

Jul 18 '05 #9

P: n/a
hokiegal99 wrote:
Thanks for the explanation, I can make it work this way:

import os, string
setpath = raw_input("Enter the path: ")
for root, dirs, files in os.walk(setpath):
fname = files
x = 'THIS'
y = 'THAT'
for fname in files:
myfile = file(os.path.join(root,fname), 'r')
mystr = myfile.read()
myfile.close()
search = string.find(mystr, x)
if search >=1:
string.replace(mystr, x, y)
print "Replacing", x, "with", y, "in", fname

If only I could actually make the change to the files! It works in
theory, but not in practice ;) Anyone recommend how to actual write the
change to the file? I'm new to this, so be kind.


I once wrote a replace recursive script. Maybe it helps you:
http://www.thomas-guettler.de/script...cursive.py.txt

thomas


Jul 18 '05 #10

P: n/a
Thomas Güttler wrote:
I once wrote a replace recursive script. Maybe it helps you:
http://www.thomas-guettler.de/script...cursive.py.txt

thomas


Yes that's very helpful, but a bit too complex for me at this point in
time. Here is the script that I put together from all of the responses I
recieved from the list:

#Thanks to comp.lang.python
import os, string
print " "
print "************************************************* *****"
print " Three Easy Steps to a Recursive find and Replace "
print "************************************************* *****"
print " "
x = raw_input("1. Enter the string that you'd like to find: ")
print " "
y = raw_input("2. What would you like to replace %s with: " %x)
print " "
setpath = raw_input("3. Enter the path where the prgroam should run: ")
print " "
for root, dirs, files in os.walk(setpath):
fname = files
for fname in files:
inputFile = file(os.path.join(root,fname), 'r')
data = inputFile.read()
inputFile.close()
search = string.find(data, x)
if search >=1:
data = data.replace(x, y)
outputFile = file(os.path.join(root,fname), 'w')
outputFile.write(data)
outputFile.close()
print "Replacing", x, "with", y, "in", fname
print " "
print "**********"
print " Done "
print "**********"
print " "

Jul 18 '05 #11

This discussion thread is closed

Replies have been disabled for this discussion.