doubt in update query inside a function

[priyan]

hi all,
I wrote a function in postgre to insert or update a row in to a table. In my function insert query is working fine but updation is not working please help me....

here is my function

CREATE OR REPLACE FUNCTION savequestionbank_quest(pquestionid integer, pquestionbankid integer, pquestion text, pquestionsno integer, pquestionhistory text, pquestionparameter text, pquestionsource text, pquestionbibliograph text)
RETURNS integer AS
$BODY$
Declare questionid integer;
Begin
    if pquestionid=0 then
        insert into questionbank_quest(questionbankid,question,questsno,questhistory,questparamet,questsource,questbibliograp)
             values(pquestionbankid,pquestion,pquestionsno,pquestionhistory,pquestionparameter,pquestionsource,pquestionbibliograph);
        questionid := lastval();
    else 
        update questionbank_quest set questionbankid=pquestionbankid,question=pquestion,questsno=pquestionsno,questhistory=pquestionhistory,
            questparamet=pquestionparameter,questsource=pquestionsource,questbibliograp=pquestionbibliograph where questionid=pquestionid;
         questionid = pquestionid;
    end if;
return questionid;
End
$BODY$
LANGUAGE 'plpgsql' VOLATILE;
 

[priyan]

hi all,
I wrote a function in postgre to insert or update a row in to a table. In my function insert query is working fine but updation is not working please help me....

here is my function

CREATE OR REPLACE FUNCTION savequestionbank_quest(pquestionid integer, pquestionbankid integer, pquestion text, pquestionsno integer, pquestionhistory text, pquestionparameter text, pquestionsource text, pquestionbibliograph text)
RETURNS integer AS
$BODY$
Declare questionid integer;
Begin
    if pquestionid=0 then
        insert into questionbank_quest(questionbankid,question,questsno,questhistory,questparamet,questsource,questbibliograp)
             values(pquestionbankid,pquestion,pquestionsno,pquestionhistory,pquestionparameter,pquestionsource,pquestionbibliograph);
        questionid := lastval();
    else 
        update questionbank_quest set questionbankid=pquestionbankid,question=pquestion,questsno=pquestionsno,questhistory=pquestionhistory,
            questparamet=pquestionparameter,questsource=pquestionsource,questbibliograp=pquestionbibliograph where questionid=pquestionid;
         questionid = pquestionid;
    end if;
return questionid;
End
$BODY$
LANGUAGE 'plpgsql' VOLATILE;
 

Please help me to solve this problem function is running properly and also insertion is taking place but updation alone is not working. Table is not get updated i don't no why it is like this.............please help me to solve this problem...........As soon as possible..............

[amitpatel66]

Please help me to solve this problem function is running properly and also insertion is taking place but updation alone is not working. Table is not get updated i don't no why it is like this.............please help me to solve this problem...........As soon as possible..............

Can you make sure that the data for the pquestionid that is passed as input parameter exists in the table??

and use COMMIT with in the procedure after INSERT and UPDATE statement in order to COMMIT the changes that are made!!