By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
434,685 Members | 1,300 Online
Bytes IT Community
Submit an Article
Got Smarts?
Share your bits of IT knowledge by writing an article on Bytes.

Uploading files into a MySQL database using PHP

Atli
Expert 5K+
P: 5,058
You may be wondering why you would want to put your files “into” the database, rather than just onto the file-system. Well, most of the time, you wouldn’t.

In situations where your PHP application needs to store entire files, the preferred method is to save the file onto the server’s file-system, and store the physical location of the file in your database. This is generally considered to be the easiest and fastest way to store files.

However, you may find yourself in situations where you would want to keep the file itself with the other data in your database. This gives you - or rather: MySQL - complete control over the file data, rather than just the location of the file on the server.

There are some downsides to this method though, such as; decreased performance and added complexity to both your PHP code and your database structure. This is something you should carefully consider before using this in a real-life application.

Having said that, this article demonstrates how you can upload a file from a browser into MySQL, and how to send the files back to the browser.

Before you start
To get through this smoothly, you should be familiar with the following:
The battle plan
As with all programs, before we start writing we need to plan a little ahead. Just so we know what we are going to write before we write it.

Before we start on the program, we need to design the database. This is not a complex design, as we are not talking about creating some complex filing system. We only need a single table, containing a BLOB field for our file and various other fields to store information on our file, such as name, size, type.

Now then. The first phase of the program is getting the file from our users onto the server where our PHP can interact with it. This is the simplest part of the process, requiring only a basic HTML form.

The second phase involves reading the uploaded file, making sure it was uploaded successfully and adding it to the database. This is a similar process as the one used when uploading a file to the file-system, but using the MySQL functions rather than the file-system functions.

The third phase is to list all files that have been uploaded and saved on the database, with a link so it can be downloaded. The only problem here would be the fact that the file does not exists on the server, so how do we create a link to it? That is a problem handled by phase 4, all we need to do in phase 3 is create a link with the ID of the file to be downloaded embedded in the URL.

The fourth, and final, part is the one that is most confusing about this process. The part where we fetch the file and send it to the client's browser.
We start by using the MySQL functions, and the ID sent by phase 3, to fetch the file data from the database. Then we set a few headers, letting the browser know what to expect, before finally sending the contents of the file.

Now, using this summary as a guide, lets start writing our program.

Phase 0: Building a database
The database is simple. One table with a BLOB field for the file data and a few fields for various pieces of information relating to the file:
Expand|Select|Wrap|Line Numbers
  1. CREATE TABLE `file` (
  2.     `id`        Int Unsigned Not Null Auto_Increment,
  3.     `name`      VarChar(255) Not Null Default 'Untitled.txt',
  4.     `mime`      VarChar(50) Not Null Default 'text/plain',
  5.     `size`      BigInt Unsigned Not Null Default 0,
  6.     `data`      MediumBlob Not Null,
  7.     `created`   DateTime Not Null,
  8.     PRIMARY KEY (`id`)
  9. )
  10.  
As you see, we store the file name, including the extension.
We have the mime type, which we use to let the browser know what kind of file we are dealing with.
The size of the file in bytes.
And finally the data itself, in a MediumBlob field.

Phase 1: Uploading the file
Now, we need to get the file from the user. The table we designed does not require any additional information from the user, so we will make this simple and create a HTML form with only a single "file" input field and a submit button:
Expand|Select|Wrap|Line Numbers
  1. <!DOCTYPE html>
  2. <head>
  3.     <title>MySQL file upload example</title>
  4.     <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  5. </head>
  6. <body>
  7.     <form action="add_file.php" method="post" enctype="multipart/form-data">
  8.         <input type="file" name="uploaded_file"><br>
  9.         <input type="submit" value="Upload file">
  10.     </form>
  11.     <p>
  12.         <a href="list_files.php">See all files</a>
  13.     </p>
  14. </body>
  15. </html>
Note the third attribute of the <form> element, "enctype". This tells the browser how to send the form data to the server. As it is, when sending files, this must be set to "multipart/form-data".
If it is set any other way, or not set at all, your file is probably not going to be transmitted correctly.

At the bottom, we have a link to the list we will create in phase 3.

Phase 2: Add the file to the database
In the form we built in phase 1, we set the action property to "add_file.php". This is the file we are going to build it this phase of the process.

This file needs to check if a file has been uploaded, make sure it was uploaded without errors, and add it to the database:
Expand|Select|Wrap|Line Numbers
  1. <?php
  2. // Check if a file has been uploaded
  3. if(isset($_FILES['uploaded_file'])) {
  4.     // Make sure the file was sent without errors
  5.     if($_FILES['uploaded_file']['error'] == 0) {
  6.         // Connect to the database
  7.         $dbLink = new mysqli('127.0.0.1', 'user', 'pwd', 'myTable');
  8.         if(mysqli_connect_errno()) {
  9.             die("MySQL connection failed: ". mysqli_connect_error());
  10.         }
  11.  
  12.         // Gather all required data
  13.         $name = $dbLink->real_escape_string($_FILES['uploaded_file']['name']);
  14.         $mime = $dbLink->real_escape_string($_FILES['uploaded_file']['type']);
  15.         $data = $dbLink->real_escape_string(file_get_contents($_FILES  ['uploaded_file']['tmp_name']));
  16.         $size = intval($_FILES['uploaded_file']['size']);
  17.  
  18.         // Create the SQL query
  19.         $query = "
  20.             INSERT INTO `file` (
  21.                 `name`, `mime`, `size`, `data`, `created`
  22.             )
  23.             VALUES (
  24.                 '{$name}', '{$mime}', {$size}, '{$data}', NOW()
  25.             )";
  26.  
  27.         // Execute the query
  28.         $result = $dbLink->query($query);
  29.  
  30.         // Check if it was successfull
  31.         if($result) {
  32.             echo 'Success! Your file was successfully added!';
  33.         }
  34.         else {
  35.             echo 'Error! Failed to insert the file'
  36.                . "<pre>{$dbLink->error}</pre>";
  37.         }
  38.     }
  39.     else {
  40.         echo 'An error accured while the file was being uploaded. '
  41.            . 'Error code: '. intval($_FILES['uploaded_file']['error']);
  42.     }
  43.  
  44.     // Close the mysql connection
  45.     $dbLink->close();
  46. }
  47. else {
  48.     echo 'Error! A file was not sent!';
  49. }
  50.  
  51. // Echo a link back to the main page
  52. echo '<p>Click <a href="index.html">here</a> to go back</p>';
  53. ?>
  54.  
  55.  
Phase 3: Listing all existing files
So, now that we have a couple of files in our database, we need to create a list of files and link them so they can be downloaded:
Expand|Select|Wrap|Line Numbers
  1. <?php
  2. // Connect to the database
  3. $dbLink = new mysqli('127.0.0.1', 'user', 'pwd', 'myTable');
  4. if(mysqli_connect_errno()) {
  5.     die("MySQL connection failed: ". mysqli_connect_error());
  6. }
  7.  
  8. // Query for a list of all existing files
  9. $sql = 'SELECT `id`, `name`, `mime`, `size`, `created` FROM `file`';
  10. $result = $dbLink->query($sql);
  11.  
  12. // Check if it was successfull
  13. if($result) {
  14.     // Make sure there are some files in there
  15.     if($result->num_rows == 0) {
  16.         echo '<p>There are no files in the database</p>';
  17.     }
  18.     else {
  19.         // Print the top of a table
  20.         echo '<table width="100%">
  21.                 <tr>
  22.                     <td><b>Name</b></td>
  23.                     <td><b>Mime</b></td>
  24.                     <td><b>Size (bytes)</b></td>
  25.                     <td><b>Created</b></td>
  26.                     <td><b>&nbsp;</b></td>
  27.                 </tr>';
  28.  
  29.         // Print each file
  30.         while($row = $result->fetch_assoc()) {
  31.             echo "
  32.                 <tr>
  33.                     <td>{$row['name']}</td>
  34.                     <td>{$row['mime']}</td>
  35.                     <td>{$row['size']}</td>
  36.                     <td>{$row['created']}</td>
  37.                     <td><a href='get_file.php?id={$row['id']}'>Download</a></td>
  38.                 </tr>";
  39.         }
  40.  
  41.         // Close table
  42.         echo '</table>';
  43.     }
  44.  
  45.     // Free the result
  46.     $result->free();
  47. }
  48. else
  49. {
  50.     echo 'Error! SQL query failed:';
  51.     echo "<pre>{$dbLink->error}</pre>";
  52. }
  53.  
  54. // Close the mysql connection
  55. $dbLink->close();
  56. ?>
Phase 4: Downloading a file
This part is the one that usually causes the most confusion.

To really understand how this works, you must understand how your browser downloads files. When a browser requests a file from a HTTP server, the server response will include information on what exactly it contains. These bits of information are called headers. The headers usually include information on the type of data being sent, the size of the response, and in the case of files, the name of the file.

There are of course a lot of other headers, which I will not cover here, but it is worth looking into!

Now, this code. We start simply by reading the ID sent by the link in phase 3. If the ID is valid, we fetch the information on the file who's ID we received, send the headers, and finally send the file data:
Expand|Select|Wrap|Line Numbers
  1. <?php
  2. // Make sure an ID was passed
  3. if(isset($_GET['id'])) {
  4. // Get the ID
  5.     $id = intval($_GET['id']);
  6.  
  7.     // Make sure the ID is in fact a valid ID
  8.     if($id <= 0) {
  9.         die('The ID is invalid!');
  10.     }
  11.     else {
  12.         // Connect to the database
  13.         $dbLink = new mysqli('127.0.0.1', 'user', 'pwd', 'myTable');
  14.         if(mysqli_connect_errno()) {
  15.             die("MySQL connection failed: ". mysqli_connect_error());
  16.         }
  17.  
  18.         // Fetch the file information
  19.         $query = "
  20.             SELECT `mime`, `name`, `size`, `data`
  21.             FROM `file`
  22.             WHERE `id` = {$id}";
  23.         $result = $dbLink->query($query);
  24.  
  25.         if($result) {
  26.             // Make sure the result is valid
  27.             if($result->num_rows == 1) {
  28.             // Get the row
  29.                 $row = mysqli_fetch_assoc($result);
  30.  
  31.                 // Print headers
  32.                 header("Content-Type: ". $row['mime']);
  33.                 header("Content-Length: ". $row['size']);
  34.                 header("Content-Disposition: attachment; filename=". $row['name']);
  35.  
  36.                 // Print data
  37.                 echo $row['data'];
  38.             }
  39.             else {
  40.                 echo 'Error! No image exists with that ID.';
  41.             }
  42.  
  43.             // Free the mysqli resources
  44.             @mysqli_free_result($result);
  45.         }
  46.         else {
  47.             echo "Error! Query failed: <pre>{$dbLink->error}</pre>";
  48.         }
  49.         @mysqli_close($dbLink);
  50.     }
  51. }
  52. else {
  53.     echo 'Error! No ID was passed.';
  54. }
  55. ?>
Any decent browser should be able to read the headers and understand what type of file this is, and that it is to be downloaded, not opened.

The finish line
So, as you see, this is not as complex as one might think.

This code is of course only written for demonstration purposes and I would not recommend using it without adding a little extra security. Un-edited, this code would basically allow anybody to upload anything to your server, which is not a good idea!

I hope this has been helpful, and I wish you all the best.

See you around,
- Atli Þór

Revisions
  • August 20th, 2008 - Replaced the old mysql functions with the improved mysqli functions.
  • December 12th, 2009 - Updated the introduction to include a bit more detail on the pros and cons of this method. Also improved the code structure a bit. Replaced the mysqli procedural functions with their OOP counterparts. (Thanks to kovik for pointing out the need for these changes!)
Nov 23 '07 #1
Share this Article
Share on Google+
218 Comments


ifedi
P: 60
This whole idea of placing files in database BLOB fields, I get the impression it generally isn't a good idea. At least, it does seem quite unpopular. Could you delve a little into the pros and cons of BLOB versus filesystem options for storage of files on the server.
Thanks.
Ifedi.
Feb 15 '08 #2

Markus
Expert 5K+
P: 6,050
This whole idea of placing files in database BLOB fields, I get the impression it generally isn't a good idea. At least, it does seem quite unpopular. Could you delve a little into the pros and cons of BLOB versus filesystem options for storage of files on the server.
Thanks.
Ifedi.
I guess it depends on what type of app you're thinking of
Storing images in a database allows for all of your data to be central stored which is more portable, and easy to replicate. This solution would likely also be easier for taking a point-in-time backup with referential integrity.

Which option you choose would really depend on the type application you’re building in my opinion.

So if you’re building an application with a moderately sized amount of image data, and moderate amount of traffic using a database would be okay as the benefits outway the cost. However if you’re building something like flickr with large amounts of data and high traffic, using the file system would be the advised approach.

I’ve also heard of a combined solution that could provide the best of both world. This is storing your images in the database to gain the benefits there, but also use filesystem caching of these to obtain the performance benefits.
Mar 11 '08 #3

Atli
Expert 5K+
P: 5,058
Hi.

In my mind, the main reason for placing files and images into a database is security and control.

If your files are likely to be accessed very frequently, you may be better of leaving them on the file-system. Fetching them from a database involves a lot of extra overhead which will most likely slow you server down.

If, however, the files you are storing are of a sensitive nature, storing them in a database will give you more control over how they are handled. You could even go as far as splitting them up into multiple fields in multiple tables (even multiple database). It allows you a level of control you will generally not have over you file-system (at least not without jumping through several OS dependent hoops).
Mar 15 '08 #4

P: 10
hi atli..it's me again...
this time i want to ask if there is a simple way to remove files that have been uploaded from database?
now i m using ur coding to upload my files ^_^
thank u so much for the coding and advice
May 19 '08 #5

P: 6
I am new using mysql and php. I tried to follow the example and everything works fine but when I try to download a file, I get the following error message:

Error! Query failed:
Table 'FileStorage.fileStorage' doesn't exist

Any idea what I did wrong?

Any help will be appreciated.
Mar 24 '09 #6

TheServant
Expert 100+
P: 1,168
@msei
I hate to state the obvious but it sounds like you ahve a typo. Look carefully where the word fileStorage was used. Capitals do make a difference, so make sure you didn't mean FileStorage or filestorage. Otherwise paste your download code if you can't see anything and we'll have a look..
Mar 24 '09 #7

P: 6
Thank you for the info. It is working now, but I am having a problem when I view the pdf or doc file on the browser, is there a way to do not show as binary, see file attached. I would like it to be download in the desktop instead view it at the browser? Any help will be appreciated

Thank you in advance.
Attached Images
File Type: png Picture 3.png (7.3 KB, 2188 views)
Mar 25 '09 #8

Markus
Expert 5K+
P: 6,050
@msei
Part 4 of the above article shows you how to download a file.
Mar 25 '09 #9

P: 6
Thanks for the info.
Mar 26 '09 #10

P: 1
Oh, thanks,my friend, !
Mar 27 '09 #11

P: 4
hello;
dose any one can help me?? I found the above code perfect but the thing I would like to know is how can I save the changes that going to be made to the file that been opened? For example... if word file is being open and any thing is changed in it how to save this changes again in mysql db :((
HEEEEELP
Apr 25 '09 #12

Atli
Expert 5K+
P: 5,058
@tweeengl
Hi.

To do that, you would have to update the existing row in the database with the new data.

You could modify the code in phase 2, replacing the INSERT query with an UPDATE query.
May 5 '09 #13

P: 4
thanx very much for your answer but the problem is still the same because cant take the file new changes after being edit I cant take the new size and new data to be able to update them as they have been inserted at the first place :'(
if you can clear that up to me it would be a great help

thanx again
May 9 '09 #14

Atli
Expert 5K+
P: 5,058
The process of updating a file, stored in the manner the article describes, is almost exactly the same as uploading a new file.

If you want to open, edit, and save a Word document stored in a MySQL database, the file would have to be:
  1. Downloaded to a client (Phase #4), where it would be edited.
  2. Uploaded to server again. (Phase #1)
  3. And finally inserted into the database again. (Phase #2, substituting the INSERT command with a UPDATE command).
The only difference between adding a new file and updating an existing one is that in Phase #2, rather than using INSERT to add a new row, you use UPDATE to alter an existing one.

That would of course require the client to pass along the ID of the old row, so it could be updated. You could simply add that to the form in Phase #1, which you would then use in Phase #2 in the UPDATE command.
May 13 '09 #15

P: 4
Thanks very much alti for you respond it was great help for me :))
May 14 '09 #16

P: 26
Hi, I am a newbie here in bytes forum.

I exactly follow the whole script you post, from phase 0 to phase 4. Fortunately there was no error and the codes works fine from phase 0 to phase 3. I have a problem in downloading. When I hit the download link, an error occur.

Here's the error..

Warning: Cannot modify header information - headers already sent by (output started at c:\Inetpub\wwwroot\uploadingfiles\ddl.php:10) in c:\Inetpub\wwwroot\uploadingfiles\ddl.php on line 42

Warning: Cannot modify header information - headers already sent by (output started at c:\Inetpub\wwwroot\uploadingfiles\ddl.php:10) in c:\Inetpub\wwwroot\uploadingfiles\ddl.php on line 43

Warning: Cannot modify header information - headers already sent by (output started at c:\Inetpub\wwwroot\uploadingfiles\ddl.php:10) in c:\Inetpub\wwwroot\uploadingfiles\ddl.php on line 44
Another error was, there's no download pop window appear.

What is seem to be the error. Thanks in advance.
Jun 9 '09 #17

P: 20
hi..
I think you should check the code in the phase 4. Make sure there is no white space before the <?php. It is related to the UTF rules..
Jun 9 '09 #18

Atli
Expert 5K+
P: 5,058
Hi roseple.

ririe is right.
The headers are sent as soon as you start sending content to the browser, at which point you can not alter them (obviously).
If you try, you get that error.

Even a single space before your <?php tags will cause this, as will any echo calls from your scripts.

If there is absolutely no way to avoid sending content before altering the headers, you can use the Output Buffering Control functions to delay sending the content.
Jun 9 '09 #19

P: 26
Thank you Atli and ririe on your reply.

I just check my codes if there is a white space on my download page. But the error is still the same. It does not raise a file download dialog box.

I don't know what to edit/debug anymore.
Thanks guys..
Jun 10 '09 #20

P: 20
Roseple, why don't you attach along your download codes here..
so that we can together see and check the codes.Then we will try to find
the errors...
Jun 10 '09 #21

P: 26
Oh.. oki i will attach the file..

By the way, is mysqli different from mysql?
If i change all mysqli command to mysql, this can cause any problem?
Jun 10 '09 #22

P: 20
MySQLi is designed to work with MySQL 4.1.3 or higher and gives access to more advanced features in MySQL. It requires PHP 5.0 to use. It also gives you more control because you can change MySQL settings using MySQLi without stopping and starting the MYSQL server.
MySQLi is also the OOP version of MySQL extension. MySQLi supports some things that the old MySQL extension doesn't. A lot of people still use the original MySQL extension vs the new MySQLi extension because MySQLi requires MySQL 4.1.13+ and PHP 5.0.7+. However, they both provide access MySQL features.
Jun 10 '09 #23

P: 26
Oh I see. But like me who is a newbie programmer, I still used the original MySql extension. So in above code you gave, I change all the mysqli to mysql. You can see on my attached file.
Expand|Select|Wrap|Line Numbers
  1. <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
  2. <html xmlns="http://www.w3.org/1999/xhtml">
  3. <head>
  4. <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  5. <title>Untitled Document</title>
  6. </head>
  7. <body><?php
  8. # Make sure an ID was passed
  9. if(isset($_GET['id']))
  10. {
  11.     # Get the ID
  12.     $id = $_GET['id'];
  13.  
  14.     # Make sure the ID is in fact a valid ID
  15.     if(!is_numeric($id) || ($id <= 0)) {
  16.         die("The ID is invalid!");
  17.     }
  18.  
  19.     # Connect to the database
  20.     $dbLink = mysql_connect("localhost", "root", "777") or die (mysql_error());
  21.         mysql_select_db("filestorage", $dbLink) or die(mysql_error());
  22.  
  23.     # Fetch the file information
  24.     $query = "
  25.         SELECT FileMime, FileName, FileSize, FileData 
  26.         FROM filestorage 
  27.         WHERE FileID = {$id}";
  28.  
  29.     $result = @mysql_query($query,$dbLink)
  30.         or die("Error! Query failed: <pre>". mysqli_error($dbLink) ."</pre>");
  31.  
  32.     # Make sure the result is valid
  33.     if(mysql_num_rows($result) == 1)
  34.     {
  35.         # Get the row
  36.         $row = mysql_fetch_assoc($result);
  37.  
  38.         # Print headers
  39.         header("Content-Type:".$row['FileMime']);
  40.         header("Content-Length:".$row['FileSize']);
  41.         header("Content-Disposition:attachment;filename=".$row['FileName']);
  42.  
  43.         # Print data
  44.         echo $row['FileData'];
  45.     }
  46.     else
  47.     {
  48.         echo "Error! No image exists with that ID.";
  49.     }
  50.  
  51.     # Free the mysqli resources
  52.     @mysql_free_result($result);
  53.     @mysql_close($dbLink);
  54.  
  55. }
  56. else
  57. {
  58.     echo "Error! No ID was passed.";
  59. }
  60. ?>
  61. </body>
  62. </html>
  63.  
Jun 10 '09 #24

P: 20
Expand|Select|Wrap|Line Numbers
  1. <?php
  2. # Make sure an ID was passed
  3. if(isset($_GET['id']))
  4. {
  5. # Get the ID
  6. $id = $_GET['id'];
  7.  
  8. # Make sure the ID is in fact a valid ID
  9. if(!is_numeric($id) || ($id <= 0)) {
  10. die("The ID is invalid!");
  11. }
  12.  
  13. # Connect to the database
  14. $dbLink = mysql_connect("localhost", "root", "777") or die (mysql_error());
  15. mysql_select_db("filestorage", $dbLink) or die(mysql_error());
  16.  
  17. # Fetch the file information
  18. $query = "
  19. SELECT FileMime, FileName, FileSize, FileData
  20. FROM filestorage
  21. WHERE FileID = {$id}";
  22.  
  23. $result = @mysql_query($query,$dbLink)
  24. or die("Error! Query failed: <pre>". mysqli_error($dbLink) ."</pre>");
  25.  
  26. # Make sure the result is valid
  27. if(mysql_num_rows($result) == 1)
  28. {
  29. # Get the row
  30. $row = mysql_fetch_assoc($result);
  31.  
  32. # Print headers
  33. header("Content-Type:".$row['FileMime']);
  34. header("Content-Length:".$row['FileSize']);
  35. header("Content-Disposition:attachment;filename=".$row['FileName']);
  36.  
  37. # Print data
  38. echo $row['FileData'];
  39. }
  40. else
  41. {
  42. echo "Error! No image exists with that ID.";
  43. }
  44.  
  45. # Free the mysqli resources
  46. @mysql_free_result($result);
  47. @mysql_close($dbLink);
  48.  
  49. }
  50. else
  51. {
  52. echo "Error! No ID was passed.";
  53. }
  54. ?>

Roseple, you just try use the codes above and delete all those thing...

-----delete-----
Expand|Select|Wrap|Line Numbers
  1. <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
  2. <html xmlns="http://www.w3.org/1999/xhtml">
  3. <head>
  4. <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  5. <title>Untitled Document</title>
  6. </head>
  7. <body>
  8. </body>
  9. </html>
-----delete------

The opening for html, head and all the things are not required for this code.As Atli said the headers are sent as soon as you start sending content to the browser, so you can not alter them. If you put the html codes, the program will assume that the header are already sent. So your actually program cannot running properly and you will get errors.
Jun 10 '09 #25

P: 26
Wow, you guys were so great.
It's running properly now. The file download dialog box is now present and I can actually download the file.

Thank you so much.
Jun 10 '09 #26

P: 20
Ok..congratulation roseple..
Good Luck in your work...
Jun 10 '09 #27

P: 26
Hi, roseple again.. :)

If I try to upload an mp3, mpeg and pdf file but an error occurred. Is it because of their file size or the code does not support that said file?

Thanks...
Jun 10 '09 #28

P: 20
well, the code cannot support the mp3 file but it should work for pdf..
Jun 10 '09 #29

P: 26
Even if I try to increase the maximum file size value, pdf file does not work still.
Jun 10 '09 #30

P: 20
show me your codes for upload
Jun 10 '09 #31

P: 26
Oki here's my code.
Expand|Select|Wrap|Line Numbers
  1. <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
  2. <html xmlns="http://www.w3.org/1999/xhtml">
  3. <head>
  4. <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  5. <title>Untitled Document</title>
  6. </head>
  7. <body>
  8. <FORM METHOD="post" ACTION="add_file.php" ENCTYPE="multipart/form-data">
  9. <INPUT TYPE="hidden" NAME="MAX_FILE_SIZE" VALUE="1000000">
  10. <INPUT TYPE="hidden" NAME="action" VALUE="Upload">
  11.  <TABLE BORDER="1" cellspacing="1" cellpadding="3">
  12.   <TR>
  13.    <TD>Subject: </TD>
  14.    <TD><input name="subjects" size = "66%" /></TD>
  15.   </TR>
  16.  
  17.   <TR>
  18.    <TD>Client Name: </TD>
  19.    <TD><input name="clientname" size = "35%" id="clientname" /></TD>
  20.   </TR>
  21.  
  22.   <TR>
  23.    <TD>File: </TD>
  24.    <TD><INPUT type="file" NAME="uploaded_file"></TD>
  25.   </TR>
  26.   <TR>
  27.    <TD COLSPAN="2"><INPUT TYPE="submit" VALUE="Upload"></TD>
  28.   </TR>
  29.  </TABLE>
  30. </FORM>
  31.  
  32.  
  33.  
  34. <?php
  35. # Check if a file has been uploaded
  36. if(isset($_FILES['uploaded_file'])) 
  37. {
  38.     # Make sure the file was sent without errors
  39.     if($_FILES['uploaded_file']['error'] == 0) 
  40.     {
  41.         # Connect to the database
  42.         $dbLink = mysql_connect("localhost", "root", "777") or die (mysql_error());
  43.         mysql_select_db("filestorage", $dbLink) or die(mysql_error());
  44.  
  45.         /*if(mysql_connect()) {
  46.             die("MySQL connection failed: ". mysql_error());
  47.         }*/
  48.  
  49.         # Gather all required data
  50.         $name = mysql_real_escape_string($_FILES['uploaded_file']['name']);
  51.         $mime = mysql_real_escape_string($_FILES['uploaded_file']['type']);
  52.         $size = $_FILES['uploaded_file']['size'];
  53.         $data = mysql_real_escape_string(file_get_contents($_FILES  ['uploaded_file']['tmp_name']));
  54.  
  55.         # Create the SQL query
  56.         $query = "
  57.             INSERT INTO file_upload (
  58.                 FileName, FileMime, FileSize, FileData, subjects, clientname, Created
  59.             )
  60.             VALUES (
  61.                 '{$name}', '{$mime}', {$size}, '{$data}', '{$subjects}','{$clientname}', NOW()
  62.             )";
  63.  
  64.         # Execute the query
  65.         $result = mysql_query($query, $dbLink);
  66.  
  67.         # Check if it was successfull
  68.         if($result) 
  69.         {
  70.             echo "Success! Your file was successfully added!";
  71.         }
  72.         else 
  73.         {
  74.             echo "Error! Failed to insert the file";
  75.             echo "<pre>". mysql_error($dbLink) ."</pre>";
  76.         }
  77.     }
  78.     else 
  79.     {
  80.         echo "Error! 
  81.                 An error accured while the file was being uploaded. 
  82.                 Error code: ". $_FILES['uploaded_file']['error'];
  83.     }
  84.  
  85.     # Close the mysql connection
  86.     mysql_close($dbLink);
  87. }
  88.  
  89. # Echo a link back to the mail page
  90.  
  91. echo "<p><a href='list.php'>Click here to see all Files.</a></p>"; 
  92. ?>
  93. </body>
  94. </html>
  95.  
Jun 10 '09 #32

P: 20
I already try your code but there is nothing wrong with it and I can upload the pdf file. What is actually the error come out??
Jun 10 '09 #33

P: 26
Error! An error accured while the file was being uploaded. Error code: 2
Notice: Undefined variable: dbLink in c:\Inetpub\wwwroot\uploadingfiles\add_file.php on line 86

Warning: mysql_close(): supplied argument is not a valid MySQL-Link resource in c:\Inetpub\wwwroot\uploadingfiles\add_file.php on line 86
Jun 10 '09 #34

P: 20
what is the code on line 82??
Jun 10 '09 #35

P: 20
sorry what is the code on line 86??
Jun 10 '09 #36

P: 26
mysql_close($dbLink); //line 86
Jun 10 '09 #37

P: 26
That warning and error only appear if pdf file was being uploaded.
Jun 10 '09 #38

P: 20
As I remember you said that you are using mysql instead of mysqli..
I think you should change and use mysql as I believe mysql does not support dblink. So better you change all to mysqli..Try it first
Jun 10 '09 #39

P: 20
Sorry I mean you should use mysqli as mysql does not support dblink
Jun 10 '09 #40

Atli
Expert 5K+
P: 5,058
ririe and roseple,

Please use [code] tags when you post you code examples.

[code] code goes here [/code]

Thanks.
Jun 10 '09 #41

P: 20
Sorry Atli...Next time I will use code tag
Jun 10 '09 #42

Atli
Expert 5K+
P: 5,058
The problem there is explained here. (Error code #2).

Your form has a MAX_FILESIZE field, who's value is to low to upload your files:
Expand|Select|Wrap|Line Numbers
  1. <input type="hidden" name="MAX_FILE_SIZE" value="30000" />
Increase that and it should work again.

Also, the error on line #86 has nothing to do with the fact you are using the old mysql extension.
It's because you open your database connection inside the if statement, so when the upload fails it skips it and goes right to the else clause without ever opening it, where it tries to close it, obviously failing.

Edit,
No, on second glance, the mysql_close call is outside the if/else block altogether.
Move it inside the if statement and that error is fixed. (The one on line #86, anyways)
Jun 10 '09 #43

P: 26
Sorry Atli.. next time I will use code tag too.
Jun 10 '09 #44

P: 26
Atli was right, I move the connection of database outside the if statement and the error regrading mysql_close(); was gone.

In max_file_size.. I put 1 000 000. And pdf file is already working, but some pdf file didn't work. Maybe because they are a too large file. Is 1000000, the maximum file size I can put?
Jun 10 '09 #45

Atli
Expert 5K+
P: 5,058
You can simply remove the max_file_size input if it is giving you problems.
It isn't really needed. PHP has it's own size limits that it uses.

The max_file_size input is mostly to give the browser a chance to prevent a file upload that is known to be to large.
Jun 10 '09 #46

P: 26
Hi Atli..

Correct me if I'm wrong.

Error Code:2 = large file
Error code:4 = there's no file to upload

And what is the other error user may encounter using the codes above?
Thanks..
Jun 11 '09 #47

P: 26
Ooops, I got it. Sorry..

You posted that already.

Thanks anyway.
Jun 11 '09 #48

P: 26
Hi Atli,

Why does the link to the next page of this forum is not visible anymore?

Thanks..
Jun 19 '09 #49

Atli
Expert 5K+
P: 5,058
@roseple
I moved some of your posts into their own threads, which made this thread fit into one page again.

Click the "subscriptions" link at the top of the page and you should be able to see them.
Jun 19 '09 #50

218 Comments