How can I make this code simpler and sexier?

[Tyler Harder]

Hello,
I wrote a little chunk of code that explodes a string and uses the string components to access some array data stored in "$instruction_json". The below code is quite repetetive/redundant and I suspect it could be done with just a couple of lines of code instead, but I can`t figure out how. Any takers?

// compile data actually comes from a database, but an example value would be "title.jp", or "title.0.en"
$compile_data = "title.jp";
 
/* $instruction_json is an array of data that was pulled previously from a json file.  it contains things like:
 
"title": {
"en" : "Comforts and Conveniences *1*",
"jp" : "Title Jp 快適さと便利さ *1*",
"kr" : "Title Kr 안락함과 편의 *1*",
"ch" : "Title Ch 舒适和方便 *1*"
}
 
So you can see what the above $compile_data var value "title.jp" is trying to access.  The code below works, but it`s long and messy, and doesn`t work past 10 levels deep (or however many times the code is repeated below).
 
*/
 
// explode instructions
$explode_compile_data = explode( ".", $compile_data );
 
// access via explosion bits
if( count( $explode_compile_data ) == 1 ) { $result_data = $instruction_json[ $explode_compile_data[0] ]; }
elseif( count( $explode_compile_data ) == 2 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ]; }
elseif( count( $explode_compile_data ) == 3 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ]; }
elseif( count( $explode_compile_data ) == 4 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ]; }
elseif( count( $explode_compile_data ) == 5 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ]; }
elseif( count( $explode_compile_data ) == 6 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ]; }
elseif( count( $explode_compile_data ) == 7 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ][ $explode_compile_data[6] ]; }
elseif( count( $explode_compile_data ) == 8 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ][ $explode_compile_data[6] ][ $explode_compile_data[7] ]; }
elseif( count( $explode_compile_data ) == 9 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ][ $explode_compile_data[6] ][ $explode_compile_data[7] ][ $explode_compile_data[8] ][ $explode_compile_data[9] ]; }
elseif( count( $explode_compile_data ) == 10 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ][ $explode_compile_data[6] ][ $explode_compile_data[7] ][ $explode_compile_data[8] ][ $explode_compile_data[9] ][ $explode_compile_data[10] ]; }
 

[Rabbit]

Use a for loop with the count as the termination condition.

[Tyler Harder]

Hi Rabbit,
Thanks, I understand a for loop with a counter will take care of iterations, but I don`t know how to request a different length of results from the "$instruction_json" variable each time.

If you know, could you give me a short example / code snippet example of this?

Tyler

[johny10151981]

I have no idea where you get this kind of array, but try this...

$result_data=$instruction_json;
for($i=0;$i<count($explode_comopile_data);$i++)
{
 $result_data=$result_date[$explode_comopile_data[$i]];
}
echo $result_data;
 

[Tyler Harder]

Hi Johny,
I think the 'for' statement is moving in the right direction, but I can`t see how the syntax for your middle bit is supposed to work (tested it).

Ie. how can the $result_data notation be setup to accept a random number of array keys.

I tried playing with your code snippet, but I can`t get it to work. It seems to return no result.

Tyler

[johny10151981]

just follow the last statement

elseif( count( $explode_compile_data ) == 10 ) { $result_data = $instruction_json[ $explode_compile_data[0] ][ $explode_compile_data[1] ][ $explode_compile_data[2] ][ $explode_compile_data[3] ][ $explode_compile_data[4] ][ $explode_compile_data[5] ][ $explode_compile_data[6] ][ $explode_compile_data[7] ][ $explode_compile_data[8] ][ $explode_compile_data[9] ][ $explode_compile_data[10] ]; }

and compare my code

$result_data=$instruction_json;
 

nothing to say about it

now for loop. it will run through 0 to lenght...

in the first loop in $result_data will get the data of $instruction_json[ $explode_compile_data[0] ]

that is what ever it is holding

thus run through the data only if data structure is correct.

[Tyler Harder]

Hi Johny,
That makes a lot of sense, thanks for the explanation.

I tried it again based on that understanding and it works.

Thanks!!

Tyler

[JKing]

Have you tried giving it long legs and blonde hair?

Ba dum cha!

[johny10151981]

what is your p[oint jking?

anyway got it :)