How to adding variable to conditional?

[Patty Kowaleski]

I have this:

// If the form fields are empty, redirect to the error page.
elseif (empty($email_address) || empty($comments)) {
header( "Location: error_message.html" );
}

I want to add another field to the string. How to do this? The additional field is "name".

Sorry. I'm a novice when it comes to PHP. I have an email form using a file "send_email.php". My contact form simply contains:

Name
Email Address
Comments

If the fields are left empty on the contact form, the form returns an error page asking to answer all questions and resubmit. The php sample file I copied listed only 2 fields if "empty":

email address
comments

I want to add "name" to the string. Not knowing php code, I tried logic...which didn't work for me. Here's the contents of the php file:

<?php
/*
This first bit sets the email address that you want the form to be submitted to.
You will need to change this value to a valid email address that you can access.
*/
$webmaster_email = "[e-mail]";
 
/*
This bit sets the URLs of the supporting pages.
If you change the names of any of the pages, you will need to change the values here.
*/
$contact_page = "contact.htm";
$error_page = "error_message.html";
$thankyou_page = "thank_you.html";
 
/*
This next bit loads the form field data into variables.
If you add a form field, you will need to add it here.
*/
$name = $_REQUEST['name'] ;
$email_address = $_REQUEST['email_address'] ;
$comments = $_REQUEST['comments'] ;
 
/*
The following function checks for email injection.
Specifically, it checks for carriage returns - typically used by spammers to inject a CC list.
*/
function isInjected($str) {
    $injections = array('(\n+)',
    '(\r+)',
    '(\t+)',
    '(%0A+)',
    '(%0D+)',
    '(%08+)',
    '(%09+)'
    );
    $inject = join('|', $injections);
    $inject = "/$inject/i";
    if(preg_match($inject,$str)) {
        return true;
    }
    else {
        return false;
    }
}
 
// If the user tries to access this script directly, redirect them to the feedback form,
if (!isset($_REQUEST['email_address'])) {
header( "Location: $contact_page" );
}
 
// If the form fields are empty, redirect to the error page.
elseif (empty($email_address) || empty($comments)) {
header( "Location: error_message.html" );
}
 
// If email injection is detected, redirect to the error page.
elseif ( isInjected($email_address) ) {
header( "Location: $error_page" );
}
 
// If we passed all previous tests, send the email then redirect to the thank you page.
else {
mail( "$webmaster_email", "Contact Form Submission",
  $comments, "From: $email_address" );
header( "Location: $thankyou_page" );
}
?>

[Markus]

Add an additional field to what string? Having trouble understanding the issue.

Also, your thread title and thread content seem to differ.

[Markus]

I see. You can just extend the ifelse to contain the $name variable:

if ( ... || empty( $name ) )
{
 // Whatever
}
 

[Patty Kowaleski]

To line 53, this is how I added the $name variable:

elseif (empty($email_address) || empty($comments) || empty(&name)) {

It returns this error message:

"Parse error: syntax error, unexpected '&', expecting T_STRING or T_VARIABLE or '$' in /home/drmosko/public_html/send_mail.php on line 53"

Am I still missing something?

[Markus]

The error message gives you all the information you need. Look at the name variable you added, and see if you can spot how it is different to the email_address and comments variables (hint: one character is different).

[Patty Kowaleski]

OMG. The characters looked soooo similar in code. Thanks for all the help. Have a wonderful weekend!!

[Markus]

You, too, Patty. Be sure to come back if you have any more questions.

Mark.