I am a rookie coder and got some great help from Marcus last year so I thought I would make another request.
I am trying to retrieve all boys in one household into a form and edit the individual rows and then update with one submit button.
I can retrieve the rows and populate the form but the update does not work.
Thanks in advance
Here is the testing code obtained from http://www.phpeasystep.com/mysql/10.html -
<body>
-
<strong>Update multiple rows in mysql</strong><br>
-
-
<?php
-
mysql_connect("","","") or die("Error: ".mysqlerror());
-
mysql_select_db("");
-
-
$x='7147010725';
-
$sql = "select * from theboard where hphone = $x";
-
$result = mysql_query($sql);
-
-
// Count table rows
-
$count=mysql_num_rows($result);
-
?>
-
-
<table width="500" border="0" cellspacing="1" cellpadding="0">
-
<form name="form1" method="post" action="">
-
<tr>
-
<td>
-
<table width="500" border="0" cellspacing="1" cellpadding="0">
-
-
-
<tr>
-
<td align="center"><strong>Id</strong></td>
-
<td align="center"><strong>Name</strong></td>
-
<td align="center"><strong>Lastname</strong></td>
-
<td align="center"><strong>Email</strong></td>
-
</tr>
-
<?php
-
while($rows=mysql_fetch_array($result)){
-
?>
-
<tr>
-
<td align="center"><? $id[]=$rows['id']; ?><? echo $rows['id']; ?></td>
-
<td align="center"><input name="first[]" type="text" id="first" value="<? echo $rows['first']; ?>"></td>
-
<td align="center"><input name="last[]" type="text" id="last" value="<? echo $rows['last']; ?>"></td>
-
<td align="center"><input name="email[]" type="text" id="email" value="<? echo $rows['email']; ?>"></td>
-
</tr>
-
-
<?php
-
}
-
?>
-
<tr>
-
<td colspan="4" align="center"><input type="submit" name="Submit" value="Submit"></td>
-
</tr>
-
</table>
-
</td>
-
</tr>
-
</form>
-
</table>
-
<?php
-
// Check if button name "Submit" is active, do this
-
if($Submit){
-
for($i=0;$i<$count;$i++){
-
$sql1="UPDATE theboard SET first='$first[$i]', last='$last[$i]', email='$email[$i]' WHERE id='$id[$i]'";
-
$result1=mysql_query($sql1);
-
}
-
}
-
//what the heck is this???
-
if($result1){
-
header("location:update_multiple.php");
-
}
-
mysql_close();
-
-
?>
-
</body>
-
7  4412 
Re: "What the heck is this???" - It's only progressing to the next page or refreshing the current page (update_multiple.php) if the MySQL query was successful. It is not really for security, but more to save errors coming up for when users ask for funny things.
Have you tried to go through the code yourself to adapt it to your situation? I always prefer rewriting things so I understand each line, and find faster ways to do things.
Is your database structure the same? ie. ID, Name, Lastname, Email? Have you constructed your database?
Yes the code has been adapted to fit my database.
Sorry, didn't read the question correctly. I believe your problem is in your update statement: - for($i=0;$i<$count;$i++){
-
$sql1="UPDATE theboard SET first='$first[$i]', last='$last[$i]', email='$email[$i]' WHERE id='$id[$i]'";
-
$result1=mysql_query($sql1);
Try: - for($i=0;$i<$count;$i++){
-
$sql1="UPDATE theboard SET first='".$first[$i]."', last='".$last[$i]."', email='".$email[$i]."' WHERE id='".$id[$i]."'";
-
$result1=mysql_query($sql1);
The problem is calling array elements in strings.
TheServant,
Is it Sunday or Monday in Australia?
Thanks for the help, but your solution did not work either. When does $submit become true? When does its value get checked?
It appears the for loop is not firing. I added an echo statement inside the loop and it does not show. Also $sql1 does not evaluate to true since it does not go to the page in the header statement.
Any ideas?
It's Monday.
Ahh yes, didn't see that little if statement. You're right, one problem is $submit. It looks like it's missing a few lines of generating the $submit.
You will need to test for whether the submit button has been pressed. However it can also be seen that you have no definitions for $first, $last, $id, $email arrays which you also use.
You will need to have some definitions like: - $Submit = $_POST['Submit'];
-
$first = $_POST['first'];
-
$last = $_POST['last'];
-
$email = $_POST['email'];
You should also be aware that an array's first key is 0, not 1. For ID 1, you will need array(0) - if you do not have someone with an ID of 0...
Also, all that PHP you have at the bottom of your page, should be at the top. The PHP function header('location:...') will not work if there has been ANY output. As in, if you have any HTML sent to the browser, it will not work. That's why it should be at the top.
Honestly, it's not very good code, and again, I recommend a do over.
It was the only code I could find that attempted to update multiple rows on one submit.
I understand how set the variables from the $_POST as you show above. I have done that many times. What I don't know how to do is set $_POST variables from the array.
In other words there will be more than one $first, $last etc. Would a loop work on the page receiving the form POST?
Sorry for my lack of knowledge but I am learning as I go.
No problem.
When you have something like name="email[]" then an array is sent in the POST variable: $_POST['email']
That means when you assign another variable to that: - $new_var = $_POST['email'];
It will assign the variable (which is an array) to the $new_var. So your POST variable can be an array of arrays.
As far as I can see that looping should work, however, I am a bit too busy to try it myself at the moment. ** Where is $count set?
I didn't mean to insult you, but there is not variable assignment in the code you posted. So I am guessing that you have not posted it all?
I will share some logic of how I would set up your page: - if (page request is from submitting a form) {
-
Go through and validate $_POST and update MySQL table with values
-
Set $message = "Table successfully updated";
-
}
-
-
Call data from MySQL table
-
Print HTML and make the form submit to the current page
-
if (isset($message)) {
-
echo $message;
-
}
-
That way, there is no header changes, your update code only runs if a form was submitted, but the rest of the page loads the same all the time. Also all of your PHP is at the top, and all your HTML is at the bottom - which is a good practice to get into.
Sign in to post your reply or Sign up for a free account.
Similar topics
by: scott |
last post by:
Hi,
I'm having some trouble with something that should be relatively easy. I
want to update multiple rows in one of my database tables simultaneously.
In my table I have these values:
...
|
by: Chefry |
last post by:
I'm trying to set up an off the shelf script and keep getting an error.
My host set up the mysql on my site and I changed the variables I had to in the
settings.php file but I keep getting the...
|
by: mlrehberg |
last post by:
Hi,
New to writing sql script
I get this error in my sql script
Server: Msg 512, Level 16, State 1, Line 1
Subquery returned more than 1 value. This is not permitted when the
subquery...
|
by: EmbersFire |
last post by:
I'm using a stored proceedure which should update a number of rows in a
table depending on a key value supplied (in this case 'JobID'). But
what's happening is when I call the proc from within the...
|
by: ameshkin |
last post by:
I know this is probably not too hard to do, but how do I display
multiple rows of a mysql query/recordset. Im having trouble doing
this. I don't just want to display them, but I want to make sure...
|
by: EOZyo |
last post by:
Hi, I would like to share this small script with you, i was looking for
2 days all over the net and i could find anything like this, thus i
decided to create one, i hope it could help somebody :)
...
|
by: Rocketfuel |
last post by:
Hi All
I have the following query in a vb program that inserts multiple rows in a table. The database resides on a server running SQL Server 2005.
Insert into TableX values...
|
by: stepterr |
last post by:
I have a form that is built based on a query. Everything is working except when I submit the form the radio buttons are only updating the first row in my database. dcategory and dthumbnail are two...
|
by: bilibytes |
last post by:
hi,
i am trying to UPDATE multiple rows with mysql. I know how to do it with multiple queries but i think it would be less resource consuming generating mysql query code with php and update all...
|
by: wozza |
last post by:
hi
I'm a Dreamweaver user who's created a few simple data entry/
registrations forms in my time, but I'm not really a coder (though I
can follow instructions and am not afraid to dabble...) - I...
|
by: Faith0G |
last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome former...
|
by: taylorcarr |
last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: ryjfgjl |
last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
|
by: ryjfgjl |
last post by:
In our work, we often receive Excel tables with data in the same format. If we want to analyze these data, it can be difficult to analyze them because the data is spread across multiple Excel files...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: Sonnysonu |
last post by:
This is the data of csv file
1 2 3
1 2 3
1 2 3
1 2 3
2 3
2 3
3
the lengths should be different i have to store the data by column-wise with in the specific length.
suppose the i have to...
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
| |
