INSERT MySQL query always causing an error.

[dgourd]

I am trying to create a registering script, but everytime I try to insert the data into my database i get an error.

$query = "INSERT INTO members (username, pass, email, first_name, last_name) VALUES ($username, $password, $email, $f_name , $l_name);";
$q = mysqli_real_query($dbc, $query);
if($q) {
    // My code goes here
} else {
    // Display an error
}
 

Everytime, $q returns false and goes to the else clause which displays the error. I am sure the database is set up properly, but I can't figure out why it is always returning false.

[Atli]

What is the error?

I would guess it has to do with the fact that the string values in your VALUES clause are not quoted. All strings inside MySQL queries need to be enclosed in single-quotes, or they will be parsed as SQL commands rather than string values.

<?php
// INCORRECT
$sql = "INSERT ... VALUES($name, $password)";
 
// Correct
$sql = "INSERT ... VALUES('$name', '$password')";
?>

[dgourd]

Thank you very much. I was putting the single quotes on the column names instead of the values.