delete based on input

[angelicdevil]

wat i m trying to do is delete a line from the xml based on the line generated i.e $mybody dynamically from the values entered by the user.

in the code i provide...it simply adds a line </gallery> belowe the existing line of </gallery> and the line echoing $temp and $arr[i] do not display it shows a icon similar broken page. just run the code n u will understand wat i m saying.

<?php
$myheading="";
$mylink="";
$mybody="";
 
if (isset($_POST['submit'])) {
 
$mylink = $_POST["link"];
$myheading = $_POST["heading"];
 
$mybody = '<image heading="'.$myheading.'" links="'.$mylink.'"/>';
 
    $start = "<gallery>";
    $end = "</gallery>";
    $file = "article.xml";
    $i=$len=0;
    $arr=array();
    $handle = fopen($file, "r");
    if ($handle) {
        while (!feof($handle)) {
            $temp = fgets($handle);
            echo $temp;
            if ($temp=="$start"){
            $arr[$i]="$start";
            $i++;
            }
            if($temp=="$end"){ $arr[$i]="";
            $i++;
            }
            if ($temp !="$start" && $temp !="$end" && $temp != $mybody){
             $arr[$i]="$temp";
             $i++;
            }            
        }
        $len=$i;
        fclose($handle);
    }
    $handle = fopen($file,"w");
    if ($handle) {
        $i=0;
        while ($i<$len) {              
            fwrite($handle,$arr[$i]);
            echo $arr[$i];
            $i++;            
        }
        fwrite($handle,"\n$end");
        fclose($handle);
        $process="complete";
    }
    else {
     $process="incomplete";
    }
 
 
 
}
 
?> 
<table id="structure">
    <tr>
        <td id="page">
            <h2>delete data</h2>
            <?php if (!empty($process)) {echo "<p class=\"message\">" . $process . "</p>";} ?>
 
            <form action="delete_p.php" method="post">
            <table>
                <tr>
                    <td>heading</td>
                    <td><input type="text" name="heading" maxlength="23" value="<?php echo htmlentities($myheading); ?>" /></td>
                </tr>
                <tr>
                    <td>links</td>
                    <td><input type="text" name="link" maxlength="40" value="<?php echo htmlentities($mylink); ?>" /></td>
                </tr>
                <tr>
                    <td colspan="2"><input type="submit" name="submit" value="delete data" /></td>
                </tr>
            </table>
            </form>
        </td>
    </tr>
</table>
 
 

here's the xml file

<gallery>
<image heading="google" links="google"/>
<image heading="reidff" links="rediff"/>
<image heading="g" links="g"/>
<image heading="jerk" links="jerk"/>
<image heading="jack" links="jack"/>
</gallery>
 
 

[Dormilich]

the line echoing $temp and $arr[i] do not display it shows a icon similar broken page.

neither of them produces valid HTML. and if I read fgets() right, the line break is included and thus neither of your conditions match.

[angelicdevil]

ok so wat shud i do?

[Dormilich]

I’m not sure why you want to edit the XML this way.

[angelicdevil]

just testing various ways. so what do i need to do now to get this working as i dont think the values r being put into the arr[i] and re written

[Dormilich]

maybe there is a better way of doing this …

[angelicdevil]

of wat? deleting from xml? how ... currently it creates a array from the data i want after comparing it with $start $end and $mybody...and then writes this array to the xml....

wat other way?

[Dormilich]

depending on the circumstances, you can also read the file in a string and do a string replacement.

[angelicdevil]

isnt that what i m doing currently

[Dormilich]

you’re doing it linewise and you are using an array. I don’t see string replacement involved.

see also
str_replace()
file_get_contents()
file_put_contents()

[angelicdevil]

in the line 31 doesnt it add the string in the $temp to the array?

doesnt $temp hold the line from the xml?

[Dormilich]

in the line 31 doesnt it add the string in the $temp to the array?

only if the condition is met.

PS. easy appending an element to an array:

$arr[] = "new value";

[angelicdevil]

ok so when the condition is met it shud add right...but in the script it does show the existing contents of the file but add an additional </gallery> again below the one already existing...y is tht so? and it writes the content too when the condition is not met.

[angelicdevil]

can u plz test the code on localhost u will understand wat i say.

[angelicdevil]

in the line 21 doesnt $temp hold the string line from the xml file?

[Dormilich]

upon testing the script does what it should do. and may I remind you of what I said in post #2?

[angelicdevil]

how do i get rid of linebreak?

[angelicdevil]

but the linebreak is /> which is part of the script so if i use str replace wont it get rid of that too?

[angelicdevil]

i have put the lines

 $temp =str_replace("\r", "", $temp);
            $temp =str_replace("\n", "", $temp);
 

below line 21 to remove line break but it still doesn't delete the line that matches the entered value but instead it all in 1 line.

[Dormilich]

but instead it all in 1 line.

obviously, you remove every line break in the file (which doesn't matter from the XML-point-of-view).

judging from my test you don't need to worry about the line breaks. but it still seems like overkill to do it this way.

[angelicdevil]

but y isnt it overwriting cthe existig file properly

[angelicdevil]

ol one thing when i echo back $start or $ end they r empty they r not echoing back anything y is tht so?

[angelicdevil]

how can i get php to trest < or > as string

[Dormilich]

for a change, try the functions mentioned in post #10.