additional variable breaks script

why wont this script work, i added the operator2 variable an it stopped working

Expand|Select|Wrap|Line Numbers

 <html>
 
<head>

<title>A Metric/Imperial Converter</title>

</head>

<body>
 
<?php
 
$number1 = $_POST[number1];

$operator = $_POST[operator];
 
if ($operator == "Miles"){

$answer = $number1*1.609;

$operator2 = "Kilometers";

}
 
elseif ($operator == "Kilometers"){

$answer = $number1/1.609;

$operator2 = "Miles";

}
 
elseif ($operator == "Inches"){

$answer = $number1*2.54;

$operator2 = "Centimetres";

}
 
elseif ($operator == "Centimetres"){

$answer = $number1/2.54;

$operator2 = "Inches";

}
 
elseif ($operator == "Pounds"){

$answer = $number1*0.454;

$operator2 = "Kilograms";

}
 
elseif ($operator == "Kilograms"){

$answer = $number1/0.454;

$operator2 = "Pounds";

}
 
elseif ($operator == "Horsepower"){

$answer = $number1*0.746;

$operator2 = "Kilowatts";

}
 
elseif ($operator == "Kilowatts"){

$answer = $number1/0.746;

$operator2 = "Horsepower";

}
 
elseif ($operator == "Pints"){

$answer = $number1*0.568;

$operator2 = "Litres";

}
 
else {

$answer = $number1/0.568;

$operator = "Litres";

$operator2 = "Pints";

}
 
echo "$number1 $operator is equal to $answer $operator2";
 
?>
 
<br>
 
<a href="Metricconvert.php/">Click here to do another conversion</a>
 
</body>
 
</html>

Nov 5 '09 #1

Subscribe Post Reply

✓ answered by Markus

Please see Turn On PHP Debugging Messages.

Another problem with your code (that will be shown when you turn on error reporting: Array indexes should be wrapped with quotes (single or double). Consider the following:

Expand|Select|Wrap|Line Numbers

 
// bad

echo $array[some_index];

// good

echo $array['some_index'];

Mark.

1822

Dormilich

8,658

Expert Mod 8TB

if you don’t submit a form via post method, the $_POST array is empty.

this would have thrown a warning, if error reporting was enabled.

Nov 5 '09 #2

Markus

6,050

Expert 4TB

Expand|Select|Wrap|Line Numbers

 
// bad

echo $array[some_index];

// good

echo $array['some_index'];

Mark.

Nov 5 '09 #3

Dormilich

8,658

Expert Mod 8TB

@Markus
there is only one exception, and it nearly never occurs.

Expand|Select|Wrap|Line Numbers

 define("some_index", "some_value");

$array[some_index];

// is now equivalent to

$array["some_value"];
 
// but writing constants in lower case is considered bad practice

Nov 5 '09 #4

Markus

6,050

Expert 4TB

@Dormilich
You know I know that! But in the context, I highly doubt he has these set as constants.

Nov 5 '09 #5

Dormilich

8,658

Expert Mod 8TB

just to have it posted for the next reader...

Nov 5 '09 #6

habilatate83

Expand|Select|Wrap|Line Numbers

 <?php
 
$number1 = $_POST[number1];

$operator = $_POST[operator];
 
if ($operator == "Miles"){

$answer = $number1*1.609;

$operator2 = "Kilometers";

}
 
elseif ($operator == "Kilometers"){

$answer = $number1/1.609;

$operator2 = "Miles";

}
 
elseif ($operator == "Inches"){

$answer = $number1*2.54;

$operator2 = "Centimetres";

}
 
elseif ($operator == "Centimetres"){

$answer = $number1/2.54;

$operator2 = "Inches";

}
 
elseif ($operator == "Pounds"){

$answer = $number1*0.454;

$operator2 = "Kilograms";

}
 
elseif ($operator == "Kilograms"){

$answer = $number1/0.454;

$operator2 = "Pounds";

}
 
elseif ($operator == "Horsepower"){

$answer = $number1*0.746;

$operator2 = "Kilowatts";

}
 
elseif ($operator == "Kilowatts"){

$answer = $number1/0.746;

$operator2 = "Horsepower";

}
 
elseif ($operator == "Pints"){

$answer = $number1*0.568;

$operator2 = "Litres";

}
 
elseif ( $operator == "litres"){

$answer = $number1/0.568;

$operator2 = "Pints";

}
 
else {

echo "An error has occured please go back and try again";

}
 
echo "$number1 $operator is equal to $answer $operator2";
 
?>

Nov 10 '09 #7

TheServant

1,168

Expert 1GB

Welcome to Bytes. Please use [code] tags around your code so that we can read the code easier and assist you a lot faster. Your title tells us that something is not working, but that's about it. You need to give more details. It sounds like all the others are working, and you're not getting the "An error has occured please go back and try again" error, so what error are you getting?

The only difference I have noticed is your litres and Litres difference in the last one.

Nov 10 '09 #8

Dormilich

8,658

Expert Mod 8TB

the reasons your script fails has already been mentioned by Markus and me.

Nov 10 '09 #9

habilatate83

thanks, i have resolved the problem mate, much appreciated

Nov 10 '09 #10

by: Bryan Ashby | last post by:

All, I'm looking for a way to define a "dummy" variable in JavaScript; specifically for the window object. I would like to define a window object that would normally be generated with...

Javascript

Declaring/populating variable arrays in ASP.NET???

by: Friday | last post by:

Sorry if this is the wrong group. I tried to find the one I thought would be most relevant. I'm an old PHP guy, who knows little about asp and NOTHING about asp.net, but need to learn at least...

.NET Framework

for loops.....code breaks

by: Hemanth | last post by:

Hello there, I'm trying to read an excel worksheet (with more than 5000 rows and 30 columns) using PHP. I'm using the "excelreader" script I found over the web -...

PHP

asp:Wizard inside of a asp:FormView breaks two-way databinding

by: John R. Lewis | last post by:

I posted this yesterday with a different email address. I am reposting with my fake-address as given to me by Microsoft so that I can be guraranteed a response from a support representative. Sorry...

ASP.NET

How to show variable on webpage?

by: brett | last post by:

I'd like to display a string variable on a webpage depending if the URL has "localhost" in it or not. The string variable will have line breaks and this text: <script type="text/javascript"...

ASP.NET

essay on jibbering says that variable instantiation is done for all local variables of a function?

by: Jake Barnes | last post by:

I saw this sentence: "The last stage of variable instantiation is to create named properties of the Variable object that correspond with all the local variables declared within the function." ...

Javascript

Add paragraph breaks in textarea

by: ThunStorm | last post by:

I have a script that is working but I can't figure out how to add paragraph breaks into the textarea. Can anyone help me? If you run the script, the problem will be easier to understand. If...

Javascript

Additional help needed with preserving textarea CR/LF

by: zjw2112 | last post by:

Hello. I have some javascript code that dynamically creates a textarea and sets the wrap value to hard, which I thought would preserve CR/LF in the textarea: var otherTextArea =...

Javascript

Unable to get line-breaks for a JavaScript 'alert' message using ClientScript.RegisterStartUpScript

by: Wayne Deleersnyder | last post by:

Hi All, I'm trying to create a function that will cause a pop-up alert to appear if dates which were chosen from a drop-down list were invalid on a page. There's 4 dates, so there's the...

C# / C Sharp

Easy Steps to Fix "Canon Printer Won't Connect to WiFi Network"

by: taylorcarr | last post by:

A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...

General

How to turn on java script in a villaon keypad mobile phone

by: Charles Arthur | last post by:

How do i turn on java script on a villaon, callus and itel keypad mobile phone

Java

Basic Javascript concepts

by: aa123db | last post by:

Variable and constants Use var or let for variables and const fror constants. Var foo ='bar'; Let foo ='bar';const baz ='bar'; Functions function $name$ ($parameters$) { } ...

Javascript

Batch import of multiple excel files into the database

by: ryjfgjl | last post by:

If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...

Data Management

Migrating Website to Cloud - Emmanuel Katto

by: emmanuelkatto | last post by:

Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud. Please let me know. Thanks! Emmanuel

General

Navigating the Data Structures and Algorithms (DSA)

by: BarryA | last post by:

What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...

Algorithms / Advanced Math

What is ONU?

by: marktang | last post by:

ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...

General

Problem With Comparison Operator <=> in G++

by: Oralloy | last post by:

Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers,...

C / C++

Maximizing Business Potential: The Nexus of Website Design and Digital Marketing

by: jinu1996 | last post by:

In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...

Online Marketing

additional variable breaks script

✓ answered by Markus

Similar topics