How can i reuse function

[luckysanj]

Hello Sir,

I have an one problme when inserting data.

I want to insert data through function cuz of reuse function.

function add_rec($tbl,$flds,$val)
    {
    $sql="insert into $tbl ($flds) values($val)";
    $sql_result=mysql_query($sql) or die(mysql_error());
    return($sql_result); 
    }

I have create this function on one file.

& i want to use this function when we insert data from multiple tables or different fields.

So can u guide me How can i reuse this function when we insert multiple data from multiple fields.

Like: Employee Records from one table to one database table.tbl_emp_record
CompanyInfromation from one table to another database table eg: tbl_company

[dlite922]

A function cannot magically guess your SQL format, you have to pass it all the values, like you have. Except in your example you don't passin the MySQL link (a database resource created by calling mysql_connect())

pass that in like mysql_query($sql,$dbLink) and you'll be good to go.

You should look into a DA (Data Accessor) class and design your app with OOP. But that's after you have a good understanding of PHP.



Dan

PS -- You $fld and $val, I assume will be arrays, need to be implode()ed with a comma and quotes like this: $fieldStr = "'" . implode("','",$fld) . "'"; THEN insert it into the query. same with $val.

[Canabeez]

As dlite922 said, you should use a mySQL link for this to work, I'd do something like:

$dbLink = mysql_connect('YOUR_HOST','YOUR_USER','YOUR_PASS');
mysql_select_db('YOUR_DATABASE', $dbLink);
 
function addData($TableName,$Fields,$Values)
{
    global $dbLink;
    $query = "
        INSERT INTO {$TableName} (".(is_array($Fields)?implode(",",$Fields):$Fields).") 
                          VALUES (".(is_array($Values)?implode(",",$Values):$Values).");
    ";
    return ($result = mysql_query($query, $dbLink)) ? $result : false;
}
 

[luckysanj]

$link=mysql_connect("localhost","root","") or die("Connection Failed");
mysql_select_db("query",$link) or die("Failed Connecting To Database");
$tblname='tbl1';
$field=array('name','address');    
$data=array($name,$address);
echo $success=InsertData($tblname,$field,$data);
function InsertData($TblName,$Fields,$Values)
{
global $link;
 $query="INSERT INTO $TblName(".(is_array($Fields)?implode(",",$Fields):$Fields).") VALUES(".(is_array($Values)?implode(",",$Values).")";
return ($result=mysql_query($query,$link))?$result:false;
}

I Use this one function but can not work. plz where is my problem ..

[luckysanj]

I used this above method like:

$fieldStr = "'" . implode("','",$fld) . "'"; 

And It works very nicely & i feel happy. But have done this above second method too. but it doesn't work means it gives error on line number 10 like this ";" error.

I want to know or solve through Canabeez Newbie method for my good programming. So plz as possible give us error free codes.

Thank You.

[luckysanj]

$field=array('name','address');    
echo $new=is_array($field)?implode(",",$field : $field);

In the above code this error is occur.

Parse error: syntax error, unexpected ':' in D:\xampp\htdocs\my\test\query\check.php on line 2

.

Plz where is my problem..

[Dormilich]

",",$field : $field is not a correct call for implode(). you probaby meant

$new=is_array($field)?implode(",",$field) : $field;

[luckysanj]

I can't understand what have suggest...plz can u clear me plz

[Dormilich]

you're simply mixing up the ternary conditional operator and the implode() function call.

essentially, it all is described in the error message (colons have a special meaning in PHP (unless they are part of a string))

[luckysanj]

    <?php
    foreach($_POST as $key=>$value)
        { 
        $key.":-".$$key=$value;
        }
    $link=mysql_connect("localhost","root","") or die("Failed Connecting to Database");
    mysql_select_db("query",$link) or die("Failed Connecting To Database");    
 
    $tblname='tbl1';
    $field=array('name','address');    
    $value=array($name,$address);  
 
    echo $success=InsertData($tblname,$field,$data); 
 
    function InsertData($TblName,$Fields,$Values) 
        { 
        global $link; 
        $query="INSERT INTO $TblName(".(is_array($Fields)?implode(",",$Fields):$Fields).")
                VALUES(".(is_array($Values)? "'".implode("','",$Values).")";
 
                return ($result=mysql_query($query,$link))?$result:false; 
        } 
 
    ?>

Plz i m frustration from this problem. so plz as you don't mind plz rectify my error & give me errror free code. plz plz

[Markus]

@luckysanj
First off, 'plz' is spelled 'please'. Adding extra 'z's to the end of this word only makes you look less intelligent. Secondly, please do not beg for code (see point 3). Thirdly, we, as a community, do not just hand out code. After reading your posts, you show little intuition, and I would not be surprised if you got 0 responses from now on.

I apologise for the rant - been a long (but beautiful (weather-wise)) day.

Now, if you'd like to explain what errors you're getting (what is being reported), in clear, concise English, I'm sure we can solve this problem.

Mark (apologies again if I sounded rude before).

[luckysanj]

Thank You Very much .

[luckysanj]

ok, I want to Select, Insert, Update & Delete data through one function by passing values through array. which function is constant. & I am inserting data through function variable like $TblName,$Fields,$Values.

The above code line number 18 have one problem. I didn't correct this problem yet. & How can i correct the error.

[Canabeez]

@luckysanj
First with the error, here's the fix I can see:

function InsertData($TblName,$Fields,$Values) 
{ 
   global $link; 
   $query="INSERT INTO `{$TblName}` (`".(is_array($Fields)?implode("`,`",$Fields):$Fields)."`) 
           VALUES (".(is_array($Values)? "'".implode("','",$Values)."')";
 
   return ($result=mysql_query($query,$link))?$result:false; 
}

Now, about mySQL function, there are tons of classes and additions to the regular, built-in mysql functions in PHP, which are probably the best way to work with mysql.

Here's an Example.

[luckysanj]

Still I have got error .

This is my index.php page:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Multiple Data entry with one query</title>
</head>
<body>
 
<form id="form1" name="form1" method="post" action="check.php">
  <table width="200" border="1">
    <tr>
      <td colspan="2">Pesonal Info Table 1 </td>
    </tr>
    <tr>
      <td width="72">Name:</td>
      <td width="112"><input name="name" type="text" id="name" value="Ashok" /></td>
    </tr>
    <tr>
      <td>Address</td>
      <td><input name="address" type="text" id="address" value="Kathmandu" /></td>
    </tr>
    <tr>
      <td><input name="submit1" type="submit" id="submit1" value="Submit" /></td>
      <td><input type="reset" name="Submit2" value="Reset" /></td>
    </tr>
  </table>
</form>
</br>
</br>
</body>
</html>
 

This is my another page: check.php

    <?php
    foreach($_POST as $key=>$value)
        { 
        $key.":-".$$key=$value;
        }
    $link=mysql_connect("localhost","root","") or die("Failed Connecting to Database");
    mysql_select_db("query",$link) or die("Failed Connecting To Database");    
 
    $tblname='tbl1';
    $field=array('name','address');    
    $value=array($name,$address);  
 
    echo $result=InsertData($tblname,$field,$value);
 
    function InsertData($TblName,$Fields,$Values)  
        {  
        global $link;  
        $query="INSERT INTO `{$TblName}` (`".(is_array($Fields)?implode("`,`",$Fields):$Fields)."`) 
        VALUES (".(is_array($Values)? "'".implode("','",$Values)."')"; 
 
        return ($result=mysql_query($query,$link))?$result:false;  
        } 
    ?>
 
 
 

Error is :Parse error: syntax error, unexpected ';' in D:\xampp\htdocs\my\test\query\check.php on line 20

[Canabeez]

Try this

$query="INSERT INTO `{$TblName}` (`".(is_array($Fields)?implode("`,`",$Fields):$Fields)."`) 
        VALUES (".(is_array($Values)? "'".implode("','",$Values))."')";
 

[luckysanj]

Now this error occur on the above php code:

Parse error: syntax error, unexpected ')' in D:\xampp\htdocs\my\test\query\check.php on line 21
 

[luckysanj]

On

$query="INSERT INTO `{$TblName}` (`".(is_array($Fields)?implode("`,`",$Fields):$Fields)."`)  
        VALUES (".(is_array($Values)? "'".implode("','",$Values))."')"; 

[Canabeez]

Sorry, my bad

$query="INSERT INTO `{$TblName}` (`".(is_array($Fields)?implode("`,`",$Fields):$Fields)."`) VALUES (".(is_array($Values)?"'".implode("','",$Values)."'":$Values).")";

I think now it should work ;)

[luckysanj]

Ya Sir, It works. Thank you very much for ur cooperation.

[Canabeez]

No problem, Good Luck ;)