how can i prevent blank upload

[simon2x1]

the code below will upload image and insert the image name and other variable into the database but i dont want the upload feild to post a blank field and also not
to allow any image which is not gif, jpeg and png. the code that i have that can do the folowing are if($_FILES['images']['size'] == 0){ and if (!eregi("^([A-Za-z0-9]+)\.jpg|\.gif|\.png$", $logoname))
but the problem is i dont know where to insert it in the code below (upload.php) i try inserting it but did not working

<?php
 
        if (isset($_POST['submit'])) {
          If(empty($_POST['fristname']) OR empty($_POST['emaill'])OR empty($_POST['category'])){
              echo '<font size="2" color="#FF0000">Please fill in all the required fields!</font>';
         }else{
 
                    $logoname = $_FILES['images']['name'];
                    $tmpname  = $_FILES['images']['tmp_name'];
                    $logosize = $_FILES['images']['size'];
                       $logotype = $_FILES['images']['type'];
 
 
 
             while(list($key,$value) = each($_FILES['images']['name'])){
             if(!empty($value)) {
                 $logoname = $value;
                     $logoname = str_replace(" ","_",$logoname);// Add _ inplace of blank space in file name, you can remove this line
 
                     $add = "./company_logo/$logoname";
                        echo "<font size='2' color='#FF0000'>your company is added successfully</font>";
                  echo "<br>";
 
                     copy($_FILES['images']['tmp_name'][$key], $add);
                     chmod("$add",0777);
            }
 
                     $image = new SimpleImage();
                     $image->load("$add");
                     $image->resize(100,100);
                     $image->save("$add"); 
 
            $fristname = ($_POST['fristname']);
            $email = ($_POST['email']);
            $category = ($_POST['category']);
 
                mysql_query("INSERT INTO companylogourl (fristname, imagename, email, category) 
    VALUES('$fristname', '$logoname', '$email', '$category')") or die(mysql_error());
         } 
        }
    }
 
        ?>
 

[Markus]

You want to do it as early as possible to avoid doing stuff that isn't necessary if the file isn't correct. So, I would suggest add your conditional statements immediately after you create the image information variables (lines 8 - 11).

[simon2x1]

i have insert the conditional statement between line 8 and 11 but is still giving me error when i try to post a blank field i will appreciate if you help me adjust my code

<?php
 
        if (isset($_POST['submit'])) {
          If(empty($_POST['fristname']) OR empty($_POST['emaill'])OR empty($_POST['category'])){
              echo '<font size="2" color="#FF0000">Please fill in all the required fields!</font>';
         }else{
 
            if($_FILES['images']['size'] == 0){ 
        echo '<font size="2" color="#FF0000">Please upload your company logo</font>';
        }
        if (!eregi("^([A-Za-z0-9]+)\.jpg|\.gif|\.png$", $logoname)){
        echo '<font size="2" color="#FF0000">invalid image format</font>';
            }
                    $logoname = $_FILES['images']['name'];
                    $tmpname  = $_FILES['images']['tmp_name'];
                    $logosize = $_FILES['images']['size'];
                       $logotype = $_FILES['images']['type'];
 
 
 
             while(list($key,$value) = each($_FILES['images']['name'])){
             if(!empty($value)) {
                 $logoname = $value;
                     $logoname = str_replace(" ","_",$logoname);// Add _ inplace of blank space in file name, you can remove this line
 
                     $add = "./company_logo/$logoname";
                        echo "<font size='2' color='#FF0000'>your company is added successfully</font>";
                  echo "<br>";
 
                     copy($_FILES['images']['tmp_name'][$key], $add);
                     chmod("$add",0777);
            }
 
                     $image = new SimpleImage();
                     $image->load("$add");
                     $image->resize(100,100);
                     $image->save("$add"); 
 
            $fristname = ($_POST['fristname']);
            $email = ($_POST['email']);
            $category = ($_POST['category']);
 
                mysql_query("INSERT INTO companylogourl (fristname, imagename, email, category) 
    VALUES('$fristname', '$logoname', '$email', '$category')") or die(mysql_error());
         } 
        }
    }
 
        ?>
 

[hoopy]

Hi when you check for if a file exists to be uploaded, if its not then you should exit() or redirect or skip all the next part. Currently it looks like you are throwing an error back but still attempting to do the upload.

So here:

if($_FILES['images']['size'] == 0){ 
  echo '<font size="2" color="#FF0000">Please upload your company logo</font>';
 ///// DO SOMETHING HERE to stop the process....
}

Post back if you are still stuck.