Form Sends Data But Also Shows Errors?

[obtrs]

i have a html form it and some php script to post it to database but every time i open page it show some error on the top but when i input data and send it it also send so how can i remove these errors?

Errors:

Notice: Undefined index: fromcombo in C:\wamp\www\site\booking.php on line 8

Notice: Undefined index: tocombo in C:\wamp\www\site\booking.php on line 8

Notice: Undefined index: DV in C:\wamp\www\site\booking.php on line 8

php script:

<?php
mysql_connect("localhost", "root", "password");
 
mysql_select_db("online_bus_project");
 
mysql_query("INSERT INTO trip (gender, country, date) VALUES ('$_POST[fromcombo]', '$_POST[tocombo]', '$_POST[DV]')");
 
?>

Html Form:

<form name="tstest" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="POST">
   <CENTER>From : <select name="fromcombo">
<option value="khairpur">Khairpur</option>
<option value="sukkur">Sukkur</option>
</select>       
 
To : <select name="tocombo">
<option value="karachi">Karachi</option>
<option value="hyderabad">Hyderabad</option>
</select></CENTER><br /><br><br>
 
<CENTER>Date : <script type="text/javascript" language="javascript">
(INPUT(NAME("DV")+READONLY())+INPUT(TYPE("button")+VALUE("Calender")+ONCLICK("popCal(this.form.DV)"))).FORM().write();
</script></CENTER><br><br><br>
 
<center><input type="submit" value="Submit Info" /></CENTER>
 
</form>

[prabirchoudhury]

This error appears because of your PHP error reporting settings. Usually,
it appears when your variable is not properly set. every time you getinto the page its try to insert the data into table
but your post variables are empry

Check if $_POST['action'] is set before insert into dataabse. if the form is not being submited then $_POST['action'] is not being set, so it would not try to insert into table.

PHP script

if (isset($_POST['action'])){
 
mysql_connect("localhost", "root", "password");
 
mysql_select_db("online_bus_project");
 
mysql_query("INSERT INTO trip (gender, country, date) VALUES ('$_POST[fromcombo]', '$_POST[tocombo]', '$_POST[DV]')");
 
}

Html Form

<form name="tstest" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="POST">
<CENTER>From : <select name="fromcombo">
<option value="khairpur">Khairpur</option>
<option value="sukkur">Sukkur</option>
</select> 
 
To : <select name="tocombo">
<option value="karachi">Karachi</option>
<option value="hyderabad">Hyderabad</option>
</select></CENTER><br /><br><br>
 
<CENTER>Date : <script type="text/javascript" language="javascript">
(INPUT(NAME("DV")+READONLY())+INPUT(TYPE("button") +VALUE("Calender")+ONCLICK("popCal(this.form.DV)") )).FORM().write();
</script></CENTER><br><br><br>
 
// add this hidden field here as an action flag
<input type="hidden" name="action" value="add">
<center><input type="submit" value="Submit Info" /></CENTER>
 
</form> 

[Markus]

On a further note: you're also inserting raw, potentially malicious data into your database. Have a look at SQL Injection, and your array indices should be wrapped with single or double quotes.

// Wrong
$_POST[key_name];
// Correct
$_POST['key_name'];
 

[obtrs]

marcus after adding this it shows this error

// Correct
$_POST['key_name'];

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in C:\wamp\www\site\booking.php on line 8

[obtrs]

after addning action isset its working fine thanx for the help prabirchoudhury's & Marcus.



close the tread

[Markus]

@obtrs
Of course. I was only showing how you should use quotes when accessing array elements.

[obtrs]

thanx man...........