show club presidents info hide everyone else's

[PomonaGrange]

HI All, I've been trying to make a membership management type script. This script would have a database with the members contact info and which office they hold, if any. The problem I am having is I would like the script to show the president's and vice president's Contact info all the time, but hide the contact info for everyone else when viewed by the general public, then if the user logs in all contact information is displayed, for everyone.

Below is the part of the script that I have so far, The if logged in / out part works like I want, but I can't get it to show the President's info but hide the other members info.

[PHP]if (($sub_office =="President")||($sub_office =="Vice President")||($sub_office =="Secretery")){ $officer_show = "YES";} ELSE{$officer_show = "NO";} if ($officer_show == YES){$hphone = $homephone;$cphone = $cellphone;$adress = $address;$cty = $city;$st = $state;$zp = $zip;$eml = $email;}ELSE{$hphone = "&nbsp;";$cphone = "&nbsp;";$adress = "&nbsp;";$cty = "&nbsp;";$st = "&nbsp;";$zp = "&nbsp;";$eml = "&nbsp;";} if($_SESSION['auth']['status'] == 1){ // do stuff here$display_block .= "<tr> <td>$sub_office</td> <td>$fname $lname</td> <td>$hphone / $cphone</td> <td>$eml</td> <td>$adress, $cty, $st $zp</td> <td>$sub_name</td></tr>"; } ELSE {$display_block .= "<tr> <td>$sub_office</td> <td>$fname $lname</td> <td>$hphone / $cphone</td> <td>$eml</td> <td>$adress, $cty, $st $zp</td> <td>$sub_name</td></tr>"; }} if (($sub_office =="President")||($sub_office =="Vice President")||($sub_office =="Secretery")){
$officer_show = "YES";}
ELSE{$officer_show = "NO";}

if ($officer_show == YES){
$hphone = $homephone;
$cphone = $cellphone;
$adress = $address;
$cty = $city;
$st = $state;
$zp = $zip;
$eml = $email;
}
ELSE
{
$hphone = "&nbsp;";
$cphone = "&nbsp;";
$adress = "&nbsp;";
$cty = "&nbsp;";
$st = "&nbsp;";
$zp = "&nbsp;";
$eml = "&nbsp;";
}
if($_SESSION['auth']['status'] == 1){
// do stuff here
$display_block .= "
<tr>
<td>$sub_office</td>
<td>$fname $lname</td>
<td>$hphone / $cphone</td>
<td>$eml</td>
<td>$adress, $cty, $st $zp</td>
<td>$sub_name</td>
</tr>";
}

ELSE {
$display_block .= "
<tr>
<td>$sub_office</td>
<td>$fname $lname</td>
<td>$hphone / $cphone</td>
<td>$eml</td>
<td>$adress, $cty, $st $zp</td>
<td>$sub_name</td>
</tr>";
}
} [/PHP]

I Have also seen the if ($sub_office =="President") done like this if ($sub_office !="President")
I can't seem to get it to work either way.
Another thing I should mention is that I want to show the contact info for the club president and a couple other offices, but hide the contact info for everyone else. I still want to show everyone's name, just hide their contact info. I posted this question in another forum and the suggestion I got from their is to change the sql query. I don't want to do that though.

If there is a better way of doing any of this, let me know. I would appreciate any help.

[code green]

You obviously do not have error_reporting switched on because this [PHP]if ($officer_show == YES)[/PHP] would throw a warning about an undefined constant. It should be [PHP]if ($officer_show == "YES")[/PHP] But get rid of this string comparison and use booleans: true, false or 1,0.
It is much cleaner [PHP]if($officer_show)[/PHP] Talking of clean. Try to seperate your HTML and PHP.
I write php in .php files that 'include' HTML code in seperate .html files.
Your code looks too cluttered to study

[PomonaGrange]

HI, I did turn on error reporting, as explained in one sticky post. I just forgot to update my script that I posted. I did get that error and fixed that one. I will try changing it as specified. Thanks for your response.

[PomonaGrange]

The tip you offered didn't seem to make a difference.



I also am getting an notice with the code below. the warnings are:

This one I get if I'm not loged in. Is there a way to get rid of it, other than logging in (with error reporting on).

Notice: Undefined index: 'auth' in /home/content/m/a/t/mattjenne***/html/members/sub_officers3.php on line 126
 
Notice: Undefined variable: display_block in /home/content/m/a/t/mattjenne***/html/members/sub_officers3.php on line 148
 

//starting at line 126//
            if($_SESSION['auth']['status'] == 1){
                // do stuff here
$display_block .= "
<tr>
 <td>$sub_office</td>
 <td>$fname $lname</td>
 <td>$hphone / $cphone</td>
 <td>$eml</td>
 <td>$adress, $cty, $st $zp</td>
 <td>$sub_name</td>
</tr>"; 
            }
 

[Atli]

Hi. welcome to Bytes!

I'm guessing a lot of your problems are caused by that monster of a first line.
It includes a few if statements, some HTML and last, but not least, a single-line comment, which will comment out everything behind it.

Copying your code into my IDE, I see half the first line commented out, and an extra closing curly-brace.

Try re-formatting that first line into something readable. If it still gives you problems, post it here and we'll take a look.

[PomonaGrange]

Hi, I noticed when I copied the script that the post came out different than I typed it. What is showed as one big line was origionally written as 25+ lines. I have tried to make a couple of changes, but no luck. I have uploaded the script in a text file to my website. If you would check it out it would be helpful. The file is at http://www.pomonagrange.org/helpme/sub_officers2.txt. I would appreciate it if you could look it over. This is the whole file, not just an a portion. Thanks for the help.

[Atli]

Just posting your code here to make the thread easier to follow. People are often scared of by external links. Hope you don't mind.

<?php
 
session_start();
 
include ('./config/db.php');
 
$sub_name = $_GET['sub_name'];
 
//make connection to dbase
$connection = @mysql_connect($server, $dbusername, $dbpassword)
                or die(mysql_error());
 
$db = @mysql_select_db($db_name,$connection)
                or die(mysql_error());
$sql = "SELECT `sub_name`, `pom_name`, `maxdegree`, `pom_office`, `sub_office`, `lname`, `fname`, `minitial`, `maidenname`, `address`, `city`, `state`, `zip`, `homephone`, `cellphone`, `email`,
(SELECT 
  CASE
   WHEN `sub_office` = 'Master - President' THEN 1
   WHEN `sub_office` = 'Overseer - Vice President' THEN 2
   WHEN `sub_office` = 'Lecturer - Program Director' THEN 3
   WHEN `sub_office` = 'Steward' THEN 4
   WHEN `sub_office` = 'Assistant Steward' THEN 5
   WHEN `sub_office` = 'Lady Assistant Steward' THEN 6
   WHEN `sub_office` = 'Chaplain' THEN 7
   WHEN `sub_office` = 'Treasurer' THEN 8
   WHEN `sub_office` = 'Building Treasurer' THEN 9
   WHEN `sub_office` = 'Secretary' THEN 10
   WHEN `sub_office` = 'Gate Keeper' THEN 11
   WHEN `sub_office` = 'Flora' THEN 12
   WHEN `sub_office` = 'Pomona' THEN 13
   WHEN `sub_office` = 'Ceres' THEN 14
   WHEN `sub_office` = 'Executive Committee' THEN 15
   WHEN `sub_office` = 'Pianist' THEN 16
   WHEN `sub_office` = 'Leadership' THEN 17
   WHEN `sub_office` = 'Membership' THEN 18
   WHEN `sub_office` = 'Legislative' THEN 19
   WHEN `sub_office` = 'Family Activities' THEN 20
   WHEN `sub_office` = 'Community Service' THEN 21
   WHEN `sub_office` = 'Fun Committee' THEN 22
   ELSE 23
  END) as sort
FROM MembersTable WHERE `sub_name` = '".$sub_name."'
 
ORDER BY sort ASC";
 
$result = @mysql_query($sql,$connection) or die(mysql_error());
 
while ($row = mysql_fetch_array($result)) {
 
if (!$row["sub_name"]) { $sub_name="&nbsp"; } 
   else { $sub_name = " ".$row['sub_name']."\n"; } 
 
if (!$row["pom_name"]) { $pom_name="&nbsp"; } 
  else { $pom_name = " ".$row['pom_name']."\n"; } 
 
if (!$row["maxdegree"]) { $maxdegree="&nbsp"; } 
  else { $maxdegree = " ".$row['maxdegree']."\n"; } 
 
if (!$row["pom_office"]) { $pom_office="&nbsp"; } 
  else { $pom_office = " ".$row['pom_office']."\n"; } 
 
if (!$row["sub_office"]) { $sub_office="&nbsp"; } 
  else { $sub_office = " ".$row['sub_office']."\n"; } 
 
if (!$row["lname"]) { $lname="&nbsp"; } 
  else { $lname = " ".$row['lname']."\n"; } 
 
if (!$row["fname"]) { $fname="&nbsp"; } 
  else { $fname = " ".$row['fname']."\n"; } 
 
if (!$row["minitial"]) { $minitial="&nbsp"; } 
  else { $minitial = " ".$row['minitial']."\n"; } 
 
if (!$row["maidenname"]) { $maidenname="&nbsp"; } 
  else { $maidenname = " ".$row['maidenname']."\n"; } 
 
if (!$row["address"]) { $address=""; } 
  else { $address = " ".$row['address']."\n"; } 
 
if (!$row["city"]) { $city="&nbsp"; } 
  else { $city = " ".$row['city']."\n"; } 
 
if (!$row["state"]) { $state="&nbsp"; } 
  else { $state = " ".$row['state']."\n"; } 
 
if (!$row["zip"]) { $zip="&nbsp"; } 
  else { $zip = " ".$row['zip']."\n"; } 
 
if (!$row["homephone"]) { $homephone="&nbsp"; } 
  else { $homephone = " ".$row['homephone']."\n"; } 
 
if (!$row["cellphone"]) { $cellphone="&nbsp"; } 
  else { $cellphone = " ".$row['cellphone']."\n"; } 
 
if (!$row["email"]) { $email="&nbsp;"; } 
  else { $email = " <a href=\"mailto:".$row['email']."\">".$row['email']."</a>\n"; } 
 
 
if ($row["sub_office"] == 'Master - President'){$officer_show = "YES";}
ELSEIF($row["sub_office"] == 'Overseer - Vice President'){$officer_show = "YES";}
ELSEIF($row["sub_office"] == 'Lecturer - Program Director'){$officer_show = "YES";}
ELSEIF($row["sub_office"] == 'Secretery'){$officer_show = "YES";}
ELSE{$officer_show = "NO";}
 
 
            if($_SESSION['auth']['status'] == 1){$show_all = "YES";}ELSE{$show_all = "NO";}
 
if ($officer_show == 'YES'){
$homephone = $homephone;
$cellphone = $cellphone;
$address = $address;
$city = $city;
$state = $state;
$zip = $zip;
$email = $email;
}
ELSEIF($show_all == 'YES'){
$homephone = $homephone;
$cellphone = $cellphone;
$address = $address;
$city = $city;
$state = $state;
$zip = $zip;
$email = $email;}
ELSE
{
$homephone = "&nbsp;";
$cellphone = "&nbsp;";
$address = "&nbsp;";
$city = "&nbsp;";
$state = "&nbsp;";
$zip = "&nbsp;";
$email = "&nbsp;";
}
 
$display_block .= "
<tr>
 <td>$sub_office</td>
 <td>$fname $lname</td>
 <td>$hphone / $cphone</td>
 <td>$eml</td>
 <td>$adress, $cty, $st $zp</td>
 <td>$sub_name</td>
</tr>"; 
} 
 
$title = "<title>Officers of the ".$sub_name." Subordinate Grange</title>";
?>
 
<? include("./config/header.php"); ?>
 
</head>
 
<body>
<? include $_SERVER['DOCUMENT_ROOT']."/glist.txt"; ?>
 
 
<table width="85%" border="1" class="main"><tbody>
<tr><td colspan="6"><h2>Officers of <? echo "$sub_name"; ?> Subordinate Grange</h2></td></tr>
 
<tr><td><b>Office</b></td>  <td><b>Officer</b></td>  <td><b>Home  / Cell Phone #</b></td>  <td><b>Email</b></td>  <td><b>Address</b></td>  <td><b>Subordinate Grange</b></td></tr>
 
<? echo "$display_block"; ?>
 
<tr><td colspan="6"><!-- C. FOOTER AREA -->      
 
 
    <div class="footer">
      <? include ('./config/footerinfo.php'); ?>
    </div>      </td></tr>
 
</tbody></table>
 
 
</body>
</html>
 

I'll have a look at it, see if I can spot any problems.

[Atli]

What is the `sub_name` value you are using to filter the SQL results with?

The main problem there would be the way you handle the data. The flood of if statements is a testament to that.
You are fetching all the data from the database, and having PHP sort through it, which is something you should never do.

Before you execute your query, you should figure out what data should be displayed and select only that. Tailor your SQL to fit the situation, don't select everything and filter the data once it has been fetched.

Consider this example:

/***
 *  Show publicly available data
 ***/
// Set up the roles that should be visible to the public
$rolesToShow = array("President", "Gardner");
$roles = "'". implode("', '", $rolesToShow) ."'");
 
// Create and execute the query
$sql = "SELECT name, email, phone FROM userTable WHERE role IN($roles)";
$result = mysql_query($sql);
 
// Display the public data
while($row = mysql_fetch_row($result)) {
  # Show data
}
 
/***
 * Show member specific data
 ***/
// Create the SQL query based on the user's status.
if($_SESSION['User']['status'] == 1) {
  $sql = "SELECT name, email phone FROM userTable WHERE role NOT IN($roles)";
}
else {
  $sql = "SELECT name FROM userTable WHERE role NOT IN($roles)";
}
 
// Execute the query and display the results
$result = mysql_query($sql);
 
while($row = mysql_fetch_assoc($result)) {
  // Set these based on whether the data was fetched or not
  // The (bool ? true : false) format is basically a compact if statement.
  $name = $row['name'];
  $email = (isset($row['email']) ? $row['email'] : "&nbsp");
  $phone = (isset($row['phone ']) ? $row['phone '] : "&nbsp");
 
  # Display data
}
 

This would show all visitors the President and Gardner roles, but hide everything but the names from all other roles, unless you are logged in.

[PomonaGrange]

Hey Thanks for the response. This club is county wide with some local groups within the county organization. The row `sub_name` is to determine which 'sub division' they are a member of. This variable will be passed using the GET method from another page.

I will try the suggestion you made.I was going to try multiple sql statements, but wasn't sure of how exactly to go about it as I am fairly new to php programming.

Also with this, is there a way to sort the names in a certain order according to their office. I had this in the file that I uploaded, but with splitting the sql statements, how could I get that to work.

Thanks again for your reply.

[PomonaGrange]

Hey just to let you know I finally got this script working. Thanks for your help. If you guys hadn't helped I wouldn't have gotten it working.